nuttxpr commented on PR #14830: URL: https://github.com/apache/nuttx/pull/14830#issuecomment-2481241785
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. The provided information is far too brief. Here's a breakdown of what's missing: * **Summary:** * Lacks crucial details. "Only one initialization is needed" is vague. *Why* was multiple initialization happening before? *What* specific change was made to address it? *How* does the single initialization now work? Which files were modified? * Missing issue references if applicable. * **Impact:** * Simply stating "mqueue" is insufficient. Does this affect the *user*? The *build process*? *Hardware*? *Documentation*? *Security*? *Compatibility*? Each of these requires a "YES/NO" answer and a description if "YES". * **Testing:** * Insufficient build host information. What OS, CPU architecture, and compiler version were used? * "sim:citest pass" is better than nothing but still minimal. What specific tests were run? Were *only* the `citest` tests run? What about other relevant tests? * Critically, the "Testing logs before change" and "Testing logs after change" sections are empty. Without these, there's no evidence provided that the change actually fixes a problem or improves anything. These logs are crucial for reviewers to understand the impact of the change. **In short:** The PR needs significantly more detail to be considered complete. It needs to clearly articulate the problem being solved, the specific solution implemented, the full impact of the change, and provide concrete evidence (logs) that the change works as intended. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
