[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #1362: netutils: Support telnetd in the kernel mode

2022-10-18 Thread GitBox
masayuki2009 commented on PR #1362: URL: https://github.com/apache/incubator-nuttx-apps/pull/1362#issuecomment-1283523369 > @masayuki2009 this command doesn't work: qemu-system-arm -net nic,model=stellaris -net user,hostfwd=tcp:127.0.0.1:20023-10.0.2.15:23,hostfwd=tcp:127.0.0.1:20021-10.0.

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1362: netutils: Support telnetd in the kernel mode

2022-10-18 Thread GitBox
xiaoxiang781216 commented on PR #1362: URL: https://github.com/apache/incubator-nuttx-apps/pull/1362#issuecomment-1283498101 @masayuki2009 this command doesn't work: ''' qemu-system-arm -net nic,model=stellaris -net user,hostfwd=tcp:127.0.0.1:20023-10.0.2.15:23,hostfwd=tcp:127.0.0.1:2

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1362: netutils: Support telnetd in the kernel mode

2022-10-18 Thread GitBox
xiaoxiang781216 commented on PR #1362: URL: https://github.com/apache/incubator-nuttx-apps/pull/1362#issuecomment-1283460766 > @xiaoxiang781216 > > Hmm, the Telenet daemon does not start automatically with `lm3s6965-ek:discover` > > ``` > + /home/ishikawa/opensource/QEMU/q

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7344: sem:remove sem default protocl

2022-10-18 Thread GitBox
xiaoxiang781216 commented on PR #7344: URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1283452196 let move this patch to the pr#5070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6783: libc/localtime: fix some issues and update to consistent with mainline

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r998956470 ## libs/libc/time/lib_localtime.c: ## @@ -611,168 +700,229 @@ static int tzload(FAR const char *name, } nread = _NX_READ(fid, up->buf, sizeof up-

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #5070: libc/semaphore:sem_init change defult protocol

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #5070: URL: https://github.com/apache/incubator-nuttx/pull/5070#discussion_r998952692 ## include/semaphore.h: ## @@ -48,8 +48,8 @@ /* Bit definitions for the struct sem_s flags field */ -#define PRIOINHERIT_FLAGS_DISABLE (1 << 0) /*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #5070: libc/semaphore:sem_init change defult protocol

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #5070: URL: https://github.com/apache/incubator-nuttx/pull/5070#discussion_r998952692 ## include/semaphore.h: ## @@ -48,8 +48,8 @@ /* Bit definitions for the struct sem_s flags field */ -#define PRIOINHERIT_FLAGS_DISABLE (1 << 0) /*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7351: boards: Update telnetd related config after apps/nshlib change

2022-10-18 Thread GitBox
xiaoxiang781216 commented on PR #7351: URL: https://github.com/apache/incubator-nuttx/pull/7351#issuecomment-128386 > The new draft release notes for NuttX-11.1.0 is on the CWIKI at https://cwiki.apache.org/confluence/display/NUTTX/NuttX+11.1.0. When this PR is merged, I will add the ch

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7115: time: Typedef time_t to uint64_t if CONFIG_SYSTEM_TIME64 is defined

2022-10-18 Thread GitBox
xiaoxiang781216 commented on PR #7115: URL: https://github.com/apache/incubator-nuttx/pull/7115#issuecomment-1283420100 > Wait for #6783, mark as draft. @pkarashchenko this patch is ready now. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[incubator-nuttx] branch master updated (f9fd53cda1 -> ec93385dfa)

2022-10-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from f9fd53cda1 gmtimer: Fixed range of tm_yday. add ec93385dfa strftime: Added support for the %w format

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7348: strftime: Added support for the %w format specifier.

2022-10-18 Thread GitBox
xiaoxiang781216 merged PR #7348: URL: https://github.com/apache/incubator-nuttx/pull/7348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated (55106685fa -> f9fd53cda1)

2022-10-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 55106685fa libc/localtime: Update to consistent with mainline add f9fd53cda1 gmtimer: Fixed range of

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7349: gmtimer: Fixed range of tm_yday.

2022-10-18 Thread GitBox
xiaoxiang781216 merged PR #7349: URL: https://github.com/apache/incubator-nuttx/pull/7349 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] anjiahao1 commented on pull request #5070: libc/semaphore:sem_init change defult protocol

2022-10-18 Thread GitBox
anjiahao1 commented on PR #5070: URL: https://github.com/apache/incubator-nuttx/pull/5070#issuecomment-1283381549 > How is this PR related to PR #7344 ? Should they be combined to a single PR? ok,i will use single PR and add documentation later -- This is an automated message from

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #5070: libc/semaphore:sem_init change defult protocol

2022-10-18 Thread GitBox
hartmannathan commented on PR #5070: URL: https://github.com/apache/incubator-nuttx/pull/5070#issuecomment-1283377442 How is this PR related to PR #7344 ? Should they be combined to a single PR? -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1358: ostest:add sem protocl to priority inheritance

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #1358: URL: https://github.com/apache/incubator-nuttx-apps/pull/1358#discussion_r998905472 ## testing/ostest/prioinherit.c: ## @@ -530,6 +530,8 @@ void priority_inheritance(void) g_medpri = my_pri - 1; sem_init(&g_sem, 0, NLOWPRI_

[GitHub] [incubator-nuttx-apps] anjiahao1 commented on a diff in pull request #1358: ostest:add sem protocl to priority inheritance

2022-10-18 Thread GitBox
anjiahao1 commented on code in PR #1358: URL: https://github.com/apache/incubator-nuttx-apps/pull/1358#discussion_r998901697 ## testing/ostest/prioinherit.c: ## @@ -530,6 +530,8 @@ void priority_inheritance(void) g_medpri = my_pri - 1; sem_init(&g_sem, 0, NLOWPRI_THREAD

[GitHub] [incubator-nuttx] hartmannathan commented on pull request #7351: boards: Update telnetd related config after apps/nshlib change

2022-10-18 Thread GitBox
hartmannathan commented on PR #7351: URL: https://github.com/apache/incubator-nuttx/pull/7351#issuecomment-1283353603 The new draft release notes for NuttX-11.1.0 is on the CWIKI at [https://cwiki.apache.org/confluence/display/NUTTX/NuttX+11.1.0](https://cwiki.apache.org/confluence/display/N

[GitHub] [incubator-nuttx-apps] anjiahao1 commented on pull request #1358: ostest:add sem protocl to priority inheritance

2022-10-18 Thread GitBox
anjiahao1 commented on PR #1358: URL: https://github.com/apache/incubator-nuttx-apps/pull/1358#issuecomment-1283351823 > @anjiahao1 @xiaoxiang781216 Do we need such a change if we enable the priority inheritance feature? if sem used as lock,need set protocl to priority inheritance, o

[GitHub] [incubator-nuttx] hartmannathan commented on a diff in pull request #6920: support /dev/crypto for nuttx

2022-10-18 Thread GitBox
hartmannathan commented on code in PR #6920: URL: https://github.com/apache/incubator-nuttx/pull/6920#discussion_r998894368 ## crypto/chacha_private.h: ## @@ -0,0 +1,335 @@ +/ + * crypto/chacha_private.h

[incubator-nuttx] branch master updated (6978446b8e -> 55106685fa)

2022-10-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 6978446b8e net/tcp: remove debug counter of connect instance add 0bff62e3e8 libc/time: don't take sem

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6783: libc/localtime: fix some issues and update to consistent with mainline

2022-10-18 Thread GitBox
xiaoxiang781216 merged PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: net/tcp: remove debug counter of connect instance

2022-10-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 6978446b8e net/tcp: remove debug cou

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7350: net/tcp: remove debug counter of connect instance

2022-10-18 Thread GitBox
xiaoxiang781216 merged PR #7350: URL: https://github.com/apache/incubator-nuttx/pull/7350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] abdallah-ali-abdallah commented on issue #7331: Is it possible to enable nsh over composite usb configuration using RP2040?

2022-10-18 Thread GitBox
abdallah-ali-abdallah commented on issue #7331: URL: https://github.com/apache/incubator-nuttx/issues/7331#issuecomment-1283174034 Hi @acassis Thank you for your help, I did what you explained and after some hacking, tweaking and a lot of jumping between files I was able to operate

[incubator-nuttx-website] branch asf-site updated: Publishing web: d696c67810809c3f81a4dd87b09d9e940db854b4 docs: dcbad62fefd6780fbb49995d22fb5b333e249dc4

2022-10-18 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new a01c2b2 Publishing web

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #1362: netutils: Support telnetd in the kernel mode

2022-10-18 Thread GitBox
masayuki2009 commented on PR #1362: URL: https://github.com/apache/incubator-nuttx-apps/pull/1362#issuecomment-1283157610 @xiaoxiang781216 Hmm, the Telenet daemon does not start automatically with `lm3s6965-ek:discover` ``` + /home/ishikawa/opensource/QEMU/qemu-7.1/build/a

[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #7349: gmtimer: Fixed range of tm_yday.

2022-10-18 Thread GitBox
fjpanag commented on code in PR #7349: URL: https://github.com/apache/incubator-nuttx/pull/7349#discussion_r998800825 ## libs/libc/time/lib_gmtimer.c: ## @@ -336,7 +336,7 @@ FAR struct tm *gmtime_r(FAR const time_t *timep, FAR struct tm *result) result->tm_wday = clock_day

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6783: libc/localtime: fix some issues and update to consistent with mainline

2022-10-18 Thread GitBox
Donny9 commented on code in PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r998800429 ## libs/libc/time/lib_localtime.c: ## @@ -1785,21 +2071,27 @@ static FAR struct tm *gmtsub(FAR const time_t *timep, } } - nxmutex_unl

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6783: libc/localtime: fix some issues and update to consistent with mainline

2022-10-18 Thread GitBox
Donny9 commented on code in PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r998800194 ## libs/libc/time/lib_localtime.c: ## @@ -1785,21 +2071,27 @@ static FAR struct tm *gmtsub(FAR const time_t *timep, } } - nxmutex_unl

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6783: libc/localtime: fix some issues and update to consistent with mainline

2022-10-18 Thread GitBox
Donny9 commented on code in PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r998800066 ## libs/libc/time/lib_localtime.c: ## @@ -611,168 +700,229 @@ static int tzload(FAR const char *name, } nread = _NX_READ(fid, up->buf, sizeof up->buf);

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6783: libc/localtime: fix some issues and update to consistent with mainline

2022-10-18 Thread GitBox
Donny9 commented on code in PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r998799917 ## libs/libc/time/lib_localtime.c: ## @@ -464,64 +554,48 @@ static void settzname(void) { FAR const struct ttinfo_s *const ttisp = &sp->ttis[i]; -

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6783: libc/localtime: fix some issues and update to consistent with mainline

2022-10-18 Thread GitBox
Donny9 commented on code in PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r998799767 ## libs/libc/time/lib_localtime.c: ## @@ -464,64 +554,48 @@ static void settzname(void) { FAR const struct ttinfo_s *const ttisp = &sp->ttis[i]; -

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6783: libc/localtime: fix some issues and update to consistent with mainline

2022-10-18 Thread GitBox
Donny9 commented on code in PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r998799660 ## libs/libc/time/lib_localtime.c: ## @@ -412,40 +423,119 @@ static int typesequiv(FAR const struct state_s *sp, int a, int b); static int tzload(FAR const ch

[GitHub] [incubator-nuttx] fjpanag commented on pull request #7348: strftime: Added support for the %w format specifier.

2022-10-18 Thread GitBox
fjpanag commented on PR #7348: URL: https://github.com/apache/incubator-nuttx/pull/7348#issuecomment-1283134100 > @fjpanag : man strftime: `%w The day of the week as a decimal, range 0 to 6, Sunday being 0.` > > Should be 0 to 6, not 00 to 06, please fix! I was pretty sure that

[GitHub] [incubator-nuttx] fjpanag commented on pull request #7348: strftime: Added support for the %w format specifier.

2022-10-18 Thread GitBox
fjpanag commented on PR #7348: URL: https://github.com/apache/incubator-nuttx/pull/7348#issuecomment-1283133904 > @fjpanag : man strftime: `%w The day of the week as a decimal, range 0 to 6, Sunday being 0.` > > Should be 0 to 6, not 00 to 06, please fix! I was pretty sure that

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7344: sem:change sem default behavior

2022-10-18 Thread GitBox
masayuki2009 commented on PR #7344: URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1283133840 >@masayuki2009 https://github.com/apache/incubator-nuttx-apps/pull/1358 this is fix patch @anjiahao1 Please update the impact in the summary. -- This is an a

[GitHub] [incubator-nuttx] Donny9 commented on a diff in pull request #6783: libc/localtime: fix some issues and update to consistent with mainline

2022-10-18 Thread GitBox
Donny9 commented on code in PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r998796561 ## libs/libc/time/lib_localtime.c: ## @@ -611,168 +700,229 @@ static int tzload(FAR const char *name, } nread = _NX_READ(fid, up->buf, sizeof up->buf);

[GitHub] [incubator-nuttx] fjpanag closed pull request #7348: strftime: Added support for the %w format specifier.

2022-10-18 Thread GitBox
fjpanag closed pull request #7348: strftime: Added support for the %w format specifier. URL: https://github.com/apache/incubator-nuttx/pull/7348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [incubator-nuttx] fjpanag commented on pull request #7348: strftime: Added support for the %w format specifier.

2022-10-18 Thread GitBox
fjpanag commented on PR #7348: URL: https://github.com/apache/incubator-nuttx/pull/7348#issuecomment-1283132885 > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[incubator-nuttx] branch master updated (edd68d8ae9 -> dcbad62fef)

2022-10-18 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from edd68d8ae9 board: Change CONFIG_SYSTEM_NSH_SYMTAB to CONFIG_NSH_SYMTAB add 774648de0f risc0v/bl602: Ca

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #7318: sched/env: Skip the envirnment variable duplication of kernel thread

2022-10-18 Thread GitBox
masayuki2009 merged PR #7318: URL: https://github.com/apache/incubator-nuttx/pull/7318 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #1362: netutils: Support telnetd in the kernel mode

2022-10-18 Thread GitBox
masayuki2009 commented on PR #1362: URL: https://github.com/apache/incubator-nuttx-apps/pull/1362#issuecomment-1283108375 @xiaoxiang781216 ``` Configuration/Tool: spresense/rndis_smp,CONFI

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #1358: ostest:add sem protocl to priority inheritance

2022-10-18 Thread GitBox
masayuki2009 commented on PR #1358: URL: https://github.com/apache/incubator-nuttx-apps/pull/1358#issuecomment-1283099825 Do we need such a change if we enable the priority inheritance feature? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7339: sched.h: Simplify HAVE_GROUP_MEMBERS logic

2022-10-18 Thread GitBox
masayuki2009 commented on PR #7339: URL: https://github.com/apache/incubator-nuttx/pull/7339#issuecomment-1283098161 >@yamt the linker error need be addressed before merging. ``` Configuration/T

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #7268: boards: adapt LVGL v8 defconfig

2022-10-18 Thread GitBox
gustavonihei commented on PR #7268: URL: https://github.com/apache/incubator-nuttx/pull/7268#issuecomment-1283096658 > @gustavonihei Can you help test other ESP32 boards? :) I have just the ESP-WROVER-KIT here, I believe @tmedicci could help testing with the `ttgo_t_display_esp32` pla

[GitHub] [incubator-nuttx-apps] gustavonihei commented on pull request #1361: add tinycrypt to crypto

2022-10-18 Thread GitBox
gustavonihei commented on PR #1361: URL: https://github.com/apache/incubator-nuttx-apps/pull/1361#issuecomment-1283093100 > @gustavonihei could you take a look? This patch replace mcuboot private copy to the official tinycrypto. MCUboot uses a modified version of tinycrypt, so it can

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7248: drivers: modem: update altair modem

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #7248: URL: https://github.com/apache/incubator-nuttx/pull/7248#discussion_r998683215 ## drivers/modem/alt1250/alt1250.c: ## @@ -0,0 +1,1280 @@ +/ + * drivers/modem/

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #5070: libc/semaphore:sem_init change defult protocol

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #5070: URL: https://github.com/apache/incubator-nuttx/pull/5070#discussion_r998678545 ## include/semaphore.h: ## @@ -48,8 +48,8 @@ /* Bit definitions for the struct sem_s flags field */ -#define PRIOINHERIT_FLAGS_DISABLE (1 << 0) /* Bi

[incubator-nuttx] branch master updated: board: Change CONFIG_SYSTEM_NSH_SYMTAB to CONFIG_NSH_SYMTAB

2022-10-18 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new edd68d8ae9 board: Change CONFIG_

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7330: board: Change CONFIG_SYSTEM_NSH_SYMTAB to CONFIG_NSH_SYMTAB

2022-10-18 Thread GitBox
pkarashchenko merged PR #7330: URL: https://github.com/apache/incubator-nuttx/pull/7330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[incubator-nuttx-apps] branch master updated: nshlib: Rename CONFIG_SYSTEM_NSH_SYMTAB to CONFIG_NSH_SYMTAB

2022-10-18 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 0d2ef4719 nshlib: Rename CO

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1354: nshlib: Rename CONFIG_SYSTEM_NSH_SYMTAB to CONFIG_NSH_SYMTAB

2022-10-18 Thread GitBox
pkarashchenko merged PR #1354: URL: https://github.com/apache/incubator-nuttx-apps/pull/1354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1354: nshlib: Rename CONFIG_SYSTEM_NSH_SYMTAB to CONFIG_NSH_SYMTAB

2022-10-18 Thread GitBox
pkarashchenko commented on PR #1354: URL: https://github.com/apache/incubator-nuttx-apps/pull/1354#issuecomment-1282950536 Seems to be a "breaking change" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6783: libc/localtime: fix some issues and update to consistent with mainline

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #6783: URL: https://github.com/apache/incubator-nuttx/pull/6783#discussion_r998655570 ## libs/libc/time/lib_localtime.c: ## @@ -412,40 +423,119 @@ static int typesequiv(FAR const struct state_s *sp, int a, int b); static int tzload(FAR c

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1358: ostest:add sem protocl to priority inheritance

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #1358: URL: https://github.com/apache/incubator-nuttx-apps/pull/1358#discussion_r998652612 ## testing/ostest/prioinherit.c: ## @@ -530,6 +530,8 @@ void priority_inheritance(void) g_medpri = my_pri - 1; sem_init(&g_sem, 0, NLOWPRI_TH

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1361: add tinycrypt to crypto

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #1361: URL: https://github.com/apache/incubator-nuttx-apps/pull/1361#discussion_r998651080 ## crypto/tinycrypt/Makefile: ## @@ -0,0 +1,89 @@ + +# apps/crypto/tinycr

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7349: gmtimer: Fixed range of tm_yday.

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #7349: URL: https://github.com/apache/incubator-nuttx/pull/7349#discussion_r998648301 ## libs/libc/time/lib_gmtimer.c: ## @@ -336,7 +336,7 @@ FAR struct tm *gmtime_r(FAR const time_t *timep, FAR struct tm *result) result->tm_wday = clo

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7344: sem:change sem default behavior

2022-10-18 Thread GitBox
pkarashchenko commented on PR #7344: URL: https://github.com/apache/incubator-nuttx/pull/7344#issuecomment-1282925127 @xiaoxiang781216 sorry, but where the sem default behaviour is changed? -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7346: stm32f7: add SocketCAN support

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #7346: URL: https://github.com/apache/incubator-nuttx/pull/7346#discussion_r998631074 ## arch/arm/src/stm32f7/stm32_can_sock.c: ## @@ -0,0 +1,2538 @@ +/ + * arch/arm

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1362: netutils: Support telnetd in the kernel mode

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #1362: URL: https://github.com/apache/incubator-nuttx-apps/pull/1362#discussion_r998625122 ## system/telnet/telnet_client.c: ## @@ -115,13 +115,17 @@ static const struct telnet_telopt_s g_telopts[] = static void send_local_input(char *bu

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7351: boards: Update telnetd related config after apps/nshlib change

2022-10-18 Thread GitBox
pkarashchenko commented on PR #7351: URL: https://github.com/apache/incubator-nuttx/pull/7351#issuecomment-1282891836 @xiaoxiang781216 is this a "breaking change" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7348: strftime: Added support for the %w format specifier.

2022-10-18 Thread GitBox
acassis commented on code in PR #7348: URL: https://github.com/apache/incubator-nuttx/pull/7348#discussion_r998592967 ## libs/libc/time/lib_strftime.c: ## @@ -398,6 +399,14 @@ size_t strftime(FAR char *s, size_t max, FAR const char *format, } break;

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1360: system: add cwebsocket support

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #1360: URL: https://github.com/apache/incubator-nuttx-apps/pull/1360#discussion_r998616725 ## netutils/cwebsocket/Kconfig: ## @@ -0,0 +1,14 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-languag

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1357: apps: system: add libjpeg

2022-10-18 Thread GitBox
pkarashchenko commented on code in PR #1357: URL: https://github.com/apache/incubator-nuttx-apps/pull/1357#discussion_r998614689 ## graphics/libjpeg/Makefile: ## @@ -0,0 +1,74 @@ + +# apps/graphics/libj

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7348: strftime: Added support for the %w format specifier.

2022-10-18 Thread GitBox
acassis commented on code in PR #7348: URL: https://github.com/apache/incubator-nuttx/pull/7348#discussion_r998592967 ## libs/libc/time/lib_strftime.c: ## @@ -398,6 +399,14 @@ size_t strftime(FAR char *s, size_t max, FAR const char *format, } break;

[GitHub] [incubator-nuttx] acassis commented on pull request #7348: strftime: Added support for the %w format specifier.

2022-10-18 Thread GitBox
acassis commented on PR #7348: URL: https://github.com/apache/incubator-nuttx/pull/7348#issuecomment-1282855961 Tested on Linux: ``` #include #include int main () { time_t rawtime; struct tm *info; char buffer[80]; time( &rawtime ); info

[GitHub] [incubator-nuttx] acassis commented on pull request #7348: strftime: Added support for the %w format specifier.

2022-10-18 Thread GitBox
acassis commented on PR #7348: URL: https://github.com/apache/incubator-nuttx/pull/7348#issuecomment-1282855612 @fjpanag : man strftime: %w The day of the week as a decimal, range 0 to 6, Sunday being 0. Should be 0 to 6, not 00 to 06, please fix! -- This is an autom

[GitHub] [incubator-nuttx] acassis merged pull request #7347: stm32/socketcan: fixes for arm_netinitialize

2022-10-18 Thread GitBox
acassis merged PR #7347: URL: https://github.com/apache/incubator-nuttx/pull/7347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[incubator-nuttx] branch master updated (ca9aeeec1f -> 27db9558de)

2022-10-18 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from ca9aeeec1f freopen: Added flush of the read buffers. add 27db9558de stm32/socketcan: fixes for arm_neti

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7351: boards: Update telnetd related config after apps/nshlib change

2022-10-18 Thread GitBox
xiaoxiang781216 opened a new pull request, #7351: URL: https://github.com/apache/incubator-nuttx/pull/7351 ## Summary paired with https://github.com/apache/incubator-nuttx-apps/pull/1362 ## Impact telnetd ## Testing Pass CI -- This is an automated message from th

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7088: sched/msgq: add support of System V message queue

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #7088: URL: https://github.com/apache/incubator-nuttx/pull/7088#discussion_r998508458 ## include/nuttx/mqueue.h: ## @@ -96,6 +96,8 @@ struct mqueue_cmn_s { + dq_queue_t waitfornotempty; /* Task list waiting for not empty */ + dq_queu

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1362: netutils: Support telnetd in the kernel mode

2022-10-18 Thread GitBox
xiaoxiang781216 commented on PR #1362: URL: https://github.com/apache/incubator-nuttx-apps/pull/1362#issuecomment-1282714888 @masayuki2009 this patch refine telnetd implementation, could you try the change with kernel mode? -- This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx-apps] pedrobertoleti opened a new pull request, #1363: Fixed unused variable and improved Kconfig for TCP IPC Client & Server

2022-10-18 Thread GitBox
pedrobertoleti opened a new pull request, #1363: URL: https://github.com/apache/incubator-nuttx-apps/pull/1363 ## Summary This PR makes the following: - Fixes unusable variable warning (ndx variable) - Improve Kconfig of TCP IPC Client and Server examples, by automatically c

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1362: netutils: Support telnetd in the kernel mode

2022-10-18 Thread GitBox
xiaoxiang781216 opened a new pull request, #1362: URL: https://github.com/apache/incubator-nuttx-apps/pull/1362 ## Summary this PR revert [Revert "netutils: Make telnetd_daemon() in public"](https://github.com/apache/incubator-nuttx-apps/commit/43ea7eb21f9566e5b101636686e4410fdca1fed5)

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1353: Remove the unnecessary cast for main_t, NULL and argv

2022-10-18 Thread GitBox
pkarashchenko merged PR #1353: URL: https://github.com/apache/incubator-nuttx-apps/pull/1353 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7339: sched.h: Simplify HAVE_GROUP_MEMBERS logic

2022-10-18 Thread GitBox
xiaoxiang781216 commented on PR #7339: URL: https://github.com/apache/incubator-nuttx/pull/7339#issuecomment-1282632566 @yamt the linker error need be addressed before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1353: Remove the unnecessary cast for main_t, NULL and argv

2022-10-18 Thread GitBox
xiaoxiang781216 commented on PR #1353: URL: https://github.com/apache/incubator-nuttx-apps/pull/1353#issuecomment-1282630669 @pkarashchenko could you merge this patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[incubator-nuttx-apps] branch master updated: apps: system: add libjpeg

2022-10-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new d6f787afc apps: system: add lib

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1357: apps: system: add libjpeg

2022-10-18 Thread GitBox
xiaoxiang781216 merged PR #1357: URL: https://github.com/apache/incubator-nuttx-apps/pull/1357 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1361: add tinycrypt to crypto

2022-10-18 Thread GitBox
xiaoxiang781216 commented on PR #1361: URL: https://github.com/apache/incubator-nuttx-apps/pull/1361#issuecomment-1282627901 @gustavonihei could you take a look? This patch replace mcuboot private copy to the official tinycrypto. -- This is an automated message from the Apache Git Servic

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #1360: system: add cwebsocket support

2022-10-18 Thread GitBox
jerpelea commented on PR #1360: URL: https://github.com/apache/incubator-nuttx-apps/pull/1360#issuecomment-1282605733 @xiaoxiang781216 thanks for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7266: ci: add qemu run support

2022-10-18 Thread GitBox
xiaoxiang781216 commented on PR #7266: URL: https://github.com/apache/incubator-nuttx/pull/7266#issuecomment-1282584549 @ttnie please rebase to the last master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[incubator-nuttx] branch master updated: freopen: Added flush of the read buffers.

2022-10-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new ca9aeeec1f freopen: Added flush of t

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7345: Added flush of the read buffers when a file is reopened.

2022-10-18 Thread GitBox
xiaoxiang781216 merged PR #7345: URL: https://github.com/apache/incubator-nuttx/pull/7345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1360: system: add cwebsocket support

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #1360: URL: https://github.com/apache/incubator-nuttx-apps/pull/1360#discussion_r998390167 ## netutils/cwebsocket/Makefile: ## @@ -0,0 +1,48 @@ + +# apps/netutils

[GitHub] [incubator-nuttx-apps] anjiahao1 opened a new pull request, #1361: Tinycrypto

2022-10-18 Thread GitBox
anjiahao1 opened a new pull request, #1361: URL: https://github.com/apache/incubator-nuttx-apps/pull/1361 ## Summary add tinycrypt to crypto and then inside of mucboot internal used lib ## Impact mcuboot ## Testing -- This is an automated message from the Apache Git

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1360: system: add cwebsocket support

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #1360: URL: https://github.com/apache/incubator-nuttx-apps/pull/1360#discussion_r998356876 ## netutils/websocket/Makefile: ## @@ -0,0 +1,50 @@ + +# apps/netutils/

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1360: system: add cwebsocket support

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #1360: URL: https://github.com/apache/incubator-nuttx-apps/pull/1360#discussion_r998355774 ## netutils/websocket/Makefile: ## @@ -0,0 +1,50 @@ + +# apps/netutils/

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1360: system: add cwebsocket support

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #1360: URL: https://github.com/apache/incubator-nuttx-apps/pull/1360#discussion_r998353207 ## netutils/websocket/Kconfig: ## @@ -0,0 +1,14 @@ +# +# For a description of the syntax of this configuration file, +# see the file kconfig-langua

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1360: system: add cwebsocket support

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #1360: URL: https://github.com/apache/incubator-nuttx-apps/pull/1360#discussion_r998352880 ## netutils/websocket/Kconfig: ## @@ -0,0 +1,14 @@ +# Review Comment: should we change websocket to cwebsocket? -- This is an automated mes

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7350: net/tcp: remove debug counter of connect instance

2022-10-18 Thread GitBox
anchao opened a new pull request, #7350: URL: https://github.com/apache/incubator-nuttx/pull/7350 ## Summary net/tcp: remove debug counter of connect instance Fixed by commit: | net: remove pvconn reference from all devif callback | | Do not use 'pvconn' argu

[incubator-nuttx-apps] branch master updated (c90866141 -> f844db519)

2022-10-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from c90866141 Client & Server examples to use TCP/IP socket as an IPC Channel for LoRaWAN new bca94

[incubator-nuttx-apps] 02/02: libapps.a: Add the static application library always to the target libraries

2022-10-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit f844db51942be35b5cbcfde0ba3077999c0d6b00 Author: Ville Juven AuthorDate: Fri Oct 14 10:01:50 2022 +0300

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1359: Libapps for kernel build

2022-10-18 Thread GitBox
xiaoxiang781216 merged PR #1359: URL: https://github.com/apache/incubator-nuttx-apps/pull/1359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[incubator-nuttx-apps] 01/02: CONFIG_BUILD_KERNEL/libapps.a: Allow creation of libapps.a separately

2022-10-18 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit bca94fce5aafdb2a01962975c8435cf92688b51a Author: Ville Juven AuthorDate: Fri Oct 14 09:59:49 2022 +0300

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7346: stm32f7: add SocketCAN support

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #7346: URL: https://github.com/apache/incubator-nuttx/pull/7346#discussion_r998345864 ## boards/arm/stm32f7/nucleo-144/configs/f722-cansock/Make.defs: ## @@ -0,0 +1,39 @@ +###

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7346: stm32f7: add SocketCAN support

2022-10-18 Thread GitBox
xiaoxiang781216 commented on code in PR #7346: URL: https://github.com/apache/incubator-nuttx/pull/7346#discussion_r998345440 ## boards/arm/stm32f7/nucleo-144/configs/f722-can/Make.defs: ## @@ -0,0 +1,39 @@ +###

[GitHub] [incubator-nuttx-apps] jerpelea commented on a diff in pull request #1360: system: add cwebsocket support

2022-10-18 Thread GitBox
jerpelea commented on code in PR #1360: URL: https://github.com/apache/incubator-nuttx-apps/pull/1360#discussion_r998302102 ## system/websocket/Make.defs: ## @@ -0,0 +1,26 @@ + +# apps/system/cwebsocket

[GitHub] [incubator-nuttx-apps] jerpelea commented on a diff in pull request #1360: system: add cwebsocket support

2022-10-18 Thread GitBox
jerpelea commented on code in PR #1360: URL: https://github.com/apache/incubator-nuttx-apps/pull/1360#discussion_r998301536 ## system/websocket/0001-Porting-the-code-for-NuttX.patch: ## @@ -0,0 +1,2257 @@ +From be917069caddfc701169f165c6900ee3cc919f0e Mon Sep 17 00:00:00 2001 +

  1   2   >