pkarashchenko commented on code in PR #5070: URL: https://github.com/apache/incubator-nuttx/pull/5070#discussion_r998678545
########## include/semaphore.h: ########## @@ -48,8 +48,8 @@ /* Bit definitions for the struct sem_s flags field */ -#define PRIOINHERIT_FLAGS_DISABLE (1 << 0) /* Bit 0: Priority inheritance - * is disabled for this semaphore. */ +#define PRIOINHERIT_FLAGS_ENABLE (1 << 0) /* Bit 0: Priority inheritance Review Comment: I do not see where `NXMUTEX_INITIALIZER` and `NXRMUTEX_INITIALIZER` are updated to reflect this change. ########## arch/arm/src/am335x/am335x_i2c.c: ########## @@ -316,7 +316,7 @@ static struct am335x_i2c_priv_s am335x_i2c0_priv = .refs = 0, .lock = NXMUTEX_INITIALIZER, #ifndef CONFIG_I2C_POLLED - .sem_isr = NXSEM_INITIALIZER(0, PRIOINHERIT_FLAGS_DISABLE), + .sem_isr = SEM_INITIALIZER(0), Review Comment: Let's use `NXSEM_INITIALIZER` in kernel code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
