[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1362: netutils: Support telnetd in the kernel mode

[GitBox]

pkarashchenko commented on code in PR #1362:
URL: 
https://github.com/apache/incubator-nuttx-apps/pull/1362#discussion_r998625122


##########
system/telnet/telnet_client.c:
##########
@@ -115,13 +115,17 @@ static const struct telnet_telopt_s g_telopts[] =
 
 static void send_local_input(char *buffer, int size)

Review Comment:
   Maybe for the next PR:
   ```suggestion
   static void send_local_input(FAR char *buffer, int size)
   ```



##########
examples/telnetd/telnetd.c:
##########
@@ -127,7 +127,7 @@ static void telnetd_quit(int argc, char **argv)
 
 static void telnetd_parse(FAR char *line, int len)
 {
-  struct ptentry_s *entry;
+  FAR const struct ptentry_s *entry;

Review Comment:
   Maybe add `FAR` in `telnetd_session` in the next PR



##########
system/telnet/telnet_client.c:
##########
@@ -295,7 +308,9 @@ int main(int argc, FAR char *argv[])
 #ifdef CONFIG_NET_IPv4
     struct sockaddr_in ipv4;
 #endif
-  } local;
+  }
+
+  local;

Review Comment:
   ditto



##########
system/telnet/telnet_client.c:
##########
@@ -286,7 +297,9 @@ int main(int argc, FAR char *argv[])
 #ifdef CONFIG_NET_IPv4
     struct sockaddr_in ipv4;
 #endif
-  } server;
+  }
+
+  server;

Review Comment:
   why do we need a newline here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org