[GitHub] [incubator-nuttx] masayuki2009 closed issue #5184: Replace all place which use semaphore as lock with mutex wrapper

2022-10-16 Thread GitBox
masayuki2009 closed issue #5184: Replace all place which use semaphore as lock with mutex wrapper URL: https://github.com/apache/incubator-nuttx/issues/5184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
masayuki2009 merged PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1280361897 @pkarashchenko @masayuki2009 could we merge this patch now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-nuttx] ttnie commented on pull request #7298: install qemu on docker

2022-10-16 Thread GitBox
ttnie commented on PR #7298: URL: https://github.com/apache/incubator-nuttx/pull/7298#issuecomment-1280361619 add --prefix as configure part, then copy to /tools/qemu/bin, and added to env PATH -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7318: sched/env: Skip the envirnment variable duplication of kernel thread

2022-10-16 Thread GitBox
xiaoxiang781216 commented on PR #7318: URL: https://github.com/apache/incubator-nuttx/pull/7318#issuecomment-1280360728 @masayuki2009 I try rv-virt:knsh64 with the last mainline: ``` commit 0dfd1f004defb2278bf99e305859a4cbb07675b0 Author: Alan Carvalho de Assis Date: Sun Oct 16

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1356: nshlib: Fix warning reported by clang

2022-10-16 Thread GitBox
xiaoxiang781216 opened a new pull request, #1356: URL: https://github.com/apache/incubator-nuttx-apps/pull/1356 ## Summary nsh_telnetlogin.c:62:15: error: implicit conversion from 'int' to 'char' changes value from 255 to -1 [-Werror,-Wconstant-conversion] ## Impact Fix warning

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

2022-10-16 Thread GitBox
xiaoxiang781216 commented on PR #7319: URL: https://github.com/apache/incubator-nuttx/pull/7319#issuecomment-1280321094 > @xiaoxiang781216 > > Hmm, ps command not found with `hifive1-revb:nsh` > > ``` > NuttShell (NSH) NuttX-3.6.1 > nsh> uname -a > NuttX 3.6.1 25df009f8

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1355: nshlib: Reuse nsh_session logic in nsh_telnetmain

2022-10-16 Thread GitBox
xiaoxiang781216 commented on PR #1355: URL: https://github.com/apache/incubator-nuttx-apps/pull/1355#issuecomment-1280261182 @masayuki2009 could you review this patch? This is the first patch to reconstruct telnetd after your change: https://github.com/apache/incubator-nuttx-apps/pull/1254

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7332: boards/sim: Enable CONFIG_NSH_TELNET_LOGIN for adb

2022-10-16 Thread GitBox
xiaoxiang781216 opened a new pull request, #7332: URL: https://github.com/apache/incubator-nuttx/pull/7332 ## Summary to test the telnet login functionality. ## Impact Minor ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7318: sched/env: Skip the envirnment variable duplication of kernel thread

2022-10-16 Thread GitBox
masayuki2009 commented on PR #7318: URL: https://github.com/apache/incubator-nuttx/pull/7318#issuecomment-1280111662 @xiaoxiang781216 `rv-virt:knsh64` fails when booting. NOTE: I tried to change ` CONFIG_ARCH_INTERRUPTSTACK` from 2048 to 4096 but the issue still happens. `

[incubator-nuttx-website] branch asf-site updated: Publishing web: d696c67810809c3f81a4dd87b09d9e940db854b4 docs: 0dfd1f004defb2278bf99e305859a4cbb07675b0

2022-10-16 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new f9e4bdc Publishing web

[GitHub] [incubator-nuttx] abdallah-ali-abdallah opened a new issue, #7331: Question: How to enable nsh over composite usb configuration using RP2040

2022-10-16 Thread GitBox
abdallah-ali-abdallah opened a new issue, #7331: URL: https://github.com/apache/incubator-nuttx/issues/7331 Hello, I'm using raspberry pi pico (RP2040) and trying to build an application requires exposing 4 USB composite devices for example, I need to run the following over USB2.0 interfa

[GitHub] [incubator-nuttx-apps] pedrobertoleti commented on pull request #1349: Client & Server examples to use TCP/IP socket as an IPC Channel

2022-10-16 Thread GitBox
pedrobertoleti commented on PR #1349: URL: https://github.com/apache/incubator-nuttx-apps/pull/1349#issuecomment-1280097854 @acassis @xiaoxiang781216 and @pkarashchenko , I've just fixed the issues pointed by you. Please, would you review it again? -- This is an automated message from t

[incubator-nuttx] branch master updated (947e771c41 -> 0dfd1f004d)

2022-10-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 947e771c41 fix typo big letter 'o' in hex value for zero. add 655faa33d4 ESP32: Add support to Qu

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
pkarashchenko merged PR #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1353: Remove the unnecessary cast for main_t, NULL and argv

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #1353: URL: https://github.com/apache/incubator-nuttx-apps/pull/1353#discussion_r996496659 ## examples/poll/select_listener.c: ## @@ -77,18 +77,18 @@ void *select_listener(pthread_addr_t pvarg) /* Open the FIFO for non-blocking read */

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1355: nshlib: Reuse nsh_session logic in nsh_telnetmain

2022-10-16 Thread GitBox
xiaoxiang781216 opened a new pull request, #1355: URL: https://github.com/apache/incubator-nuttx-apps/pull/1355 ## Summary to avoid the code duplication ## Impact Code refactor only ## Testing Pass CI -- This is an automated message from the Apache Git Service. T

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1353: Remove the unnecessary cast for main_t, NULL and argv

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #1353: URL: https://github.com/apache/incubator-nuttx-apps/pull/1353#discussion_r996492804 ## examples/poll/select_listener.c: ## @@ -77,18 +77,18 @@ void *select_listener(pthread_addr_t pvarg) /* Open the FIFO for non-blocking read */

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7330: board: Change CONFIG_SYSTEM_NSH_SYMTAB to CONFIG_NSH_SYMTAB

2022-10-16 Thread GitBox
xiaoxiang781216 opened a new pull request, #7330: URL: https://github.com/apache/incubator-nuttx/pull/7330 ## Summary follow the apps side change: https://github.com/apache/incubator-nuttx-apps/pull/1354 ## Impact ## Testing -- This is an automated message from th

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1354: nshlib: Rename CONFIG_SYSTEM_NSH_SYMTAB to CONFIG_NSH_SYMTAB

2022-10-16 Thread GitBox
xiaoxiang781216 opened a new pull request, #1354: URL: https://github.com/apache/incubator-nuttx-apps/pull/1354 ## Summary Follow up the patch: https://github.com/apache/incubator-nuttx-apps/pull/1350/commits/44b90f584a05c9b52ccc0f0ba6a97cc365ba1298 ## Impact ## Testing

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1353: Remove the unnecessary cast for main_t, NULL and argv

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #1353: URL: https://github.com/apache/incubator-nuttx-apps/pull/1353#discussion_r996491703 ## graphics/nxwidgets/UnitTests/CButton/cbuttontest.cxx: ## @@ -64,9 +64,9 @@ CButtonTest::CButtonTest() { - m_bgWindow = (CBgWindow *)NULL; -

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7198: libs/libc: add obstack

2022-10-16 Thread GitBox
acassis commented on code in PR #7198: URL: https://github.com/apache/incubator-nuttx/pull/7198#discussion_r996491755 ## libs/libc/obstack/lib_obstack_grow.c: ## @@ -0,0 +1,54 @@ +/ + * libs/libc/obstack

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1353: Remove the unnecessary cast for main_t, NULL and argv

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #1353: URL: https://github.com/apache/incubator-nuttx-apps/pull/1353#discussion_r996491703 ## graphics/nxwidgets/UnitTests/CButton/cbuttontest.cxx: ## @@ -64,9 +64,9 @@ CButtonTest::CButtonTest() { - m_bgWindow = (CBgWindow *)NULL; -

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #7233: mtd/smart: compile error in smart_fsck

2022-10-16 Thread GitBox
pkarashchenko commented on issue #7233: URL: https://github.com/apache/incubator-nuttx/issues/7233#issuecomment-1280049614 Is the issue already fixed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
pkarashchenko commented on PR #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328#issuecomment-1280048558 Please ping me when all changes are applied. Also please squash commints -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328#discussion_r996489621 ## arch/xtensa/src/esp32/esp32_qencoder.c: ## @@ -0,0 +1,928 @@ +/ + * arch/xte

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
acassis commented on code in PR #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328#discussion_r996489606 ## arch/xtensa/src/esp32/esp32_qencoder.c: ## @@ -0,0 +1,928 @@ +/ + * arch/xtensa/sr

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
acassis commented on code in PR #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328#discussion_r996489348 ## arch/xtensa/src/esp32/esp32_qencoder.c: ## @@ -0,0 +1,928 @@ +/ + * arch/xtensa/sr

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1353: Remove the unnecessary cast for main_t, NULL and argv

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #1353: URL: https://github.com/apache/incubator-nuttx-apps/pull/1353#discussion_r996485995 ## graphics/pdcurs34/pdcurses/pdc_terminfo.c: ## @@ -244,15 +244,15 @@ char *tigetstr(const char *capname) { PDC_LOG(("tigetstr() - called: capna

[GitHub] [incubator-nuttx-apps] hartmannathan commented on pull request #1350: Refine nshlib implementation

2022-10-16 Thread GitBox
hartmannathan commented on PR #1350: URL: https://github.com/apache/incubator-nuttx-apps/pull/1350#issuecomment-1280040024 > @hartmannathan please merge if you are fine with this changes Done. Thanks! -- This is an automated message from the Apache Git Service. To respond to the me

[incubator-nuttx-apps] 02/04: nshlib: Call nsh_telnetstart in nsh_initialize to avoid the dupliation

2022-10-16 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 964747dd36db46428bd767d13aaee6f60f32d0b5 Author: Xiang Xiao AuthorDate: Sat Oct 15 17:00:22 2022 +0

[incubator-nuttx-apps] 01/04: nshlib: Call nsh_sysinitscript in usb or alt console like normal one

2022-10-16 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit cf70d8f95bccb265ba84acc5e3957ada64cdf379 Author: Xiang Xiao AuthorDate: Sat Oct 15 16:31:12 2022 +0

[incubator-nuttx-apps] branch master updated (893387b2c -> 8e460e7e1)

2022-10-16 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git from 893387b2c Fix the minor style issue new cf70d8f95 nshlib: Call nsh_sysinitscript in usb or a

[incubator-nuttx-apps] 03/04: nshlib: Move commoin initialization from console_main to nsh_initialize

2022-10-16 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 0d210c3227f2b49955e59e04d0f9c674223c9066 Author: Xiang Xiao AuthorDate: Sat Oct 15 17:31:04 2022 +0

[incubator-nuttx-apps] 04/04: nshlib: Move symbol table initialization from nsh_main to nsh_initialize

2022-10-16 Thread hartmannathan
This is an automated email from the ASF dual-hosted git repository. hartmannathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 8e460e7e19747ff8cb148f7bde5492cd118f20fd Author: Xiang Xiao AuthorDate: Sat Oct 15 17:53:09 2022 +0

[GitHub] [incubator-nuttx-apps] hartmannathan merged pull request #1350: Refine nshlib implementation

2022-10-16 Thread GitBox
hartmannathan merged PR #1350: URL: https://github.com/apache/incubator-nuttx-apps/pull/1350 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996485176 ## drivers/input/stmpe811_base.c: ## @@ -302,6 +302,7 @@ STMPE811_HANDLE stmpe811_instantiate(FAR struct i2c_master_s *dev, ret = stmpe811_checkid(priv

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1353: Remove the unnecessary cast for main_t, NULL and argv

2022-10-16 Thread GitBox
xiaoxiang781216 opened a new pull request, #1353: URL: https://github.com/apache/incubator-nuttx-apps/pull/1353 ## Summary ## Impact Minor, code refactor ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

2022-10-16 Thread GitBox
xiaoxiang781216 commented on PR #7319: URL: https://github.com/apache/incubator-nuttx/pull/7319#issuecomment-1280034150 @acassis @pkarashchenko done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1280034074 @pkarashchenko done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996482144 ## drivers/input/stmpe811_base.c: ## @@ -302,6 +302,7 @@ STMPE811_HANDLE stmpe811_instantiate(FAR struct i2c_master_s *dev, ret = stmpe811_checkid(pr

[incubator-nuttx] branch master updated (47b47e0bb7 -> 947e771c41)

2022-10-16 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 47b47e0bb7 fs/vfs: Remove the redundancy file name comparison in mountptrename add 947e771c41 fix ty

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7329: fix typo big letter 'o' in hex value for zero.

2022-10-16 Thread GitBox
xiaoxiang781216 merged PR #7329: URL: https://github.com/apache/incubator-nuttx/pull/7329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
acassis commented on code in PR #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328#discussion_r996477851 ## arch/xtensa/src/esp32/esp32_qencoder.c: ## @@ -0,0 +1,928 @@ +/ + * arch/xtensa/sr

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
acassis commented on code in PR #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328#discussion_r996477811 ## arch/xtensa/src/esp32/esp32_qencoder.c: ## @@ -0,0 +1,928 @@ +/ + * arch/xtensa/sr

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
acassis commented on code in PR #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328#discussion_r996477396 ## arch/xtensa/src/esp32/hardware/esp32_pcnt.h: ## @@ -0,0 +1,2495 @@ +/ + * arch/xte

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
acassis commented on code in PR #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328#discussion_r996477213 ## arch/xtensa/src/esp32/hardware/esp32_pcnt.h: ## @@ -0,0 +1,2495 @@ +/ + * arch/xte

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
acassis commented on code in PR #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328#discussion_r996476912 ## arch/xtensa/src/esp32/esp32_qencoder.c: ## @@ -0,0 +1,928 @@ +/ + * arch/xtensa/sr

[incubator-nuttx] branch master updated (6854cce059 -> 47b47e0bb7)

2022-10-16 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 6854cce059 sched/spawn: Add the dummy task_spawnattr_xxxstackyyy in the kernel mode add 7b19a605a7 fs/

[GitHub] [incubator-nuttx] acassis merged pull request #7317: Refine the implementation of rename

2022-10-16 Thread GitBox
acassis merged PR #7317: URL: https://github.com/apache/incubator-nuttx/pull/7317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996470424 ## drivers/lcd/ht16k33_14seg.c: ## @@ -107,7 +108,7 @@ struct ht16k33_dev_s uint8_tcol; /* Current col position to write on display *

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996471651 ## drivers/serial/ptmx.c: ## @@ -276,7 +277,7 @@ int ptmx_register(void) { /* Initialize driver state */ - nxsem_init(&g_ptmx.px_exclsem, 0, 1); +

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996471606 ## drivers/timers/pwm.c: ## @@ -602,7 +603,7 @@ int pwm_register(FAR const char *path, FAR struct pwm_lowerhalf_s *dev) * kmm_zalloc()). */ -

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996471511 ## drivers/serial/serial.c: ## @@ -1683,14 +1659,14 @@ int uart_register(FAR const char *path, FAR uart_dev_t *dev) } #endif - /* Initialize se

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996470868 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_sdio.c: ## @@ -674,7 +674,7 @@ static int bcmf_bus_sdio_initialize(FAR struct bcmf_dev_s *priv, /* Init

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996470518 ## wireless/bluetooth/bt_ioctl.c: ## @@ -628,7 +629,7 @@ int btnet_ioctl(FAR struct net_driver_s *netdev, int cmd, unsigned long arg) i

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996469452 ## drivers/sensors/lsm330_spi.c: ## @@ -1370,7 +1367,7 @@ int lsm330_register(FAR const char *devpath_acl, priv->flink = g_lsm330a_list; g_lsm330a_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996469335 ## wireless/pktradio/pktradio_metadata.c: ## @@ -49,7 +49,7 @@ static FAR struct pktradio_metadata_s *g_free_metadata; /* Supports mutually exclusive

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996469192 ## libs/libc/wqueue/work_usrthread.c: ## @@ -281,7 +280,7 @@ int work_usrstart(void) /* Set up the work queue lock */ - _SEM_INIT(&g_usrwork.lock

[incubator-nuttx] branch master updated: sched/spawn: Add the dummy task_spawnattr_xxxstackyyy in the kernel mode

2022-10-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 6854cce059 sched/spawn: Add the

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7327: sched/spawn: Add the dummy task_spawnattr_xxxstackyyy in the kernel mode

2022-10-16 Thread GitBox
pkarashchenko merged PR #7327: URL: https://github.com/apache/incubator-nuttx/pull/7327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996468049 ## drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi.c: ## @@ -856,7 +856,7 @@ static int bcmf_bus_gspi_initialize(FAR struct bcmf_dev_s *priv, /* Ini

[incubator-nuttx-apps] branch master updated: Fix the minor style issue

2022-10-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 893387b2c Fix the minor sty

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1340: Fix the minor style issue

2022-10-16 Thread GitBox
pkarashchenko merged PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1350: Refine nshlib implementation

2022-10-16 Thread GitBox
pkarashchenko commented on PR #1350: URL: https://github.com/apache/incubator-nuttx-apps/pull/1350#issuecomment-1280010106 @hartmannathan please merge if you are fine with this changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[incubator-nuttx] branch master updated (ffe8dd39c6 -> b9cd0508e7)

2022-10-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from ffe8dd39c6 arch/arm64: update for coding style add 78f6a02bc8 boards: Remove the duplicated proto

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7324: boards: Remove the duplicated prototype of CONFIG_INIT_ENTRYPOINT

2022-10-16 Thread GitBox
pkarashchenko merged PR #7324: URL: https://github.com/apache/incubator-nuttx/pull/7324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #7319: URL: https://github.com/apache/incubator-nuttx/pull/7319#discussion_r996467030 ## fs/procfs/fs_procfs.c: ## @@ -1025,7 +989,7 @@ static int procfs_statfs(struct inode *mountpt, struct statfs *buf) static int procfs_stat(struct inode

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996466761 ## drivers/usbhost/usbhost_hidkbd.c: ## @@ -2551,7 +2504,7 @@ int usbhost_kbdinit(void) { /* Perform any one-time initialization of the class impleme

[GitHub] [incubator-nuttx] ticso24 opened a new pull request, #7329: fix typo big letter 'o' in hex value for zero.

2022-10-16 Thread GitBox
ticso24 opened a new pull request, #7329: URL: https://github.com/apache/incubator-nuttx/pull/7329 ## Summary Hex value contains letter O instead of number 0. ## Impact compile error if the define is being used ## Testing -- This is an automated message from the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996460570 ## drivers/sensors/adxl345_base.c: ## @@ -373,7 +373,7 @@ ADXL345_HANDLE adxl345_instantiate(FAR struct i2c_master_s *dev, /* Initialize the device

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r996460258 ## drivers/sensors/qencoder.c: ## @@ -409,7 +409,7 @@ int qe_register(FAR const char *devpath, FAR struct qe_lowerhalf_s *lower) * (it was already z

[GitHub] [incubator-nuttx] acassis closed pull request #7320: Kconfig: use "default y if DEFAULT_SMALL" for readability

2022-10-16 Thread GitBox
acassis closed pull request #7320: Kconfig: use "default y if DEFAULT_SMALL" for readability URL: https://github.com/apache/incubator-nuttx/pull/7320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-nuttx] acassis commented on pull request #7320: Kconfig: use "default y if DEFAULT_SMALL" for readability

2022-10-16 Thread GitBox
acassis commented on PR #7320: URL: https://github.com/apache/incubator-nuttx/pull/7320#issuecomment-1279992043 Ok! If you and @xiaoxiang781216 think it is fine I will close this PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-nuttx] acassis opened a new pull request, #7328: esp32: Add support to Quadrature Encoder

2022-10-16 Thread GitBox
acassis opened a new pull request, #7328: URL: https://github.com/apache/incubator-nuttx/pull/7328 ## Summary Add support to Quadrature Encoder ## Impact Users will be able to use QE and Rotary Encoder with NuttX on ESP32 ## Testing esp32-devkitc -- This is an automated

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7319: URL: https://github.com/apache/incubator-nuttx/pull/7319#discussion_r996455791 ## fs/procfs/fs_procfs.c: ## @@ -186,25 +176,21 @@ static const struct procfs_entry_s g_procfs_entries[] = #endif }; -#ifdef CONFIG_FS_PROCFS_REGISTE

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7324: boards: Remove the duplicated prototype of CONFIG_INIT_ENTRYPOINT

2022-10-16 Thread GitBox
xiaoxiang781216 commented on PR #7324: URL: https://github.com/apache/incubator-nuttx/pull/7324#issuecomment-1279975243 Fix all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7324: boards: Remove the duplicated prototype of CONFIG_INIT_ENTRYPOINT

2022-10-16 Thread GitBox
pkarashchenko commented on PR #7324: URL: https://github.com/apache/incubator-nuttx/pull/7324#issuecomment-1279974523 Same with `dram_main.c:76:5: error: conflicting types for 'dram_main'` -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7318: sched/env: Skip the envirnment variable duplication of kernel thread

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #7318: URL: https://github.com/apache/incubator-nuttx/pull/7318#discussion_r996445093 ## sched/init/nx_bringup.c: ## @@ -224,19 +224,34 @@ static inline void nx_workqueues(void) static inline void nx_start_application(void) { -#ifdef CON

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7318: sched/env: Skip the envirnment variable duplication of kernel thread

2022-10-16 Thread GitBox
xiaoxiang781216 commented on PR #7318: URL: https://github.com/apache/incubator-nuttx/pull/7318#issuecomment-1279971664 @masayuki2009 please try again, I verify the update with sim:posix_spawn without problem. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7294: tools/ci: patch for docker gcc-arm-none-eabi to 11.3.Rel1 August 08, 2022

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #7294: URL: https://github.com/apache/incubator-nuttx/pull/7294#discussion_r996442093 ## tools/ci/docker/linux/Dockerfile: ## @@ -85,7 +86,9 @@ FROM nuttx-toolchain-base AS nuttx-toolchain-arm # Download the latest ARM GCC toolchain prebuil

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #7319: URL: https://github.com/apache/incubator-nuttx/pull/7319#discussion_r996441187 ## fs/procfs/fs_procfs.c: ## @@ -186,25 +176,21 @@ static const struct procfs_entry_s g_procfs_entries[] = #endif }; -#ifdef CONFIG_FS_PROCFS_REGISTER

[GitHub] [incubator-nuttx-apps] hartmannathan commented on pull request #1350: Refine nshlib implementation

2022-10-16 Thread GitBox
hartmannathan commented on PR #1350: URL: https://github.com/apache/incubator-nuttx-apps/pull/1350#issuecomment-1279966351 > Will nsh over telnet still work? > > (I use nsh over telnet on some boards that lack serial ports.) Ah, nevermind, I see the where the call to `nsh_telne

[incubator-nuttx-apps] branch master updated: Make.defs: Change "ifeq ($(XXX),y)" to "ifneq ($(XXX),)

2022-10-16 Thread pkarashchenko
This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 4941182cc Make.defs: Change

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1352: Make.defs: Change "ifeq ($(XXX),y)" to "ifneq ($(XXX),)

2022-10-16 Thread GitBox
pkarashchenko merged PR #1352: URL: https://github.com/apache/incubator-nuttx-apps/pull/1352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-uns

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1352: Make.defs: Change "ifeq ($(XXX),y)" to "ifneq ($(XXX),)

2022-10-16 Thread GitBox
pkarashchenko commented on PR #1352: URL: https://github.com/apache/incubator-nuttx-apps/pull/1352#issuecomment-1279964705 > > Why not change to `ifneq ($(CONFIG_XXX),n)`? > > tristate has three possible values(y, m, n), only n(empty) can skip the build, both y and m need continue.

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1352: Make.defs: Change "ifeq ($(XXX),y)" to "ifneq ($(XXX),)

2022-10-16 Thread GitBox
xiaoxiang781216 commented on PR #1352: URL: https://github.com/apache/incubator-nuttx-apps/pull/1352#issuecomment-1279961470 > Why not change to `ifneq ($(CONFIG_XXX),n)`? tristate has three possible value(y, m, n), only n can skip the build, both y and m need continue. -- This is

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7324: boards: Remove the duplicated prototype of CONFIG_INIT_ENTRYPOINT

2022-10-16 Thread GitBox
xiaoxiang781216 commented on PR #7324: URL: https://github.com/apache/incubator-nuttx/pull/7324#issuecomment-1279961190 > ``` > Error: nor_main.c:78:5: error: conflicting types for 'nor_main' >78 | int nor_main(int argc, char *argv) > | ^~~~ > In file included fr

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7327: sched/spawn: Add the dummy task_spawnattr_xxxstackyyy in the kernel mode

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7327: URL: https://github.com/apache/incubator-nuttx/pull/7327#discussion_r996436973 ## include/spawn.h: ## @@ -216,6 +217,12 @@ int task_spawnattr_getstacksize(FAR const posix_spawnattr_t *attr, FAR size

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #7319: URL: https://github.com/apache/incubator-nuttx/pull/7319#discussion_r996436090 ## fs/procfs/fs_procfs.c: ## @@ -184,27 +184,24 @@ static const struct procfs_entry_s g_procfs_entries[] = #if defined(CONFIG_DEBUG_TCBINFO) && !defined(C

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7327: sched/spawn: Add the dummy task_spawnattr_xxxstackyyy in the kernel mode

2022-10-16 Thread GitBox
pkarashchenko commented on code in PR #7327: URL: https://github.com/apache/incubator-nuttx/pull/7327#discussion_r996435401 ## include/spawn.h: ## @@ -216,6 +217,12 @@ int task_spawnattr_getstacksize(FAR const posix_spawnattr_t *attr, FAR size_t

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7327: sched/spawn: Add the dummy task_spawnattr_xxxstackyyy in the kernel mode

2022-10-16 Thread GitBox
xiaoxiang781216 opened a new pull request, #7327: URL: https://github.com/apache/incubator-nuttx/pull/7327 ## Summary ## Impact Minor ## Testing Pass CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

2022-10-16 Thread GitBox
acassis commented on code in PR #7319: URL: https://github.com/apache/incubator-nuttx/pull/7319#discussion_r996433969 ## fs/procfs/Kconfig: ## @@ -31,15 +31,15 @@ menu "Exclude individual procfs entries" config FS_PROCFS_EXCLUDE_PROCESS bool "Exclude process informati

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7319: URL: https://github.com/apache/incubator-nuttx/pull/7319#discussion_r996433261 ## fs/procfs/fs_procfs.c: ## @@ -184,27 +184,24 @@ static const struct procfs_entry_s g_procfs_entries[] = #if defined(CONFIG_DEBUG_TCBINFO) && !defined

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7319: URL: https://github.com/apache/incubator-nuttx/pull/7319#discussion_r996433261 ## fs/procfs/fs_procfs.c: ## @@ -184,27 +184,24 @@ static const struct procfs_entry_s g_procfs_entries[] = #if defined(CONFIG_DEBUG_TCBINFO) && !defined

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7317: Refine the implementation of rename

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #7317: URL: https://github.com/apache/incubator-nuttx/pull/7317#discussion_r996432560 ## fs/vfs/fs_rename.c: ## @@ -90,7 +90,7 @@ static int pseudorename(FAR const char *oldpath, FAR struct inode *oldinode, { inode_rel

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1350: Refine nshlib implementation

2022-10-16 Thread GitBox
xiaoxiang781216 commented on code in PR #1350: URL: https://github.com/apache/incubator-nuttx-apps/pull/1350#discussion_r996431512 ## nshlib/nsh_init.c: ## @@ -66,25 +100,86 @@ static const struct extmatch_vtable_s g_nsh_extmatch = void nsh_initialize(void) { +#if defined (

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7294: tools/ci: patch for docker gcc-arm-none-eabi to 11.3.Rel1 August 08, 2022

2022-10-16 Thread GitBox
anchao commented on code in PR #7294: URL: https://github.com/apache/incubator-nuttx/pull/7294#discussion_r996431238 ## tools/ci/docker/linux/Dockerfile: ## @@ -85,7 +86,9 @@ FROM nuttx-toolchain-base AS nuttx-toolchain-arm # Download the latest ARM GCC toolchain prebuilt by AR

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7318: sched/env: Skip the envirnment variable duplication of kernel thread

2022-10-16 Thread GitBox
masayuki2009 commented on PR #7318: URL: https://github.com/apache/incubator-nuttx/pull/7318#issuecomment-1279950194 @xiaoxiang781216 >Hmm, I noticed that 'hello' application not found with spresense:wifi_smp The issue does not happen now but 'spresense:posix_spawn' has a probl

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #7325: Revert "Revert "tools/ci: patch for gcc-arm-none-eabi to 11.3.Rel1 August 08, 2022""

2022-10-16 Thread GitBox
anchao commented on code in PR #7325: URL: https://github.com/apache/incubator-nuttx/pull/7325#discussion_r996428670 ## tools/ci/docker/linux/Dockerfile: ## @@ -84,8 +85,10 @@ WORKDIR /tools FROM nuttx-toolchain-base AS nuttx-toolchain-arm # Download the latest ARM GCC toolcha

  1   2   >