pkarashchenko commented on code in PR #7319:
URL: https://github.com/apache/incubator-nuttx/pull/7319#discussion_r996441187


##########
fs/procfs/fs_procfs.c:
##########
@@ -186,25 +176,21 @@ static const struct procfs_entry_s g_procfs_entries[] =
 #endif
 };
 
-#ifdef CONFIG_FS_PROCFS_REGISTER
 static const uint8_t g_base_entrycount = sizeof(g_base_entries) /
                                          sizeof(struct procfs_entry_s);
 
+#ifdef CONFIG_FS_PROCFS_REGISTER
 static FAR struct procfs_entry_s *g_procfs_entries;
 static uint8_t g_procfs_entrycount;
 #else
-static const uint8_t g_procfs_entrycount = sizeof(g_procfs_entries) /
-                                           sizeof(struct procfs_entry_s);
+static FAR const struct procfs_entry_s *g_procfs_entries = g_base_entries;

Review Comment:
   Maybe we can use `define` and not introduce new variable?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to