[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7319: fs/procfs: Change FS_PROCFS_EXCLUDE_xxx default value to DEFAULT_SMALL

[GitBox]

pkarashchenko commented on code in PR #7319:
URL: https://github.com/apache/incubator-nuttx/pull/7319#discussion_r996467030


##########
fs/procfs/fs_procfs.c:
##########
@@ -1025,7 +989,7 @@ static int procfs_statfs(struct inode *mountpt, struct 
statfs *buf)
 static int procfs_stat(struct inode *mountpt, const char *relpath,
                        struct stat *buf)

Review Comment:
   ditto
   ```suggestion
   static int procfs_stat(FAR struct inode *mountpt, FAR const char *relpath,
                          FAR struct stat *buf)
   ```



##########
fs/procfs/fs_procfs.c:
##########
@@ -375,15 +363,14 @@ static int procfs_open(FAR struct file *filep, FAR const 
char *relpath,
           /* Match found!  Stat using this procfs entry */
 
           DEBUGASSERT(g_procfs_entries[x].ops &&
-              g_procfs_entries[x].ops->open);
+                      g_procfs_entries[x].ops->open);
 
           ret = g_procfs_entries[x].ops->open(filep, relpath, oflags, mode);
-
           if (ret == OK)
             {
               DEBUGASSERT(filep->f_priv);
 
-              ((struct procfs_file_s *) filep->f_priv)->procfsentry =
+              ((struct procfs_file_s *)filep->f_priv)->procfsentry =

Review Comment:
   Note for one of next PRs.
   ```suggestion
                 ((FAR struct procfs_file_s *)filep->f_priv)->procfsentry =
   ```



##########
fs/procfs/fs_procfs.c:
##########
@@ -947,7 +911,7 @@ static int procfs_rewinddir(struct inode *mountpt, struct 
fs_dirent_s *dir)
 
   if (priv->level > 0 && priv->procfsentry == NULL)
     {
-      priv->index = ((struct procfs_level1_s *) priv)->firstindex;
+      priv->index = ((struct procfs_level1_s *)priv)->firstindex;

Review Comment:
   ditto
   ```suggestion
         priv->index = ((FAR struct procfs_level1_s *)priv)->firstindex;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org