[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7284: tools/ci: Update gcc-arm-none-eabi to 11.3.Rel1 August 08, 2022

pkarashchenko commented on code in PR #7284: URL: https://github.com/apache/incubator-nuttx/pull/7284#discussion_r993064760 ## tools/ci/patch/arm-none-eabi-workaround-for-newlib-version-break.patch: ## @@ -0,0 +1,38 @@ +From 819ab4ac433b809fdaca33246e2bffa1426acc0f Mon Sep 17 00

[incubator-nuttx] branch master updated (fc9b5e1980 -> c860a6e5f1)

This is an automated email from the ASF dual-hosted git repository. pkarashchenko pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from fc9b5e1980 arch_alarm: adjust oneshot/arch_alarm to support tick add c860a6e5f1 rpmsgdev: forward

[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7287: rpmsgdev: forward all open/close to server to support complex driver

pkarashchenko merged PR #7287: URL: https://github.com/apache/incubator-nuttx/pull/7287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6965: nxmutex replace nxsem when used as a lock

xiaoxiang781216 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1275621697 > @xiaoxiang781216 As for style changes, I think you can create another PR, and after the PR is merged then rebase this PR. The result would be much simpler to review.

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6965: nxmutex replace nxsem when used as a lock

masayuki2009 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1275596146 @xiaoxiang781216 As for style changes, I think you can create another PR, and after the PR is merged then rebase this PR. The result would be much simpler to review.

[GitHub] [incubator-nuttx] masayuki2009 commented on a diff in pull request #7288: armv7-a: add l2 page mapping interface

masayuki2009 commented on code in PR #7288: URL: https://github.com/apache/incubator-nuttx/pull/7288#discussion_r992985722 ## arch/arm/src/armv7-a/mmu.h: ## @@ -605,10 +605,17 @@ #endif #define MMU_L1_DATAFLAGS (PMD_TYPE_PTE | PMD_PTE_PXN | PMD_PTE_DOM(0)) -#define MMU_

[GitHub] [incubator-nuttx] W-Mai commented on a diff in pull request #7114: Add CodeChecker to CI

W-Mai commented on code in PR #7114: URL: https://github.com/apache/incubator-nuttx/pull/7114#discussion_r992977997 ## tools/testbuild.sh: ## @@ -218,6 +236,32 @@ function makefunc { return $fail } +function checkfunc { + build_cmd="${MAKE} ${MAKE_FLAGS} \"${EXTRA_FLAGS}\

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7114: Add CodeChecker to CI

xiaoxiang781216 commented on code in PR #7114: URL: https://github.com/apache/incubator-nuttx/pull/7114#discussion_r992977554 ## tools/testbuild.sh: ## @@ -218,6 +236,32 @@ function makefunc { return $fail } +function checkfunc { + build_cmd="${MAKE} ${MAKE_FLAGS} \"${EXT

[GitHub] [incubator-nuttx] W-Mai commented on a diff in pull request #7114: Add CodeChecker to CI

W-Mai commented on code in PR #7114: URL: https://github.com/apache/incubator-nuttx/pull/7114#discussion_r992973348 ## tools/testbuild.sh: ## @@ -218,6 +236,32 @@ function makefunc { return $fail } +function checkfunc { + build_cmd="${MAKE} ${MAKE_FLAGS} \"${EXTRA_FLAGS}\

[incubator-nuttx] branch master updated (7225e44725 -> fc9b5e1980)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 7225e44725 arch/sim: support multiple tapdev for sim add 750007ded9 sched: use tick count for sched t

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7033: nuttx/timer: add arch_alarm tick interface

xiaoxiang781216 merged PR #7033: URL: https://github.com/apache/incubator-nuttx/pull/7033 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7288: armv7-a: add l2 page mapping interface

xiaoxiang781216 commented on code in PR #7288: URL: https://github.com/apache/incubator-nuttx/pull/7288#discussion_r992963782 ## arch/arm/src/armv7-a/mmu.h: ## @@ -907,6 +914,21 @@ struct section_mapping_s uint32_t mmuflags; /* MMU settings for the region (e.g., cache-able)

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #7105: libxx: Update libcxx to a newer version

xiaoxiang781216 commented on issue #7105: URL: https://github.com/apache/incubator-nuttx/issues/7105#issuecomment-1275546364 1. Change LIBCXX_VERSION(https://github.com/apache/incubator-nuttx/blob/master/libs/libxx/libcxx.defs#L21) and LIBCXXABI_VERSION(https://github.com/apache/incub

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7114: Add CodeChecker to CI

xiaoxiang781216 commented on code in PR #7114: URL: https://github.com/apache/incubator-nuttx/pull/7114#discussion_r992958326 ## tools/testbuild.sh: ## @@ -218,6 +236,32 @@ function makefunc { return $fail } +function checkfunc { + build_cmd="${MAKE} ${MAKE_FLAGS} \"${EXT

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6965: nxmutex replace nxsem when used as a lock

xiaoxiang781216 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1275535337 @masayuki2009 what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] AndrewD commented on issue #7105: libxx: Update libcxx to a newer version

AndrewD commented on issue #7105: URL: https://github.com/apache/incubator-nuttx/issues/7105#issuecomment-1275532978 > Yes, it's always good to update libcxx/libcxxabit to the last official release and remove the temp patch, could you send a PR? While we had a quick look in concept w

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue

xiaoxiang781216 commented on code in PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992941872 ## examples/poll/net_listener.c: ## @@ -343,7 +343,7 @@ void *net_listener(pthread_addr_t pvarg) memset(&nls, 0, sizeof(struct net_listener_s));

[GitHub] [incubator-nuttx] zyfeier opened a new pull request, #7288: armv7-a: add l2 page mapping interface

zyfeier opened a new pull request, #7288: URL: https://github.com/apache/incubator-nuttx/pull/7288 ## Summary Add ARMv7-A L2 page mapping interface. User can use these interface to configure 4K L2 page when CONFIG_PAGING is not enable. The mmu_l2_map_page function is used to

[GitHub] [incubator-nuttx] anchao commented on pull request #7284: tools/ci: Update gcc-arm-none-eabi to 11.3.Rel1 August 08, 2022

anchao commented on PR #7284: URL: https://github.com/apache/incubator-nuttx/pull/7284#issuecomment-1275516392 > Seems recently we merged PR with wrong logic This is a toolchain bug, it seems that the release of arm-none-eabi-gcc 11-12 did not replace the newlib version macro properly

[GitHub] [incubator-nuttx] CV-Bowen opened a new pull request, #7287: rpmsgdev: forward all open/close to server to support complex driver

CV-Bowen opened a new pull request, #7287: URL: https://github.com/apache/incubator-nuttx/pull/7287 ## Summary Before this commit, each rpmsgdev server only manages one file no matter how many times the client opened. It can't work fine with some complex drivers, such as input driv

[GitHub] [incubator-nuttx] ttnie commented on a diff in pull request #7266: ci: add qemu run support

ttnie commented on code in PR #7266: URL: https://github.com/apache/incubator-nuttx/pull/7266#discussion_r992875906 ## boards/risc-v/qemu-rv/rv-virt/configs/citest/run: ## @@ -0,0 +1 @@ +../../../../../arm/imx6/sabre-6quad/configs/citest/run Review Comment: OK, I'll move the

[incubator-nuttx-website] branch asf-site updated: Publishing web: 6758fc5efbbf5ed16c807ccdfb012d94d1db201a docs: 7225e44725d7986e32a2ae4445ffbb3e7a79204f

This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 4e72b9a Publishing web

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1341: LVGL v8 upgrade

pkarashchenko commented on code in PR #1341: URL: https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r992691070 ## graphics/lvgl/port/lv_port_button.c: ## @@ -0,0 +1,237 @@ +/ + * apps/

[GitHub] [incubator-nuttx] tmedicci commented on issue #7193: Missing SoftAP documentation or feature for ESP32

tmedicci commented on issue #7193: URL: https://github.com/apache/incubator-nuttx/issues/7193#issuecomment-1275131105 Hi @SrivamsiMalladi We found that [this commit](https://github.com/apache/incubator-nuttx-apps/commit/be516e4c5e44ac35fa4ab1fed203567f3e98cda6) causes a software re

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1340: Fix the minor style issue

pkarashchenko commented on code in PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992661169 ## examples/netloop/lo_listener.c: ## @@ -297,7 +297,7 @@ void *lo_listener(pthread_addr_t pvarg) memset(&nls, 0, sizeof(struct net_listener_s));

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7033: nuttx/timer: add arch_alarm tick interface

pkarashchenko commented on code in PR #7033: URL: https://github.com/apache/incubator-nuttx/pull/7033#discussion_r992649770 ## include/nuttx/clock.h: ## @@ -251,6 +251,19 @@ EXTERN volatile clock_t g_system_ticks; * Public Function Prototypes

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #7284: tools/ci: Update gcc-arm-none-eabi to 11.3.Rel1 August 08, 2022

pkarashchenko commented on PR #7284: URL: https://github.com/apache/incubator-nuttx/pull/7284#issuecomment-1275092828 Seems recently we merged PR with wrong logic ``` Error: ./misc/lib_impure.c:48:28: error: token "@" is not valid in preprocessor expressions 48 |(defined(__NE

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7285: Fixed undefined behavior in UBSan.

pkarashchenko commented on code in PR #7285: URL: https://github.com/apache/incubator-nuttx/pull/7285#discussion_r992642956 ## mm/ubsan/ubsan.c: ## @@ -160,7 +160,7 @@ static int64_t get_signed_val(FAR struct type_descriptor *type, unsigned extra_bits = sizeof(int64_t) *

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1341: LVGL v8 upgrade

xiaoxiang781216 commented on code in PR #1341: URL: https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r992631794 ## graphics/lvgl/lv_conf/Kconfig: ## @@ -0,0 +1,1110 @@ +# Kconfig file for LVGL v8.0 + +menu "LVGL configuration" Review Comment: @FASTSHIFT l

[incubator-nuttx] branch master updated (bcdd03cdf3 -> 7225e44725)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from bcdd03cdf3 arm/backtrace: rename arm_backtrace_thumb.c to arm_backtrace_sp.c add 7225e44725 arch/sim

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7282: arch/sim: support multiple tapdev for sim

xiaoxiang781216 merged PR #7282: URL: https://github.com/apache/incubator-nuttx/pull/7282 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated (83a3fd9780 -> bcdd03cdf3)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 83a3fd9780 newlib/impure: sync with newlib(4.2.0) reent update add bcdd03cdf3 arm/backtrace: rename a

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7286: Added handling of MSG_WAITALL flag in TCP recv.

xiaoxiang781216 commented on code in PR #7286: URL: https://github.com/apache/incubator-nuttx/pull/7286#discussion_r992627598 ## net/tcp/tcp_recvfrom.c: ## @@ -706,7 +706,8 @@ ssize_t psock_tcp_recvfrom(FAR struct socket *psock, FAR struct msghdr *msg, *want for more be

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7283: arm/backtrace: rename arm_backtrace_thumb.c to arm_backtrace_sp.c

xiaoxiang781216 merged PR #7283: URL: https://github.com/apache/incubator-nuttx/pull/7283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #7286: Added handling of MSG_WAITALL flag in TCP recv.

fjpanag commented on code in PR #7286: URL: https://github.com/apache/incubator-nuttx/pull/7286#discussion_r992626504 ## net/tcp/tcp_recvfrom.c: ## @@ -706,7 +706,8 @@ ssize_t psock_tcp_recvfrom(FAR struct socket *psock, FAR struct msghdr *msg, *want for more because th

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7286: Added handling of MSG_WAITALL flag in TCP recv.

pkarashchenko commented on code in PR #7286: URL: https://github.com/apache/incubator-nuttx/pull/7286#discussion_r992624004 ## net/tcp/tcp_recvfrom.c: ## @@ -706,7 +706,8 @@ ssize_t psock_tcp_recvfrom(FAR struct socket *psock, FAR struct msghdr *msg, *want for more beca

[GitHub] [incubator-nuttx] fjpanag closed pull request #7278: Blocking psock_tcp_recvfrom waits for all requested data.

fjpanag closed pull request #7278: Blocking psock_tcp_recvfrom waits for all requested data. URL: https://github.com/apache/incubator-nuttx/pull/7278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-nuttx] fjpanag commented on pull request #7278: Blocking psock_tcp_recvfrom waits for all requested data.

fjpanag commented on PR #7278: URL: https://github.com/apache/incubator-nuttx/pull/7278#issuecomment-1275056864 Closing in favour of #7286. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [incubator-nuttx] fjpanag opened a new pull request, #7286: Added handling of MSG_WAITALL flag in TCP recv.

fjpanag opened a new pull request, #7286: URL: https://github.com/apache/incubator-nuttx/pull/7286 ## Summary Added handling of the flag `MSG_WAITALL` when receiving in TCP sockets. This PR replaces the relevant one #7278. ## Impact New functionality. ## Tes

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7278: Blocking psock_tcp_recvfrom waits for all requested data.

xiaoxiang781216 commented on PR #7278: URL: https://github.com/apache/incubator-nuttx/pull/7278#issuecomment-1274937662 > Maybe the correct approach would be to implement `MSG_WAITALL` in flags. > Yes, this is right direction to go. Both receive what available and return imm

[GitHub] [incubator-nuttx] fjpanag opened a new pull request, #7285: Fixed undefined behavior in UBSan.

fjpanag opened a new pull request, #7285: URL: https://github.com/apache/incubator-nuttx/pull/7285 ## Summary Fixes an undefined behavior within UBSan. Relevant issue #7274. ## Impact UBSan is working correctly now. ## Testing Tested with code that has

[GitHub] [incubator-nuttx] fjpanag commented on pull request #7278: Blocking psock_tcp_recvfrom waits for all requested data.

fjpanag commented on PR #7278: URL: https://github.com/apache/incubator-nuttx/pull/7278#issuecomment-1274925941 Maybe the correct approach would be to implement `MSG_WAITALL` in flags. I will try this, and update the PR. -- This is an automated message from the Apache Git Service. T

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue

xiaoxiang781216 commented on code in PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992508355 ## examples/elf/tests/mutex/mutex.c: ## @@ -103,7 +103,7 @@ int main(int argc, char **argv) printf("Starting thread 1\n"); bendoftest = fal

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue

xiaoxiang781216 commented on code in PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992506078 ## examples/pipe/transfer_test.c: ## @@ -70,46 +70,57 @@ static void *transfer_reader(pthread_addr_t pvarg) int ndx; printf("transfer_reade

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7284: tools/ci: Update gcc-arm-none-eabi to 11.3.Rel1 August 08, 2022

anchao opened a new pull request, #7284: URL: https://github.com/apache/incubator-nuttx/pull/7284 ## Summary tools/ci: Update gcc-arm-none-eabi to 11.3.Rel1 August 08, 2022 https://gcc.gnu.org/gcc-11/changes.html ## Impact N/A ## Testing Ci check -- Th

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7283: arm/backtrace: rename arm_backtrace_thumb.c to arm_backtrace_sp.c

anchao opened a new pull request, #7283: URL: https://github.com/apache/incubator-nuttx/pull/7283 ## Summary arm/backtrace: rename arm_backtrace_thumb.c to arm_backtrace_sp.c 1. rename arm_backtrace_thumb.c to arm_backtrace_sp.c 2. use EHABI stack unwinder instead of

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6965: nxmutex replace nxsem when used as a lock

xiaoxiang781216 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1274841464 > > @masayuki2009 it's hard to split the style change from the patch now. could you have method to retrieve the old revision from github? > > I think you can always

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7278: Blocking psock_tcp_recvfrom waits for all requested data.

xiaoxiang781216 commented on PR #7278: URL: https://github.com/apache/incubator-nuttx/pull/7278#issuecomment-1274803295 > @xiaoxiang781216 The fact that recv _can_ return less bytes than requested, does not mean that it _should_. > > At least in my case, all data have been received by

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6965: nxmutex replace nxsem when used as a lock

masayuki2009 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1274779803 >@masayuki2009 it's hard to split the style change from the patch now. could you have method to retrieve the old revision from github? I think you can always retrieve t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6965: nxmutex replace nxsem when used as a lock

xiaoxiang781216 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1274753705 @masayuki2009 it's hard to split the style change from the patch now. could you method to retrieve the old patch from github? -- This is an automated message from the Ap

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #6965: nxmutex replace nxsem when used as a lock

masayuki2009 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1274750655 @anjiahao1 This PR contains only one big commit. Please divide the commit into smaller ones (e.g. style changes, etc) -- This is an automated message from the

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #7033: nuttx/timer: add arch_alarm tick interface

masayuki2009 commented on PR #7033: URL: https://github.com/apache/incubator-nuttx/pull/7033#issuecomment-1274679995 @zyfeier Please rebase this PR to the latest upstream master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6965: nxmutex replace nxsem when used as a lock

xiaoxiang781216 commented on PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#issuecomment-1274675439 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-nuttx-apps] gustavonihei commented on a diff in pull request #1341: LVGL v8 upgrade

gustavonihei commented on code in PR #1341: URL: https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r992264960 ## graphics/lvgl/lv_conf/Kconfig: ## @@ -0,0 +1,1110 @@ +# Kconfig file for LVGL v8.0 + +menu "LVGL configuration" + +# Define CONFIG_LV_CONF_SKIP

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1340: Fix the minor style issue

pkarashchenko commented on code in PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992257807 ## examples/elf/tests/mutex/mutex.c: ## @@ -103,7 +103,7 @@ int main(int argc, char **argv) printf("Starting thread 1\n"); bendoftest = false

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1340: Fix the minor style issue

pkarashchenko commented on PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#issuecomment-1274607182 Please rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [incubator-nuttx-apps] FASTSHIFT commented on a diff in pull request #1341: LVGL v8 upgrade

FASTSHIFT commented on code in PR #1341: URL: https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r992252530 ## graphics/lvgl/lv_conf/Kconfig: ## @@ -0,0 +1,1110 @@ +# Kconfig file for LVGL v8.0 + +menu "LVGL configuration" + +# Define CONFIG_LV_CONF_SKIP so

[GitHub] [incubator-nuttx-apps] gustavonihei commented on a diff in pull request #1341: LVGL v8 upgrade

gustavonihei commented on code in PR #1341: URL: https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r992247970 ## graphics/lvgl/lv_conf/Kconfig: ## @@ -0,0 +1,1110 @@ +# Kconfig file for LVGL v8.0 + +menu "LVGL configuration" Review Comment: Taking it to an

[GitHub] [incubator-nuttx-apps] gustavonihei commented on a diff in pull request #1341: LVGL v8 upgrade

gustavonihei commented on code in PR #1341: URL: https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r992243438 ## graphics/lvgl/lv_conf/Kconfig: ## @@ -0,0 +1,1110 @@ +# Kconfig file for LVGL v8.0 + +menu "LVGL configuration" Review Comment: I am not sure i

[GitHub] [incubator-nuttx-apps] gustavonihei commented on a diff in pull request #1341: LVGL v8 upgrade

gustavonihei commented on code in PR #1341: URL: https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r992235246 ## graphics/lvgl/lv_conf/Kconfig: ## @@ -0,0 +1,1110 @@ +# Kconfig file for LVGL v8.0 + +menu "LVGL configuration" + +# Define CONFIG_LV_CONF_SKIP

[GitHub] [incubator-nuttx-apps] gustavonihei commented on a diff in pull request #1341: LVGL v8 upgrade

gustavonihei commented on code in PR #1341: URL: https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r992235246 ## graphics/lvgl/lv_conf/Kconfig: ## @@ -0,0 +1,1110 @@ +# Kconfig file for LVGL v8.0 + +menu "LVGL configuration" + +# Define CONFIG_LV_CONF_SKIP

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue

xiaoxiang781216 commented on code in PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992229836 ## wireless/ieee802154/libmac/sixlowpan_getreq.c: ## @@ -40,7 +40,7 @@ **

[GitHub] [incubator-nuttx] fjpanag commented on pull request #7278: Blocking psock_tcp_recvfrom waits for all requested data.

fjpanag commented on PR #7278: URL: https://github.com/apache/incubator-nuttx/pull/7278#issuecomment-1274564800 @xiaoxiang781216 The fact that recv *can* return less bytes than requested, does not mean that it *should*. At least in my case, all data have been received by the device, i

[GitHub] [incubator-nuttx] zyfeier commented on a diff in pull request #7033: nuttx/timer: add arch_alarm tick interface

zyfeier commented on code in PR #7033: URL: https://github.com/apache/incubator-nuttx/pull/7033#discussion_r992224306 ## arch/arm/src/stm32h7/stm32_tickless.c: ## @@ -729,9 +729,9 @@ int up_timer_gettime(struct timespec *ts) *

[GitHub] [incubator-nuttx] zyfeier commented on a diff in pull request #7033: nuttx/timer: add arch_alarm tick interface

zyfeier commented on code in PR #7033: URL: https://github.com/apache/incubator-nuttx/pull/7033#discussion_r992223618 ## arch/arm/src/stm32/stm32_tickless.c: ## @@ -698,9 +698,9 @@ int up_timer_gettime(struct timespec *ts) * **

[GitHub] [incubator-nuttx] zyfeier commented on a diff in pull request #7033: nuttx/timer: add arch_alarm tick interface

zyfeier commented on code in PR #7033: URL: https://github.com/apache/incubator-nuttx/pull/7033#discussion_r992224033 ## arch/arm/src/stm32f7/stm32_tickless.c: ## @@ -776,7 +776,7 @@ int up_timer_getcounter(uint64_t *cycles) *

[incubator-nuttx-apps] branch master updated: examples: clean warning of pipe

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 6e3b402cf examples: clean warni

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1344: examples: clean warning of pipe

xiaoxiang781216 merged PR #1344: URL: https://github.com/apache/incubator-nuttx-apps/pull/1344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [incubator-nuttx] fjpanag commented on issue #7271: Build error with SIM_NETUSRSOCK.

fjpanag commented on issue #7271: URL: https://github.com/apache/incubator-nuttx/issues/7271#issuecomment-1274510986 `NET_USRSOCK_CUSTOM` is needed for this to build successfully. Unfortunately, `SIM_NETUSRSOCK` cannot select `NET_USRSOCK_CUSTOM` since the later is a choice. I d

[GitHub] [incubator-nuttx] fjpanag closed issue #7271: Build error with SIM_NETUSRSOCK.

fjpanag closed issue #7271: Build error with SIM_NETUSRSOCK. URL: https://github.com/apache/incubator-nuttx/issues/7271 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[incubator-nuttx] branch master updated (09a06e7fce -> 83a3fd9780)

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 09a06e7fce sem: don't clear waitobj when do sem recover add 83a3fd9780 newlib/impure: sync with newli

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7281: newlib/impure: sync with newlib(4.2.0) reent update

xiaoxiang781216 merged PR #7281: URL: https://github.com/apache/incubator-nuttx/pull/7281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1340: Fix the minor style issue

pkarashchenko commented on code in PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992130915 ## wireless/ieee802154/libmac/sixlowpan_getreq.c: ## @@ -40,7 +40,7 @@

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

pkarashchenko commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r992124847 ## drivers/rptun/rptun.c: ## @@ -462,7 +462,7 @@ static int rptun_notify_wait(FAR struct remoteproc *rproc, uint32_t id) return 0; } -static void *r

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1344: examples: clean warning of pipe

pkarashchenko commented on PR #1344: URL: https://github.com/apache/incubator-nuttx-apps/pull/1344#issuecomment-127443 Oah, seems that is an apps side PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1344: examples: clean warning of pipe

xiaoxiang781216 commented on code in PR #1344: URL: https://github.com/apache/incubator-nuttx-apps/pull/1344#discussion_r992105881 ## examples/pipe/interlock_test.c: ## @@ -177,21 +194,24 @@ int interlock_test(void) ret = pthread_join(writerid, &value); if (ret != 0)

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1344: examples: clean warning of pipe

pkarashchenko commented on code in PR #1344: URL: https://github.com/apache/incubator-nuttx-apps/pull/1344#discussion_r992100633 ## examples/pipe/interlock_test.c: ## @@ -86,10 +89,12 @@ static void *null_writer(pthread_addr_t pvarg) { fprintf(stderr, "null_writer:

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue

xiaoxiang781216 commented on code in PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992062166 ## examples/pipe/transfer_test.c: ## @@ -70,46 +70,57 @@ static void *transfer_reader(pthread_addr_t pvarg) int ndx; printf("transfer_reade

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1340: Fix the minor style issue

xiaoxiang781216 commented on code in PR #1340: URL: https://github.com/apache/incubator-nuttx-apps/pull/1340#discussion_r992061835 ## examples/pipe/interlock_test.c: ## @@ -69,9 +69,10 @@ static void *null_writer(pthread_addr_t pvarg) fd = open(FIFO_PATH2, O_WRONLY); if (

[GitHub] [incubator-nuttx] jlaitine commented on pull request #5782: RISC-V: Implement option to run NuttX in supervisor mode (S-mode)

jlaitine commented on PR #5782: URL: https://github.com/apache/incubator-nuttx/pull/5782#issuecomment-1274324119 I agree with @acassis on this one; it is better to make another PR for style improvements, if needed. This one was already approved, and too long living. Thanks, Jukka

[GitHub] [incubator-nuttx] slorquet commented on issue #7138: stm32h7 UART drain problem

slorquet commented on issue #7138: URL: https://github.com/apache/incubator-nuttx/issues/7138#issuecomment-1274320139 Hi, I'm already on : nsh> uname -a NuttX 10.3.0-RC0 40144a652d The bug has disappeared thanks to our programming tricks. I have no time to test ag

[GitHub] [incubator-nuttx-apps] ttnie opened a new pull request, #1344: examples: clean warning of pipe

ttnie opened a new pull request, #1344: URL: https://github.com/apache/incubator-nuttx-apps/pull/1344 ## Summary clean example pipe build warning transfer_test.c:66:12: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast] int fd = (int)pvar

[GitHub] [incubator-nuttx] wengzhe opened a new pull request, #7282: arch/sim: support multiple tapdev for sim

wengzhe opened a new pull request, #7282: URL: https://github.com/apache/incubator-nuttx/pull/7282 ## Summary Support more than one TAP device for debugging (future) NAT and FORWARD, left WPCAP and VPNKit unchanged (force number to 1). Although we can support at most 31 interfaces, l

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7033: nuttx/timer: add arch_alarm tick interface

pkarashchenko commented on code in PR #7033: URL: https://github.com/apache/incubator-nuttx/pull/7033#discussion_r991918819 ## arch/arm/src/stm32/stm32_tickless.c: ## @@ -698,9 +698,9 @@ int up_timer_gettime(struct timespec *ts) *

[GitHub] [incubator-nuttx] anchao opened a new pull request, #7281: newlib/impure: sync with newlib(4.2.0) reent update

anchao opened a new pull request, #7281: URL: https://github.com/apache/incubator-nuttx/pull/7281 ## Summary newlib/impure: sync with newlib(4.2.0) reent update arm-none-eabi-ld: nuttx/staging/libc.a(lib_impure.o):(.data.impure_data+0x4): undefined reference to `__sf' arm-

[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6965: nxmutex replace nxsem when used as a lock

pkarashchenko commented on code in PR #6965: URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r991890244 ## arch/arm/src/stm32h7/stm32_serial.c: ## @@ -3347,7 +3352,7 @@ static void up_dma_txcallback(DMA_HANDLE handle, uint8_t status, void *arg) /*

[incubator-nuttx] branch master updated (4ce8cf7bdc -> 09a06e7fce)

This is an automated email from the ASF dual-hosted git repository. masayuki pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 4ce8cf7bdc bl602/dma: Fix possible call of null pointer to function add 09a06e7fce sem: don't clear wa

[GitHub] [incubator-nuttx-apps] FASTSHIFT commented on a diff in pull request #1341: LVGL v8 upgrade

FASTSHIFT commented on code in PR #1341: URL: https://github.com/apache/incubator-nuttx-apps/pull/1341#discussion_r991912457 ## graphics/lvgl/lv_conf/Kconfig: ## @@ -0,0 +1,1110 @@ +# Kconfig file for LVGL v8.0 + +menu "LVGL configuration" Review Comment: This Kconfig is co

[incubator-nuttx-apps] branch master updated: ostest: add semaphore wait case for task restart

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 7fcba8a11 ostest: add semaphore

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #7267: sem: don't clear waitobj when do sem recover

masayuki2009 merged PR #7267: URL: https://github.com/apache/incubator-nuttx/pull/7267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1342: ostest: add semaphore wait case for task restart

xiaoxiang781216 merged PR #1342: URL: https://github.com/apache/incubator-nuttx-apps/pull/1342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-u

[GitHub] [incubator-nuttx] XinStellaris commented on pull request #6512: driver/syslog:sched lock in syslog to prevent garbled print from multi-thread

XinStellaris commented on PR #6512: URL: https://github.com/apache/incubator-nuttx/pull/6512#issuecomment-1274214376 after all the discussion, i think maybe its better to change how the application code uses syslog, by splitting long string into several lines and limiting the line size less

[GitHub] [incubator-nuttx] anjiahao1 commented on pull request #6920: support /dev/crypto for nuttx

anjiahao1 commented on PR #6920: URL: https://github.com/apache/incubator-nuttx/pull/6920#issuecomment-1274191020 > Many of the crypto implementations come from other places under BSD or related license. They should be added to https://github.com/apache/incubator-nuttx/blob/master/LICENSE

[GitHub] [incubator-nuttx] jerpelea commented on issue #7138: stm32h7 UART drain problem

jerpelea commented on issue #7138: URL: https://github.com/apache/incubator-nuttx/issues/7138#issuecomment-1274180072 Hi @slorquet