[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7114: Add CodeChecker to CI

[GitBox]

xiaoxiang781216 commented on code in PR #7114:
URL: https://github.com/apache/incubator-nuttx/pull/7114#discussion_r992958326


##########
tools/testbuild.sh:
##########
@@ -218,6 +236,32 @@ function makefunc {
   return $fail
 }
 
+function checkfunc {
+  build_cmd="${MAKE} ${MAKE_FLAGS} \"${EXTRA_FLAGS}\" ${JOPTION} 1>/dev/null"
+
+  local config_sub_path=$(echo "$config" | sed "s/:/\//")
+  local sub_target_name=${config_sub_path#$(dirname "${config_sub_path}")/}
+  local codechecker_logs_dir=${ARTIFACTDIR}/codechecker_logs/${config_sub_path}

Review Comment:
   why need config_sub_path? let's remove it.



##########
tools/testbuild.sh:
##########
@@ -218,6 +236,32 @@ function makefunc {
   return $fail
 }
 
+function checkfunc {
+  build_cmd="${MAKE} ${MAKE_FLAGS} \"${EXTRA_FLAGS}\" ${JOPTION} 1>/dev/null"
+
+  local config_sub_path=$(echo "$config" | sed "s/:/\//")
+  local sub_target_name=${config_sub_path#$(dirname "${config_sub_path}")/}
+  local codechecker_logs_dir=${ARTIFACTDIR}/codechecker_logs/${config_sub_path}
+
+  mkdir -p "${codechecker_logs_dir}"
+
+  echo "    Checking NuttX by Codechecker..."
+  CodeChecker check -b "${build_cmd}" -o 
"${codechecker_logs_dir}"/codechecker_reports -e sensitive --ctu

Review Comment:
   ```suggestion
     CodeChecker check -b "${build_cmd}" -o "${codechecker_logs_dir}"/log -e 
sensitive --ctu
   ```



##########
tools/testbuild.sh:
##########
@@ -218,6 +236,32 @@ function makefunc {
   return $fail
 }
 
+function checkfunc {
+  build_cmd="${MAKE} ${MAKE_FLAGS} \"${EXTRA_FLAGS}\" ${JOPTION} 1>/dev/null"
+
+  local config_sub_path=$(echo "$config" | sed "s/:/\//")
+  local sub_target_name=${config_sub_path#$(dirname "${config_sub_path}")/}
+  local codechecker_logs_dir=${ARTIFACTDIR}/codechecker_logs/${config_sub_path}

Review Comment:
   ```suggestion
     local codechecker_dir=${ARTIFACTDIR}/codechecker
   ```



##########
tools/testbuild.sh:
##########
@@ -218,6 +236,32 @@ function makefunc {
   return $fail
 }
 
+function checkfunc {
+  build_cmd="${MAKE} ${MAKE_FLAGS} \"${EXTRA_FLAGS}\" ${JOPTION} 1>/dev/null"
+
+  local config_sub_path=$(echo "$config" | sed "s/:/\//")
+  local sub_target_name=${config_sub_path#$(dirname "${config_sub_path}")/}
+  local codechecker_logs_dir=${ARTIFACTDIR}/codechecker_logs/${config_sub_path}
+
+  mkdir -p "${codechecker_logs_dir}"
+
+  echo "    Checking NuttX by Codechecker..."
+  CodeChecker check -b "${build_cmd}" -o 
"${codechecker_logs_dir}"/codechecker_reports -e sensitive --ctu
+  codecheck_ret=$?
+  echo "    Storing analysis result to CodeChecker..."
+  echo "      Generating HTML report..."
+  CodeChecker parse --export html --output 
"${codechecker_logs_dir}/codechecker_reports_html" 
"${codechecker_logs_dir}/codechecker_reports" 1>/dev/null
+  echo "      Compressing logs..."
+  compressartifacts "$(dirname "${codechecker_logs_dir}")" "${sub_target_name}"
+
+# If you need to stop CI, uncomment the following line.
+#  if [ $codecheck_ret -ne 0 ]; then
+#    fail=114

Review Comment:
   fail=1



##########
tools/testbuild.sh:
##########
@@ -36,6 +36,8 @@ PRINTLISTONLY=0
 GITCLEAN=0
 SAVEARTIFACTS=0
 CHECKCLEAN=1
+CODECHECKER=0
+CODECHECKERFAILS=0

Review Comment:
   remove



##########
tools/testbuild.sh:
##########
@@ -218,6 +236,32 @@ function makefunc {
   return $fail
 }
 
+function checkfunc {
+  build_cmd="${MAKE} ${MAKE_FLAGS} \"${EXTRA_FLAGS}\" ${JOPTION} 1>/dev/null"
+
+  local config_sub_path=$(echo "$config" | sed "s/:/\//")
+  local sub_target_name=${config_sub_path#$(dirname "${config_sub_path}")/}
+  local codechecker_logs_dir=${ARTIFACTDIR}/codechecker_logs/${config_sub_path}
+
+  mkdir -p "${codechecker_logs_dir}"
+
+  echo "    Checking NuttX by Codechecker..."
+  CodeChecker check -b "${build_cmd}" -o 
"${codechecker_logs_dir}"/codechecker_reports -e sensitive --ctu
+  codecheck_ret=$?
+  echo "    Storing analysis result to CodeChecker..."
+  echo "      Generating HTML report..."
+  CodeChecker parse --export html --output 
"${codechecker_logs_dir}/codechecker_reports_html" 
"${codechecker_logs_dir}/codechecker_reports" 1>/dev/null

Review Comment:
   ```suggestion
     CodeChecker parse --export html --output "${codechecker_logs_dir}/html" 
"${codechecker_logs_dir}/codechecker_reports" 1>/dev/null
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org