davids5 commented on code in PR #6894:
URL: https://github.com/apache/incubator-nuttx/pull/6894#discussion_r952211951
##
drivers/syslog/ramlog.c:
##
@@ -125,8 +125,8 @@ static const struct file_operations g_ramlogfops =
#ifdef CONFIG_RAMLOG_SYSLOG
static char g_sysbuffer[CON
anchao opened a new pull request, #6897:
URL: https://github.com/apache/incubator-nuttx/pull/6897
## Summary
arch/sim: add windows host simulate support
sim/host: move host implement to posix directory
This PR is depends on cmake support:
https://github.com/apache/incubato
xiaoxiang781216 commented on code in PR #6894:
URL: https://github.com/apache/incubator-nuttx/pull/6894#discussion_r952175233
##
drivers/syslog/ramlog.c:
##
@@ -125,8 +125,8 @@ static const struct file_operations g_ramlogfops =
#ifdef CONFIG_RAMLOG_SYSLOG
static char g_sysbu
xiaoxiang781216 commented on code in PR #6894:
URL: https://github.com/apache/incubator-nuttx/pull/6894#discussion_r952175233
##
drivers/syslog/ramlog.c:
##
@@ -125,8 +125,8 @@ static const struct file_operations g_ramlogfops =
#ifdef CONFIG_RAMLOG_SYSLOG
static char g_sysbu
davids5 commented on code in PR #6894:
URL: https://github.com/apache/incubator-nuttx/pull/6894#discussion_r952173591
##
drivers/syslog/ramlog.c:
##
@@ -125,8 +125,8 @@ static const struct file_operations g_ramlogfops =
#ifdef CONFIG_RAMLOG_SYSLOG
static char g_sysbuffer[CON
xiaoxiang781216 commented on issue #6896:
URL:
https://github.com/apache/incubator-nuttx/issues/6896#issuecomment-1223491787
Yes, I agree that C89 is too old and not perfect(miss many important
feature/patch). C99 is a better baseline that we should follow. Since it's a
big decision, it's
takayoshi-k commented on PR #1283:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1283#issuecomment-1223358968
Hi @pkarashchenko
I hadn't mension to you.
I updated. Please check it again.
--
This is an automated message from the Apache Git Service.
To respond to the messa
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 606b27b Publishing web
AlanRosenthal opened a new issue, #6896:
URL: https://github.com/apache/incubator-nuttx/issues/6896
The `C Coding Standard` states:
```
C Style Comments. C99/C11/C++ style comments (beginning with //) should not
be used with NuttX. NuttX generally follows C89 and all code outside of
a
acassis opened a new pull request, #6895:
URL: https://github.com/apache/incubator-nuttx/pull/6895
## Summary
Add initial support to esp32c3-devkit-rust-1 board
## Impact
Users could use the esp32c3-devkit-rust-1 board with NuttX (and eventually
run Rust on it over NuttX)
## Test
xiaoxiang781216 opened a new pull request, #6894:
URL: https://github.com/apache/incubator-nuttx/pull/6894
## Summary
1.Remove the default value(.bss)
2.Remove !ARCH_SIM dependence
## Impact
Refactor only
## Testing
Pass CI
--
This is an automated message from
xiaoxiang781216 closed pull request #3704: Migrate build system to CMake
URL: https://github.com/apache/incubator-nuttx/pull/3704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
xiaoxiang781216 commented on PR #3704:
URL: https://github.com/apache/incubator-nuttx/pull/3704#issuecomment-1222775940
let's track this work in https://github.com/apache/incubator-nuttx/pull/6718
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
xiaoxiang781216 opened a new pull request, #6893:
URL: https://github.com/apache/incubator-nuttx/pull/6893
## Summary
by generating the new xid for each transaction
## Impact
Minor
## Testing
sim:adb
--
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 0cdb2cfa4 Fixed compiler warnin
xiaoxiang781216 merged PR #1290:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-u
pkarashchenko commented on PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#issuecomment-1222550817
Yes, I will review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
xiaoxiang781216 commented on PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#issuecomment-1222550143
@pkarashchenko could you review again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
xiaoxiang781216 commented on code in PR #6892:
URL: https://github.com/apache/incubator-nuttx/pull/6892#discussion_r951593884
##
mm/kasan/kasan.c:
##
@@ -116,7 +117,7 @@ static bool kasan_is_poisoned(uintptr_t addr, size_t size)
return p && ((*p >> bit) & 1);
}
-static voi
xiaoxiang781216 commented on code in PR #6892:
URL: https://github.com/apache/incubator-nuttx/pull/6892#discussion_r951582835
##
mm/kasan/kasan.c:
##
@@ -107,12 +107,12 @@ static void kasan_report(uintptr_t addr, size_t size,
bool is_write)
--recursion;
}
-static bool kas
xiaoxiang781216 commented on code in PR #6862:
URL: https://github.com/apache/incubator-nuttx/pull/6862#discussion_r951576919
##
sched/signal/signal.h:
##
@@ -147,7 +147,7 @@ struct task_group_s;
/* sig_initializee.c */
-void weak_function nxsig_initialize(void);
+void
xiaoxiang781216 commented on code in PR #6892:
URL: https://github.com/apache/incubator-nuttx/pull/6892#discussion_r951572859
##
mm/kasan/kasan.c:
##
@@ -222,188 +222,188 @@ void __asan_handle_no_return(void)
/* Shut up compiler complaints */
}
-void __asan_report_load_n_n
xiaoxiang781216 commented on PR #6885:
URL: https://github.com/apache/incubator-nuttx/pull/6885#issuecomment-1222489743
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
xiaoxiang781216 merged PR #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 55df6e951e drivers: Fix compiler err
xiaoxiang781216 commented on PR #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891#issuecomment-1222486188
Let's ignore the false alarm from check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
no1wudi opened a new pull request, #6892:
URL: https://github.com/apache/incubator-nuttx/pull/6892
## Summary
Change some prototypes of KASAN function to pass build with both KASAN and
UBSan enabled.
## Impact
Should be none
## Testing
sim
--
This is an automated messag
pkarashchenko commented on code in PR #6862:
URL: https://github.com/apache/incubator-nuttx/pull/6862#discussion_r951548733
##
sched/signal/signal.h:
##
@@ -147,7 +147,7 @@ struct task_group_s;
/* sig_initializee.c */
-void weak_function nxsig_initialize(void);
+void
pkarashchenko commented on PR #6885:
URL: https://github.com/apache/incubator-nuttx/pull/6885#issuecomment-1222477664
please rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
pkarashchenko merged PR #6883:
URL: https://github.com/apache/incubator-nuttx/pull/6883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new b60704614e arch/sim: set CMDLINE
This is an automated email from the ASF dual-hosted git repository.
pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 697e2a333b net/usrsock: Remove d
pkarashchenko merged PR #6890:
URL: https://github.com/apache/incubator-nuttx/pull/6890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr
fjpanag opened a new pull request, #1290:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1290
## Summary
Fixes various compiler warnings that I encounter using some of the apps.
## Impact
N/A
## Testing
Build test.
--
This is an automated me
anchao commented on code in PR #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891#discussion_r951358093
##
drivers/misc/rwbuffer.c:
##
@@ -76,13 +76,11 @@ static int rwb_semtake(FAR sem_t *sem)
{
return nxsem_wait_uninterruptible(sem);
}
-#endif
/***
anchao commented on code in PR #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891#discussion_r951357870
##
drivers/misc/rwbuffer.c:
##
@@ -76,13 +76,11 @@ static int rwb_semtake(FAR sem_t *sem)
{
return nxsem_wait_uninterruptible(sem);
Review Comment:
Done
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new eb9cfefc1b sched: fix visual studio
xiaoxiang781216 merged PR #6887:
URL: https://github.com/apache/incubator-nuttx/pull/6887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
CV-Bowen commented on code in PR #6829:
URL: https://github.com/apache/incubator-nuttx/pull/6829#discussion_r951266153
##
drivers/mtd/mtd_config_fs.c:
##
@@ -0,0 +1,2435 @@
+/
+ * drivers/mtd/mtd_config_
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 8a8c268e6b arch/arm/src/stm32f7/Kcon
xiaoxiang781216 merged PR #6889:
URL: https://github.com/apache/incubator-nuttx/pull/6889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 78f44e7769 arch/arm/src/stm32f7/stm3
xiaoxiang781216 merged PR #6888:
URL: https://github.com/apache/incubator-nuttx/pull/6888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubs
xiaoxiang781216 commented on code in PR #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891#discussion_r951215809
##
drivers/misc/rwbuffer.c:
##
@@ -76,13 +76,11 @@ static int rwb_semtake(FAR sem_t *sem)
{
return nxsem_wait_uninterruptible(sem);
Review Comment:
anchao opened a new pull request, #6891:
URL: https://github.com/apache/incubator-nuttx/pull/6891
## Summary
drivers: Fix compiler errors
riscv64-unknown-elf-ld: staging/libdrivers.a(rwbuffer.o): in function
`rwb_flush':
rwbuffer.c:(.text.rwb_flush+0x12): undefined reference
xiaoxiang781216 opened a new pull request, #6890:
URL: https://github.com/apache/incubator-nuttx/pull/6890
## Summary
since this field isn't really used at all
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To resp
46 matches
Mail list logo
