[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6892: sim: Enable ubsan in sim:kasan

[GitBox]

xiaoxiang781216 commented on code in PR #6892:
URL: https://github.com/apache/incubator-nuttx/pull/6892#discussion_r951572859


##########
mm/kasan/kasan.c:
##########
@@ -222,188 +222,188 @@ void __asan_handle_no_return(void)
   /* Shut up compiler complaints */
 }
 
-void __asan_report_load_n_noabort(uintptr_t addr, size_t size)
+void __asan_report_load_n_noabort(FAR void *addr, size_t size)
 {
-  kasan_report(addr, size, false);
+  kasan_report((uintptr_t)addr, size, false);

Review Comment:
   let's change the prototype of kasan_report and kasan_set_posion to avoid the 
cast



##########
mm/kasan/kasan.c:
##########
@@ -222,188 +222,188 @@ void __asan_handle_no_return(void)
   /* Shut up compiler complaints */
 }
 
-void __asan_report_load_n_noabort(uintptr_t addr, size_t size)
+void __asan_report_load_n_noabort(FAR void *addr, size_t size)
 {
-  kasan_report(addr, size, false);
+  kasan_report((uintptr_t)addr, size, false);
 }
 
-void __asan_report_store_n_noabort(uintptr_t addr, size_t size)
+void __asan_report_store_n_noabort(FAR void *addr, size_t size)
 {
-  kasan_report(addr, size, true);
+  kasan_report((uintptr_t)addr, size, true);
 }
 
-void __asan_report_load16_noabort(uintptr_t addr)
+void __asan_report_load16_noabort(FAR void *addr)
 {
   __asan_report_load_n_noabort(addr, 16);
 }
 
-void __asan_report_store16_noabort(uintptr_t addr)
+void __asan_report_store16_noabort(FAR void *addr)
 {
   __asan_report_store_n_noabort(addr, 16);
 }
 
-void __asan_report_load8_noabort(uintptr_t addr)
+void __asan_report_load8_noabort(FAR void *addr)
 {
   __asan_report_load_n_noabort(addr, 8);
 }
 
-void __asan_report_store8_noabort(uintptr_t addr)
+void __asan_report_store8_noabort(FAR void *addr)
 {
   __asan_report_store_n_noabort(addr, 8);
 }
 
-void __asan_report_load4_noabort(uintptr_t addr)
+void __asan_report_load4_noabort(FAR void *addr)
 {
   __asan_report_load_n_noabort(addr, 4);
 }
 
-void __asan_report_store4_noabort(uintptr_t addr)
+void __asan_report_store4_noabort(FAR void *addr)
 {
   __asan_report_store_n_noabort(addr, 4);
 }
 
-void __asan_report_load2_noabort(uintptr_t addr)
+void __asan_report_load2_noabort(FAR void *addr)
 {
   __asan_report_load_n_noabort(addr, 2);
 }
 
-void __asan_report_store2_noabort(uintptr_t addr)
+void __asan_report_store2_noabort(FAR void *addr)
 {
   __asan_report_store_n_noabort(addr, 2);
 }
 
-void __asan_report_load1_noabort(uintptr_t addr)
+void __asan_report_load1_noabort(FAR void *addr)
 {
   __asan_report_load_n_noabort(addr, 1);
 }
 
-void __asan_report_store1_noabort(uintptr_t addr)
+void __asan_report_store1_noabort(FAR void *addr)
 {
   __asan_report_store_n_noabort(addr, 1);
 }
 
-void __asan_loadN_noabort(uintptr_t addr, size_t size)
+void __asan_loadN_noabort(FAR void *addr, size_t size)
 {
-  if (kasan_is_poisoned(addr, size))
+  if (kasan_is_poisoned((uintptr_t)addr, size))

Review Comment:
   let's change the prototype of kasan_is_poisoned to avoid the cast



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org