davids5 commented on code in PR #6894: URL: https://github.com/apache/incubator-nuttx/pull/6894#discussion_r952211951
########## drivers/syslog/ramlog.c: ########## @@ -125,8 +125,8 @@ static const struct file_operations g_ramlogfops = #ifdef CONFIG_RAMLOG_SYSLOG static char g_sysbuffer[CONFIG_RAMLOG_BUFSIZE] -#ifdef CONFIG_RAMLOG_BUFFER_SECTION - locate_data(CONFIG_RAMLOG_BUFFER_SECTION) +#ifdef RAMLOG_BUFFER_SECTION Review Comment: I suggesting using the pattern (choose the naming as you like) ``` #if defined(RAMLOG_BUFFER_SECTION) # define RAM_LOG_LOCATE locate_data(RAMLOG_BUFFER_SECTION) # else # define RAM_LOG_LOCATE #endif ``` ... ``` static char g_sysbuffer[CONFIG_RAMLOG_BUFSIZE] RAM_LOG_LOCATE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
