[incubator-nuttx] branch master updated: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 0e478e559f xtensa: coproc: modify cop

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
masayuki2009 merged PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[incubator-nuttx] branch master updated: build: Fix dependencies of kernel targets.

2022-05-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 4896623be2 build: Fix dependencies o

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6316: build: Fix dependencies of kernel targets.

2022-05-23 Thread GitBox
xiaoxiang781216 merged PR #6316: URL: https://github.com/apache/incubator-nuttx/pull/6316 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx-website] branch asf-site updated: Publishing web: 1b39f27b512cbb1fc294b70e0e70a67d0092b98d docs: 2a8b2cad1739896b2ed33da9d153f59e0796f486

2022-05-23 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 6d946ad Publishing web

[incubator-nuttx] branch master updated: esp32_cpuidlestack.c: Remove unnecessary code.

2022-05-23 Thread masayuki
This is an automated email from the ASF dual-hosted git repository. masayuki pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 2a8b2cad17 esp32_cpuidlestack.c: Remo

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #6317: esp32_cpuidlestack.c: Remove unnecessary code.

2022-05-23 Thread GitBox
masayuki2009 merged PR #6317: URL: https://github.com/apache/incubator-nuttx/pull/6317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6279: include:add recursive lock

2022-05-23 Thread GitBox
anchao commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r879932826 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); } +/**

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6279: include:add recursive lock

2022-05-23 Thread GitBox
anchao commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r879932826 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); } +/**

[GitHub] [incubator-nuttx] anchao commented on a diff in pull request #6279: include:add recursive lock

2022-05-23 Thread GitBox
anchao commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r879932826 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); } +/**

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #6310: Priority Inheritance fails to restore base priority

2022-05-23 Thread GitBox
pkarashchenko commented on issue #6310: URL: https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1135186671 I drafted some changes in https://github.com/apache/incubator-nuttx/pull/6318 The test described in this issue pass, but I didn't tried all the other OS tests relate

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request, #6318: sched/semaphore: fix priority boost restoration for priority inheritance

2022-05-23 Thread GitBox
pkarashchenko opened a new pull request, #6318: URL: https://github.com/apache/incubator-nuttx/pull/6318 ## Summary Attempt to fix priority boost restoration in case of priority inheritance ## Impact ## Testing WIP -- This is an automated message from the Apache Git

[GitHub] [incubator-nuttx] davids5 commented on issue #6310: Priority Inheritance fails to restore base priority

2022-05-23 Thread GitBox
davids5 commented on issue #6310: URL: https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1135157994 @pkarashchenko yes. Exactly - I will back port it. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #6310: Priority Inheritance fails to restore base priority

2022-05-23 Thread GitBox
pkarashchenko commented on issue #6310: URL: https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1135156441 @davids5 I think you are still looking into 10.1.0+ code. The bug with `pthread_barrier` was identified and fixed by adding `sem_setprotocol(&barrier->sem, SEM_PRIO_NO

[GitHub] [incubator-nuttx] davids5 commented on issue #6310: Priority Inheritance fails to restore base priority

2022-05-23 Thread GitBox
davids5 commented on issue #6310: URL: https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1135150514 @pkarashchenko - I am looking into the behavior if the pthread_barrier, and I am wondering if the init should be excluding the _barrier's semaphore from being involved in p

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #6310: Priority Inheritance fails to restore base priority

2022-05-23 Thread GitBox
pkarashchenko commented on issue #6310: URL: https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1135143549 The other method could be to iterate `g_waitingforsemaphore` the `n` times where `n` is a number of currently held semaphores. But the complexity of such operation mig

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
Ouss4 commented on PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302#issuecomment-1135111700 > > @zhuyanlinzyl > > > I noticed that crash happened with esp32-devkitc:smp on qemu. > > > > > > The issue happens with the following PR. #6269 > > @masayuki2009

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
Ouss4 commented on PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302#issuecomment-1135109660 > > I was trying to look into it but couldn't find an immediate solution/explanation. We can see from the crash dump that SP is pointing at the very bottom of the stack: `0x 3ffe7a8

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request, #6317: esp32_cpuidlestack.c: Remove unnecessary code.

2022-05-23 Thread GitBox
Ouss4 opened a new pull request, #6317: URL: https://github.com/apache/incubator-nuttx/pull/6317 ## Summary Remove an unused `#ifded`. ## Impact N/A ## Testing N/A -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[incubator-nuttx] branch master updated: xtensa:esp32: enable cp processor of app core

2022-05-23 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 23d35336ad xtensa:esp32: enable cp

[GitHub] [incubator-nuttx] Ouss4 merged pull request #6314: xtensa:esp32: enable cp processor of app core

2022-05-23 Thread GitBox
Ouss4 merged PR #6314: URL: https://github.com/apache/incubator-nuttx/pull/6314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nutt

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request, #6316: build: Fix dependencies of kernel targets.

2022-05-23 Thread GitBox
Ouss4 opened a new pull request, #6316: URL: https://github.com/apache/incubator-nuttx/pull/6316 ## Summary Targets build during the kernel phase did not have their dependencies specified and thus they were not rebuilt after their dependencies have changed, for example by changin

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
xiaoxiang781216 commented on PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302#issuecomment-1135065173 > I was trying to look into it but couldn't find an immediate solution/explanation. We can see from the crash dump that SP is pointing at the very bottom of the stack: `0x

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
xiaoxiang781216 commented on PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302#issuecomment-1135061260 > @zhuyanlinzyl > > > I noticed that crash happened with esp32-devkitc:smp on qemu. > > The issue happens with the following PR. #6269 @masayuki2009 FP

[incubator-nuttx] branch master updated: arch/arm/samv7: Fix PWM operation for single channel mode

2022-05-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 7a6253cb89 arch/arm/samv7: Fix PWM o

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6298: arch/arm/samv7: Fix PWM operation for single channel mode

2022-05-23 Thread GitBox
xiaoxiang781216 merged PR #6298: URL: https://github.com/apache/incubator-nuttx/pull/6298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[incubator-nuttx] branch master updated: risc-v/mpfs: amend OpenSBI to utilize IHC

2022-05-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3ea7d4bab4 risc-v/mpfs: amend OpenSB

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6304: risc-v/mpfs: amend OpenSBI to utilize IHC

2022-05-23 Thread GitBox
xiaoxiang781216 merged PR #6304: URL: https://github.com/apache/incubator-nuttx/pull/6304 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6315: LCD / SSD1306 added (re)configure IOCTL

2022-05-23 Thread GitBox
xiaoxiang781216 commented on code in PR #6315: URL: https://github.com/apache/incubator-nuttx/pull/6315#discussion_r879772994 ## drivers/lcd/ssd1306_base.c: ## @@ -782,7 +783,7 @@ static int ssd1306_setpower(FAR struct lcd_dev_s *dev, int power) { /* Configu

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
xiaoxiang781216 commented on PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1135055104 > > I amn't sure why you get crash here since the code exist for a long time. Yes, it isn't good to flush the stdio stream inside kernel, but it should work not crash at l

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6315: LCD / SSD1306 added (re)configure IOCTL

2022-05-23 Thread GitBox
xiaoxiang781216 commented on code in PR #6315: URL: https://github.com/apache/incubator-nuttx/pull/6315#discussion_r879772994 ## drivers/lcd/ssd1306_base.c: ## @@ -782,7 +783,7 @@ static int ssd1306_setpower(FAR struct lcd_dev_s *dev, int power) { /* Configu

[GitHub] [incubator-nuttx] michallenc commented on a diff in pull request #6298: arch/arm/samv7: Fix PWM operation for single channel mode

2022-05-23 Thread GitBox
michallenc commented on code in PR #6298: URL: https://github.com/apache/incubator-nuttx/pull/6298#discussion_r879707050 ## arch/arm/src/samv7/sam_pwm.c: ## @@ -493,71 +449,39 @@ static int pwm_start(struct pwm_lowerhalf_s *dev, const struct pwm_info_s *inf

[GitHub] [incubator-nuttx] pussuw commented on pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
pussuw commented on PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1134923458 > I amn't sure why you get crash here since the code exist for a long time. Yes, it isn't good to flush the stdio stream inside kernel, but it should work not crash at least.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
xiaoxiang781216 commented on PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1134893248 > For now I suggest for 1. that in sched/task/exit.c just > > * rename exit() -> _exit() > * remove old _exit() > * rename call to _exit() in exit() to up_exit(

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r879662422 ## libs/libc/stdlib/Kconfig: ## @@ -39,4 +39,11 @@ config LIBC_MAX_TMPFILE maximum size of that last filename. This size is the size of the full

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r879661884 ## libs/libc/stdlib/Kconfig: ## @@ -39,4 +39,11 @@ config LIBC_MAX_TMPFILE maximum size of that last filename. This size is the size of the full

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
xiaoxiang781216 commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r879660728 ## libs/libc/stdlib/Kconfig: ## @@ -39,4 +39,11 @@ config LIBC_MAX_TMPFILE maximum size of that last filename. This size is the size of

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6279: include:add recursive lock

2022-05-23 Thread GitBox
xiaoxiang781216 commented on code in PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#discussion_r879651029 ## include/nuttx/mutex.h: ## @@ -205,6 +214,200 @@ static inline int nxmutex_unlock(FAR mutex_t *mutex) return nxsem_post(mutex); } +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6279: include:add recursive lock

2022-05-23 Thread GitBox
xiaoxiang781216 commented on PR #6279: URL: https://github.com/apache/incubator-nuttx/pull/6279#issuecomment-1134878227 @davids5 and @pkarashchenko could you take a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #6310: Priority Inheritance fails to restore base priority

2022-05-23 Thread GitBox
pkarashchenko commented on issue #6310: URL: https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1134844516 So one of the possible solutions could be moving `pend_reprios` from `struct tcb_s` to a `struct semholder_s`, but that would grow memory consumption a lot. I tried to

[GitHub] [incubator-nuttx] pkarashchenko commented on issue #6310: Priority Inheritance fails to restore base priority

2022-05-23 Thread GitBox
pkarashchenko commented on issue #6310: URL: https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1134832614 I modified your test and added "task0.5" with priority 209 (in between of task0 and task1) and one additional semaphore (lets call it also "sem0.5"). So now task0 ta

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6313: arch: risc-v: Fix crt0.c if CONFIG_HAVE_CXX is not set

2022-05-23 Thread GitBox
pussuw commented on code in PR #6313: URL: https://github.com/apache/incubator-nuttx/pull/6313#discussion_r879604401 ## arch/risc-v/src/common/crt0.c: ## @@ -169,13 +169,15 @@ void _start(int argc, char *argv[]) ARCH_DATA_RESERVE->ar_sigtramp = (addrenv_sigtramp_t)sig_tramp

[GitHub] [incubator-nuttx] pussuw commented on pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
pussuw commented on PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1134827578 For now I suggest for 1. that in sched/task/exit.c just - rename exit() -> _exit() - remove old _exit() - rename call to _exit() to up_exit() This way works and p

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r879598935 ## boards/arm/imx6/sabre-6quad/configs/libcxx/defconfig: ## @@ -51,7 +51,6 @@ CONFIG_RAM_VSTART=0x1000 CONFIG_RAW_BINARY=y CONFIG_READLINE_CMD_HISTORY=y CO

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r879594294 ## libs/libc/stdlib/Kconfig: ## @@ -39,4 +39,11 @@ config LIBC_MAX_TMPFILE maximum size of that last filename. This size is the size of the full

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r879590707 ## include/nuttx/atexit.h: ## @@ -0,0 +1,81 @@ +/ + * include/nuttx/atexit.h + * + * L

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
pussuw commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r879590337 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,71 @@ +/ + * libs/libc/stdlib/lib_

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
xiaoxiang781216 commented on PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#issuecomment-1134795742 > Now there are still two open questions: > > 1. Where is the part prior to the call to _exit() supposed to go now ? There are now two definitions of exit() and this

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6197: libc: Implement userland implementations of exit functions

2022-05-23 Thread GitBox
xiaoxiang781216 commented on code in PR #6197: URL: https://github.com/apache/incubator-nuttx/pull/6197#discussion_r879536802 ## libs/libc/stdlib/lib_cxa_atexit.c: ## @@ -0,0 +1,71 @@ +/ + * libs/libc/st

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6313: arch: risc-v: Fix crt0.c if CONFIG_HAVE_CXX is not set

2022-05-23 Thread GitBox
xiaoxiang781216 commented on PR #6313: URL: https://github.com/apache/incubator-nuttx/pull/6313#issuecomment-1134671449 > LGTM, just need to remember to remove this after 6197 is merged Even #6197 is merged, the condition check is also good to save the code size, so it's better to kee

[incubator-nuttx] branch master updated (200109fd28 -> 84bcb075d7)

2022-05-23 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git from 200109fd28 arm/tlsr82: optimize the adc driver. add 84bcb075d7 arch: risc-v: Fix crt0.c if CONFIG_HAV

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6313: arch: risc-v: Fix crt0.c if CONFIG_HAVE_CXX is not set

2022-05-23 Thread GitBox
xiaoxiang781216 merged PR #6313: URL: https://github.com/apache/incubator-nuttx/pull/6313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubs

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6313: arch: risc-v: Fix crt0.c if CONFIG_HAVE_CXX is not set

2022-05-23 Thread GitBox
xiaoxiang781216 commented on code in PR #6313: URL: https://github.com/apache/incubator-nuttx/pull/6313#discussion_r879447482 ## arch/risc-v/src/common/crt0.c: ## @@ -169,13 +169,15 @@ void _start(int argc, char *argv[]) ARCH_DATA_RESERVE->ar_sigtramp = (addrenv_sigtramp_t)

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-23 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r879423498 ## arch/xtensa/src/esp32s3/esp32s3_spi.h: ## @@ -0,0 +1,170 @@ +/ + * arch/xtens

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-23 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r879422538 ## arch/xtensa/src/esp32s3/esp32s3_spi.h: ## @@ -0,0 +1,170 @@ +/ + * arch/xtens

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-23 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r879421712 ## arch/xtensa/src/esp32s3/esp32s3_spi.h: ## @@ -0,0 +1,170 @@ +/ + * arch/xtens

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-23 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r879419545 ## boards/xtensa/esp32s3/esp32s3-devkit/src/esp32s3_board_spi.c: ## @@ -0,0 +1,83 @@ +/*

[GitHub] [incubator-nuttx] gustavonihei commented on a diff in pull request #6312: xtensa/esp32s3: Add basic support to SPI

2022-05-23 Thread GitBox
gustavonihei commented on code in PR #6312: URL: https://github.com/apache/incubator-nuttx/pull/6312#discussion_r879418323 ## arch/xtensa/src/esp32s3/esp32s3_spi.h: ## @@ -0,0 +1,170 @@ +/ + * arch/xtens

[GitHub] [incubator-nuttx] davids5 commented on issue #6310: Priority Inheritance fails to restore base priority

2022-05-23 Thread GitBox
davids5 commented on issue #6310: URL: https://github.com/apache/incubator-nuttx/issues/6310#issuecomment-1134584734 @pkarashchenko Thanks for looking into this. It can be complex with multi counts, multi semaphores being held. > The case is that task pend_reprios does not

[GitHub] [incubator-nuttx] cisvanmierlo opened a new pull request, #6315: LCD / SSD1306 added (re)configure IOCTL

2022-05-23 Thread GitBox
cisvanmierlo opened a new pull request, #6315: URL: https://github.com/apache/incubator-nuttx/pull/6315 ## Summary Added IOCTL to (re)configure the display. This is needed if for example the voltage domain of the display is not active during NuttX initialization. ## Impact Ex

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
Ouss4 commented on PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302#issuecomment-1134580123 I was trying to look into it but couldn't find an immediate solution/explanation. We can see from the crash dump that SP is pointing at the very bottom of the stack: `0x 3ffe7a80

[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
zhuyanlinzyl commented on PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302#issuecomment-1134571209 @Ouss4 This crash seem have nothing to do with FPU. As I revert all xtensa new fpu patch, this crash also happen. -- This is an automated message from the Apache Git Servi

[GitHub] [incubator-nuttx] pussuw commented on a diff in pull request #6025: Add vm map

2022-05-23 Thread GitBox
pussuw commented on code in PR #6025: URL: https://github.com/apache/incubator-nuttx/pull/6025#discussion_r879314830 ## mm/shm/shm_initialize.c: ## @@ -69,20 +69,20 @@ struct shm_info_s g_shminfo = int shm_group_initialize(FAR struct task_group_s *group) { - DEBUGASSERT(gro

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
Ouss4 commented on PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302#issuecomment-1134497858 Looks like the stack is corrupted. I see that sack coloration is enabled, I remember having issues with it. -- This is an automated message from the Apache Git Service. To respon

[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
zhuyanlinzyl commented on PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302#issuecomment-1134486539 After that, the esp32 smp qemu was crash with this @Ouss4 ``` If RR scheduling is working, they should start and complete at about the same time

[GitHub] [incubator-nuttx] zhuyanlinzyl commented on pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
zhuyanlinzyl commented on PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302#issuecomment-1134472638 hi . @Ouss4 , @masayuki2009 . I have test with add this PR https://github.com/apache/incubator-nuttx/pull/6314 Ostest with fpu success with esp32-qemu. -- This is an au

[GitHub] [incubator-nuttx] zhuyanlinzyl opened a new pull request, #6314: xtensa:esp32: enable cp processor of app core

2022-05-23 Thread GitBox
zhuyanlinzyl opened a new pull request, #6314: URL: https://github.com/apache/incubator-nuttx/pull/6314 Signed-off-by: zhuyanlin ## Summary ## Impact ## Testing Ostest with fpu in Qemu esp32 smp -- This is an automated message from the Apache Git Service. To re

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6302: xtensa: coproc: modify coproc_save/restore to macro

2022-05-23 Thread GitBox
Ouss4 commented on PR #6302: URL: https://github.com/apache/incubator-nuttx/pull/6302#issuecomment-1134422962 The cause indicates 0x20 which is a coprocessor disabled but accessed (specifically the FPU here). I think we are not cleaning `CPENABLE` for CPU1. -- This is an automated messag

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1170: webclient: implement basic proxy

2022-05-23 Thread GitBox
pkarashchenko commented on code in PR #1170: URL: https://github.com/apache/incubator-nuttx-apps/pull/1170#discussion_r879147230 ## netutils/webclient/webclient.c: ## @@ -182,15 +182,21 @@ struct conn_s #defineWGET_FLAG_GOT_CONTENT_LENGTH 1U #defineWGET_FLAG_C

[GitHub] [incubator-nuttx-apps] yamt commented on a diff in pull request #1170: webclient: implement basic proxy

2022-05-23 Thread GitBox
yamt commented on code in PR #1170: URL: https://github.com/apache/incubator-nuttx-apps/pull/1170#discussion_r879144144 ## netutils/webclient/webclient.c: ## @@ -182,15 +182,21 @@ struct conn_s #defineWGET_FLAG_GOT_CONTENT_LENGTH 1U #defineWGET_FLAG_CHUNKED

[GitHub] [incubator-nuttx-apps] yamt commented on a diff in pull request #1170: webclient: implement basic proxy

2022-05-23 Thread GitBox
yamt commented on code in PR #1170: URL: https://github.com/apache/incubator-nuttx-apps/pull/1170#discussion_r879143983 ## netutils/webclient/webclient.c: ## @@ -1300,9 +1358,21 @@ int webclient_perform(FAR struct webclient_context *ctx) { /*

[GitHub] [incubator-nuttx-apps] yamt commented on a diff in pull request #1170: webclient: implement basic proxy

2022-05-23 Thread GitBox
yamt commented on code in PR #1170: URL: https://github.com/apache/incubator-nuttx-apps/pull/1170#discussion_r879140655 ## netutils/webclient/webclient.c: ## @@ -182,15 +182,21 @@ struct conn_s #defineWGET_FLAG_GOT_CONTENT_LENGTH 1U #defineWGET_FLAG_CHUNKED

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1170: webclient: implement basic proxy

2022-05-23 Thread GitBox
pkarashchenko commented on code in PR #1170: URL: https://github.com/apache/incubator-nuttx-apps/pull/1170#discussion_r879126090 ## netutils/webclient/webclient.c: ## @@ -1300,9 +1358,21 @@ int webclient_perform(FAR struct webclient_context *ctx) {

[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6313: arch: risc-v: Fix crt0.c if CONFIG_HAVE_CXX is not set

2022-05-23 Thread GitBox
pkarashchenko commented on PR #6313: URL: https://github.com/apache/incubator-nuttx/pull/6313#issuecomment-1134303031 > LGTM, just need to remember to remove this after 6197 is merged I think we can add removal to 6197 as soon as this PR is merged -- This is an automated message fro

[GitHub] [incubator-nuttx] eenurkka commented on a diff in pull request #6304: risc-v/mpfs: amend OpenSBI to utilize IHC

2022-05-23 Thread GitBox
eenurkka commented on code in PR #6304: URL: https://github.com/apache/incubator-nuttx/pull/6304#discussion_r879090489 ## arch/risc-v/src/mpfs/mpfs_ihc.c: ## @@ -115,22 +114,30 @@ struct mpfs_rptun_dev_s char shmemname[RPMSG_NAME_SIZE + 1]; }; -typede

[GitHub] [incubator-nuttx] eenurkka commented on a diff in pull request #6304: risc-v/mpfs: amend OpenSBI to utilize IHC

2022-05-23 Thread GitBox
eenurkka commented on code in PR #6304: URL: https://github.com/apache/incubator-nuttx/pull/6304#discussion_r879090062 ## arch/risc-v/src/mpfs/mpfs_ihc.c: ## @@ -367,6 +440,50 @@ static void mpfs_ihc_rx_handler(uint32_t *message, bool is_ack) } } +/*