[GitHub] [incubator-nuttx-apps] yamt commented on pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
yamt commented on pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#issuecomment-760720438 > BTW, please merge all patches(except webclient: Don't call the sink callback if no data is available) into one. i will squash them after testing with my local a

[incubator-nuttx-testing] branch revert-85-disable-avr updated (c9775ea -> 80ec90f)

2021-01-14 Thread yamamoto
This is an automated email from the ASF dual-hosted git repository. yamamoto pushed a change to branch revert-85-disable-avr in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git. discard c9775ea Run "brew update" before installing avr-gcc add d3846bf Run "brew up

[GitHub] [incubator-nuttx-testing] btashton commented on pull request #88: Revert "Disable AVR targets on macOS due to homebrew issue"

2021-01-14 Thread GitBox
btashton commented on pull request #88: URL: https://github.com/apache/incubator-nuttx-testing/pull/88#issuecomment-760692949 @yamt looks like the brew upgrade hits this bug https://github.com/actions/virtual-environments/issues/2322 Current recommendation from GitHub is to first

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
xiaoxiang781216 commented on pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#issuecomment-760687644 BTW, please merge all patches(except webclient: Don't call the sink callback if no data is available) into one.

[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #564: netutils : iperf: Fix compile warnings with Arm GCC 9.3.1

2021-01-14 Thread GitBox
masayuki2009 opened a new pull request #564: URL: https://github.com/apache/incubator-nuttx-apps/pull/564 ## Summary - This commit fixes compile warnings with Arm GCC 9.3.1 ## Impact - None ## Testing - Tested with lm3s6965-ek:discover - NOTE: need to ad

[incubator-nuttx-testing] branch revert-85-disable-avr updated (c22f723 -> c9775ea)

2021-01-14 Thread yamamoto
This is an automated email from the ASF dual-hosted git repository. yamamoto pushed a change to branch revert-85-disable-avr in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-testing.git. from c22f723 Revert "Disable AVR targets on macOS due to homebrew issue" add c9775

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557849077 ## File path: netutils/webclient/webclient.c ## @@ -740,6 +760,40 @@ int webclient_perform(FAR struct webclient_context *ctx)

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
yamt commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557843591 ## File path: netutils/webclient/webclient.c ## @@ -740,6 +760,40 @@ int webclient_perform(FAR struct webclient_context *ctx) retu

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2683: graphics: nxmu: Fix a compile warning with CONFIG_DEBUG_ASSERTIONS=y

2021-01-14 Thread GitBox
xiaoxiang781216 merged pull request #2683: URL: https://github.com/apache/incubator-nuttx/pull/2683 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated: graphics: nxmu: Fix a compile warning with CONFIG_DEBUG_ASSERTIONS=y

2021-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new eaae5dc graphics: nxmu: Fix a compi

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557837333 ## File path: include/netutils/webclient.h ## @@ -191,13 +191,17 @@ struct webclient_context * url - A pointer to a str

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557837333 ## File path: include/netutils/webclient.h ## @@ -191,13 +191,17 @@ struct webclient_context * url - A pointer to a str

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2681: libs: libxx: Fix compile errors with CONFIG_DEBUG_ERROR=y

2021-01-14 Thread GitBox
masayuki2009 commented on pull request #2681: URL: https://github.com/apache/incubator-nuttx/pull/2681#issuecomment-760616672 > > @masayuki2009 how about we enable CONFIG_DEBUG_xxx in several config to catch the similar error in the furture? > > Historically, we have forbidden debug

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557825630 ## File path: netutils/webclient/webclient.c ## @@ -740,6 +760,40 @@ int webclient_perform(FAR struct webclient_context *ctx)

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2682: arch: cxd56xx: Fix a compile warning with CONFIG_DEBUG_ERROR=y

2021-01-14 Thread GitBox
xiaoxiang781216 merged pull request #2682: URL: https://github.com/apache/incubator-nuttx/pull/2682 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (6626420 -> 5f0e334)

2021-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 6626420 libs: libxx: Fix compile errors with CONFIG_DEBUG_ERROR=y add 5f0e334 arch: cxd56xx: Fix a

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557829097 ## File path: include/netutils/webclient.h ## @@ -191,13 +191,17 @@ struct webclient_context * url - A pointer to a str

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557822826 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557822826 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/*

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
yamt commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557830349 ## File path: include/netutils/webclient.h ## @@ -191,13 +191,17 @@ struct webclient_context * url - A pointer to a string contain

[GitHub] [incubator-nuttx] patacongo commented on pull request #2681: libs: libxx: Fix compile errors with CONFIG_DEBUG_ERROR=y

2021-01-14 Thread GitBox
patacongo commented on pull request #2681: URL: https://github.com/apache/incubator-nuttx/pull/2681#issuecomment-760602250 > > > @masayuki2009 how about we enable CONFIG_DEBUG_xxx in several config to catch the similar error in the furture? Historically, we have forbidden deb

[incubator-nuttx] branch master updated (caf2d14 -> 6626420)

2021-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from caf2d14 arch/risc-v/bl602: add gpioirq and i2c(master) driver add 6626420 libs: libxx: Fix compile

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2681: libs: libxx: Fix compile errors with CONFIG_DEBUG_ERROR=y

2021-01-14 Thread GitBox
xiaoxiang781216 merged pull request #2681: URL: https://github.com/apache/incubator-nuttx/pull/2681 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2681: libs: libxx: Fix compile errors with CONFIG_DEBUG_ERROR=y

2021-01-14 Thread GitBox
xiaoxiang781216 commented on pull request #2681: URL: https://github.com/apache/incubator-nuttx/pull/2681#issuecomment-760598610 @masayuki2009 how about we enable CONFIG_DEBUG_xxx in several config to catch the similar error in the furture?

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2683: graphics: nxmu: Fix a compile warning with CONFIG_DEBUG_ASSERTIONS=y

2021-01-14 Thread GitBox
masayuki2009 opened a new pull request #2683: URL: https://github.com/apache/incubator-nuttx/pull/2683 ## Summary - This commit fixes a compile warning in nxmu_sendclient.c - Actually, conn->swrmq will be checked in nxmq_send() ## Impact - None ## Testing

[incubator-nuttx-website] branch asf-site updated: Publishing web: 59c4fb7620bc9aabf46df895f9e5cdb361f50177 docs: caf2d1430e07613c65de7b11f4ce380acf10e03d

2021-01-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 0964cf1 Publishing web

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2682: arch: cxd56xx: Fix a compile warning with CONFIG_DEBUG_ERROR=y

2021-01-14 Thread GitBox
masayuki2009 opened a new pull request #2682: URL: https://github.com/apache/incubator-nuttx/pull/2682 ## Summary - This commit fixes a compile warning in cxd56_sdhci.c ## Impact - None ## Testing - Built with spresense:wifi --

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
yamt commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557772358 ## File path: netutils/webclient/webclient.c ## @@ -740,6 +760,40 @@ int webclient_perform(FAR struct webclient_context *ctx) retu

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
yamt commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557770421 ## File path: netutils/webclient/webclient.c ## @@ -740,6 +769,40 @@ int webclient_perform(FAR struct webclient_context *ctx) retu

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
yamt commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557770258 ## File path: include/netutils/webclient.h ## @@ -191,13 +191,17 @@ struct webclient_context * url - A pointer to a string contain

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2681: libs: libxx: Fix compile errors with CONFIG_DEBUG_ERROR=y

2021-01-14 Thread GitBox
masayuki2009 opened a new pull request #2681: URL: https://github.com/apache/incubator-nuttx/pull/2681 ## Summary - This commit fixes compile errors in libxx_new.cxx and libxx_newa.cxx ## Impact - None ## Testing - Build with spresense:nsh with CONFIG_DEBUG

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557642414 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx-apps] PetervdPerk-NXP commented on a change in pull request #563: canutils/slcan: Add SLCAN utility

2021-01-14 Thread GitBox
PetervdPerk-NXP commented on a change in pull request #563: URL: https://github.com/apache/incubator-nuttx-apps/pull/563#discussion_r557630430 ## File path: canutils/slcan/slcan.c ## @@ -0,0 +1,504 @@ +/**

[GitHub] [incubator-nuttx-apps] PetervdPerk-NXP commented on a change in pull request #563: canutils/slcan: Add SLCAN utility

2021-01-14 Thread GitBox
PetervdPerk-NXP commented on a change in pull request #563: URL: https://github.com/apache/incubator-nuttx-apps/pull/563#discussion_r557630090 ## File path: canutils/slcan/slcan.h ## @@ -0,0 +1,47 @@ +/***

[GitHub] [incubator-nuttx-apps] PetervdPerk-NXP commented on a change in pull request #563: canutils/slcan: Add SLCAN utility

2021-01-14 Thread GitBox
PetervdPerk-NXP commented on a change in pull request #563: URL: https://github.com/apache/incubator-nuttx-apps/pull/563#discussion_r557629633 ## File path: canutils/slcan/slcan.c ## @@ -0,0 +1,504 @@ +/**

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557617455 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557617211 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx-apps] acassis commented on a change in pull request #563: canutils/slcan: Add SLCAN utility

2021-01-14 Thread GitBox
acassis commented on a change in pull request #563: URL: https://github.com/apache/incubator-nuttx-apps/pull/563#discussion_r557578282 ## File path: canutils/slcan/slcan.c ## @@ -0,0 +1,504 @@ +/ + * a

[incubator-nuttx-apps] branch master updated: ntpclient: change sinfo to ninfo

2021-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 3553565 ntpclient: change sinf

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #562: ntpclient: change sinfo to ninfo

2021-01-14 Thread GitBox
xiaoxiang781216 merged pull request #562: URL: https://github.com/apache/incubator-nuttx-apps/pull/562 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx-apps] davids5 commented on a change in pull request #563: canutils/slcan: Add SLCAN utility

2021-01-14 Thread GitBox
davids5 commented on a change in pull request #563: URL: https://github.com/apache/incubator-nuttx-apps/pull/563#discussion_r557547287 ## File path: canutils/slcan/slcan.c ## @@ -0,0 +1,504 @@ +/ + * a

[GitHub] [incubator-nuttx] btashton closed pull request #2637: BL602: Initial I2C support

2021-01-14 Thread GitBox
btashton closed pull request #2637: URL: https://github.com/apache/incubator-nuttx/pull/2637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-nuttx] btashton commented on pull request #2637: BL602: Initial I2C support

2021-01-14 Thread GitBox
btashton commented on pull request #2637: URL: https://github.com/apache/incubator-nuttx/pull/2637#issuecomment-760324907 Closing and merging #2669 instead This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-nuttx] btashton merged pull request #2669: arch/risc-v/bl602 : add gpioirq、 i2c(master) driver.

2021-01-14 Thread GitBox
btashton merged pull request #2669: URL: https://github.com/apache/incubator-nuttx/pull/2669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-nuttx] branch master updated (c618d04 -> caf2d14)

2021-01-14 Thread btashton
This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c618d04 Add placement new and new[] function. add caf2d14 arch/risc-v/bl602: add gpioirq and i2c(ma

[GitHub] [incubator-nuttx] btashton commented on pull request #2669: arch/risc-v/bl602 : add gpioirq、 i2c(master) driver.

2021-01-14 Thread GitBox
btashton commented on pull request #2669: URL: https://github.com/apache/incubator-nuttx/pull/2669#issuecomment-760324290 @liangzhanggb Let's merge this in, we can make some more improvements later. This is an automated me

[GitHub] [incubator-nuttx-apps] PetervdPerk-NXP opened a new pull request #563: canutils/slcan: Add SLCAN utility

2021-01-14 Thread GitBox
PetervdPerk-NXP opened a new pull request #563: URL: https://github.com/apache/incubator-nuttx-apps/pull/563 ## Summary Implementation of SLCAN (CAN over serial) UART protocol to convert SocketCAN interfaces to UART interfaces ## Impact None, just a new application ## Te

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557459942 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2675: Add placement new and new[] function.

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2675: URL: https://github.com/apache/incubator-nuttx/pull/2675#discussion_r557457814 ## File path: libs/libxx/libxx_new.cxx ## @@ -88,3 +88,18 @@ FAR void *operator new(std::size_t nbytes) return alloc; } + +FAR void

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557446171 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx-apps] juniskane opened a new pull request #562: ntpclient: change sinfo to ninfo

2021-01-14 Thread GitBox
juniskane opened a new pull request #562: URL: https://github.com/apache/incubator-nuttx-apps/pull/562 ## Summary Change sinfo() to ninfo(), as I could not figure out why use scheduler debug macro in networking code Cosmetic changes, nxstyle ## Impact ## Testing -

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2675: Add placement new and new[] function.

2021-01-14 Thread GitBox
davids5 commented on a change in pull request #2675: URL: https://github.com/apache/incubator-nuttx/pull/2675#discussion_r557443881 ## File path: libs/libxx/libxx_new.cxx ## @@ -88,3 +88,18 @@ FAR void *operator new(std::size_t nbytes) return alloc; } + +FAR void *operato

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557443340 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2675: Add placement new and new[] function.

2021-01-14 Thread GitBox
xiaoxiang781216 merged pull request #2675: URL: https://github.com/apache/incubator-nuttx/pull/2675 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (8e43979 -> c618d04)

2021-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 8e43979 net/ & esp32/wlan: Fix some typos and nxstyle issues. add c618d04 Add placement new and ne

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557430079 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557423365 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557421239 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/*

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557420652 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557419042 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/*

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557418477 ## File path: drivers/efuse/efuse.c ## @@ -0,0 +1,395 @@ +/ + * driver

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557418357 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/*

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557416948 ## File path: drivers/efuse/efuse.c ## @@ -0,0 +1,395 @@ +/ +

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2680: net/ & esp32/wlan: Fix some typos and nxstyle issues.

2021-01-14 Thread GitBox
xiaoxiang781216 merged pull request #2680: URL: https://github.com/apache/incubator-nuttx/pull/2680 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (c11413a -> 8e43979)

2021-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from c11413a Added formatted timestamps in syslog. add 8e43979 net/ & esp32/wlan: Fix some typos and nx

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2621: Added formatted timestamps in syslog.

2021-01-14 Thread GitBox
xiaoxiang781216 merged pull request #2621: URL: https://github.com/apache/incubator-nuttx/pull/2621 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (4e6adef -> c11413a)

2021-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 4e6adef sim: Use c++14 for LIBCXX add c11413a Added formatted timestamps in syslog. No new revisi

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2621: Added formatted timestamps in syslog.

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2621: URL: https://github.com/apache/incubator-nuttx/pull/2621#discussion_r557410510 ## File path: drivers/syslog/vsyslog.c ## @@ -132,8 +137,25 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR va_list *ap) #

[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #2621: Added formatted timestamps in syslog.

2021-01-14 Thread GitBox
fjpanag commented on a change in pull request #2621: URL: https://github.com/apache/incubator-nuttx/pull/2621#discussion_r557386693 ## File path: drivers/syslog/vsyslog.c ## @@ -132,8 +137,25 @@ int nx_vsyslog(int priority, FAR const IPTR char *fmt, FAR va_list *ap) #if defin

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2679: tools/esp32/btdecode.sh: Script to decode the Xtensa backtrace.

2021-01-14 Thread GitBox
Ouss4 commented on pull request #2679: URL: https://github.com/apache/incubator-nuttx/pull/2679#issuecomment-760180904 > Shouldn't be "backtrace_file" or path/to/backtrace_file ? Yes, backtrace_file is better. I guess I wrote first path_to_backtrace and then changed to backtrace_pat

[GitHub] [incubator-nuttx] acassis commented on pull request #2679: tools/esp32/btdecode.sh: Script to decode the Xtensa backtrace.

2021-01-14 Thread GitBox
acassis commented on pull request #2679: URL: https://github.com/apache/incubator-nuttx/pull/2679#issuecomment-760165853 Hi @Ouss4 the comment: ``` script as: ./tools/esp32/btdecode.sh backtrace_path ``` Shouldn't be "backtrace_file" or path/to/backtrace_file ?

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
acassis commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557355538 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/ + *

[GitHub] [incubator-nuttx] saramonteiro commented on a change in pull request #2628: Add generic efuse driver for NuttX

2021-01-14 Thread GitBox
saramonteiro commented on a change in pull request #2628: URL: https://github.com/apache/incubator-nuttx/pull/2628#discussion_r557345542 ## File path: include/nuttx/efuse/efuse.h ## @@ -0,0 +1,155 @@ +/

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2680: net/ & esp32/wlan: Fix some typos and nxstyle issues.

2021-01-14 Thread GitBox
Ouss4 opened a new pull request #2680: URL: https://github.com/apache/incubator-nuttx/pull/2680 ## Summary Some typos and cosmetic changes only. ## Impact N/A ## Testing N/A This is an automated message fro

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2678: Fix libcxx for sim/macOS (less controversial parts)

2021-01-14 Thread GitBox
xiaoxiang781216 merged pull request #2678: URL: https://github.com/apache/incubator-nuttx/pull/2678 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (21c091f -> 4e6adef)

2021-01-14 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 21c091f esp32: Add a gdb script to show backtrace add 3fc06ff sim: Specify -fshort-wchar as NuttX

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557287757 ## File path: netutils/webclient/webclient.c ## @@ -740,6 +769,40 @@ int webclient_perform(FAR struct webclient_context *ctx)

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557287383 ## File path: netutils/webclient/webclient.c ## @@ -740,6 +760,40 @@ int webclient_perform(FAR struct webclient_context *ctx)

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557286167 ## File path: include/netutils/webclient.h ## @@ -191,13 +191,17 @@ struct webclient_context * url - A pointer to a str

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
yamt commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557244180 ## File path: netutils/webclient/webclient.c ## @@ -740,6 +760,40 @@ int webclient_perform(FAR struct webclient_context *ctx) retu

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
yamt commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557243451 ## File path: include/netutils/webclient.h ## @@ -191,13 +191,17 @@ struct webclient_context * url - A pointer to a string contain

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
yamt commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557242140 ## File path: include/netutils/webclient.h ## @@ -191,13 +191,17 @@ struct webclient_context * url - A pointer to a string contain

[GitHub] [incubator-nuttx-apps] yamt commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
yamt commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557241524 ## File path: netutils/webclient/webclient.c ## @@ -724,6 +724,15 @@ int webclient_perform(FAR struct webclient_context *ctx) {

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #561: webclient: Add AF_LOCAL support

2021-01-14 Thread GitBox
xiaoxiang781216 commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557223407 ## File path: include/netutils/webclient.h ## @@ -191,13 +191,17 @@ struct webclient_context * url - A pointer to a str

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2673: esp32: Add a gdb script to show backtrace

2021-01-14 Thread GitBox
Ouss4 commented on pull request #2673: URL: https://github.com/apache/incubator-nuttx/pull/2673#issuecomment-760024885 > > @yamt for reference I have this little script that I use with the backtrace. It requires a few manual input though (copying the backtrace to a file). > > ```shell

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2679: tools/esp32/btdecode.sh: Script to decode the Xtensa backtrace.

2021-01-14 Thread GitBox
Ouss4 opened a new pull request #2679: URL: https://github.com/apache/incubator-nuttx/pull/2679 ## Summary A script that decodes the backtrace dumped during assertions. ## Impact ## Testing This is an

[incubator-nuttx] branch master updated (6570883 -> 21c091f)

2021-01-14 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 6570883 stm32412: Fixes pinmap CAN1 add 21c091f esp32: Add a gdb script to show backtrace No ne

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2673: esp32: Add a gdb script to show backtrace

2021-01-14 Thread GitBox
Ouss4 merged pull request #2673: URL: https://github.com/apache/incubator-nuttx/pull/2673 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to