yamt commented on a change in pull request #561: URL: https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557772358
########## File path: netutils/webclient/webclient.c ########## @@ -740,6 +760,40 @@ int webclient_perform(FAR struct webclient_context *ctx) return -errno; } +#if defined(CONFIG_WEBCLIENT_NET_LOCAL) Review comment: do you mean to move the "prepare server_address" part before socket() call? why? the number of #ifdef is the same. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org