xiaoxiang781216 commented on a change in pull request #561:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/561#discussion_r557223407
##########
File path: include/netutils/webclient.h
##########
@@ -191,13 +191,17 @@ struct webclient_context
* url - A pointer to a string containing the full URL.
* (e.g., http://www.nutt.org/index.html, or
* http://192.168.23.1:80/index.html)
+ * unix_socket - If not NULL, the path to an AF_LOCAL socket.
* headers - An array of pointers to the extra headers.
* nheaders - The number of elements in the "headers" array.
* bodylen - The size of the request body.
*/
FAR const char *method;
FAR const char *url;
Review comment:
why not reuse url for unix_socket?
##########
File path: netutils/webclient/webclient.c
##########
@@ -724,6 +724,15 @@ int webclient_perform(FAR struct webclient_context *ctx)
{
char port_str[sizeof("65535")];
+#if defined(CONFIG_WEBCLIENT_NET_LOCAL)
+ if (ctx->unix_socket != NULL)
Review comment:
If unix_socket doesn't implement TLS, why isn't conn.tls zero in the
first place and then the whole block skip at line 723?
##########
File path: include/netutils/webclient.h
##########
@@ -191,13 +191,17 @@ struct webclient_context
* url - A pointer to a string containing the full URL.
* (e.g., http://www.nutt.org/index.html, or
* http://192.168.23.1:80/index.html)
+ * unix_socket - If not NULL, the path to an AF_LOCAL socket.
* headers - An array of pointers to the extra headers.
* nheaders - The number of elements in the "headers" array.
* bodylen - The size of the request body.
*/
FAR const char *method;
FAR const char *url;
+#if defined(CONFIG_WEBCLIENT_NET_LOCAL)
+ FAR const char *unix_socket;
Review comment:
who will set unix_socket? I don't find the related code.
##########
File path: netutils/webclient/webclient.c
##########
@@ -740,6 +760,40 @@ int webclient_perform(FAR struct webclient_context *ctx)
return -errno;
}
+#if defined(CONFIG_WEBCLIENT_NET_LOCAL)
Review comment:
merge line 742-752
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
