[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #492: wireless/wapi/src/driver_wext.c: Fix a syslog format

2020-11-20 Thread GitBox
xiaoxiang781216 merged pull request #492: URL: https://github.com/apache/incubator-nuttx-apps/pull/492 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated: wireless/wapi/src/driver_wext.c: Fix a syslog format

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new aea1ba9 wireless/wapi/src/driv

[incubator-nuttx] branch master updated (8cf6cfd -> ac6b08c)

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 8cf6cfd imxrt: Added support for DP83825I PHY new c443809 net/local/local_recvfrom.c: Appease nxst

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2357: Syslog format fixes

2020-11-20 Thread GitBox
xiaoxiang781216 merged pull request #2357: URL: https://github.com/apache/incubator-nuttx/pull/2357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2355: esp32_himem: Fix issue that was preventing to map all free memory

2020-11-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2355: URL: https://github.com/apache/incubator-nuttx/pull/2355#discussion_r528079011 ## File path: arch/xtensa/src/esp32/esp32_himem.c ## @@ -320,7 +320,7 @@ static bool allocate_blocks(int count, uint16_t *blocks_out)

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731514560 Yes, The build should pass now. This is an automated message from the Apache Git Service. To res

[GitHub] [incubator-nuttx] yamt opened a new pull request #2357: Syslog format fixes

2020-11-20 Thread GitBox
yamt opened a new pull request #2357: URL: https://github.com/apache/incubator-nuttx/pull/2357 ## Summary Extracted from https://github.com/apache/incubator-nuttx/pull/2347 ## Impact ## Testing This is an

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #492: wireless/wapi/src/driver_wext.c: Fix a syslog format

2020-11-20 Thread GitBox
yamt opened a new pull request #492: URL: https://github.com/apache/incubator-nuttx-apps/pull/492 ## Summary see https://github.com/apache/incubator-nuttx/pull/2347 ## Impact ## Testing This is an automat

[GitHub] [incubator-nuttx] RockySong edited a comment on issue #844: Should the makefile warn if there isn't a valid APPDIR?

2020-11-20 Thread GitBox
RockySong edited a comment on issue #844: URL: https://github.com/apache/incubator-nuttx/issues/844#issuecomment-731484557 [solved on my side, thanks @acassis, the results are appended at last] Hi @acassis Noted with thanks for your reply! Later I downloaded the 9.1.0 release from

[GitHub] [incubator-nuttx] RockySong edited a comment on issue #844: Should the makefile warn if there isn't a valid APPDIR?

2020-11-20 Thread GitBox
RockySong edited a comment on issue #844: URL: https://github.com/apache/incubator-nuttx/issues/844#issuecomment-731484557 [solved on my side, thanks @acassis, the results are appended at last] Hi @acassis Noted with thanks for your reply! Later I downloaded the 9.1.0 release from

[GitHub] [incubator-nuttx] RockySong edited a comment on issue #844: Should the makefile warn if there isn't a valid APPDIR?

2020-11-20 Thread GitBox
RockySong edited a comment on issue #844: URL: https://github.com/apache/incubator-nuttx/issues/844#issuecomment-731484557 Hi @acassis Noted with thanks for your reply! Later I downloaded the 9.1.0 release from Nuttx official site and deleted the git cloned version, and 9.1.0 release wor

[GitHub] [incubator-nuttx] RockySong commented on issue #844: Should the makefile warn if there isn't a valid APPDIR?

2020-11-20 Thread GitBox
RockySong commented on issue #844: URL: https://github.com/apache/incubator-nuttx/issues/844#issuecomment-731484557 Hi @acassis Noted with thanks for your reply! Later I downloaded the 9.1.0 release from Nuttx official site and deleted the git cloned version, and 9.1.0 release worked nor

[incubator-nuttx-website] branch asf-site updated: Publishing web: 5eb8540a7fe060c5e451b36dfb23656a6f18e3e7 docs: 8cf6cfda1a1f34fe9fdfac75f94e93f73a7db201

2020-11-20 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 53eb94c Publishing web

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2356: Fix lc823450

2020-11-20 Thread GitBox
masayuki2009 commented on pull request #2356: URL: https://github.com/apache/incubator-nuttx/pull/2356#issuecomment-731467977 @acassis I fixed the file. This is an automated message from the Apache Git Service

[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #2356: Fix lc823450

2020-11-20 Thread GitBox
masayuki2009 opened a new pull request #2356: URL: https://github.com/apache/incubator-nuttx/pull/2356 ## Summary - arch: lc823450: Fix compile errors in lc823450_usbdev.c with CONFIG_USBDEV_DMA=y - boards: lc823450-xgevk: Add CONFIG_USBDEV_DMA=y to rndis/defconfig ## Impac

[incubator-nuttx] branch master updated: imxrt: Added support for DP83825I PHY

2020-11-20 Thread acassis
This is an automated email from the ASF dual-hosted git repository. acassis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 8cf6cfd imxrt: Added support for DP83

[GitHub] [incubator-nuttx] acassis merged pull request #2354: imxrt: Added support for DP83825I PHY

2020-11-20 Thread GitBox
acassis merged pull request #2354: URL: https://github.com/apache/incubator-nuttx/pull/2354 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] acassis commented on pull request #2354: imxrt: Added support for DP83825I PHY

2020-11-20 Thread GitBox
acassis commented on pull request #2354: URL: https://github.com/apache/incubator-nuttx/pull/2354#issuecomment-731460826 Thank you @michallenc for more this contribution! This is an automated message from the Apache Git Servi

[GitHub] [incubator-nuttx] acassis opened a new pull request #2355: esp32_himem: Fix issue that was preventing to map all free memory

2020-11-20 Thread GitBox
acassis opened a new pull request #2355: URL: https://github.com/apache/incubator-nuttx/pull/2355 ## Summary esp32_himem: Fix issue that was preventing to map all free memory ## Impact User will be able to use all free PSRAM memory ## Testing esp32-core -

[GitHub] [incubator-nuttx] michallenc opened a new pull request #2354: imxrt: Added support for DP83825I PHY

2020-11-20 Thread GitBox
michallenc opened a new pull request #2354: URL: https://github.com/apache/incubator-nuttx/pull/2354 ## Summary Adds support for DP83825I PHY on i.MX RT MCU. ## Testing Tested on Teensy 4.1 board. This is an

[GitHub] [incubator-nuttx] patacongo removed a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo removed a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731383446 Anyone who merges this PR is potentially an accessory to a crime. My recommendation is that you wait for the advice of @justinmclean I will abide by tha

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731402283 @xiaoxiang781216 fails: Error: unistd/lib_getopt.c:300:34: error: 'struct option' declared inside parameter list will not be visible outside of this d

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731402283 @xiaoxiang781216 fails: Error: unistd/lib_getopt.c:300:34: error: 'struct option' declared inside parameter list will not be visible outside of this definiti

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731393867 It looks to me that the stripped down version in the current PR does contains only original code. I think this can be merged as it is. I will do that after a

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731393867 It looks to me that the stripped down version in the current PR does contain only original code. I think this can be merged as it is. I will do that after a f

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731375176 > > > @patacongo the code is rewritten, it shouldn't have the copyright issue now. Modifying copyrighted code does not change the copyright or rel

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731393867 It looks to me that the stripped down version in the current PR does contain only original code. I think this can be merged as it is. Please be careful w

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731393867 It looks to me that the stripped down version in the current PR does contain only original code. I think this can be merged as it is. Please be careful with res

[GitHub] [incubator-nuttx] patacongo removed a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo removed a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731387451 I have zero confidence in the code and do not believe anything you are saying. I am going to back out of the picture now. I will not be merging this PR.

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731391670 The C code comes clearly from Gregory Pietsch implementation https://github.com/eblot/newlib/blob/master/newlib/libc/stdlib/getopt.c down to variable names and functio

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731387451 I have zero confidence in the code and do not believe anything you are saying. I am going to back out of the picture now. I will not be merging this PR. If so

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731385404 > This code appears to have been stolen from other open source implementation. We cannot plaster an Apache 2.0 license on it and say that we own it! > > F

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731383446 Anyone who merges this PR is potentially an accessory to a crime. My recommendation is that you wait for the advice of @justinmclean I will abide by that. ---

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731382885 > > > Let me repeat again: the code is written by myself now, no code copy or modify from Gregory Pietsch: > https://users.cs.cf.ac.uk/KurtevaA/MSCProject/c

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731379509 Let me repeat again: the code is written by myself now, no code copy or modify from Gregory Pietsch: https://users.cs.cf.ac.uk/KurtevaA/MSCProject/code

[GitHub] [incubator-nuttx] kernelgurumeditation commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi

2020-11-20 Thread GitBox
kernelgurumeditation commented on pull request #2353: URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731380388 yes... the style check script is really picky! :D This is an automated message from the Apa

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731379509 Let me repeat again: the code is written by myself now, no code come from Gregory Pietsch: https://users.cs.cf.ac.uk/KurtevaA/MSCProject/code/speak.js-

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731379509 Let me repeat again: the code is written by myself now, no code come from Gregory Pietsch. If you think there are any similarity, please point out them.

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731379509 Let me repeat again: the code is written by myself now. There is no any code come from Gregory Pietsch.

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731379509 Let me repeat again: the code is written by myself now, no code come from Gregory Pietsch. --

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731375176 > > > @patacongo the code is rewritten, it shouldn't have the copyright issue now. Modifying copyrighted code does not change the copyright or rel

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731375176 > > > @patacongo the code is rewritten, it shouldn't have the copyright issue now. Modifying copyrighted code does not change the copyright or rel

[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi

2020-11-20 Thread GitBox
btashton commented on pull request #2353: URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731377305 Also a tip for local testing the style issues. ``` git diff origin/master | ./tools/checkpatch.sh - ``` ---

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731375176 > > > @patacongo the code is rewritten, it shouldn't have the copyright issue now. Modifying copyrighted code does not change the copyright or rel

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731375176 > > > @patacongo the code is rewritten, it shouldn't have the copyright issue now. Modifying copyrighted code does not change the copyright or release yo

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r527931070 ## File path: include/getopt.h ## @@ -0,0 +1,117 @@ +/ + * inc

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731368344 @patacongo the code is rewritten, it is no copyright issue now. This is an automated mess

[GitHub] [incubator-nuttx-apps] kernelgurumeditation commented on issue #481: Elf loader sample app doesn't build

2020-11-20 Thread GitBox
kernelgurumeditation commented on issue #481: URL: https://github.com/apache/incubator-nuttx-apps/issues/481#issuecomment-731369541 Ok, it's athttps://github.com/apache/incubator-nuttx/pull/2353 Not pretty but works, and can be useful to someone :) -

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731368344 @patacongo the code is rewritten, it shouldn't have the copyright issue now. This is an a

[GitHub] [incubator-nuttx-apps] kernelgurumeditation edited a comment on issue #481: Elf loader sample app doesn't build

2020-11-20 Thread GitBox
kernelgurumeditation edited a comment on issue #481: URL: https://github.com/apache/incubator-nuttx-apps/issues/481#issuecomment-731369541 Ok @btashton , it's athttps://github.com/apache/incubator-nuttx/pull/2353 Not pretty but works, and can be useful to someone :) ---

[GitHub] [incubator-nuttx] btashton commented on pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi

2020-11-20 Thread GitBox
btashton commented on pull request #2353: URL: https://github.com/apache/incubator-nuttx/pull/2353#issuecomment-731370834 Thanks! One thing off the bat can you use `make savedefconfig` to generate the defconfig file. It will be generated in the base NuttX directory. That will give us t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 commented on a change in pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r527931070 ## File path: include/getopt.h ## @@ -0,0 +1,117 @@ +/ + * inc

[GitHub] [incubator-nuttx] kernelgurumeditation opened a new pull request #2353: Fix of the OTG FS HOST for nucleo-h743zi

2020-11-20 Thread GitBox
kernelgurumeditation opened a new pull request #2353: URL: https://github.com/apache/incubator-nuttx/pull/2353 ## Summary Small fix to enable OTG FS HOST capability of the nucleo-h743zi board Added also a default configuration file with this capability enabled ## Impact #

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731368344 @patacongo the code is written, it is no copyright issue now. This is an automated message from

[GitHub] [incubator-nuttx-apps] btashton edited a comment on issue #481: Elf loader sample app doesn't build

2020-11-20 Thread GitBox
btashton edited a comment on issue #481: URL: https://github.com/apache/incubator-nuttx-apps/issues/481#issuecomment-731341220 Sure I'm happy to review it. I really want to pull some of the common board logic out so we don't have to keep copy pasting it for every variant, but that will ta

[GitHub] [incubator-nuttx-apps] btashton commented on issue #481: Elf loader sample app doesn't build

2020-11-20 Thread GitBox
btashton commented on issue #481: URL: https://github.com/apache/incubator-nuttx-apps/issues/481#issuecomment-731341220 Sure I'm happy to review it. I really want to pull some of the common board logic out so we don't have to keep copy pasting it for every variant, but that will take some

[GitHub] [incubator-nuttx-apps] kernelgurumeditation closed issue #481: Elf loader sample app doesn't build

2020-11-20 Thread GitBox
kernelgurumeditation closed issue #481: URL: https://github.com/apache/incubator-nuttx-apps/issues/481 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731329650 This code seems to derive from the implementation by Gregory Pietsch. That is public domain and not GPL: https://users.cs.cf.ac.uk/KurtevaA/MSCProject/code/sp

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731329650 This code seems to derive from the implementation by Gregory Pietsch. That is public domain and not GPL: https://users.cs.cf.ac.uk/KurtevaA/MSCProject/code/sp

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731329650 This code seems to derive from the implementation by Gregory Pietsch. That is public domain and not GPL: https://users.cs.cf.ac.uk/KurtevaA/MSCProject/code/sp

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731329650 This code seems to derive from the implementation by Gregory Pietsch. That is public domain and not GPL: https://users.cs.cf.ac.uk/KurtevaA/MSCProject/code/speak.js-

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731319923 This code appears to have been stolen from other open source implementation. We cannot plaster an Apache 2.0 license on it and say that we own it! For ex

[GitHub] [incubator-nuttx] acassis commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
acassis commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731327038 The file seams to be in public domain, but the author asked to include his name, so @xiaoxiang781216 I think it should include "Copyright (C) 1997 Gregory Pietsch" if th

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731319923 This code appears to have been stolen from other open source implementation. We cannot plaster an Apache 2.0 license on it and say that we own it! For example,

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on a change in pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r527866501 ## File path: include/getopt.h ## @@ -0,0 +1,117 @@ +/ + * include/g

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on a change in pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r527861295 ## File path: libs/libc/unistd/lib_getopt.c ## @@ -39,257 +39,565 @@ #include -#include -#include +#include +#include #include +#inc

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on a change in pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r527861009 ## File path: libs/libc/unistd/lib_getopt.c ## @@ -39,257 +39,565 @@ #include -#include -#include +#include +#include #include +#inc

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on a change in pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r527859737 ## File path: libs/libc/unistd/lib_getopt.c ## @@ -39,257 +39,565 @@ #include -#include -#include +#include +#include #include +#inc

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on a change in pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r527859737 ## File path: libs/libc/unistd/lib_getopt.c ## @@ -39,257 +39,565 @@ #include -#include -#include +#include +#include #include +#inc

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on a change in pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r527858513 ## File path: libs/libc/unistd/lib_getopt.c ## @@ -39,257 +39,565 @@ #include -#include -#include +#include +#include #include +#inc

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on a change in pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#discussion_r527857099 ## File path: libs/libc/unistd/lib_getopt.c ## @@ -39,257 +39,565 @@ #include -#include -#include +#include +#include #include +#inc

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731287234 Yes, TLS or task_group_s is better than getopt_r. So I drop the xxx_r from this patch. @patacongo please review whether the rest change is good. We can address t

[GitHub] [incubator-nuttx] patacongo edited a comment on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731261177 An issue with using TLS is that the variables would be duplicated for each thread. That would be required for true thread safety, but in reality only one insta

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731261177 An issue with using TLS is that the variables would be duplicated for each thread. That would be required for true thread safety, but in reality only one instance of

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
xiaoxiang781216 commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731252590 > My recommendation is that you do not go in this direction. It is not standard and totally inappropriate for used in a standards-based OS. > > My recommen

[GitHub] [incubator-nuttx] v01d commented on pull request #2335: Parallelize depend file generation

2020-11-20 Thread GitBox
v01d commented on pull request #2335: URL: https://github.com/apache/incubator-nuttx/pull/2335#issuecomment-731249783 I just applied the change to other archs and some missing directories. Does someone want to give this a try? --

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #490: Fix syslog formats

2020-11-20 Thread GitBox
xiaoxiang781216 merged pull request #490: URL: https://github.com/apache/incubator-nuttx-apps/pull/490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] 04/05: fsutils/mkfatfs/writefat.c: Appease nxstyle

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 807fab7836f6f0ea2d8d1b91ba87ef9850cf54c1 Author: YAMAMOTO Takashi AuthorDate: Fri Nov 20 19:53:58 2020

[incubator-nuttx-apps] 03/05: fsutils/mkfatfs/configfat.c: Fix syslog formats

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 2c0c033b43a7eb06ed8e7878ed6acfe326533741 Author: YAMAMOTO Takashi AuthorDate: Fri Nov 20 19:48:43 2020

[incubator-nuttx-apps] 01/05: fsutils/mkfatfs/mkfatfs.c: Fix syslog formats

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit 2319502ea35837f1062b0727e0e5b45ae2c30d6d Author: YAMAMOTO Takashi AuthorDate: Fri Nov 20 19:33:06 2020

[incubator-nuttx-apps] branch master updated (73fb7ba -> e4584b0)

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git. from 73fb7ba webclient: Distinguish request size and buffer size in body callback new 2319502 fsu

[incubator-nuttx-apps] 05/05: fsutils/mkfatfs/writefat.c: Fix syslog formats

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit e4584b00d6a3ad92559f87957077ce74cd83f989 Author: YAMAMOTO Takashi AuthorDate: Fri Nov 20 19:57:59 2020

[incubator-nuttx-apps] 02/05: fsutils/mkfatfs/configfat.c: Appease nxstyle

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git commit b92526ab2bb12ce035b47768c30f14c050c424a7 Author: YAMAMOTO Takashi AuthorDate: Fri Nov 20 19:41:39 2020

[GitHub] [incubator-nuttx-apps] kernelgurumeditation commented on issue #481: Elf loader sample app doesn't build

2020-11-20 Thread GitBox
kernelgurumeditation commented on issue #481: URL: https://github.com/apache/incubator-nuttx-apps/issues/481#issuecomment-731206100 @btashton, thanks for fixing it. PS: I fixed the USB HOST OTG port for this board, if you want the fix I can send it. --

[GitHub] [incubator-nuttx] patacongo commented on pull request #2326: libc: Enhance getopt function

2020-11-20 Thread GitBox
patacongo commented on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731201603 My recommendation is that you do not go in this direction. It is not standard and totally inappropriate for used in a standards-based OS. My recommendation is t

[GitHub] [incubator-nuttx] acassis commented on issue #844: Should the makefile warn if there isn't a valid APPDIR?

2020-11-20 Thread GitBox
acassis commented on issue #844: URL: https://github.com/apache/incubator-nuttx/issues/844#issuecomment-731173006 Hi @RockySong the issue appears related to issues on your file system, could you please confirm that this file has execution permission, like mine: ``` $ ls -l apps/tools/

[incubator-nuttx] branch master updated (93ff68e -> 8f9ca79)

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 93ff68e serial: Prevent RX stall new 23ddeaf mm/circbuf: support circular buffer managerment

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2315: Add common circular buffer management

2020-11-20 Thread GitBox
xiaoxiang781216 merged pull request #2315: URL: https://github.com/apache/incubator-nuttx/pull/2315 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] 01/02: mm/circbuf: support circular buffer managerment

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 23ddeaf3be530cd8faa7e7077fa9ea7caa83d708 Author: dongjiuzhu AuthorDate: Thu Nov 12 18:40:06 2020 +0800

[incubator-nuttx] 02/02: driver/sensor rc: use mm/circbuf manage intermediate buffer

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git commit 8f9ca79ffc7d031e273449b2fbff4a6dc56f3730 Author: dongjiuzhu AuthorDate: Thu Nov 12 18:40:37 2020 +0800

[GitHub] [incubator-nuttx] RockySong commented on issue #844: Should the makefile warn if there isn't a valid APPDIR?

2020-11-20 Thread GitBox
RockySong commented on issue #844: URL: https://github.com/apache/incubator-nuttx/issues/844#issuecomment-731156381 After I cloned https://github.com/apache/incubator-nuttx-apps and moved+renamed it to ../apps, I got other problems. rs@DESKTOP-UG5S1LM:~/nuttx/incubator-nuttx$ ./tools/con

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2352: arch/xtensa: Print the bakctrace on assertions.

2020-11-20 Thread GitBox
Ouss4 opened a new pull request #2352: URL: https://github.com/apache/incubator-nuttx/pull/2352 ## Summary This PR adds the ability to print a backtrace, to a configurable depth, on assertions. The backtrace is given as PC:SP pair, the PC values can be used with `addr2line` to get th

[GitHub] [incubator-nuttx] Donny9 commented on pull request #2216: support infrared remote control

2020-11-20 Thread GitBox
Donny9 commented on pull request #2216: URL: https://github.com/apache/incubator-nuttx/pull/2216#issuecomment-731151144 We can test remote control by irtest tool, https://github.com/apache/incubator-nuttx-apps/pull/491 This

[GitHub] [incubator-nuttx-apps] Donny9 opened a new pull request #491: Test rc by LIRC interface

2020-11-20 Thread GitBox
Donny9 opened a new pull request #491: URL: https://github.com/apache/incubator-nuttx-apps/pull/491 ## Summary Test remote control by this Interactive cmd shell tool. This tool supports simultaneous operation of multiple devices, the maximum number of devices depends on CONFIG_TESTING

[GitHub] [incubator-nuttx] cwespressif opened a new pull request #2351: xtensa/esp32: Fix issues of force-sleep

2020-11-20 Thread GitBox
cwespressif opened a new pull request #2351: URL: https://github.com/apache/incubator-nuttx/pull/2351 ## Summary Fix issues of force-sleep. ## Impact 1. improve the stability of "force-sleep" function. 2. fixed the issues of using "force-sleep" when enable "PSRAM".

[GitHub] [incubator-nuttx] acassis commented on pull request #2325: arch/arm/src/stm32/stm32_serial.c: for flowcontrol use common idiom f…

2020-11-20 Thread GitBox
acassis commented on pull request #2325: URL: https://github.com/apache/incubator-nuttx/pull/2325#issuecomment-731140386 Hi @juniskane there is a flow control test application at apps/examples/flowc I think it could be used to validate this patch. Did you use it or only tested communicatin

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2343: serial: Prevent RX stall

2020-11-20 Thread GitBox
xiaoxiang781216 merged pull request #2343: URL: https://github.com/apache/incubator-nuttx/pull/2343 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (96c29e7 -> 93ff68e)

2020-11-20 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 96c29e7 Update TODO regarding SMP add 93ff68e serial: Prevent RX stall No new revisions were adde

[GitHub] [incubator-nuttx] juniskane commented on a change in pull request #2345: drivers/mtd/mtd_progmem.c: fix progmem_log2 parameter type to match prototype

2020-11-20 Thread GitBox
juniskane commented on a change in pull request #2345: URL: https://github.com/apache/incubator-nuttx/pull/2345#discussion_r527653254 ## File path: drivers/mtd/mtd_progmem.c ## @@ -131,7 +131,7 @@ static struct progmem_dev_s g_progmem = * ***

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2343: serial: Prevent RX stall

2020-11-20 Thread GitBox
acassis commented on a change in pull request #2343: URL: https://github.com/apache/incubator-nuttx/pull/2343#discussion_r527651572 ## File path: drivers/serial/serial.c ## @@ -924,6 +924,20 @@ static ssize_t uart_read(FAR struct file *filep, FAR char *buffer, size_t buflen

  1   2   >