patacongo edited a comment on pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731319923
This code appears to have been stolen from other open source implementation. We cannot plaster an Apache 2.0 license on it and say that we own it! For example, there are weird definitions like: #define no_argument 0 #define required_argument 1 #define optional_argument 2 The above definitions were certainly NOT written for NuttX since they do not follow the coding standard. And these exact definitions are found in other GPL sources such as https://github.com/espressif/arduino-esp32/blob/master/tools/sdk/include/newlib/getopt.h /* include files needed by this include file */ #define no_argument 0 #define required_argument 1 #define optional_argument 2 I do not believe that this original original code. I believed it is stolen and is misrepresented by the putting an illegal Apache license on it. It must not be merged. I will mark it as a draft. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
