[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2326: libc: Enhance getopt function

[GitBox]

xiaoxiang781216 commented on pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326#issuecomment-731385404


   > This code appears to have been stolen from other open source 
implementation. We cannot plaster an Apache 2.0 license on it and say that we 
own it!
   > 
   > For example, there are weird definitions like:
   > 
   > #define no_argument 0
   > #define required_argument 1
   > #define optional_argument 2
   > 
   > The above definitions were certainly NOT written for NuttX since they do 
not follow the coding standard.
   
   The above names come from https://www.freebsd.org/cgi/man.cgi?getopt_long(3):
   
![image](https://user-images.githubusercontent.com/18066964/99845568-d0f63680-2baf-11eb-9cd2-0c9b0da3cbfe.png)
   they are not invented by Gregory Pietsch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org