[GitHub] [incubator-nuttx] liuguo09 commented on pull request #1125: build: exit normaly once catch 'make depend' failure case

liuguo09 commented on pull request #1125: URL: https://github.com/apache/incubator-nuttx/pull/1125#issuecomment-691857666 @v01d I remember there are cases that 'make -j4' still pass the full build even if there is mkdep fail issue. So add the exit into for loop to end it. As for using 'f

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1778: WIP board: Keyboard FeatherWing on nrf52-feather

btashton commented on a change in pull request #1778: URL: https://github.com/apache/incubator-nuttx/pull/1778#discussion_r487673440 ## File path: boards/arm/nrf52/nrf52-feather/src/nrf52_ili9341_lcd.c ## @@ -0,0 +1,410 @@ +/*

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1778: WIP board: Keyboard FeatherWing on nrf52-feather

btashton commented on a change in pull request #1778: URL: https://github.com/apache/incubator-nuttx/pull/1778#discussion_r487673440 ## File path: boards/arm/nrf52/nrf52-feather/src/nrf52_ili9341_lcd.c ## @@ -0,0 +1,410 @@ +/*

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1778: WIP board: Keyboard FeatherWing on nrf52-feather

btashton commented on a change in pull request #1778: URL: https://github.com/apache/incubator-nuttx/pull/1778#discussion_r487673440 ## File path: boards/arm/nrf52/nrf52-feather/src/nrf52_ili9341_lcd.c ## @@ -0,0 +1,410 @@ +/*

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1778: WIP board: Keyboard FeatherWing on nrf52-feather

btashton commented on a change in pull request #1778: URL: https://github.com/apache/incubator-nuttx/pull/1778#discussion_r487673440 ## File path: boards/arm/nrf52/nrf52-feather/src/nrf52_ili9341_lcd.c ## @@ -0,0 +1,410 @@ +/*

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1778: WIP board: Keyboard FeatherWing on nrf52-feather

btashton commented on a change in pull request #1778: URL: https://github.com/apache/incubator-nuttx/pull/1778#discussion_r487672068 ## File path: boards/arm/nrf52/nrf52-feather/Kconfig ## @@ -5,4 +5,54 @@ if ARCH_BOARD_NRF52_FEATHER -endif +menuconfig NRF52_FEATHER_KB_FEA

[GitHub] [incubator-nuttx] btashton opened a new pull request #1778: WIP board: Keyboard FeatherWing on nrf52-feather

btashton opened a new pull request #1778: URL: https://github.com/apache/incubator-nuttx/pull/1778 ## Summary This adds support for using the Solder Party FeatherWing to the NRF52 Feather Board https://www.solder.party/docs/keyboard-featherwing/ Supported Hardware Interfaces:

[incubator-nuttx] branch master updated: nrf52: SPI transfer failure and corruption

This is an automated email from the ASF dual-hosted git repository. raiden00 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 93eeecf nrf52: SPI transfer failure

[GitHub] [incubator-nuttx] raiden00pl merged pull request #1777: nrf52: SPI transfer failure and corruption

raiden00pl merged pull request #1777: URL: https://github.com/apache/incubator-nuttx/pull/1777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-nuttx] artemopolus closed issue #1659: SPI half duplex driver

artemopolus closed issue #1659: URL: https://github.com/apache/incubator-nuttx/issues/1659 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-nuttx] yamt merged pull request #1776: Remove extra application of EXTRAFLAGS and KDEFINE at the arch-level

yamt merged pull request #1776: URL: https://github.com/apache/incubator-nuttx/pull/1776 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [incubator-nuttx] yamt closed issue #1688: EXTRAFLAGS appears in AFLAGS three times

yamt closed issue #1688: URL: https://github.com/apache/incubator-nuttx/issues/1688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[incubator-nuttx] branch master updated: Remove extra application of EXTRAFLAGS and KDEFINE and the arch-level

This is an automated email from the ASF dual-hosted git repository. yamamoto pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new 3d11590 Remove extra application of

[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #1767: To better access host tty interface on sim platform

Donny9 commented on a change in pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#discussion_r487632144 ## File path: arch/sim/src/sim/up_uart.c ## @@ -0,0 +1,570 @@ +/ + * ar

[GitHub] [incubator-nuttx] Apache9 commented on issue #128: IP Clearance

Apache9 commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691788340 I think @xiaoxiang781216 has already found someone wish to help here? But anyway, we need at least a committer to review the work... --

[GitHub] [incubator-nuttx] patacongo commented on issue #128: IP Clearance

patacongo commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691787646 > Let's clear the license for the files we own first. I think it is OK > to have some files under compatibile licenses for a ASF project. You > just need to mention

[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #1767: To better access host tty interface on sim platform

Donny9 commented on a change in pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#discussion_r487628131 ## File path: arch/sim/src/sim/up_internal.h ## @@ -259,17 +259,22 @@ void up_timer_update(void); void rpmsg_serialinit(void); #endif -/* up_de

[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #1767: To better access host tty interface on sim platform

Donny9 commented on a change in pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#discussion_r487628056 ## File path: libs/libc/termios/lib_cfspeed.c ## @@ -0,0 +1,196 @@ +/ +

[GitHub] [incubator-nuttx] Donny9 commented on pull request #1767: To better access host tty interface on sim platform

Donny9 commented on pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#issuecomment-691784497 > @Donny9 please indicate if you have address all comments outlined by Xiang (resolve each conversation) so that we know you took care of each one. Okay. thanks!

[GitHub] [incubator-nuttx] Apache9 commented on issue #128: IP Clearance

Apache9 commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691783428 Let's clear the license for the files we own first. I think it is OK to have some files under compatibile licenses for a ASF project. You just need to mention them in the NOTIC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 closed pull request #95: Avoid calling ARCHIVE in multiple places (again)

xiaoxiang781216 closed pull request #95: URL: https://github.com/apache/incubator-nuttx-apps/pull/95 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #95: Avoid calling ARCHIVE in multiple places (again)

xiaoxiang781216 commented on pull request #95: URL: https://github.com/apache/incubator-nuttx-apps/pull/95#issuecomment-691778102 @yamt I will close this PR, let's focus on PR #380. This is an automated message from the Apac

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #378: interpreters: Initial wasm3 WebAssembly runtime support

xiaoxiang781216 merged pull request #378: URL: https://github.com/apache/incubator-nuttx-apps/pull/378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated: interpreters: Initial wasm3 WebAssembly runtime support

This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 52b28ed interpreters: Initial

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #382: Remove -x from cibuild.sh call in CI since this will abort the build on first error and we do not want that

xiaoxiang781216 commented on a change in pull request #382: URL: https://github.com/apache/incubator-nuttx-apps/pull/382#discussion_r487621138 ## File path: .github/workflows/build.yml ## @@ -180,7 +180,7 @@ jobs: with: run: | cd sources/testin

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds

xiaoxiang781216 commented on pull request #1765: URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691774163 @Ouss4 looks good, please go ahead. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-nuttx] v01d merged pull request #1770: nrf52: SPI cmddata function mapping wrong for SPI(0,2,3)

v01d merged pull request #1770: URL: https://github.com/apache/incubator-nuttx/pull/1770 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-nuttx] branch master updated (7d16090 -> 5f85024)

This is an automated email from the ASF dual-hosted git repository. protobits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 7d16090 Fix testbuild.sh to actually fail when using -x. Leave -x out for CI so that we detect all poss

[GitHub] [incubator-nuttx] liuguo09 commented on pull request #1771: Fix -x of testbuild.sh; Do not use -x on CI to have all build errors

liuguo09 commented on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691746971 @btashton @v01d Yes, it's intentional to cover all possible failures at first time to ease development, as @xiaoxiang781216 shows more info in comments.

[GitHub] [incubator-nuttx] justinmclean commented on issue #128: IP Clearance

justinmclean commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691737364 Hi, > @justinmclean https://github.com/justinmclean For many cases there are multiple contributo

[GitHub] [incubator-nuttx] v01d commented on issue #128: IP Clearance

v01d commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691737228 We can try to see what wording you used in general and use some regular expression to try to match the attribution. What I'm thinking is that in any case we will always need

[GitHub] [incubator-nuttx] btashton opened a new pull request #1777: nrf52: SPI transfer failure and corruption

btashton opened a new pull request #1777: URL: https://github.com/apache/incubator-nuttx/pull/1777 ## Summary The current EasyDMA implementation will fail if a transfer of over 255 bytes is requested with no warning. Also we do not set the RX and TX transfer lengths to 0 if the

[GitHub] [incubator-nuttx] patacongo commented on issue #128: IP Clearance

patacongo commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691735973 > We can only operate on the information we have. If authorship information was lost from CVS and SVN era (git author is Greg) and the header does not list anyone else than G

[GitHub] [incubator-nuttx] v01d commented on issue #128: IP Clearance

v01d commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691735273 We can only operate on the information we have. If authorship information was lost from CVS and SVN era (git author is Greg) and the header does not list anyone else than Greg, we

[GitHub] [incubator-nuttx] patacongo edited a comment on issue #128: IP Clearance

patacongo edited a comment on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691732515 > Take care with this. The copyright holder in source may or may not be the correct one. Similarly, the author in GIT may not be the author of the file. Often t

[GitHub] [incubator-nuttx] v01d commented on issue #1688: EXTRAFLAGS appears in AFLAGS three times

v01d commented on issue #1688: URL: https://github.com/apache/incubator-nuttx/issues/1688#issuecomment-691733377 @yamt I think I solved this in https://github.com/apache/incubator-nuttx/pull/1776 can you verify this removes your case of repeated flags in AFLAGS? The fix should apply to

[GitHub] [incubator-nuttx] v01d opened a new pull request #1776: Remove extra application of EXTRAFLAGS and KDEFINE and the arch-level

v01d opened a new pull request #1776: URL: https://github.com/apache/incubator-nuttx/pull/1776 ## Summary EXTRAFLAGS is already applied to *FLAGS in board's Make.defs (and it applies to whole build, not just arch-code). EXTRAFLAGS is passed around each make call to the complete

[GitHub] [incubator-nuttx] patacongo commented on issue #128: IP Clearance

patacongo commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691732515 > Take care with this. The copyright holder in source may or may not be the correct one. Similarly, the author in GIT may not be the author of the file. Often the cop

[GitHub] [incubator-nuttx-apps] Ouss4 commented on pull request #380: Fix: ensure archive files do not carry object files from prior builds

Ouss4 commented on pull request #380: URL: https://github.com/apache/incubator-nuttx-apps/pull/380#issuecomment-691731421 > LGTM, @Ouss4 please merge it if you are fine too. @xiaoxiang781216 did you had the chance to take a look at https://github.com/apache/incubator-nuttx/pull/1765

[GitHub] [incubator-nuttx] justinmclean commented on issue #128: IP Clearance

justinmclean commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691719524 Hi, > So @justinmclean is it safe we do the batch conversion if the source code meet all following critieria? > 1.The source cod

[GitHub] [incubator-nuttx] v01d commented on pull request #1765: Fix: ensure archive files do not carry object files from prior builds

v01d commented on pull request #1765: URL: https://github.com/apache/incubator-nuttx/pull/1765#issuecomment-691703378 I removed references to flock in documentation as `apps` no longer uses (as @xiaoxiang781216 suggested) Th

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1771: Fix -x of testbuild.sh; Do not use -x on CI to have all build errors

v01d commented on a change in pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#discussion_r487556736 ## File path: .github/workflows/build.yml ## @@ -161,7 +161,7 @@ jobs: export CCACHE_DIR=`pwd`/ccache mkdir $CCACHE_DIR

[GitHub] [incubator-nuttx-apps] btashton merged pull request #382: Remove -x from cibuild.sh call in CI since this will abort the build on first error and we do not want that

btashton merged pull request #382: URL: https://github.com/apache/incubator-nuttx-apps/pull/382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [incubator-nuttx-apps] btashton commented on pull request #382: Remove -x from cibuild.sh call in CI since this will abort the build on first error and we do not want that

btashton commented on pull request #382: URL: https://github.com/apache/incubator-nuttx-apps/pull/382#issuecomment-691699976 One more for testing? This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-nuttx] btashton merged pull request #1771: Fix -x of testbuild.sh; Do not use -x on CI to have all build errors

btashton merged pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[incubator-nuttx-apps] branch master updated: Remove -x from cibuild.sh call in CI since this will abort the build on first error and we do not want that.

This is an automated email from the ASF dual-hosted git repository. btashton pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 282e565 Remove -x from cibuild.

[incubator-nuttx] branch master updated (1ab6833 -> 7d16090)

This is an automated email from the ASF dual-hosted git repository. btashton pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 1ab6833 tiva: tiva_eeprom.c: Fix nxstyle warnings add 7d16090 Fix testbuild.sh to actually fail whe

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1771: Fix -x of testbuild.sh; Do not use -x on CI to have all build errors

btashton commented on a change in pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#discussion_r487555201 ## File path: .github/workflows/build.yml ## @@ -161,7 +161,7 @@ jobs: export CCACHE_DIR=`pwd`/ccache mkdir $CCACHE_DIR

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #1771: Fix -x of testbuild.sh; Do not use -x on CI to have all build errors

btashton commented on a change in pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#discussion_r487555201 ## File path: .github/workflows/build.yml ## @@ -161,7 +161,7 @@ jobs: export CCACHE_DIR=`pwd`/ccache mkdir $CCACHE_DIR

[GitHub] [incubator-nuttx-apps] v01d opened a new pull request #382: Remove -x from cibuild.sh call in CI since this will abort the build on first error and we do not want that

v01d opened a new pull request #382: URL: https://github.com/apache/incubator-nuttx-apps/pull/382 ## Summary Follow up change to https://github.com/apache/incubator-nuttx/pull/1771 ## Impact CI ## Testing CI ---

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #1771: Fix -x of testbuild.sh; Do not use -x on CI to have all build errors

v01d commented on a change in pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#discussion_r487552317 ## File path: .github/workflows/build.yml ## @@ -161,7 +161,7 @@ jobs: export CCACHE_DIR=`pwd`/ccache mkdir $CCACHE_DIR

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #380: Fix: ensure archive files do not carry object files from prior builds

v01d commented on pull request #380: URL: https://github.com/apache/incubator-nuttx-apps/pull/380#issuecomment-691696329 > Sorry, just remeber that we can remove .built and .lock from .gitignore? @v01d Done This is a

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1771: Fix -x of testbuild.sh; Do not use -x on CI to have all build errors

xiaoxiang781216 commented on a change in pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#discussion_r487552052 ## File path: .github/workflows/build.yml ## @@ -161,7 +161,7 @@ jobs: export CCACHE_DIR=`pwd`/ccache mkdir $CCA

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1771: Fix -x of testbuild.sh; Do not use -x on CI to have all build errors

xiaoxiang781216 commented on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691696202 LGTM, @btashton please merge it if you don't have the furture concern. This is an automated mess

[GitHub] [incubator-nuttx-apps] v01d commented on a change in pull request #380: Fix: ensure archive files do not carry object files from prior builds

v01d commented on a change in pull request #380: URL: https://github.com/apache/incubator-nuttx-apps/pull/380#discussion_r487551931 ## File path: Make.defs ## @@ -108,10 +108,6 @@ define REGISTER $(Q) touch "$(BUILTIN_REGISTRY)$(DELIM).updated" endef -define ARLOCK

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #380: Fix: ensure archive files do not carry object files from prior builds

xiaoxiang781216 commented on pull request #380: URL: https://github.com/apache/incubator-nuttx-apps/pull/380#issuecomment-691695941 Sorry, just remeber that we can remove .built and .lock from .gitignore? @v01d This is an

[GitHub] [incubator-nuttx] v01d commented on pull request #1771: Fix -x of testbuild.sh; Do not use -x on CI to have all build errors

v01d commented on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691695640 Ok, I removed the -x and updated the PR description/commit msg. This is an automated message from the Apach

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #380: Fix: ensure archive files do not carry object files from prior builds

xiaoxiang781216 commented on pull request #380: URL: https://github.com/apache/incubator-nuttx-apps/pull/380#issuecomment-691695735 LGTM, @Ouss4 please merge it if you are fine too. This is an automated message from the Apac

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #380: Fix: ensure archive files do not carry object files from prior builds

xiaoxiang781216 commented on a change in pull request #380: URL: https://github.com/apache/incubator-nuttx-apps/pull/380#discussion_r487549775 ## File path: Make.defs ## @@ -108,10 +108,6 @@ define REGISTER $(Q) touch "$(BUILTIN_REGISTRY)$(DELIM).updated" endef -def

[GitHub] [incubator-nuttx] btashton commented on pull request #1771: Make CI fail on first error and not have to finish the job to fail

btashton commented on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691695015 Sounds good to me. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1763: documentation: quickstart, add tabs sphinx extension and other improvements

adamfeuer commented on pull request #1763: URL: https://github.com/apache/incubator-nuttx/pull/1763#issuecomment-691694782 👍 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-nuttx] btashton commented on pull request #1763: documentation: quickstart, add tabs sphinx extension and other improvements

btashton commented on pull request #1763: URL: https://github.com/apache/incubator-nuttx/pull/1763#issuecomment-691694618 The macOS runners do not seem to have Gatekeeper enabled they are on Catalina so I don't think there is anything to change there. -

[GitHub] [incubator-nuttx] v01d commented on pull request #1771: Make CI fail on first error and not have to finish the job to fail

v01d commented on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691694473 > > I understand the usefulness of having this continue to run, I'm not opposed. > > However, do note that what I'm actually fixing here is the behavior of `-x` paramete

[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1763: documentation: quickstart, add tabs sphinx extension and other improvements

adamfeuer commented on pull request #1763: URL: https://github.com/apache/incubator-nuttx/pull/1763#issuecomment-691694272 @btashton BTW should we add the `xattr` line to the build script, in case the build box changes? Or is it already in another script? -

[GitHub] [incubator-nuttx-apps] v01d commented on a change in pull request #380: Fix: ensure archive files do not carry object files from prior builds

v01d commented on a change in pull request #380: URL: https://github.com/apache/incubator-nuttx-apps/pull/380#discussion_r487549853 ## File path: Application.mk ## @@ -131,13 +131,12 @@ $(CXXOBJS): %$(SUFFIX)$(OBJEXT): %$(CXXEXT) $(if $(and $(CONFIG_BUILD_LOADABLE),$(C

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #380: Fix: ensure archive files do not carry object files from prior builds

xiaoxiang781216 commented on a change in pull request #380: URL: https://github.com/apache/incubator-nuttx-apps/pull/380#discussion_r487549682 ## File path: Application.mk ## @@ -131,13 +131,12 @@ $(CXXOBJS): %$(SUFFIX)$(OBJEXT): %$(CXXEXT) $(if $(and $(CONFIG_BUILD_LO

[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1763: documentation: quickstart, add tabs sphinx extension and other improvements

adamfeuer commented on pull request #1763: URL: https://github.com/apache/incubator-nuttx/pull/1763#issuecomment-691691811 @btashton That Zephyr recommendation is a cool piece of documentation. I'll include something like that in the macOS instructions. Re: testing, you're welcome. I

[GitHub] [incubator-nuttx] v01d merged pull request #1774: tiva: tiva_eeprom.c: Fix nxstyle warnings

v01d merged pull request #1774: URL: https://github.com/apache/incubator-nuttx/pull/1774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[incubator-nuttx] branch master updated (749eac9 -> 1ab6833)

This is an automated email from the ASF dual-hosted git repository. protobits pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 749eac9 boards/nrf52840-dk: normalize adc and pwm configs add 1ab6833 tiva: tiva_eeprom.c: Fix nxs

[GitHub] [incubator-nuttx] btashton commented on pull request #1763: documentation: quickstart, add tabs sphinx extension and other improvements

btashton commented on pull request #1763: URL: https://github.com/apache/incubator-nuttx/pull/1763#issuecomment-691690767 @adamfeuer ah yeah I think I set the extended attributes with xattr which looks like what Zephyr also recommends. So if you keep all your non homebrew files in one pla

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1589: net/tcp: fix tcp socket close timeout if loss wireless connection

xiaoxiang781216 edited a comment on pull request #1589: URL: https://github.com/apache/incubator-nuttx/pull/1589#issuecomment-691688394 > I would think that a change like this would re-use the same logic as when the PHY detects a loss of the network in a wired connection as in drivers/net/

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new issue #1775: the net monitor shouldn't tightly couple with the ethernet hardware

xiaoxiang781216 opened a new issue #1775: URL: https://github.com/apache/incubator-nuttx/issues/1775 netinit_monitor(https://github.com/apache/incubator-nuttx-apps/blob/master/netutils/netinit/netinit.c#L571) interact with the kernel through the follow IOCTL: ``` /* MDIO/MCD ***

[GitHub] [incubator-nuttx] adamfeuer commented on pull request #1763: documentation: quickstart, add tabs sphinx extension and other improvements

adamfeuer commented on pull request #1763: URL: https://github.com/apache/incubator-nuttx/pull/1763#issuecomment-691689915 @btashton On macOS 10.15 Catalina, at least my system (and it seems many others have this problem too) the macOS Gatekeeper program will not let unsigned binaries run

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1589: net/tcp: fix tcp socket close timeout if loss wireless connection

xiaoxiang781216 edited a comment on pull request #1589: URL: https://github.com/apache/incubator-nuttx/pull/1589#issuecomment-691688394 > I would think that a change like this would re-use the same logic as when the PHY detects a loss of the network in a wired connection as in drivers/net/

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1589: net/tcp: fix tcp socket close timeout if loss wireless connection

xiaoxiang781216 commented on pull request #1589: URL: https://github.com/apache/incubator-nuttx/pull/1589#issuecomment-691688394 > I would think that a change like this would re-use the same logic as when the PHY detects a loss of the network in a wired connection as in drivers/net/phy_not

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #95: Avoid calling ARCHIVE in multiple places (again)

v01d commented on pull request #95: URL: https://github.com/apache/incubator-nuttx-apps/pull/95#issuecomment-691685031 @yamt I believe I actually addressed this in a separate PR #380 If you think it does, we can close this. -

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #378: interpreters: Initial wasm3 WebAssembly runtime support

v01d commented on pull request #378: URL: https://github.com/apache/incubator-nuttx-apps/pull/378#issuecomment-691684489 My suggestion was to simply have a "notice" not necessarily a user choice. I understand we don't actually need a per-license choice (that would really be annoying since

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1771: Make CI fail on first error and not have to finish the job to fail

xiaoxiang781216 commented on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691683967 > I understand the usefulness of having this continue to run, I'm not opposed. > However, do note that what I'm actually fixing here is the behavior of `-x` p

[GitHub] [incubator-nuttx] v01d commented on pull request #1767: To better access host tty interface on sim platform

v01d commented on pull request #1767: URL: https://github.com/apache/incubator-nuttx/pull/1767#issuecomment-691683689 @Donny9 please indicate if you have address all comments outlined by Xiang (resolve each conversation) so that we know you took care of each one. -

[GitHub] [incubator-nuttx] v01d commented on pull request #380: arm: Fix "make export" for KERNEL build

v01d commented on pull request #380: URL: https://github.com/apache/incubator-nuttx/pull/380#issuecomment-691682813 @yamt could you fill the PR description. We can leave this open to indicate the solution needs testing. This

[GitHub] [incubator-nuttx] v01d commented on pull request #1503: Change shes related headers

v01d commented on pull request #1503: URL: https://github.com/apache/incubator-nuttx/pull/1503#issuecomment-691682525 @masayuki2009 any updates on this? This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #1774: tiva: tiva_eeprom.c: Fix nxstyle warnings

hartmannathan opened a new pull request #1774: URL: https://github.com/apache/incubator-nuttx/pull/1774 ## Summary arch/arm/src/tiva/common/tiva_eeprom.c: * Fix nxstyle warnings. No functional changes. ## Impact Removes nxstyle errors when this file receives m

[GitHub] [incubator-nuttx] v01d commented on pull request #1589: net/tcp: fix tcp socket close timeout if loss wireless connection

v01d commented on pull request #1589: URL: https://github.com/apache/incubator-nuttx/pull/1589#issuecomment-691682171 @patacongo please advise if you feel this is a valid change or not. If you're not sure we can request for someone else's review. I can't comment since I don't know about th

[GitHub] [incubator-nuttx] v01d commented on pull request #1758: mm/mm_heap/mm_initialize.c: add sem lock to mm_addregion()

v01d commented on pull request #1758: URL: https://github.com/apache/incubator-nuttx/pull/1758#issuecomment-691681828 @GUIDINGLI please fill the PR description fields, it is important to understand what is the problem you're trying to fix and evaluate the fix itself. -

[GitHub] [incubator-nuttx] v01d commented on pull request #1771: Make CI fail on first error and not have to finish the job to fail

v01d commented on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691681045 I understand the usefulness of having this continue to run, I'm not opposed. However, do note that what I'm actually fixing here is the behavior of `-x` parameter, which

[GitHub] [incubator-nuttx] acassis commented on pull request #1773: NRF52: add ADC and PWM support

acassis commented on pull request #1773: URL: https://github.com/apache/incubator-nuttx/pull/1773#issuecomment-691674780 LGTM, thank you! This is an automated message from the Apache Git Service. To respond to the message, pl

[incubator-nuttx] branch master updated (5106c3f -> 749eac9)

This is an automated email from the ASF dual-hosted git repository. acassis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 5106c3f documentation: make the "make clean" suggestion a warning add 493b0bf drivers/timers/pwm.c:

[GitHub] [incubator-nuttx] acassis merged pull request #1773: NRF52: add ADC and PWM support

acassis merged pull request #1773: URL: https://github.com/apache/incubator-nuttx/pull/1773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #128: IP Clearance

xiaoxiang781216 edited a comment on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691672883 > Hi > What confuses me though is that we're worrying about git authors whereas I believe that if someone contributes a file without listing themselves as the

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #128: IP Clearance

xiaoxiang781216 edited a comment on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691672883 > Hi > What confuses me though is that we're worrying about git authors whereas I believe that if someone contributes a file without listing themselves as the

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #128: IP Clearance

xiaoxiang781216 edited a comment on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691672883 > Hi > What confuses me though is that we're worrying about git authors whereas I believe that if someone contributes a file without listing themselves as the

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #128: IP Clearance

xiaoxiang781216 commented on issue #128: URL: https://github.com/apache/incubator-nuttx/issues/128#issuecomment-691672883 > Hi > What confuses me though is that we're worrying about git authors whereas I believe that if someone contributes a file without listing themselves as the author

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1771: Make CI fail on first error and not have to finish the job to fail

xiaoxiang781216 edited a comment on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691669115 Sometime, the change may introduce the break in the multiple locations. If we terminate the build when the first error hit, we have to fix the error and t

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1771: Make CI fail on first error and not have to finish the job to fail

xiaoxiang781216 edited a comment on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691669115 Sometime, the change may introduce the break in the multiple locations. If we terminate the build when the first error hit, we have to fix the error and t

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #1771: Make CI fail on first error and not have to finish the job to fail

xiaoxiang781216 edited a comment on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691669115 Sometime, the change may introduce the break in the multiple locations. If we terminate the build when the first error hit, we have to fix the error and t

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #1771: Make CI fail on first error and not have to finish the job to fail

xiaoxiang781216 commented on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691669115 Sometime, the change may introduce the break in the multiple locations. If we terminate the build when the first error hit, we have to fix the error one by one w

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #1754: esp32-core: Add support for the external SPIFLASH

Ouss4 commented on a change in pull request #1754: URL: https://github.com/apache/incubator-nuttx/pull/1754#discussion_r487522557 ## File path: arch/xtensa/src/esp32/esp32_spiflash.c ## @@ -131,7 +155,7 @@ static struct esp32_spiflash_s s_esp32_spiflash1 = .bwrite

[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #1773: NRF52: add ADC and PWM support

raiden00pl commented on a change in pull request #1773: URL: https://github.com/apache/incubator-nuttx/pull/1773#discussion_r487517583 ## File path: arch/arm/src/nrf52/nrf52_pwm.c ## @@ -0,0 +1,719 @@ +/***

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #1771: Make CI fail on first error and not have to finish the job to fail

acassis edited a comment on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691658268 I think it could behave this way: 1) if it is a coding style error or a warning that was promoted to error, then the building system should carry on. 2) if it is

[GitHub] [incubator-nuttx] acassis commented on pull request #1771: Make CI fail on first error and not have to finish the job to fail

acassis commented on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691658268 I think it could behave this way: 1) if it is a coding style error or a warning was promoted to error, then the building system should carry on. 2) if it is a real compi

  1   2   >