xiaoxiang781216 edited a comment on pull request #1589:
URL: https://github.com/apache/incubator-nuttx/pull/1589#issuecomment-691688394


   > I would think that a change like this would re-use the same logic as when 
the PHY detects a loss of the network in a wired connection as in 
drivers/net/phy_notify.c.
   
   @patacongo let's the already opened socket could close timely when the wire 
or wireless network lose the conntection(what's this patch do), which doesn't 
conflict or block to notify the userspace the connection status change through 
PHY notificaiton. Actually, the fix is required because the kernel space 
network stack should work without depending on an optional userspace component. 
Do you think so?
   
   On the other hand, the current PHY notification and recovering design isn't 
general enough because it tightly couple with Ethernet MII/GMII definition and 
make it's hard to work with the wireless case. 
https://github.com/apache/incubator-nuttx/issues/1775 is opened to track this 
issue, @patacongo please give your comment there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to