v01d commented on pull request #1771: URL: https://github.com/apache/incubator-nuttx/pull/1771#issuecomment-691694473
> > I understand the usefulness of having this continue to run, I'm not opposed. > > However, do note that what I'm actually fixing here is the behavior of `-x` parameter, which is actually used on CI. Maybe the -x is to have the script abort on other errors, but with `-x` I would expect any build failure to abort the script. In other words, maybe the path is merge this PR and then remove `-x` from the workflow. > > Yes, it will be good that we remove -x from the workflow together with this path. @btashton sounds also OK to you? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
