[GitHub] [inlong] fuweng11 commented on a diff in pull request #8109: [INLONG-8108][Manager] WorkflowApprover API Permissions Optimization

2023-05-29 Thread via GitHub
fuweng11 commented on code in PR #8109: URL: https://github.com/apache/inlong/pull/8109#discussion_r1208988031 ## inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/WorkflowApproverController.java: ## @@ -54,19 +56,22 @@ public class WorkflowApprov

[GitHub] [inlong] hnrainll commented on a diff in pull request #8109: [INLONG-8108][Manager] WorkflowApprover API Permissions Optimization

2023-05-29 Thread via GitHub
hnrainll commented on code in PR #8109: URL: https://github.com/apache/inlong/pull/8109#discussion_r1208990812 ## inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/WorkflowApproverController.java: ## @@ -54,19 +56,22 @@ public class WorkflowApprov

[GitHub] [inlong] thexiay commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
thexiay commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1209008166 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -51,49 +53,81

[GitHub] [inlong] gunli opened a new pull request, #8111: [INLONG-4961][DataProxy] add dataproxy-sdk-golang

2023-05-29 Thread via GitHub
gunli opened a new pull request, #8111: URL: https://github.com/apache/inlong/pull/8111 ### [INLONG-4961][DataProxy] add dataproxy-sdk-golang - Fixes #4961 ### Motivation Add a golang version SDK of InLong Data Proxy ### Modifications - Add a discoverer to

[GitHub] [inlong] healchow commented on a diff in pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

2023-05-29 Thread via GitHub
healchow commented on code in PR #8105: URL: https://github.com/apache/inlong/pull/8105#discussion_r1209032332 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/util/SchemaChangeUtils.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (AS

[GitHub] [inlong] healchow commented on a diff in pull request #8107: [INLONG-8106][DataProxy] Optimize ConfigManager implementation ( part one )

2023-05-29 Thread via GitHub
healchow commented on code in PR #8107: URL: https://github.com/apache/inlong/pull/8107#discussion_r1209033544 ## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/channel/FailoverChannelSelector.java: ## @@ -145,11 +143,9 @@ public void configure(Conte

[GitHub] [inlong] healchow commented on a diff in pull request #8107: [INLONG-8106][DataProxy] Optimize ConfigManager implementation ( part one )

2023-05-29 Thread via GitHub
healchow commented on code in PR #8107: URL: https://github.com/apache/inlong/pull/8107#discussion_r1209037292 ## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/holder/BlackListConfigHolder.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apa

[GitHub] [inlong] gosonzhang commented on a diff in pull request #8107: [INLONG-8106][DataProxy] Optimize ConfigManager implementation ( part one )

2023-05-29 Thread via GitHub
gosonzhang commented on code in PR #8107: URL: https://github.com/apache/inlong/pull/8107#discussion_r1209040833 ## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/holder/BlackListConfigHolder.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the A

[GitHub] [inlong] github-actions[bot] commented on issue #8112: [Feature][Data Proxy]Golang SDK documents

2023-05-29 Thread via GitHub
github-actions[bot] commented on issue #8112: URL: https://github.com/apache/inlong/issues/8112#issuecomment-1566736591 Hello @gunli, thank you for opening your first issue in InLong 🧡 We will respond as soon as possible ⏳ If this is a bug report, please provide screenshots or error logs

[GitHub] [inlong] gunli commented on issue #8112: [Feature][Data Proxy]Golang SDK documents

2023-05-29 Thread via GitHub
gunli commented on issue #8112: URL: https://github.com/apache/inlong/issues/8112#issuecomment-1566744704 Should to create issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [inlong] lordcheng10 commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
lordcheng10 commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1209051456 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -51,49 +5

[GitHub] [inlong] gunli commented on issue #8112: [Feature][Data Proxy]Golang SDK documents

2023-05-29 Thread via GitHub
gunli commented on issue #8112: URL: https://github.com/apache/inlong/issues/8112#issuecomment-1566745768 This issue should be create at [inlong-website](https://github.com/gunli/inlong-website) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [inlong-website] gunli opened a new issue, #764: [Feature][DataProxy]Add Golang SDK documents

2023-05-29 Thread via GitHub
gunli opened a new issue, #764: URL: https://github.com/apache/inlong-website/issues/764 ### Description Add documents for DataProxy Golang SDK ### Use case Add documents for DataProxy Golang SDK to guide users how to use the SDK to produce messages to InLong DataProxy.

[inlong] branch master updated: [INLONG-8106][DataProxy] Optimize ConfigManager implementation ( part one ) (#8107)

2023-05-29 Thread gosonzhang
This is an automated email from the ASF dual-hosted git repository. gosonzhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git The following commit(s) were added to refs/heads/master by this push: new 6e8d77a48 [INLONG-8106][DataProxy] Optimize

[GitHub] [inlong] EMsnap commented on a diff in pull request #8096: [INLONG-8092][Sort] Support all database and multiple tables transmission for Hive

2023-05-29 Thread via GitHub
EMsnap commented on code in PR #8096: URL: https://github.com/apache/inlong/pull/8096#discussion_r1209078921 ## inlong-sort/sort-flink/base/src/main/java/org/apache/inlong/sort/base/sink/PartitionPolicy.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [inlong] dockerzhang commented on pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
dockerzhang commented on PR #8095: URL: https://github.com/apache/inlong/pull/8095#issuecomment-1566773880 @hejiay if all comments are confirmed, please click `resolve`, and I found there are some conflicts, please fix them, thanks. -- This is an automated message from the Apache Git Serv

[GitHub] [inlong] EMsnap commented on a diff in pull request #8096: [INLONG-8092][Sort] Support all database and multiple tables transmission for Hive

2023-05-29 Thread via GitHub
EMsnap commented on code in PR #8096: URL: https://github.com/apache/inlong/pull/8096#discussion_r1209085490 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/hive/src/main/java/org/apache/inlong/sort/hive/HiveTableSink.java: ## @@ -172,23 +199,50 @@ private DataStreamS

[GitHub] [inlong] hejiay commented on a diff in pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
hejiay commented on code in PR #8095: URL: https://github.com/apache/inlong/pull/8095#discussion_r1209087824 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -51,49 +53,81

[GitHub] [inlong] EMsnap commented on a diff in pull request #8096: [INLONG-8092][Sort] Support all database and multiple tables transmission for Hive

2023-05-29 Thread via GitHub
EMsnap commented on code in PR #8096: URL: https://github.com/apache/inlong/pull/8096#discussion_r1209088899 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/hive/src/main/java/org/apache/inlong/sort/hive/HiveOutputFormatFactory.java: ## @@ -0,0 +1,85 @@ +/* + * Licens

[GitHub] [inlong] chestnut-c opened a new pull request, #8115: [INLONG-8114][Manager] Fix the NEP that may appear when building Properties.

2023-05-29 Thread via GitHub
chestnut-c opened a new pull request, #8115: URL: https://github.com/apache/inlong/pull/8115 - Fixes #8114 ### Motivation Fix the NEP that may appear when building Properties , Filter empty values ​​to prevent NEP, because empty values ​​are meaningless to pass downstream. --

[GitHub] [inlong] EMsnap commented on a diff in pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

2023-05-29 Thread via GitHub
EMsnap commented on code in PR #8105: URL: https://github.com/apache/inlong/pull/8105#discussion_r1209100513 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/enums/SchemaChangeType.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [inlong] gong opened a new pull request, #8117: [INLONG-8116][Sort] Support table api config setting

2023-05-29 Thread via GitHub
gong opened a new pull request, #8117: URL: https://github.com/apache/inlong/pull/8117 ### Prepare a Pull Request - [INLONG-8116][Sort] Support table api config setting - Fixes #8116 ### Motivation Support table api config setting ref to https://nightlies.apac

[GitHub] [inlong] gong commented on a diff in pull request #8115: [INLONG-8114][Manager] Fix the NEP that may appear when building Properties.

2023-05-29 Thread via GitHub
gong commented on code in PR #8115: URL: https://github.com/apache/inlong/pull/8115#discussion_r1209111662 ## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/LoadNodeUtils.java: ## @@ -17,6 +17,7 @@ package org.apache.inlong.manager.pojo.sor

[GitHub] [inlong] gong commented on a diff in pull request #8115: [INLONG-8114][Manager] Fix the NEP that may appear when building Properties.

2023-05-29 Thread via GitHub
gong commented on code in PR #8115: URL: https://github.com/apache/inlong/pull/8115#discussion_r1209111662 ## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/LoadNodeUtils.java: ## @@ -17,6 +17,7 @@ package org.apache.inlong.manager.pojo.sor

[GitHub] [inlong] hejiay closed pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
hejiay closed pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg URL: https://github.com/apache/inlong/pull/8095 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8115: [INLONG-8114][Manager] Fix the NEP that may appear when building Properties.

2023-05-29 Thread via GitHub
fuweng11 commented on code in PR #8115: URL: https://github.com/apache/inlong/pull/8115#discussion_r1209117077 ## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/LoadNodeUtils.java: ## @@ -117,6 +118,7 @@ public static LoadNode createLoadNode(S

[GitHub] [inlong] chestnut-c commented on a diff in pull request #8115: [INLONG-8114][Manager] Fix the NEP that may appear when building Properties.

2023-05-29 Thread via GitHub
chestnut-c commented on code in PR #8115: URL: https://github.com/apache/inlong/pull/8115#discussion_r1209118467 ## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/LoadNodeUtils.java: ## @@ -17,6 +17,7 @@ package org.apache.inlong.manager.po

[GitHub] [inlong] chestnut-c commented on a diff in pull request #8115: [INLONG-8114][Manager] Fix the NEP that may appear when building Properties.

2023-05-29 Thread via GitHub
chestnut-c commented on code in PR #8115: URL: https://github.com/apache/inlong/pull/8115#discussion_r1209120934 ## inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/sort/util/ExtractNodeUtils.java: ## @@ -563,6 +564,7 @@ private static List parseFieldInf

[GitHub] [inlong] vernedeng opened a new pull request, #8119: [INLONG-8118][Manager] Support tenant user permission control #8118

2023-05-29 Thread via GitHub
vernedeng opened a new pull request, #8119: URL: https://github.com/apache/inlong/pull/8119 ### Prepare a Pull Request *(Change the title refer to the following example)* - Fixes #8118 - Parent #7914 ### Motivation Support tenant user permission control ##

[GitHub] [inlong] gong commented on a diff in pull request #8102: [INLONG-8101][Sort] Support multi-version packaging of sort-connectors

2023-05-29 Thread via GitHub
gong commented on code in PR #8102: URL: https://github.com/apache/inlong/pull/8102#discussion_r1209135921 ## inlong-sort/sort-flink/pom.xml: ## @@ -30,6 +30,13 @@ pom Apache InLong - Sort Flink + +cdc-base +base +sort-flink-v1.13 +

[GitHub] [inlong] hejiay opened a new pull request, #8120: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
hejiay opened a new pull request, #8120: URL: https://github.com/apache/inlong/pull/8120 I accidentally deleted the original PR https://github.com/apache/inlong/pull/8095 by mistake, so I resubmitted it.For details, see this PR https://github.com/apache/inlong/pull/8095 -- Th

[GitHub] [inlong] hejiay commented on pull request #8120: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
hejiay commented on PR #8120: URL: https://github.com/apache/inlong/pull/8120#issuecomment-1566883701 @dockerzhang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [inlong] hejiay commented on pull request #8095: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
hejiay commented on PR #8095: URL: https://github.com/apache/inlong/pull/8095#issuecomment-1566892860 I accidentally deleted the original PR by mistake, so I resubmitted it. The new PR https://github.com/apache/inlong/pull/8120 -- This is an automated message from the Apache Git Service.

[GitHub] [inlong] vernedeng commented on a diff in pull request #8100: [INLONG-8098][Manager] Support Inlong user permission control

2023-05-29 Thread via GitHub
vernedeng commented on code in PR #8100: URL: https://github.com/apache/inlong/pull/8100#discussion_r1209205206 ## inlong-manager/manager-web/sql/changes-1.8.0.sql: ## @@ -44,4 +44,42 @@ CREATE TABLE IF NOT EXISTS `inlong_tenant` DEFAULT CHARSET = utf8 COMMENT ='Inlong tenant

[GitHub] [inlong] yunqingmoswu commented on a diff in pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

2023-05-29 Thread via GitHub
yunqingmoswu commented on code in PR #8105: URL: https://github.com/apache/inlong/pull/8105#discussion_r1209205400 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/util/SchemaChangeUtils.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [inlong] yunqingmoswu closed pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

2023-05-29 Thread via GitHub
yunqingmoswu closed pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink URL: https://github.com/apache/inlong/pull/8105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [inlong] dockerzhang merged pull request #8115: [INLONG-8114][Manager] Fix the NEP that may appear when building Properties.

2023-05-29 Thread via GitHub
dockerzhang merged PR #8115: URL: https://github.com/apache/inlong/pull/8115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.

[inlong] branch master updated: [INLONG-8114][Manager] Fix the NEP that may appear when building Properties. (#8115)

2023-05-29 Thread dockerzhang
This is an automated email from the ASF dual-hosted git repository. dockerzhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git The following commit(s) were added to refs/heads/master by this push: new 049eaf36b [INLONG-8114][Manager] Fix the NE

[GitHub] [inlong] EMsnap commented on a diff in pull request #8102: [INLONG-8101][Sort] Support multi-version packaging of sort-connectors

2023-05-29 Thread via GitHub
EMsnap commented on code in PR #8102: URL: https://github.com/apache/inlong/pull/8102#discussion_r1209231337 ## inlong-sort/sort-flink/pom.xml: ## @@ -30,6 +30,13 @@ pom Apache InLong - Sort Flink + +cdc-base +base +sort-flink-v1.13 +

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8109: [INLONG-8108][Manager] WorkflowApprover API Permissions Optimization

2023-05-29 Thread via GitHub
fuweng11 commented on code in PR #8109: URL: https://github.com/apache/inlong/pull/8109#discussion_r1209349797 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/WorkflowApproverServiceImpl.java: ## @@ -89,11 +92,18 @@ public Integer save

[GitHub] [inlong] hnrainll commented on a diff in pull request #8109: [INLONG-8108][Manager] WorkflowApprover API Permissions Optimization

2023-05-29 Thread via GitHub
hnrainll commented on code in PR #8109: URL: https://github.com/apache/inlong/pull/8109#discussion_r1209379107 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/core/impl/WorkflowApproverServiceImpl.java: ## @@ -89,11 +92,18 @@ public Integer save

[GitHub] [inlong] github-actions[bot] commented on issue #7737: [Feature][Tool] Auto-add the JDBC jar to the Manager-web module with inlong-dev-toolkit.sh

2023-05-29 Thread via GitHub
github-actions[bot] commented on issue #7737: URL: https://github.com/apache/inlong/issues/7737#issuecomment-1567664051 This issue is stale because it has been open for 60 days with no activity. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [inlong] dockerzhang commented on a diff in pull request #8111: [INLONG-4961][DataProxy] add dataproxy-sdk-golang

2023-05-29 Thread via GitHub
dockerzhang commented on code in PR #8111: URL: https://github.com/apache/inlong/pull/8111#discussion_r1209640138 ## inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/README.md: ## @@ -0,0 +1,197 @@ +# dataproxy-sdk-golang Review Comment: This line is needless.

[GitHub] [inlong] dockerzhang commented on a diff in pull request #8111: [INLONG-4961][DataProxy] add dataproxy-sdk-golang

2023-05-29 Thread via GitHub
dockerzhang commented on code in PR #8111: URL: https://github.com/apache/inlong/pull/8111#discussion_r1209641026 ## inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/README.md: ## @@ -0,0 +1,197 @@ +# dataproxy-sdk-golang + +## Overview + +dataproxy-sdk-golang is the golang v

[GitHub] [inlong] gong commented on a diff in pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

2023-05-29 Thread via GitHub
gong commented on code in PR #8105: URL: https://github.com/apache/inlong/pull/8105#discussion_r1209643175 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/util/SchemaChangeUtils.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) u

[GitHub] [inlong] e-mhui commented on a diff in pull request #8044: [INLONG-8038][Sort] Optimize MySQL CDC chunk splitting

2023-05-29 Thread via GitHub
e-mhui commented on code in PR #8044: URL: https://github.com/apache/inlong/pull/8044#discussion_r1209650776 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/mysql-cdc/src/main/java/org/apache/inlong/sort/cdc/mysql/source/assigners/MySqlSnapshotSplitAssigner.java: ## @

[GitHub] [inlong] xuehuanran opened a new pull request, #8123: [INLONG-8122][TubeMQ] Implement "Heartbeat" method for GO SDK

2023-05-29 Thread via GitHub
xuehuanran opened a new pull request, #8123: URL: https://github.com/apache/inlong/pull/8123 - Add `Heartbeat` for GO producer SDK - Implement #8122 - Partent issue #4968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [inlong] fuweng11 opened a new pull request, #8124: [INLONG-8121][Manager] Supports cluster node status management in the case of multiple manager nodes

2023-05-29 Thread via GitHub
fuweng11 opened a new pull request, #8124: URL: https://github.com/apache/inlong/pull/8124 ### Prepare a Pull Request - Fixes #8121 ### Motivation Supports cluster node status management in the case of multiple manager nodes. ### Modifications Supp

[GitHub] [inlong] gunli commented on a diff in pull request #8111: [INLONG-4961][DataProxy] Add dataproxy-sdk-golang

2023-05-29 Thread via GitHub
gunli commented on code in PR #8111: URL: https://github.com/apache/inlong/pull/8111#discussion_r1209652770 ## inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/README.md: ## @@ -0,0 +1,197 @@ +# dataproxy-sdk-golang + +## Overview + +dataproxy-sdk-golang is the golang version

[GitHub] [inlong] featzhang commented on a diff in pull request #8120: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
featzhang commented on code in PR #8120: URL: https://github.com/apache/inlong/pull/8120#discussion_r1209654300 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -52,49 +54,

[GitHub] [inlong] thexiay commented on a diff in pull request #8120: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
thexiay commented on code in PR #8120: URL: https://github.com/apache/inlong/pull/8120#discussion_r1209655765 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -52,49 +54,85

[GitHub] [inlong] hejiay commented on a diff in pull request #8120: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
hejiay commented on code in PR #8120: URL: https://github.com/apache/inlong/pull/8120#discussion_r1209656737 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -52,49 +54,85

[GitHub] [inlong] hejiay commented on a diff in pull request #8120: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
hejiay commented on code in PR #8120: URL: https://github.com/apache/inlong/pull/8120#discussion_r1209657943 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -52,49 +54,85

[GitHub] [inlong] EMsnap commented on a diff in pull request #8117: [INLONG-8116][Sort] Support table api config setting

2023-05-29 Thread via GitHub
EMsnap commented on code in PR #8117: URL: https://github.com/apache/inlong/pull/8117#discussion_r1209659371 ## inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/configuration/Constants.java: ## @@ -97,6 +97,31 @@ public class Constants { */ public static f

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8100: [INLONG-8098][Manager] Support Inlong user permission control

2023-05-29 Thread via GitHub
fuweng11 commented on code in PR #8100: URL: https://github.com/apache/inlong/pull/8100#discussion_r1209647609 ## inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/InlongUserRoleEntityMapper.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache Sof

[GitHub] [inlong] vernedeng commented on a diff in pull request #8124: [INLONG-8121][Manager] Supports cluster node status management in the case of multiple manager nodes

2023-05-29 Thread via GitHub
vernedeng commented on code in PR #8124: URL: https://github.com/apache/inlong/pull/8124#discussion_r1209660751 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/heartbeat/HeartbeatManager.java: ## @@ -223,6 +227,13 @@ private void evictClusterNod

[GitHub] [inlong] dockerzhang merged pull request #8109: [INLONG-8108][Manager] WorkflowApprover API Permissions Optimization

2023-05-29 Thread via GitHub
dockerzhang merged PR #8109: URL: https://github.com/apache/inlong/pull/8109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.

[inlong] branch master updated: [INLONG-8108][Manager] WorkflowApprover API Permissions Optimization (#8109)

2023-05-29 Thread dockerzhang
This is an automated email from the ASF dual-hosted git repository. dockerzhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git The following commit(s) were added to refs/heads/master by this push: new a39e03cc5 [INLONG-8108][Manager] WorkflowAp

[GitHub] [inlong] thexiay commented on a diff in pull request #8120: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
thexiay commented on code in PR #8120: URL: https://github.com/apache/inlong/pull/8120#discussion_r1209667336 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -52,49 +54,85

[GitHub] [inlong] yunqingmoswu merged pull request #8105: [INLONG-7853][Sort] Add common handle for schema-change in sink

2023-05-29 Thread via GitHub
yunqingmoswu merged PR #8105: URL: https://github.com/apache/inlong/pull/8105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong

[inlong] branch master updated (a39e03cc5 -> b9446908f)

2023-05-29 Thread yunqing
This is an automated email from the ASF dual-hosted git repository. yunqing pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git from a39e03cc5 [INLONG-8108][Manager] WorkflowApprover API Permissions Optimization (#8109) add b9446908f [INLONG-78

[GitHub] [inlong] hejiay commented on a diff in pull request #8120: [INLONG-7959][Sort] Dynamic schema evolution support delete and update columns when sink to Iceberg

2023-05-29 Thread via GitHub
hejiay commented on code in PR #8120: URL: https://github.com/apache/inlong/pull/8120#discussion_r1209672436 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/iceberg/src/main/java/org/apache/inlong/sort/iceberg/sink/multiple/SchemaChangeUtils.java: ## @@ -52,49 +54,85

[GitHub] [inlong] gong commented on a diff in pull request #8044: [INLONG-8038][Sort] Optimize MySQL CDC chunk splitting

2023-05-29 Thread via GitHub
gong commented on code in PR #8044: URL: https://github.com/apache/inlong/pull/8044#discussion_r1209672869 ## inlong-sort/sort-flink/sort-flink-v1.13/sort-connectors/mysql-cdc/src/main/java/org/apache/inlong/sort/cdc/mysql/source/assigners/MySqlSnapshotSplitAssigner.java: ## @@

[GitHub] [inlong] dockerzhang merged pull request #8102: [INLONG-8101][Sort] Support multi-version packaging of sort-connectors

2023-05-29 Thread via GitHub
dockerzhang merged PR #8102: URL: https://github.com/apache/inlong/pull/8102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.

[inlong] branch master updated (b9446908f -> 383a28a34)

2023-05-29 Thread dockerzhang
This is an automated email from the ASF dual-hosted git repository. dockerzhang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git from b9446908f [INLONG-7853][Sort] Add common handle for schema-change in sink (#8105) add 383a28a34 [INLONG-810

[GitHub] [inlong] healchow commented on a diff in pull request #8119: [INLONG-8118][Manager] Support tenant user permission control

2023-05-29 Thread via GitHub
healchow commented on code in PR #8119: URL: https://github.com/apache/inlong/pull/8119#discussion_r1209683669 ## inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/InlongUserTypeEnum.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Softwa

[GitHub] [inlong] healchow commented on a diff in pull request #8119: [INLONG-8118][Manager] Support tenant user permission control

2023-05-29 Thread via GitHub
healchow commented on code in PR #8119: URL: https://github.com/apache/inlong/pull/8119#discussion_r1209684589 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/TenantRoleService.java: ## @@ -15,20 +15,24 @@ * limitations under the License.

[GitHub] [inlong] healchow commented on a diff in pull request #8107: [INLONG-8106][DataProxy] Optimize ConfigManager implementation ( part one )

2023-05-29 Thread via GitHub
healchow commented on code in PR #8107: URL: https://github.com/apache/inlong/pull/8107#discussion_r1209687344 ## inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/config/holder/BlackListConfigHolder.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apa

[GitHub] [inlong] dockerzhang merged pull request #8124: [INLONG-8121][Manager] Supports cluster node status management in the case of multiple manager nodes

2023-05-29 Thread via GitHub
dockerzhang merged PR #8124: URL: https://github.com/apache/inlong/pull/8124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@inlong.

[inlong] branch master updated: [INLONG-8121][Manager] Supports cluster node status management in the case of multiple manager nodes (#8124)

2023-05-29 Thread dockerzhang
This is an automated email from the ASF dual-hosted git repository. dockerzhang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git The following commit(s) were added to refs/heads/master by this push: new 45e6cea21 [INLONG-8121][Manager] Supports c

[inlong] branch master updated (45e6cea21 -> 6fd0f0a1b)

2023-05-29 Thread dockerzhang
This is an automated email from the ASF dual-hosted git repository. dockerzhang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git from 45e6cea21 [INLONG-8121][Manager] Supports cluster node status management in the case of multiple manager nodes (

[inlong] branch master updated: [INLONG-8038][Sort] Optimize MySQL CDC chunk splitting to prevent large chunk (#8044)

2023-05-29 Thread zirui
This is an automated email from the ASF dual-hosted git repository. zirui pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/inlong.git The following commit(s) were added to refs/heads/master by this push: new 792001139 [INLONG-8038][Sort] Optimize MySQL CDC

[GitHub] [inlong] vernedeng commented on a diff in pull request #8100: [INLONG-8098][Manager] Support Inlong user permission control

2023-05-29 Thread via GitHub
vernedeng commented on code in PR #8100: URL: https://github.com/apache/inlong/pull/8100#discussion_r1209767088 ## inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/InlongUserRoleEntityMapper.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache So

[GitHub] [inlong] vernedeng commented on a diff in pull request #8100: [INLONG-8098][Manager] Support Inlong user permission control

2023-05-29 Thread via GitHub
vernedeng commented on code in PR #8100: URL: https://github.com/apache/inlong/pull/8100#discussion_r1209768625 ## inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/controller/InlongRoleController.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Soft

[GitHub] [inlong] vernedeng commented on a diff in pull request #8100: [INLONG-8098][Manager] Support Inlong user permission control

2023-05-29 Thread via GitHub
vernedeng commented on code in PR #8100: URL: https://github.com/apache/inlong/pull/8100#discussion_r1209769843 ## inlong-manager/manager-dao/src/main/resources/mappers/InlongUserRoleEntityMapper.xml: ## @@ -0,0 +1,88 @@ + + + +http://mybatis.org/dtd/mybatis-3-mapper.dtd";> + +

[GitHub] [inlong] vernedeng commented on a diff in pull request #8100: [INLONG-8098][Manager] Support Inlong user permission control

2023-05-29 Thread via GitHub
vernedeng commented on code in PR #8100: URL: https://github.com/apache/inlong/pull/8100#discussion_r1209770774 ## inlong-manager/manager-web/sql/apache_inlong_manager.sql: ## @@ -580,6 +580,29 @@ CREATE TABLE IF NOT EXISTS `user_role` ) ENGINE = InnoDB DEFAULT CHARSET = utf

[GitHub] [inlong] vernedeng commented on a diff in pull request #8100: [INLONG-8098][Manager] Support Inlong user permission control

2023-05-29 Thread via GitHub
vernedeng commented on code in PR #8100: URL: https://github.com/apache/inlong/pull/8100#discussion_r1209772418 ## inlong-manager/manager-dao/src/main/java/org/apache/inlong/manager/dao/mapper/InlongUserRoleEntityMapper.java: ## @@ -0,0 +1,36 @@ +/* + * Licensed to the Apache So

[GitHub] [inlong] vernedeng commented on a diff in pull request #8119: [INLONG-8118][Manager] Support tenant user permission control

2023-05-29 Thread via GitHub
vernedeng commented on code in PR #8119: URL: https://github.com/apache/inlong/pull/8119#discussion_r1209782719 ## inlong-manager/manager-common/src/main/java/org/apache/inlong/manager/common/enums/InlongUserTypeEnum.java: ## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Softw

[GitHub] [inlong] fuweng11 commented on a diff in pull request #8100: [INLONG-8098][Manager] Support Inlong user permission control

2023-05-29 Thread via GitHub
fuweng11 commented on code in PR #8100: URL: https://github.com/apache/inlong/pull/8100#discussion_r1209779574 ## inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/user/InlongRoleServiceImpl.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache So