vernedeng commented on code in PR #8124:
URL: https://github.com/apache/inlong/pull/8124#discussion_r1209660751


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/heartbeat/HeartbeatManager.java:
##########
@@ -223,6 +227,13 @@ private void evictClusterNode(HeartbeatMsg heartbeat) {
                 protocolTypes = null;
             }
         }
+        // If the manager has multiple nodes, need to determine that the 
heartbeat is updated
+        ComponentHeartbeatEntity componentHeartbeatEntity = 
componentHeartbeatMapper.selectTimeOutHeartBeat(
+                componentHeartbeat.getComponentType(), 
componentHeartbeat.getIp(), heartbeatInterval() * 2L);

Review Comment:
   magic number



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to