(gravitino-site) branch main updated (9a453597 -> d7380919)

2025-02-25 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/gravitino-site.git from 9a453597 Merge pull request #43 from hrushi5387/hrushi-ASF-security-page-link add 3cad3848 local google f

Re: [PR] [#6496] feat(CLI): Support plain format output for Schema and Table command [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on PR #6497: URL: https://github.com/apache/gravitino/pull/6497#issuecomment-2681035736 > @Abyss-lord I'm not sure what you mean here, can you point to an example? in table format table details will return as follows: ```bash +--+-+---

Re: [PR] [#6496] feat(CLI): Support plain format output for Schema and Table command [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on PR #6497: URL: https://github.com/apache/gravitino/pull/6497#issuecomment-2681060096 The original object was that a LIST command should give just the basic information, i.e. name and comment, and a DETAILS command would provide more details. I don't know why the ta

[I] [Bug report] Rust build failed on rust check [gravitino]

2025-02-25 Thread via GitHub
diqiu50 opened a new issue, #6511: URL: https://github.com/apache/gravitino/issues/6511 ### Version main branch ### Describe what's wrong taplo check error: failed to parse manifest at `/home/runner/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cargo-mac

Re: [PR] [#6496] feat(CLI): Support plain format output for Schema and Table command [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on PR #6497: URL: https://github.com/apache/gravitino/pull/6497#issuecomment-2681078970 > The original object was that a LIST command should give just the basic information, i.e. name and comment, and a DETAILS command would provide more details. I don't know why the ta

Re: [PR] [#6496] feat(CLI): Support plain format output for Schema and Table command [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on code in PR #6497: URL: https://github.com/apache/gravitino/pull/6497#discussion_r1969237456 ## clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java: ## @@ -124,14 +137,98 @@ public CatalogListPlainFormat(CommandContext context) {

Re: [PR] [#6496] feat(CLI): Support plain format output for Schema and Table command [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on PR #6497: URL: https://github.com/apache/gravitino/pull/6497#issuecomment-2681091920 Have the space after coma's been removed in the plain output? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[PR] [#6511] fix (gvfs-fuse): Fix rust build failed on `rust check` [gravitino]

2025-02-25 Thread via GitHub
diqiu50 opened a new pull request, #6512: URL: https://github.com/apache/gravitino/pull/6512 ### What changes were proposed in this pull request? Fix rust build failed on `rust check, make the version of `cargo-machete` is 0.7.0. ### Why are the changes needed? Fix: #651

Re: [PR] [#6496] feat(CLI): Support plain format output for Schema and Table command [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on code in PR #6497: URL: https://github.com/apache/gravitino/pull/6497#discussion_r1969248527 ## clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java: ## @@ -124,14 +137,98 @@ public CatalogListPlainFormat(CommandContext context) {

Re: [PR] [#6496] feat(CLI): Support plain format output for Schema and Table command [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on PR #6497: URL: https://github.com/apache/gravitino/pull/6497#issuecomment-2681112659 > Have the space after coma's been removed in the plain output? The COMMA JOINER has removed the Spaces. -- This is an automated message from the Apache Git Service. To respo

[I] [Improvement] Possible resource leak in BaseCatalog.java [gravitino]

2025-02-25 Thread via GitHub
justinmclean opened a new issue, #6513: URL: https://github.com/apache/gravitino/issues/6513 ### What would you like to be improved? This code: BaseAuthorization authorization = BaseAuthorization.createAuthorization(classLoader, authorizationProvider); Th

Re: [PR] [#6392] fix(test): SparkJdbcMysqlCatalogIT33 failed in some enviroment [gravitino]

2025-02-25 Thread via GitHub
jerryshao commented on code in PR #6432: URL: https://github.com/apache/gravitino/pull/6432#discussion_r1969294397 ## integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/MySQLContainer.java: ## @@ -119,6 +119,14 @@ public void createDatabase(Tes

[PR] [#4620] improvement(authz): Throw the necessary exception when Ranger plugin the exception [gravitino]

2025-02-25 Thread via GitHub
jerqi opened a new pull request, #6515: URL: https://github.com/apache/gravitino/pull/6515 ### What changes were proposed in this pull request? Don't ignore the necessary exception. We should throw necessary exception from underlying system, ### Why are the changes needed?

Re: [PR] [#6511] fix (gvfs-fuse): Fix rust build failed on `rust check` [gravitino]

2025-02-25 Thread via GitHub
jerryshao closed pull request #6514: [#6511] fix (gvfs-fuse): Fix rust build failed on `rust check` URL: https://github.com/apache/gravitino/pull/6514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Bug report] Rust build failed on rust check [gravitino]

2025-02-25 Thread via GitHub
jerryshao closed issue #6511: [Bug report] Rust build failed on rust check URL: https://github.com/apache/gravitino/issues/6511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(gravitino) branch main updated: [#6511] fix (gvfs-fuse): Fix rust build failed on `rust check` (#6512)

2025-02-25 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 4996d0c50e [#6511] fix (gvfs-fuse): Fix rust build

Re: [PR] [#6511] fix (gvfs-fuse): Fix rust build failed on `rust check` [gravitino]

2025-02-25 Thread via GitHub
jerryshao merged PR #6512: URL: https://github.com/apache/gravitino/pull/6512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

[PR] [#6511] fix (gvfs-fuse): Fix rust build failed on `rust check` [gravitino]

2025-02-25 Thread via GitHub
github-actions[bot] opened a new pull request, #6514: URL: https://github.com/apache/gravitino/pull/6514 ### What changes were proposed in this pull request? Fix rust build failed on `rust check, make the version of `cargo-machete` is 0.7.0. ### Why are the changes needed?

(gravitino) branch cherry-pick-branch-0.8-4996d0c50e64fc9a702117a4ded1451867d7b89b created (now 19bc285436)

2025-02-25 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch cherry-pick-branch-0.8-4996d0c50e64fc9a702117a4ded1451867d7b89b in repository https://gitbox.apache.org/repos/asf/gravitino.git at 19bc285436 [#6511] fix (gvfs-fuse): Fix rust build fa

Re: [I] [Improvement] Missing @Override in SchemaMetaPostgreSQLProvider.java [gravitino]

2025-02-25 Thread via GitHub
AndreVale69 commented on issue #6516: URL: https://github.com/apache/gravitino/issues/6516#issuecomment-2681528929 Hi, I've solved this issue on the PR https://github.com/apache/gravitino/pull/6520 -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [#6511] fix (gvfs-fuse): Fix rust build failed on `rust check` [gravitino]

2025-02-25 Thread via GitHub
jerryshao merged PR #6514: URL: https://github.com/apache/gravitino/pull/6514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch branch-0.8 updated: [#6511] fix (gvfs-fuse): Fix rust build failed on `rust check` (#6514)

2025-02-25 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch branch-0.8 in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-0.8 by this push: new 681845f966 [#6511] fix (gvfs-fuse): Fi

(gravitino) branch cherry-pick-branch-0.8-4996d0c50e64fc9a702117a4ded1451867d7b89b deleted (was 19bc285436)

2025-02-25 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a change to branch cherry-pick-branch-0.8-4996d0c50e64fc9a702117a4ded1451867d7b89b in repository https://gitbox.apache.org/repos/asf/gravitino.git was 19bc285436 [#6511] fix (gvfs-fuse): Fix rust build failed

[I] [Improvement] Change document `manage-fileset-metadata-using-gravitino` as the API has changed [gravitino]

2025-02-25 Thread via GitHub
yuqi1129 opened a new issue, #6519: URL: https://github.com/apache/gravitino/issues/6519 ### What would you like to be improved? When I create a fileset as stated in the document: https://github.com/user-attachments/assets/f44a0b7b-2ae7-4ed9-b379-ca4f123ec656"; />

Re: [PR] [#6459]improve(test): Use explicit wait for time-based condition [gravitino]

2025-02-25 Thread via GitHub
jerryshao commented on code in PR #6460: URL: https://github.com/apache/gravitino/pull/6460#discussion_r1969517075 ## web/integration-test/src/test/java/org/apache/gravitino/integration/test/web/ui/pages/CatalogsPage.java: ## @@ -683,79 +683,67 @@ public boolean verifyShowTableT

Re: [PR] [#6459]improve(test): Use explicit wait for time-based condition [gravitino]

2025-02-25 Thread via GitHub
zzzk1 commented on code in PR #6460: URL: https://github.com/apache/gravitino/pull/6460#discussion_r1969522656 ## web/integration-test/src/test/java/org/apache/gravitino/integration/test/web/ui/pages/CatalogsPage.java: ## @@ -683,79 +683,67 @@ public boolean verifyShowTableTitle

Re: [I] [Improvement] Fix Web UI compliance with ASF licensing policy [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on issue #6441: URL: https://github.com/apache/gravitino/issues/6441#issuecomment-2681549586 Also, If you also look at issues like [1] you see it's checking if its DB is up to date when running, not compiling. 1. https://github.com/vercel/next.js/discussions/131

Re: [I] [Improvement] Fix Web UI compliance with ASF licensing policy [gravitino]

2025-02-25 Thread via GitHub
LauraXia123 commented on issue #6441: URL: https://github.com/apache/gravitino/issues/6441#issuecomment-2681580260 > Also, If you also look at issues like [1] you see it's checking if its DB is up to date when running, not compiling. > > 1. [I recently started getting the "Browserslis

[I] [Improvement] In IcebergTableRenameOperations.java wrong logging class is used [gravitino]

2025-02-25 Thread via GitHub
justinmclean opened a new issue, #6518: URL: https://github.com/apache/gravitino/issues/6518 ### What would you like to be improved? This line uses the incorrect class: `private static final Logger LOG = LoggerFactory.getLogger(IcebergTableOperations.class);` ### How should

Re: [PR] [#6392] fix(test): SparkJdbcMysqlCatalogIT33 failed in some enviroment [gravitino]

2025-02-25 Thread via GitHub
yuqi1129 commented on code in PR #6432: URL: https://github.com/apache/gravitino/pull/6432#discussion_r1969408451 ## integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/MySQLContainer.java: ## @@ -119,6 +119,14 @@ public void createDatabase(Test

Re: [I] [Improvement] Fix Web UI compliance with ASF licensing policy [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on issue #6441: URL: https://github.com/apache/gravitino/issues/6441#issuecomment-2681493986 As you can see above, this is not correct it's a production dependency, not a development dependency. -- This is an automated message from the Apache Git Service. To respond

Re: [I] [FEATURE] Support plain format output for Schema and Table command [gravitino]

2025-02-25 Thread via GitHub
justinmclean closed issue #6496: [FEATURE] Support plain format output for Schema and Table command URL: https://github.com/apache/gravitino/issues/6496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [#6496] feat(CLI): Support plain format output for Schema and Table command [gravitino]

2025-02-25 Thread via GitHub
justinmclean merged PR #6497: URL: https://github.com/apache/gravitino/pull/6497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [I] [FEATURE] Support plain format output for Schema and Table command [gravitino]

2025-02-25 Thread via GitHub
justinmclean closed issue #6496: [FEATURE] Support plain format output for Schema and Table command URL: https://github.com/apache/gravitino/issues/6496 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [#6392] fix(test): SparkJdbcMysqlCatalogIT33 failed in some enviroment [gravitino]

2025-02-25 Thread via GitHub
yuqi1129 commented on code in PR #6432: URL: https://github.com/apache/gravitino/pull/6432#discussion_r1970794434 ## integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/MySQLContainer.java: ## @@ -119,6 +119,14 @@ public void createDatabase(Test

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-25 Thread via GitHub
FANNG1 commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1970800358 ## core/src/main/java/org/apache/gravitino/metrics/MetricNames.java: ## @@ -22,6 +22,12 @@ public class MetricNames { public static final String HTTP_PROCESS_DURAT

Re: [PR] [#6499] improvement(server): Support custom configuration options in the REST API `/configs` [gravitino]

2025-02-25 Thread via GitHub
jerqi commented on PR #6501: URL: https://github.com/apache/gravitino/pull/6501#issuecomment-2683747093 > What is the usage scenario of this change? It's useful for some users to extend Gravitino service. For example, we can add a Ranger service. We can provide the Ranger information

Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on issue #5957: URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2683793236 @waukin @justinmclean The feature has been implemented, and the issue can be closed. -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [I] [FEATURE] Support table format output for ListSchema command [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on issue #5958: URL: https://github.com/apache/gravitino/issues/5958#issuecomment-2683792882 @waukin The feature has been implemented, and the issue can be closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [#6076] improve(CLI): Support model pre event to Gravitino server [gravitino]

2025-02-25 Thread via GitHub
FANNG1 commented on code in PR #6250: URL: https://github.com/apache/gravitino/pull/6250#discussion_r1970840811 ## core/src/main/java/org/apache/gravitino/listener/api/info/ModelInfo.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [I] [EPIC] Gravitino CLI Table formatted output [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on issue #5747: URL: https://github.com/apache/gravitino/issues/5747#issuecomment-2683793966 @xunliu @waukin @justinmclean All the feature has been implemented, and the issue can be closed. -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] [Improvement] Fix potential null pointer expections in CLI [gravitino]

2025-02-25 Thread via GitHub
Brijeshthummar02 commented on issue #6528: URL: https://github.com/apache/gravitino/issues/6528#issuecomment-2683810720 @justinmclean assign me i'll fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [#4620] improvement(authz): Throw the necessary exception when Ranger plugin the exception [gravitino]

2025-02-25 Thread via GitHub
jerqi commented on code in PR #6515: URL: https://github.com/apache/gravitino/pull/6515#discussion_r1970826991 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java: ## @@ -278,9 +278,18 @@ protected RangerRole createRan

Re: [PR] [#6076] improve(CLI): Support model pre event to Gravitino server [gravitino]

2025-02-25 Thread via GitHub
FANNG1 commented on code in PR #6250: URL: https://github.com/apache/gravitino/pull/6250#discussion_r1970838921 ## core/src/main/java/org/apache/gravitino/listener/ModelEventDispatcher.java: ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#6076] improve(CLI): Support model pre event to Gravitino server [gravitino]

2025-02-25 Thread via GitHub
FANNG1 commented on code in PR #6250: URL: https://github.com/apache/gravitino/pull/6250#discussion_r1970842535 ## core/src/main/java/org/apache/gravitino/listener/api/info/ModelInfo.java: ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one +

Re: [PR] [#6076] improve(CLI): Support model pre event to Gravitino server [gravitino]

2025-02-25 Thread via GitHub
FANNG1 commented on code in PR #6250: URL: https://github.com/apache/gravitino/pull/6250#discussion_r1970844045 ## core/src/main/java/org/apache/gravitino/listener/ModelEventDispatcher.java: ## @@ -0,0 +1,377 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] [#6076] improve(CLI): Support model pre event to Gravitino server [gravitino]

2025-02-25 Thread via GitHub
FANNG1 commented on PR #6250: URL: https://github.com/apache/gravitino/pull/6250#issuecomment-2683802954 Totally, please try to avoid doing another IO to get model or model version information for the event, using the parameter in the request seems enough. -- This is an automated message

Re: [I] [Improvement] In IcebergTableRenameOperations.java wrong logging class is used [gravitino]

2025-02-25 Thread via GitHub
jerryshao closed issue #6518: [Improvement] In IcebergTableRenameOperations.java wrong logging class is used URL: https://github.com/apache/gravitino/issues/6518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [I] [Improvement] Muliple repeated strings in Ranger classes [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on issue #6530: URL: https://github.com/apache/gravitino/issues/6530#issuecomment-2683824451 I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[PR] [Minor] Improve log messages [gravitino]

2025-02-25 Thread via GitHub
justinmclean opened a new pull request, #6531: URL: https://github.com/apache/gravitino/pull/6531 ### What changes were proposed in this pull request? Improve a couple of log messages. ### Why are the changes needed? For clarity. Fix: #(issue) ### Does this

Re: [I] [FEATURE] Support table format output for ListSchema command [gravitino]

2025-02-25 Thread via GitHub
justinmclean closed issue #5958: [FEATURE] Support table format output for ListSchema command URL: https://github.com/apache/gravitino/issues/5958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] [FEATURE] Support table format output for SchemaDetails command [gravitino]

2025-02-25 Thread via GitHub
justinmclean closed issue #5957: [FEATURE] Support table format output for SchemaDetails command URL: https://github.com/apache/gravitino/issues/5957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [EPIC] Gravitino CLI Table formatted output [gravitino]

2025-02-25 Thread via GitHub
justinmclean closed issue #5747: [EPIC] Gravitino CLI Table formatted output URL: https://github.com/apache/gravitino/issues/5747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] [#4620] improvement(authz): Throw the necessary exception when Ranger plugin the exception [gravitino]

2025-02-25 Thread via GitHub
tengqm commented on code in PR #6515: URL: https://github.com/apache/gravitino/pull/6515#discussion_r1970759166 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerHelper.java: ## @@ -278,9 +278,18 @@ protected RangerRole createRa

Re: [PR] [#6392] fix(test): SparkJdbcMysqlCatalogIT33 failed in some enviroment [gravitino]

2025-02-25 Thread via GitHub
FANNG1 commented on code in PR #6432: URL: https://github.com/apache/gravitino/pull/6432#discussion_r1970770397 ## integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/MySQLContainer.java: ## @@ -119,6 +119,14 @@ public void createDatabase(TestDa

[PR] fix: Remove incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED [gravitino]

2025-02-25 Thread via GitHub
Brijeshthummar02 opened a new pull request, #6532: URL: https://github.com/apache/gravitino/pull/6532 **What changes were proposed in this pull request?** - Removed the incorrect `@VisibleForTesting` annotation from `ICEBERG_CATALOG_CACHE_ENABLED` in `IcebergPropertiesConstants

Re: [PR] [#6523] fix(core): Filter null prop when init properties [gravitino]

2025-02-25 Thread via GitHub
TEOTEO520 commented on PR #6524: URL: https://github.com/apache/gravitino/pull/6524#issuecomment-2683858220 > Because this is a bug fix. Could you add a UT to cover this change? OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] [Improvement] Muliple repeated strings in Ranger classes [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on issue #6530: URL: https://github.com/apache/gravitino/issues/6530#issuecomment-2683844662 Note I just put in a PR to improve some of the messages, you might want to wait until that is merged. -- This is an automated message from the Apache Git Service. To respond

Re: [I] [Improvement] Fix Web UI compliance with ASF licensing policy [gravitino]

2025-02-25 Thread via GitHub
LauraXia123 commented on issue #6441: URL: https://github.com/apache/gravitino/issues/6441#issuecomment-2683862748 Here's my analysis report: https://docs.google.com/document/d/1fyH1KGPGO3upR8cVQn0bzZbyPM2ePhBMc6X5KVmqWME/edit?tab=t.0 -- This is an automated message from the Apache Git

Re: [I] [Improvement] Add default values to column list output in CLI [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on issue #6533: URL: https://github.com/apache/gravitino/issues/6533#issuecomment-2683874420 I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] fix: Remove incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on PR #6532: URL: https://github.com/apache/gravitino/pull/6532#issuecomment-2683967976 I'm sorry you are having issues here; as it is hard to work out what might be wrong, I would suggest making a fresh clone and giving that a try. -- This is an automated message f

Re: [I] [Improvement] Fix Web UI compliance with ASF licensing policy [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on issue #6441: URL: https://github.com/apache/gravitino/issues/6441#issuecomment-2683972617 I'm a little confused by that report, it seems to show that caniuse is used in production. It doesn't matter if the dependency is transitive. A dependency of next.js, which is

Re: [I] [Improvement] Fix Web UI compliance with ASF licensing policy [gravitino]

2025-02-25 Thread via GitHub
LauraXia123 commented on issue #6441: URL: https://github.com/apache/gravitino/issues/6441#issuecomment-2684022179 1. It show that caniuse-lite is used in next production, not gravitino production. A dependency of next.js, which is a indirect dependency of gravitino. The indirect dependency

Re: [PR] [#6136] improvement(CLI): Move check for enable and disable command in Gravitino CLI to command [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on PR #6535: URL: https://github.com/apache/gravitino/pull/6535#issuecomment-2684030767 @justinmclean @tengqm could you please review this PR when you have time? I’d really appreciate your feedback. -- This is an automated message from the Apache Git Service. To respo

Re: [PR] [#6459]improve(test): Use explicit wait for time-based condition [gravitino]

2025-02-25 Thread via GitHub
jerryshao merged PR #6460: URL: https://github.com/apache/gravitino/pull/6460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Improvement] Use the explicit wait feature provided by Selenium to replace Thread.Sleep [gravitino]

2025-02-25 Thread via GitHub
jerryshao closed issue #6459: [Improvement] Use the explicit wait feature provided by Selenium to replace Thread.Sleep URL: https://github.com/apache/gravitino/issues/6459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [I] [Improvement] Use the explicit wait feature provided by Selenium to replace Thread.Sleep [gravitino]

2025-02-25 Thread via GitHub
jerryshao closed issue #6459: [Improvement] Use the explicit wait feature provided by Selenium to replace Thread.Sleep URL: https://github.com/apache/gravitino/issues/6459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] fix: Remove incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED [gravitino]

2025-02-25 Thread via GitHub
Brijeshthummar02 commented on PR #6532: URL: https://github.com/apache/gravitino/pull/6532#issuecomment-2683948478 @justinmclean apart from this issue, i'm running through critical issue like not able to do commit from any ide vs nor github desktop i am not sure why its happening and never

Re: [PR] fix: Remove incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on PR #6532: URL: https://github.com/apache/gravitino/pull/6532#issuecomment-2683953055 I don't think GitHub is having any issues right now. First off, I'd make sure you are trying to commit to your clone of the repo, not the ASF repo. -- This is an automated messag

Re: [PR] fix: Remove incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED [gravitino]

2025-02-25 Thread via GitHub
Brijeshthummar02 commented on PR #6532: URL: https://github.com/apache/gravitino/pull/6532#issuecomment-2683956357 the clone repo which i forked not only this repo neither of my any repo works when i do commit it adds files, creates and pushes it but during commit msg it just buffer/loads n

Re: [PR] fix: Remove incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED [gravitino]

2025-02-25 Thread via GitHub
Brijeshthummar02 closed pull request #6532: fix: Remove incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED URL: https://github.com/apache/gravitino/pull/6532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[I] [Improvement] Change LockManager logging level to DEBUG [gravitino]

2025-02-25 Thread via GitHub
youngyjd opened a new issue, #6537: URL: https://github.com/apache/gravitino/issues/6537 ### What would you like to be improved? We recently deployed Gravitino service but found out logs are hard to read, because [logs from LockManager](https://github.com/apache/gravitino/blob/f7719f

Re: [PR] fix: Remove incorrect @VisibleForTesting annotation from ICEBERG_CATALOG_CACHE_ENABLED [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on PR #6532: URL: https://github.com/apache/gravitino/pull/6532#issuecomment-2683928569 The CI check is failing as we use Spotless to format our code to ensure consistency. You'll need to run `./gradlew :spark-connector:spark-common:spotlessApply` and commit any chang

Re: [I] [Improvement] Support custom configuration options in the REST API /configs [gravitino]

2025-02-25 Thread via GitHub
jerryshao closed issue #6499: [Improvement] Support custom configuration options in the REST API /configs URL: https://github.com/apache/gravitino/issues/6499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [Improvement] Support custom configuration options in the REST API /configs [gravitino]

2025-02-25 Thread via GitHub
jerryshao closed issue #6499: [Improvement] Support custom configuration options in the REST API /configs URL: https://github.com/apache/gravitino/issues/6499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [#6499] improvement(server): Support custom configuration options in the REST API `/configs` [gravitino]

2025-02-25 Thread via GitHub
jerryshao merged PR #6501: URL: https://github.com/apache/gravitino/pull/6501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [#6499] improvement(server): Support custom configuration options in the REST API `/configs` (#6501)

2025-02-25 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 769265419f [#6499] improvement(server): Support cu

Re: [PR] [#6467] improve(core): Allow JDBC backend configs be configurable [gravitino]

2025-02-25 Thread via GitHub
tengqm commented on code in PR #6469: URL: https://github.com/apache/gravitino/pull/6469#discussion_r1970730379 ## core/src/main/java/org/apache/gravitino/Configs.java: ## @@ -137,6 +147,21 @@ private Configs() {} .stringConf() .createWithDefault(DEFAULT_RE

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-25 Thread via GitHub
tengqm commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1970736157 ## core/src/main/java/org/apache/gravitino/metrics/MetricNames.java: ## @@ -22,6 +22,12 @@ public class MetricNames { public static final String HTTP_PROCESS_DURAT

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-25 Thread via GitHub
tengqm commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1970737726 ## core/src/main/java/org/apache/gravitino/metrics/MetricNames.java: ## @@ -22,6 +22,12 @@ public class MetricNames { public static final String HTTP_PROCESS_DURAT

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-25 Thread via GitHub
tengqm commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1970739910 ## core/src/main/java/org/apache/gravitino/metrics/MetricNames.java: ## @@ -22,6 +22,12 @@ public class MetricNames { public static final String HTTP_PROCESS_DURAT

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-25 Thread via GitHub
tengqm commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1970741496 ## core/src/main/java/org/apache/gravitino/metrics/MetricNames.java: ## @@ -22,6 +22,12 @@ public class MetricNames { public static final String HTTP_PROCESS_DURAT

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-25 Thread via GitHub
FANNG1 commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1970739956 ## core/src/main/java/org/apache/gravitino/metrics/MetricNames.java: ## @@ -22,6 +22,12 @@ public class MetricNames { public static final String HTTP_PROCESS_DURAT

[I] [Improvement] Liveness check and health check [gravitino]

2025-02-25 Thread via GitHub
youngyjd opened a new issue, #6527: URL: https://github.com/apache/gravitino/issues/6527 ### What would you like to be improved? In an ideal environment, we should have 2 type of checks: 1. Liveness check: to determine if a container has started or not 2. Readiness check: to dete

(gravitino) branch main updated: fix(logging): Correct logger class in IcebergTableRenameOperations (#6522)

2025-02-25 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new d36ebac3f7 fix(logging): Correct logger class in

Re: [PR] fix(logging): Correct logger class in IcebergTableRenameOperations [gravitino]

2025-02-25 Thread via GitHub
justinmclean merged PR #6522: URL: https://github.com/apache/gravitino/pull/6522 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [PR] [#6523] fix(core): Filter null prop when init properties [gravitino]

2025-02-25 Thread via GitHub
jerqi commented on PR #6524: URL: https://github.com/apache/gravitino/pull/6524#issuecomment-2683740988 Because this is a bug fix. Could you add a UT to cover this change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] [Improvement] Liveness check and health check [gravitino]

2025-02-25 Thread via GitHub
jerqi commented on issue #6527: URL: https://github.com/apache/gravitino/issues/6527#issuecomment-2683756268 > As stated in the issue description, readiness check is expected to indicate that the service can serve requests. So I don't think `/configs` is a proper endpoint for this purpose.

Re: [I] [Subtask] Support update comment operations for model alteration [gravitino]

2025-02-25 Thread via GitHub
TEOTEO520 commented on issue #6525: URL: https://github.com/apache/gravitino/issues/6525#issuecomment-2682890662 I'll be much appreciate if I can take on this task -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [I] [Subtask] Support update properties operations for model alteration. [gravitino]

2025-02-25 Thread via GitHub
TEOTEO520 commented on issue #6526: URL: https://github.com/apache/gravitino/issues/6526#issuecomment-2682890890 I'll be much appreciate if I can take on this task -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[I] [Subtask] Support update properties operations for model alteration. [gravitino]

2025-02-25 Thread via GitHub
TEOTEO520 opened a new issue, #6526: URL: https://github.com/apache/gravitino/issues/6526 ### Describe the subtask This issue focuses on adding model properties update operation support for model alteration. The work should include: 1. Add ModelChange API interface for properti

Re: [PR] [#6392] fix(test): SparkJdbcMysqlCatalogIT33 failed in some enviroment [gravitino]

2025-02-25 Thread via GitHub
FANNG1 commented on code in PR #6432: URL: https://github.com/apache/gravitino/pull/6432#discussion_r1969651141 ## integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/MySQLContainer.java: ## @@ -119,6 +119,14 @@ public void createDatabase(TestDa

Re: [PR] [#6392] fix(test): SparkJdbcMysqlCatalogIT33 failed in some enviroment [gravitino]

2025-02-25 Thread via GitHub
yuqi1129 commented on code in PR #6432: URL: https://github.com/apache/gravitino/pull/6432#discussion_r1969652592 ## integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/MySQLContainer.java: ## @@ -119,6 +119,14 @@ public void createDatabase(Test

Re: [PR] [#6392] fix(test): SparkJdbcMysqlCatalogIT33 failed in some enviroment [gravitino]

2025-02-25 Thread via GitHub
FANNG1 commented on code in PR #6432: URL: https://github.com/apache/gravitino/pull/6432#discussion_r1969651141 ## integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/MySQLContainer.java: ## @@ -119,6 +119,14 @@ public void createDatabase(TestDa

Re: [PR] fix(logging): Correct logger class in IcebergTableRenameOperations [gravitino]

2025-02-25 Thread via GitHub
Brijeshthummar02 commented on PR #6522: URL: https://github.com/apache/gravitino/pull/6522#issuecomment-2681907850 @jerryshao updated, cool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [I] [Improvement] Fix Web UI compliance with ASF licensing policy [gravitino]

2025-02-25 Thread via GitHub
justinmclean commented on issue #6441: URL: https://github.com/apache/gravitino/issues/6441#issuecomment-2681930943 We need to prove that it is not used in production. How can we do this? So far all available evidence points to it being a production dependancy. -- This is an automated mes

Re: [PR] [#6467] improve(core): Allow JDBC backend configs be configurable [gravitino]

2025-02-25 Thread via GitHub
TEOTEO520 commented on code in PR #6469: URL: https://github.com/apache/gravitino/pull/6469#discussion_r1970248812 ## core/src/main/java/org/apache/gravitino/Configs.java: ## @@ -48,6 +48,12 @@ private Configs() {} public static final String ENTITY_RELATIONAL_JDBC_BACKEND_PAS

Re: [PR] [#6467] improve(core): Allow JDBC backend configs be configurable [gravitino]

2025-02-25 Thread via GitHub
TEOTEO520 commented on code in PR #6469: URL: https://github.com/apache/gravitino/pull/6469#discussion_r1970247984 ## core/src/main/java/org/apache/gravitino/Configs.java: ## @@ -48,6 +48,12 @@ private Configs() {} public static final String ENTITY_RELATIONAL_JDBC_BACKEND_PAS

Re: [I] [Improvement] Change document `manage-fileset-metadata-using-gravitino` as the API has changed [gravitino]

2025-02-25 Thread via GitHub
Abyss-lord commented on issue #6519: URL: https://github.com/apache/gravitino/issues/6519#issuecomment-2682573693 I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [#6468] feature(core): add metrics for mysql backend connect pool [gravitino]

2025-02-25 Thread via GitHub
TEOTEO520 commented on code in PR #6470: URL: https://github.com/apache/gravitino/pull/6470#discussion_r1970167280 ## core/src/main/java/org/apache/gravitino/metrics/MetricNames.java: ## @@ -22,6 +22,12 @@ public class MetricNames { public static final String HTTP_PROCESS_DU

  1   2   >