justinmclean commented on code in PR #6497:
URL: https://github.com/apache/gravitino/pull/6497#discussion_r1969237456
##########
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java:
##########
@@ -124,14 +137,98 @@ public CatalogListPlainFormat(CommandContext context) {
/** {@inheritDoc} */
@Override
public String getOutput(Catalog[] catalogs) {
- if (catalogs == null || catalogs.length == 0) {
- output("No catalogs exist.", System.out);
- return null;
- } else {
- List<String> catalogNames =
-
Arrays.stream(catalogs).map(Catalog::name).collect(Collectors.toList());
- return NEWLINE_JOINER.join(catalogNames);
- }
+
+ List<String> catalogNames =
+
Arrays.stream(catalogs).map(Catalog::name).collect(Collectors.toList());
+ return NEWLINE_JOINER.join(catalogNames);
+ }
+ }
Review Comment:
Will we still get "No catalogs exist." if no catalog exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
