justinmclean opened a new issue, #6413:
URL: https://github.com/apache/gravitino/issues/6413
### What would you like to be improved?
In #6343 a command context was added for Metalakes. We need to add it for
other command sets:
- [ ] Catalogs
- [ ] Filesets
- [ ] Schema
- [
yuqi1129 commented on PR #2873:
URL: https://github.com/apache/gravitino/pull/2873#issuecomment-2646824213
> I think you can do some fine-grained access control for the lock scope,
rather than blindly wrapping the whole logic into one lock. For example, like
"load fileset", you only need to
diqiu50 commented on code in PR #6405:
URL: https://github.com/apache/gravitino/pull/6405#discussion_r1948347727
##
clients/filesystem-fuse/README.md:
##
@@ -0,0 +1,90 @@
+
+
+# Gvfs-fuse
+
+Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount
Gravitino
diqiu50 commented on code in PR #6405:
URL: https://github.com/apache/gravitino/pull/6405#discussion_r1948347400
##
clients/filesystem-fuse/README.md:
##
@@ -0,0 +1,90 @@
+
+
+# Gvfs-fuse
+
+Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount
Gravitino
diqiu50 commented on code in PR #6405:
URL: https://github.com/apache/gravitino/pull/6405#discussion_r1948350420
##
clients/filesystem-fuse/README.md:
##
@@ -0,0 +1,90 @@
+
+
+# Gvfs-fuse
+
+Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount
Gravitino
yuqi1129 commented on code in PR #6211:
URL: https://github.com/apache/gravitino/pull/6211#discussion_r1948306054
##
core/src/main/java/org/apache/gravitino/utils/NamespaceUtil.java:
##
@@ -107,6 +108,17 @@ public static Namespace ofFileset(String metalake, String
catalog, Stri
justinmclean commented on code in PR #6359:
URL: https://github.com/apache/gravitino/pull/6359#discussion_r1948320577
##
clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java:
##
@@ -23,6 +23,8 @@
public class ErrorMessages {
public static final String CATALO
yuqi1129 commented on code in PR #6405:
URL: https://github.com/apache/gravitino/pull/6405#discussion_r1948363967
##
clients/filesystem-fuse/README.md:
##
@@ -0,0 +1,95 @@
+
+
+# Gvfs-fuse
+
+Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount
Gravitino
yuqi1129 commented on PR #6405:
URL: https://github.com/apache/gravitino/pull/6405#issuecomment-2646864864
By the way, where do you plan to place this page?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Abyss-lord commented on PR #6425:
URL: https://github.com/apache/gravitino/pull/6425#issuecomment-2646851451
Hi @justinmclean, could you please review this PR when you have time? I’d
really appreciate your feedback.
--
This is an automated message from the Apache Git Service.
To respond
shaofengshi commented on code in PR #6359:
URL: https://github.com/apache/gravitino/pull/6359#discussion_r1948369568
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteUser.java:
##
@@ -53,6 +53,10 @@ public DeleteUser(
public void handle() {
boolean de
justinmclean commented on code in PR #6425:
URL: https://github.com/apache/gravitino/pull/6425#discussion_r1948380952
##
clients/cli/src/main/java/org/apache/gravitino/cli/CatalogCommandHandler.java:
##
@@ -33,32 +33,34 @@ public class CatalogCommandHandler extends CommandHandle
justinmclean commented on code in PR #6425:
URL: https://github.com/apache/gravitino/pull/6425#discussion_r1948383621
##
clients/cli/src/test/java/org/apache/gravitino/cli/TestCatalogCommands.java:
##
@@ -163,31 +161,28 @@ void testCreateCatalogCommand() {
doReturn(mockCrea
justinmclean commented on code in PR #6425:
URL: https://github.com/apache/gravitino/pull/6425#discussion_r1948383902
##
clients/cli/src/test/java/org/apache/gravitino/cli/TestCatalogCommands.java:
##
@@ -253,24 +246,22 @@ void testSetCatalogPropertyCommand() {
doReturn(moc
justinmclean commented on PR #6412:
URL: https://github.com/apache/gravitino/pull/6412#issuecomment-2646908152
I'm still seeing the same issue, did you run `./gradlew :core:spotlessApply`
and commit the changes?
--
This is an automated message from the Apache Git Service.
To respond to th
Abyss-lord opened a new pull request, #6427:
URL: https://github.com/apache/gravitino/pull/6427
### What changes were proposed in this pull request?
Add schema command context CLI
### Why are the changes needed?
Fix: #6416
### Does this PR introduce _any_ user-fac
Abyss-lord commented on PR #6427:
URL: https://github.com/apache/gravitino/pull/6427#issuecomment-2647104278
@justinmclean could you please review this PR when you have time? I’d really
appreciate your feedback.
--
This is an automated message from the Apache Git Service.
To respond to th
FANNG1 commented on code in PR #6405:
URL: https://github.com/apache/gravitino/pull/6405#discussion_r1948503635
##
clients/filesystem-fuse/README.md:
##
@@ -0,0 +1,90 @@
+
+
+# Gvfs-fuse
+
+Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount
Gravitino f
FANNG1 commented on code in PR #6405:
URL: https://github.com/apache/gravitino/pull/6405#discussion_r1948503216
##
clients/filesystem-fuse/README.md:
##
@@ -0,0 +1,95 @@
+
+
+# Gvfs-fuse
+
+Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount
Gravitino f
FANNG1 commented on PR #5980:
URL: https://github.com/apache/gravitino/pull/5980#issuecomment-2646156993
@amazingLychee merged to main, thanks for your contribution and patience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
This is an automated email from the ASF dual-hosted git repository.
fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new a84fd189ac [#5900] feat(tag): support tag pre-even
FANNG1 closed issue #5900: [Subtask] Support tag pre event to Gravitino server
URL: https://github.com/apache/gravitino/issues/5900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
FANNG1 merged PR #5980:
URL: https://github.com/apache/gravitino/pull/5980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
FANNG1 closed issue #5900: [Subtask] Support tag pre event to Gravitino server
URL: https://github.com/apache/gravitino/issues/5900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
Abyss-lord commented on code in PR #6359:
URL: https://github.com/apache/gravitino/pull/6359#discussion_r1948339736
##
clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java:
##
@@ -23,6 +23,8 @@
public class ErrorMessages {
public static final String CATALOG_
sunxiaojian commented on issue #6403:
URL: https://github.com/apache/gravitino/issues/6403#issuecomment-2646810991
@gesaleh According to the Trino connector documentation, updating data is
not currently supported.
https://gravitino.apache.org/docs/0.6.0-incubating/trino-connector/sql-suppor
tengqm commented on PR #6359:
URL: https://github.com/apache/gravitino/pull/6359#issuecomment-2646936602
/lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
Pranaykarvi commented on PR #6400:
URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2646966223
> There's some formatting issue with your PR, to make the tests pass you'll
need to run prettier with --write to format the code correctly.
Thanks for the heads-up! I ran Pret
parampreetchahal commented on PR #6412:
URL: https://github.com/apache/gravitino/pull/6412#issuecomment-2646983071
> I'm still seeing the same issue, did you run `./gradlew
:core:spotlessApply` and commit the changes?
yes i did
--
This is an automated message from the Apache Git Se
justinmclean commented on PR #6412:
URL: https://github.com/apache/gravitino/pull/6412#issuecomment-2646986220
You may need to use Java 17 as that's what it is failing on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
Abyss-lord commented on code in PR #6425:
URL: https://github.com/apache/gravitino/pull/6425#discussion_r1948437498
##
clients/cli/src/test/java/org/apache/gravitino/cli/TestCatalogCommands.java:
##
@@ -253,24 +246,22 @@ void testSetCatalogPropertyCommand() {
doReturn(mockS
jerryshao commented on PR #2873:
URL: https://github.com/apache/gravitino/pull/2873#issuecomment-2647015977
I see your point, the original code may have some problems, or it can be
optimized. I think it would be better to optimize (guarantee the consistency)
as much as we can. If it cannot
github-actions[bot] opened a new pull request, #6426:
URL: https://github.com/apache/gravitino/pull/6426
### What changes were proposed in this pull request?
This PR changes the return value to `GenericFileset` for fileset operation.
### Why are the changes needed?
Previo
jerryshao closed pull request #6426: [#6409] fix(client-python): Change to use
`GenericFileset` for the return value of fileset catalog
URL: https://github.com/apache/gravitino/pull/6426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jerryshao closed issue #6409: [Bug report] `FilesetCatalog` in Python doesn't
return `GenericFileset`
URL: https://github.com/apache/gravitino/issues/6409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
justinmclean commented on PR #6412:
URL: https://github.com/apache/gravitino/pull/6412#issuecomment-2646798935
We use Spotless to make sure code is consistently formatted; you'll need to
run `./gradlew :core:spotlessApply` to fix the formatting error to get the
tests to pass.
--
This is
justinmclean commented on PR #6400:
URL: https://github.com/apache/gravitino/pull/6400#issuecomment-2646801033
There's some formatting issue with your PR, to make the tests pass you'll
need to run prettier with --write to format teh code correctly.
--
This is an automated message from
Abyss-lord commented on issue #6414:
URL: https://github.com/apache/gravitino/issues/6414#issuecomment-2646723233
I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
Abyss-lord commented on issue #6415:
URL: https://github.com/apache/gravitino/issues/6415#issuecomment-2646723519
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
FANNG1 commented on code in PR #5998:
URL: https://github.com/apache/gravitino/pull/5998#discussion_r1948293402
##
core/src/main/java/org/apache/gravitino/listener/api/event/AlterTagEvent.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
Abyss-lord commented on issue #6420:
URL: https://github.com/apache/gravitino/issues/6420#issuecomment-2646724697
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Abyss-lord commented on issue #6418:
URL: https://github.com/apache/gravitino/issues/6418#issuecomment-2646724246
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Abyss-lord commented on issue #6422:
URL: https://github.com/apache/gravitino/issues/6422#issuecomment-2646725171
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Abyss-lord commented on issue #6420:
URL: https://github.com/apache/gravitino/issues/6420#issuecomment-2646724565
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Abyss-lord commented on issue #6423:
URL: https://github.com/apache/gravitino/issues/6423#issuecomment-2646725311
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Abyss-lord commented on issue #6416:
URL: https://github.com/apache/gravitino/issues/6416#issuecomment-2646723718
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
FANNG1 commented on PR #5998:
URL: https://github.com/apache/gravitino/pull/5998#issuecomment-2646728106
Could you rebase the code, add tag related event(include tag failure event
and tag pre event) to the document,
https://github.com/apache/gravitino/blob/main/docs/gravitino-server-config.
Abyss-lord commented on issue #6419:
URL: https://github.com/apache/gravitino/issues/6419#issuecomment-2646724329
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Abyss-lord commented on issue #6417:
URL: https://github.com/apache/gravitino/issues/6417#issuecomment-2646724050
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Abyss-lord commented on issue #6421:
URL: https://github.com/apache/gravitino/issues/6421#issuecomment-2646724981
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Abyss-lord commented on issue #6424:
URL: https://github.com/apache/gravitino/issues/6424#issuecomment-2646725434
Hi, @justinmclean , I would like to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Abyss-lord commented on code in PR #6359:
URL: https://github.com/apache/gravitino/pull/6359#discussion_r1948304863
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteUser.java:
##
@@ -53,6 +53,10 @@ public DeleteUser(
public void handle() {
boolean del
yuqi1129 commented on code in PR #6211:
URL: https://github.com/apache/gravitino/pull/6211#discussion_r1948306285
##
core/src/main/java/org/apache/gravitino/authorization/AuthorizationUtils.java:
##
@@ -465,30 +471,72 @@ public static List getMetadataObjectLocation(
}
yuqi1129 commented on code in PR #6211:
URL: https://github.com/apache/gravitino/pull/6211#discussion_r1948306054
##
core/src/main/java/org/apache/gravitino/utils/NamespaceUtil.java:
##
@@ -107,6 +108,17 @@ public static Namespace ofFileset(String metalake, String
catalog, Stri
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 708b61055c [#6409] fix(client-python): Change to u
jerryshao merged PR #6410:
URL: https://github.com/apache/gravitino/pull/6410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
cherry-pick-branch-0.8-708b61055c196c2d7042b452d41de3f97092024f
in repository https://gitbox.apache.org/repos/asf/gravitino.git
at 9c3ec132be [#6409] fix(client-python): Change to use
jerryshao closed issue #6409: [Bug report] `FilesetCatalog` in Python doesn't
return `GenericFileset`
URL: https://github.com/apache/gravitino/issues/6409
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1948066100
##
clients/filesystem-fuse/Cargo.toml:
##
@@ -46,6 +47,7 @@ opendal = { version = "0.46.0", features = ["services-s3"] }
reqwest = { version = "0.12.9", features
unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1948066172
##
clients/filesystem-fuse/src/fuse_api_handle.rs:
##
@@ -53,7 +53,7 @@ impl FuseApiHandle {
}
}
-async fn get_modified_file_stat(
+pub asy
unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1948066319
##
clients/filesystem-fuse/src/fuse_api_handle_debug.rs:
##
@@ -0,0 +1,584 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1948066128
##
clients/filesystem-fuse/conf/gvfs_fuse.toml:
##
@@ -20,6 +20,7 @@
file_mask = 0o600
dir_mask = 0o700
fs_type = "memory"
+fuse_debug=true
Review Comment:
unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1948067099
##
clients/filesystem-fuse/src/fuse_api_handle_debug.rs:
##
@@ -0,0 +1,737 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
unknowntpo commented on code in PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#discussion_r1948066985
##
clients/filesystem-fuse/src/fuse_api_handle_debug.rs:
##
@@ -0,0 +1,584 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contri
unknowntpo commented on PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#issuecomment-2646184462
@diqiu50 Sorry I'm late, I've finished the modification, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
65 matches
Mail list logo