yuqi1129 commented on PR #2873: URL: https://github.com/apache/gravitino/pull/2873#issuecomment-2646824213
> I think you can do some fine-grained access control for the lock scope, rather than blindly wrapping the whole logic into one lock. For example, like "load fileset", you only need to lock the `doWithCatalog` operation, no need to lock the whole logic. For "create fileset", you can lock the catalog for property validation, and again lock the fileset for fileset creation. Can you please carefully check the code, and optimize them as possible as you can. @jerryshao I have encountered several code as following: <img width="1450" alt="image" src="https://github.com/user-attachments/assets/9abd5315-0a29-448b-8389-46ecf310684a"; /> Is this behavior acceptable? The consequence is complex and the goal of tree lock is to guarantee the behavior in the method is determinate. According to the code above, I have not seen the effect of the tree lock, and seems to be the same effect without any lock. Could you show your review on this point? If this is acceptable, I will take it and change many places accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
