yuqi1129 commented on code in PR #6405: URL: https://github.com/apache/gravitino/pull/6405#discussion_r1948363967
########## clients/filesystem-fuse/README.md: ########## @@ -0,0 +1,95 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino filesets to their local file system via Fuse, enabling access to Gravitino fileset files as if they were part of the local file system. + +## Features + +- Supports mounting S3 filesets. +- Supports basic file read and write operations. +- Supports directory operations +- Allows file attribute manipulation. + + +## Environment Setup and Build Instructions +### Prerequisites +- [fuse3 and libfuse3-dev](https://www.kernel.org/doc/html/next/filesystems/fuse.html) for Linux systems. Review Comment: Can these three software be installed on the machine directly? I suggest you add more sentence like 'you need to install the following software before you can use gvfs-fuse' or something similar. ########## clients/filesystem-fuse/README.md: ########## @@ -0,0 +1,95 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino filesets to their local file system via Fuse, enabling access to Gravitino fileset files as if they were part of the local file system. + +## Features + +- Supports mounting S3 filesets. +- Supports basic file read and write operations. +- Supports directory operations +- Allows file attribute manipulation. + + +## Environment Setup and Build Instructions +### Prerequisites +- [fuse3 and libfuse3-dev](https://www.kernel.org/doc/html/next/filesystems/fuse.html) for Linux systems. +- [macFUSE](https://macfuse.github.io) for macOS systems. +- [Rust](https://www.rust-lang.org) environment for compiling. + +### Build Process Review Comment: Build Process Only the first letter of the first word needs to be capitalized unless it's a proper noun. ditto ########## clients/filesystem-fuse/README.md: ########## @@ -0,0 +1,95 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino filesets to their local file system via Fuse, enabling access to Gravitino fileset files as if they were part of the local file system. + +## Features + +- Supports mounting S3 filesets. +- Supports basic file read and write operations. +- Supports directory operations +- Allows file attribute manipulation. + + +## Environment Setup and Build Instructions +### Prerequisites +- [fuse3 and libfuse3-dev](https://www.kernel.org/doc/html/next/filesystems/fuse.html) for Linux systems. +- [macFUSE](https://macfuse.github.io) for macOS systems. +- [Rust](https://www.rust-lang.org) environment for compiling. + +### Build Process +Navigate to the `client/filesystem-fuse` directory of the Gravitino project and execute the following commands: + +```shell +# Code verification +make check + +# Code formatting +make fmt + +# Building Gvfs-fuse +make +``` + +After building, the executable gvfs-fuse will be located in the target/debug directory. + +### Testing + +Run the following commands to execute tests: + +``` +# Run tests that do not depend on the S3 or Gravitino environment +make test + +# Run tests that depend on the S3 environment +make test-s3 + +# Run integration tests that depend on the Gravitino fileset environment +make test-fuse-it +``` + +## Usage Guide + +Navigate to the directory containing the executable and use the following commands to view help information Review Comment: ... the executable .. -> ...to executable binary... ########## clients/filesystem-fuse/README.md: ########## @@ -0,0 +1,95 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino filesets to their local file system via Fuse, enabling access to Gravitino fileset files as if they were part of the local file system. + +## Features + +- Supports mounting S3 filesets. +- Supports basic file read and write operations. +- Supports directory operations +- Allows file attribute manipulation. + + +## Environment Setup and Build Instructions Review Comment: Environment Setup and Build Instructions -> Environment setup and build instructions ########## clients/filesystem-fuse/README.md: ########## @@ -0,0 +1,95 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +# Gvfs-fuse + +Gvfs-fuse is the Fuse client for Gravitino fileset. It allows users to mount Gravitino filesets to their local file system via Fuse, enabling access to Gravitino fileset files as if they were part of the local file system. + +## Features + +- Supports mounting S3 filesets. +- Supports basic file read and write operations. +- Supports directory operations +- Allows file attribute manipulation. + + +## Environment Setup and Build Instructions +### Prerequisites +- [fuse3 and libfuse3-dev](https://www.kernel.org/doc/html/next/filesystems/fuse.html) for Linux systems. +- [macFUSE](https://macfuse.github.io) for macOS systems. +- [Rust](https://www.rust-lang.org) environment for compiling. + +### Build Process +Navigate to the `client/filesystem-fuse` directory of the Gravitino project and execute the following commands: + +```shell +# Code verification +make check + +# Code formatting +make fmt + +# Building Gvfs-fuse +make +``` + +After building, the executable gvfs-fuse will be located in the target/debug directory. Review Comment: After building the source, the executable `gvfs-fuse` binary... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
