Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-15 Thread via GitHub
diqiu50 commented on code in PR #5835: URL: https://github.com/apache/gravitino/pull/5835#discussion_r1886089430 ## clients/filesystem-fuse/src/filesystem.rs: ## @@ -0,0 +1,236 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license

Re: [PR] [#5846] build(dev): Add support for JDBC SQL standard authorization [gravitino]

2024-12-15 Thread via GitHub
xunliu commented on code in PR #5849: URL: https://github.com/apache/gravitino/pull/5849#discussion_r1886138164 ## docs/docker-image-details.md: ## @@ -168,6 +168,10 @@ Changelog You can use this kind of image to test the catalog of Apache Hive. Changelog + +- apache/graviti

[PR] [Minor] Add support for topic and fileset in set owner in Gravitino CLI [gravitino]

2024-12-15 Thread via GitHub
justinmclean opened a new pull request, #5870: URL: https://github.com/apache/gravitino/pull/5870 ### What changes were proposed in this pull request? Add support for topic and fileset in set owner in Gravitino CLI ### Why are the changes needed? these entities can also h

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544455369 @justinmclean @tengqm Another concern is the frequent issues with changing error messages. The root cause of this lies in parameter validation not being performed before executi

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
tengqm commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544502236 > Personally, I would like to combine Justin's switch/case logic(https://github.com/apache/gravitino/pull/5793 ) with a unified approach to argument validation. 100% support

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544577692 Yep there is no need to check for metalake, as that is already done in the above code. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544576417 This is what is would look like. Add a verify method to the base `Command` class and a few common checkers. ``` public Command verify() { return this;

Re: [PR] [#3888] Metadata Support ClickHouse [gravitino]

2024-12-15 Thread via GitHub
flaming-archer commented on code in PR #5819: URL: https://github.com/apache/gravitino/pull/5819#discussion_r1886088912 ## catalogs/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operation/ClickHouseTableOperations.java: ## @@ -0,0 +1,730 @@ +/* +

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-15 Thread via GitHub
diqiu50 commented on code in PR #5835: URL: https://github.com/apache/gravitino/pull/5835#discussion_r1886088375 ## clients/filesystem-fuse/src/filesystem.rs: ## @@ -32,33 +32,33 @@ pub(crate) type Result = std::result::Result; #[async_trait] pub(crate) trait RawFileSystem: Se

[I] [FEATURE] Support Hbase catalog [gravitino]

2024-12-15 Thread via GitHub
flaming-archer opened a new issue, #5865: URL: https://github.com/apache/gravitino/issues/5865 ### Describe the feature Support Hbase catalog ### Motivation Our company needs to manage HBase. Perhaps I might go and implement it. I open an issue first.

Re: [I] [FEATURE] Support Custom Token Service Endpoint for S3 [gravitino]

2024-12-15 Thread via GitHub
FANNG1 closed issue #5839: [FEATURE] Support Custom Token Service Endpoint for S3 URL: https://github.com/apache/gravitino/issues/5839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

(gravitino) branch main updated: [#5839] feat(core): support custom STS Endpoint for AWS S3 (#5801)

2024-12-15 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 7a8b09002 [#5839] feat(core): support custom STS E

Re: [PR] [#5839] feat(core): support custom STS Endpoint for AWS S3 [gravitino]

2024-12-15 Thread via GitHub
FANNG1 merged PR #5801: URL: https://github.com/apache/gravitino/pull/5801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [PR] [#5867] feat(flink-connector) Improve flink connector [gravitino]

2024-12-15 Thread via GitHub
sunxiaojian commented on PR #5868: URL: https://github.com/apache/gravitino/pull/5868#issuecomment-2544556308 @xunliu @coolderli PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544562965 My concern is that @jerryshao would prefer a different approach and it does add a lot of complexity, new methods and new objects. A better way, I think, would be to add a veri

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544655065 > Yep there is no need to check for metalake in the above code, as that is already done, and there is probably no need to check for catalog as name must have a value at this poi

Re: [PR] [#5790] auth(chain): Chain authorization properties [gravitino]

2024-12-15 Thread via GitHub
mchades commented on code in PR #5791: URL: https://github.com/apache/gravitino/pull/5791#discussion_r1886083415 ## authorizations/authorization-ranger/src/main/java/org/apache/gravitino/authorization/ranger/RangerAuthorizationProperties.java: ## @@ -0,0 +1,74 @@ +/* + * License

[I] [FEATURE] Support CK permission control [gravitino]

2024-12-15 Thread via GitHub
flaming-archer opened a new issue, #5866: URL: https://github.com/apache/gravitino/issues/5866 ### Describe the feature Our company needs to manage CK permission control. Perhaps I might go and implement it. I open an issue first. ### Motivation _No resp

[I] [FEATURE] Improve flink connector [gravitino]

2024-12-15 Thread via GitHub
sunxiaojian opened a new issue, #5867: URL: https://github.com/apache/gravitino/issues/5867 ### Describe the feature This is mainly to optimize the Flink connector so that when adding other catalogs in the future, there will be no changes to the store ### Motivation _No

[PR] [Minor] Fix list column output in Gravitino CLI [gravitino]

2024-12-15 Thread via GitHub
justinmclean opened a new pull request, #5871: URL: https://github.com/apache/gravitino/pull/5871 ### What changes were proposed in this pull request? Stop an error line being output in list columns CLI command. ### Why are the changes needed? It should not display an err

Re: [PR] [#5846] build(dev): Add support for JDBC SQL standard authorization [gravitino]

2024-12-15 Thread via GitHub
jerqi commented on code in PR #5849: URL: https://github.com/apache/gravitino/pull/5849#discussion_r1886254867 ## docs/docker-image-details.md: ## @@ -168,6 +168,10 @@ Changelog You can use this kind of image to test the catalog of Apache Hive. Changelog + +- apache/gravitin

Re: [PR] [#5624] feat(bundles): support ADLS credential provider [gravitino]

2024-12-15 Thread via GitHub
FANNG1 commented on PR #5737: URL: https://github.com/apache/gravitino/pull/5737#issuecomment-2544741800 > Hi @FANNG1, This PR is ready for review. Please take a look when you have time. > > Regarding the SAS path token failure issue: please verify if your storage account supports AD

Re: [PR] [#5846] build(dev): Add support for JDBC SQL standard authorization [gravitino]

2024-12-15 Thread via GitHub
xunliu commented on code in PR #5849: URL: https://github.com/apache/gravitino/pull/5849#discussion_r1886272971 ## dev/docker/hive/hive-site-for-jdbc.xml: ## Review Comment: `for-jdbc` is a confusing name, what's mean is `for-jdbc`? change to `for-sqlBaseAuth`? or `for-s

Re: [PR] [#5846] build(dev): Add support for JDBC SQL standard authorization [gravitino]

2024-12-15 Thread via GitHub
jerqi commented on code in PR #5849: URL: https://github.com/apache/gravitino/pull/5849#discussion_r1886289536 ## dev/docker/hive/start.sh: ## @@ -39,6 +39,12 @@ cp -f ${HADOOP_TMP_CONF_DIR}/* ${HADOOP_CONF_DIR} cp -f ${HIVE_TMP_CONF_DIR}/* ${HIVE_CONF_DIR} sed -i "s/__REPLACE

Re: [PR] [#5846] build(dev): Add support for JDBC SQL standard authorization [gravitino]

2024-12-15 Thread via GitHub
jerqi commented on code in PR #5849: URL: https://github.com/apache/gravitino/pull/5849#discussion_r1886294667 ## dev/docker/hive/hiveserver2-site-for-jdbc.xml: ## Review Comment: Renamed. I use `for-sql-base-auth`. -- This is an automated message from the Apache Git Se

Re: [PR] [#5846] build(dev): Add support for JDBC SQL standard authorization [gravitino]

2024-12-15 Thread via GitHub
jerqi commented on code in PR #5849: URL: https://github.com/apache/gravitino/pull/5849#discussion_r1886295139 ## dev/docker/hive/start.sh: ## @@ -39,6 +39,12 @@ cp -f ${HADOOP_TMP_CONF_DIR}/* ${HADOOP_CONF_DIR} cp -f ${HIVE_TMP_CONF_DIR}/* ${HIVE_CONF_DIR} sed -i "s/__REPLACE

Re: [PR] [#5846] build(dev): Add support for JDBC SQL standard authorization [gravitino]

2024-12-15 Thread via GitHub
jerqi commented on code in PR #5849: URL: https://github.com/apache/gravitino/pull/5849#discussion_r1886294950 ## dev/docker/hive/hive-site-for-jdbc.xml: ## Review Comment: Renamed. I use `for-sql-base-auth`. -- This is an automated message from the Apache Git Service.

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885627914 ## spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/paimon/SparkPaimonTable.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache S

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885659209 ## spark-connector/spark-common/src/test/java/org/apache/gravitino/spark/connector/integration/test/paimon/SparkPaimonCatalogIT.java: ## @@ -0,0 +1,119 @@ +/* + * Li

[PR] [#5830] fix(client): add error handling for no tag in cli. [gravitino]

2024-12-15 Thread via GitHub
LindaSummer opened a new pull request, #5857: URL: https://github.com/apache/gravitino/pull/5857 ### What changes were proposed in this pull request? Add error handle with a friendly output for no tags command line. ### Why are the changes needed? Now it throws an excepti

[PR] [#4732] feat(paimon-spark-connector): Support jdbc backend catalog in paimon spark3.3 connector [gravitino]

2024-12-15 Thread via GitHub
caican00 opened a new pull request, #5859: URL: https://github.com/apache/gravitino/pull/5859 ### What changes were proposed in this pull request? Support jdbc backend catalog in paimon spark3.3 connector. Will add support for paimon spark3.4 and spark3.5 in a new pr. ###

Re: [I] [Subtask] Add skeleton IT code for paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 closed issue #4716: [Subtask] Add skeleton IT code for paimon spark connector URL: https://github.com/apache/gravitino/issues/4716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord opened a new issue, #5861: URL: https://github.com/apache/gravitino/issues/5861 ### What would you like to be improved? Current Issues 1. The `executeCommand` method contains a large number of if-else structures, which leads to poor readability and scalability. 2. The

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885546473 ## catalogs/catalog-common/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonPropertiesUtils.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

[I] [Improvement] Make the entity and command options case-insensitive [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord opened a new issue, #5853: URL: https://github.com/apache/gravitino/issues/5853 ### What would you like to be improved? At present, the requirement for entities to be entered in lowercase is not user-friendly. For instance, when I input "Metalake," the system returns an "U

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885562828 ## spark-connector/spark-common/build.gradle.kts: ## @@ -123,6 +130,9 @@ dependencies { exclude("org.glassfish.jersey.inject") } testImplementation("org.

Re: [I] [Improvement] Make the entity and command options case-insensitive [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on issue #5853: URL: https://github.com/apache/gravitino/issues/5853#issuecomment-2543707666 @justinmclean I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [Improvement] Setting a tag property in the Gravitino CLi give anexpected output [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on issue #5831: URL: https://github.com/apache/gravitino/issues/5831#issuecomment-2543712086 I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[I] [Subtask] Support hive catalog backend for paimon spark3.4 and spark3.5 [gravitino]

2024-12-15 Thread via GitHub
caican00 opened a new issue, #5854: URL: https://github.com/apache/gravitino/issues/5854 ### Describe the subtask Support hive catalog backend for paimon spark3.4 and spark3.5 ### Parent issue https://github.com/apache/gravitino/issues/4733 -- This is an automated mess

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885627069 ## spark-connector/spark-common/src/test/java/org/apache/gravitino/spark/connector/integration/test/SparkCommonIT.java: ## @@ -484,7 +487,7 @@ void testAlterTableRen

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885627914 ## spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/paimon/SparkPaimonTable.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache S

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885562828 ## spark-connector/spark-common/build.gradle.kts: ## @@ -123,6 +130,9 @@ dependencies { exclude("org.glassfish.jersey.inject") } testImplementation("org.

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2543854637 Hi, @justinmclean @tengqm @xunliu @jerryshao , could you plz help to see if this design is reasonable when you have some time. -- This is an automated message from the Apach

[PR] Print Help information when the help option is passed [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord opened a new pull request, #5852: URL: https://github.com/apache/gravitino/pull/5852 ### What changes were proposed in this pull request? This is a small improvement, previously, typing `entity help` will displays the help information for that entity. Now, the `enti

Re: [PR] Print Help information when the help option is passed [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on PR #5852: URL: https://github.com/apache/gravitino/pull/5852#issuecomment-2543635047 Hi @justinmclean @xunliu, would you mind reviewing my code when you have a moment? -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[PR] [#4720] feat(paimon-spark-connector): Support time travel for paimon tables in spark queries [gravitino]

2024-12-15 Thread via GitHub
caican00 opened a new pull request, #5862: URL: https://github.com/apache/gravitino/pull/5862 ### What changes were proposed in this pull request? Support time travel for paimon tables in spark queries ### Why are the changes needed? Fix: https://github.com/apache/graviti

[PR] [#4724] feat(paimon-spark-connector): Support paimon metadata columns for spark conenctor [gravitino]

2024-12-15 Thread via GitHub
caican00 opened a new pull request, #5863: URL: https://github.com/apache/gravitino/pull/5863 ### What changes were proposed in this pull request? Support paimon metadata columns for spark conenctor ### Why are the changes needed? Fix: https://github.com/apache/gravit

[PR] [#4731] feat(paimon-spark-conenctor): Support delete, update and mergeInto paimon table in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 opened a new pull request, #5864: URL: https://github.com/apache/gravitino/pull/5864 ### What changes were proposed in this pull request? Support delete, update and mergeInto paimon table in paimon spark connector ### Why are the changes needed? Fix: https://gith

Re: [PR] [#4717] feat(paimon-spark-connector): support basic table DDl and DML operations for paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 closed pull request #5723: [#4717] feat(paimon-spark-connector): support basic table DDl and DML operations for paimon spark connector URL: https://github.com/apache/gravitino/pull/5723 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885633091 ## spark-connector/spark-common/src/test/java/org/apache/gravitino/spark/connector/integration/test/paimon/SparkPaimonCatalogIT.java: ## @@ -0,0 +1,119 @@ +/* + * Li

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on PR #5722: URL: https://github.com/apache/gravitino/pull/5722#issuecomment-2543749276 > LGTM, just minor comments. Besides, do you plan to add HIVE and JDBC catalog backend IT? >> do you plan to add HIVE and JDBC catalog backend IT i will implememt these in

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885644709 ## catalogs/catalog-common/src/main/java/org/apache/gravitino/catalog/lakehouse/paimon/PaimonPropertiesUtils.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885642551 ## spark-connector/spark-common/src/test/java/org/apache/gravitino/spark/connector/integration/test/paimon/SparkPaimonCatalogIT.java: ## @@ -0,0 +1,119 @@ +/* + * Li

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on code in PR #5722: URL: https://github.com/apache/gravitino/pull/5722#discussion_r1885633091 ## spark-connector/spark-common/src/test/java/org/apache/gravitino/spark/connector/integration/test/paimon/SparkPaimonCatalogIT.java: ## @@ -0,0 +1,119 @@ +/* + * Li

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
tengqm commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544268639 Yes. My favorite is the simple naive implementation using switch/case statements. One key design consideration, in my view, is to make the code as straightforward as possible.

Re: [PR] [#5822] Print Help information when the help option is passed [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on PR #5852: URL: https://github.com/apache/gravitino/pull/5852#issuecomment-2544275488 > The help files have already been added in PR #5809 ok @justinmclean , than I just change the code and delete the help file -- This is an automated message from the Apache G

Re: [PR] [#5825] improvement(CLI): Update the error message for creating a metalake when the required parameter is missing. [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on PR #5851: URL: https://github.com/apache/gravitino/pull/5851#issuecomment-2544280099 Hi @justinmclean , plz review this pr again, I just change the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] [#5822] Print Help information when the help option is passed [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on PR #5852: URL: https://github.com/apache/gravitino/pull/5852#issuecomment-2544289913 Hi @justinmclean, I just remove those help files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] [Improvement] Make the entity and arguments case-insensitive [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord closed issue #5853: [Improvement] Make the entity and arguments case-insensitive URL: https://github.com/apache/gravitino/issues/5853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [I] [Improvement] Make the entity and arguments case-insensitive [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on issue #5853: URL: https://github.com/apache/gravitino/issues/5853#issuecomment-2544293047 > In general CLI commands are all lower case see https://clig.dev/#naming see "Use only lowercase letters,..." @justinmclean Should we provide some assistance information

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544297868 > I proposed a similar solution in PR #5688 @jerryshao thought that building command maps was too heavy. There is an outstanding PR to remove some of the if/else logic and use s

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
caican00 commented on PR #5722: URL: https://github.com/apache/gravitino/pull/5722#issuecomment-2544303792 comments have been addressed. cc @FANNG1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [Draft][#4309] feat(core): support tag events for event listener [gravitino]

2024-12-15 Thread via GitHub
jerryshao commented on code in PR #5847: URL: https://github.com/apache/gravitino/pull/5847#discussion_r1886029265 ## api/src/main/java/org/apache/gravitino/SupportsTags.java: ## @@ -17,11 +17,12 @@ * under the License. */ -package org.apache.gravitino.tag; +package org.ap

Re: [PR] [#5822] Print Help information when the help option is passed [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on PR #5852: URL: https://github.com/apache/gravitino/pull/5852#issuecomment-2544217903 The help files have already been added in PR #5809 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Improvement] Make the entity and arguments case-insensitive [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on issue #5853: URL: https://github.com/apache/gravitino/issues/5853#issuecomment-2544220697 In general CLI commands are all lower case see https://clig.dev/#naming see "Use only lowercase letters,..." -- This is an automated message from the Apache Git Service. To

Re: [PR] [#5830] fix(client): add error handling for no tag in cli. [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on code in PR #5857: URL: https://github.com/apache/gravitino/pull/5857#discussion_r1885983613 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateTag.java: ## @@ -52,11 +52,17 @@ public CreateTag( /** Create tags. */ @Override pu

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544238033 I proposed a similar solution in PR #5688 @jerryshao thought that building command maps was too heavy. There is an outstanding PR to remove some of the if/else logic and use

Re: [PR] [#5830] fix(client): add error handling for no tag in cli. [gravitino]

2024-12-15 Thread via GitHub
LindaSummer commented on code in PR #5857: URL: https://github.com/apache/gravitino/pull/5857#discussion_r1885991713 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateTag.java: ## @@ -52,11 +52,17 @@ public CreateTag( /** Create tags. */ @Override pub

Re: [PR] [#5830] fix(client): add error handling for no tag in cli. [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on code in PR #5857: URL: https://github.com/apache/gravitino/pull/5857#discussion_r1885993061 ## clients/cli/src/main/java/org/apache/gravitino/cli/commands/CreateTag.java: ## @@ -52,11 +52,17 @@ public CreateTag( /** Create tags. */ @Override pu

Re: [PR] [#5825] improvement(CLI): Update the error message for creating a metalake when the required parameter is missing. [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on code in PR #5851: URL: https://github.com/apache/gravitino/pull/5851#discussion_r1885900795 ## clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java: ## @@ -174,6 +176,10 @@ private void handleMetalakeCommand() { } else if (C

Re: [I] [Improvement] Make the entity and arguments case-insensitive [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on issue #5853: URL: https://github.com/apache/gravitino/issues/5853#issuecomment-2544415281 I really don't think a user would use mixed case, or if they did, it would be very very rare. If you want, feel free to convert the command and entity passed in to lowercase.

(gravitino) branch main updated: [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector (#5722)

2024-12-15 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 873217554 [#4722] feat(paimon-spark-connector): su

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
FANNG1 merged PR #5722: URL: https://github.com/apache/gravitino/pull/5722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [I] [Subtask] support basic schema DDL for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
FANNG1 closed issue #4722: [Subtask] support basic schema DDL for GravitinoPaimonCatalog in paimon spark connector URL: https://github.com/apache/gravitino/issues/4722 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] [#4722] feat(paimon-spark-connector): support schema and table DDL and table DML for GravitinoPaimonCatalog in paimon spark connector [gravitino]

2024-12-15 Thread via GitHub
FANNG1 commented on PR #5722: URL: https://github.com/apache/gravitino/pull/5722#issuecomment-2544491108 merged to main, thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [#3888] Metadata Support ClickHouse [gravitino]

2024-12-15 Thread via GitHub
flaming-archer commented on code in PR #5819: URL: https://github.com/apache/gravitino/pull/5819#discussion_r1886085849 ## catalogs/catalog-jdbc-clickhouse/src/main/java/org/apache/gravitino/catalog/clickhouse/operation/ClickHouseDatabaseOperations.java: ## @@ -0,0 +1,80 @@ +/*

Re: [PR] [#5839] feat(core): support custom STS Endpoint for AWS S3 [gravitino]

2024-12-15 Thread via GitHub
FANNG1 commented on PR #5801: URL: https://github.com/apache/gravitino/pull/5801#issuecomment-2544452473 Thanks @hienduyph for your work and @tengqm for your review ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] [#5867] feat(flink-connector) Improve flink connector [gravitino]

2024-12-15 Thread via GitHub
sunxiaojian opened a new pull request, #5868: URL: https://github.com/apache/gravitino/pull/5868 ### Why are the changes needed? (Please clarify why the changes are needed. For instance, 1. If you propose a new API, clarify the use case for a new API. 2. If you fix a bug,

(gravitino) branch branch-gvfs-fuse-dev updated: [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout (#5835)

2024-12-15 Thread fanng
This is an automated email from the ASF dual-hosted git repository. fanng pushed a commit to branch branch-gvfs-fuse-dev in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/branch-gvfs-fuse-dev by this push: new b238873df [#5734]

Re: [PR] [#5734] feat (gvfs-fuse): Gvfs-fuse basic FUSE-level implementation and code structure layout [gravitino]

2024-12-15 Thread via GitHub
FANNG1 merged PR #5835: URL: https://github.com/apache/gravitino/pull/5835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino

Re: [I] [Subtask] Gvfs-fuse basic FUSE-level implementation and code structure layout. [gravitino]

2024-12-15 Thread via GitHub
FANNG1 closed issue #5734: [Subtask] Gvfs-fuse basic FUSE-level implementation and code structure layout. URL: https://github.com/apache/gravitino/issues/5734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
xunliu commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544537091 > Personally, I would like to combine Justin's switch/case logic(https://github.com/apache/gravitino/pull/5793 ) with a unified approach to argument validation. I think it ok

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544573558 > My concern is that @jerryshao would prefer a different approach and it does add a lot of complexity, new methods and new objects. A better way, I think, would be to add a veri

Re: [I] [Improvement] Refactor the code for the role command. [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on issue #5861: URL: https://github.com/apache/gravitino/issues/5861#issuecomment-2544660740 We would need to throw an exception so that no code in handle is called. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[I] Implement the Java client API for model catalog. [gravitino]

2024-12-15 Thread via GitHub
jerryshao opened a new issue, #5872: URL: https://github.com/apache/gravitino/issues/5872 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] [#5808] fix(CLI): Fix improper exception throwing When a malformed name is passed to the CLI command [gravitino]

2024-12-15 Thread via GitHub
justinmclean commented on PR #5836: URL: https://github.com/apache/gravitino/pull/5836#issuecomment-2544679226 There still a pending comment that needs to be address before this can be merged. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] [#5825] improvement(CLI): Update the error message for creating a metalake when the required parameter is missing. [gravitino]

2024-12-15 Thread via GitHub
justinmclean merged PR #5851: URL: https://github.com/apache/gravitino/pull/5851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gra

Re: [I] [Improvement] If no metalake is specified an obscure error is displayed in the Gravitino CLI [gravitino]

2024-12-15 Thread via GitHub
justinmclean closed issue #5825: [Improvement] If no metalake is specified an obscure error is displayed in the Gravitino CLI URL: https://github.com/apache/gravitino/issues/5825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [I] [Improvement] If no metalake is specified an obscure error is displayed in the Gravitino CLI [gravitino]

2024-12-15 Thread via GitHub
justinmclean closed issue #5825: [Improvement] If no metalake is specified an obscure error is displayed in the Gravitino CLI URL: https://github.com/apache/gravitino/issues/5825 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

(gravitino) branch main updated: [#5825] improvement(CLI): Update the error message for creating a metalake when the required parameter is missing. (#5851)

2024-12-15 Thread jmclean
This is an automated email from the ASF dual-hosted git repository. jmclean pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new fe0712846 [#5825] improvement(CLI): Update the e

Re: [PR] [#5808] fix(CLI): Fix improper exception throwing When a malformed name is passed to the CLI command [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on PR #5836: URL: https://github.com/apache/gravitino/pull/5836#issuecomment-2544688150 > There are still two pending review comments that need to be addressed before this can be merged. Hi, @justinmclean I just resolved all the comments, plz check again, thank y

Re: [PR] [#5790] auth(chain): Chain authorization properties [gravitino]

2024-12-15 Thread via GitHub
xunliu commented on code in PR #5791: URL: https://github.com/apache/gravitino/pull/5791#discussion_r1886233104 ## core/src/test/java/org/apache/gravitino/connector/authorization/mysql/TestMySQLAuthorization.java: ## @@ -26,9 +26,11 @@ public class TestMySQLAuthorization extends

Re: [I] [Improvement] Don't thow execption when table name is unknown in Gravitino CLI command [gravitino]

2024-12-15 Thread via GitHub
Abyss-lord commented on issue #5824: URL: https://github.com/apache/gravitino/issues/5824#issuecomment-2544720739 I would like to work on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s