jerryshao commented on code in PR #5847: URL: https://github.com/apache/gravitino/pull/5847#discussion_r1886029265
########## api/src/main/java/org/apache/gravitino/SupportsTags.java: ########## @@ -17,11 +17,12 @@ * under the License. */ -package org.apache.gravitino.tag; +package org.apache.gravitino; import org.apache.gravitino.annotation.Evolving; import org.apache.gravitino.exceptions.NoSuchTagException; import org.apache.gravitino.exceptions.TagAlreadyAssociatedException; +import org.apache.gravitino.tag.Tag; Review Comment: I think you can have two options: 1) No need to use dispatcher pattern, just implement the listener logic in `TagManager`. 2) To refer to `PatitionDispatcher`, just add the methods in this `TagDispatcher` interface, no need to have another `SupportsXXX` interface. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
