xunliu commented on code in PR #5849:
URL: https://github.com/apache/gravitino/pull/5849#discussion_r1886272971
##########
dev/docker/hive/hive-site-for-jdbc.xml:
##########
Review Comment:
`for-jdbc` is a confusing name, what's mean is `for-jdbc`?
change to `for-sqlBaseAuth`? or `for-sql-base-auth`?
##########
dev/docker/hive/start.sh:
##########
@@ -39,6 +39,12 @@ cp -f ${HADOOP_TMP_CONF_DIR}/* ${HADOOP_CONF_DIR}
cp -f ${HIVE_TMP_CONF_DIR}/* ${HIVE_CONF_DIR}
sed -i "s/__REPLACE__HOST_NAME/$(hostname)/g" ${HADOOP_CONF_DIR}/core-site.xml
sed -i "s/__REPLACE__HOST_NAME/$(hostname)/g" ${HADOOP_CONF_DIR}/hdfs-site.xml
+
+if [[ -n "${ENABLE_JDBC_AUTHORIZATION}" ]]; then
Review Comment:
Change `ENABLE_JDBC_AUTHORIZATION` to `ENABLE_SQLBASE_AUTHORIZATION `?
anothe questiong, Will `ENABLE_JDBC_AUTHORIZATION` and
`RANGER_HIVE_REPOSITORY_NAME, xxx` conflict??
##########
dev/docker/hive/hiveserver2-site-for-jdbc.xml:
##########
Review Comment:
`for-jdbc` is a confusing name, what's mean is `for-jdbc`?
change to `for-sqlBaseAuth`? or `for-sql-base-auth`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
