[PR] [#5061] Basic user and group CLI [gravitino]

2024-10-14 Thread via GitHub
justinmclean opened a new pull request, #5133: URL: https://github.com/apache/gravitino/pull/5133 ### What changes were proposed in this pull request? Added basic user and group commands. ### Why are the changes needed? For the CLI to support users and groups.

Re: [PR] [#5061] Basic user and group CLI [gravitino]

2024-10-14 Thread via GitHub
justinmclean commented on PR #5133: URL: https://github.com/apache/gravitino/pull/5133#issuecomment-2412496423 I am waiting on #5057 and #5059 to be merged, so those PRs changes are included. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1800302418 ## api/src/main/java/org/apache/gravitino/credential/CredentialConstants.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

(gravitino) branch main updated: [#4992] support credential vending framework (#4995)

2024-10-14 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 53bd22713 [#4992] support credential vending frame

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
jerryshao merged PR #4995: URL: https://github.com/apache/gravitino/pull/4995 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [I] [Subtask] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
jerryshao closed issue #4992: [Subtask] support credential vending framework URL: https://github.com/apache/gravitino/issues/4992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800368627 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -72,10 +71,11 @@ public class HadoopCatalogOpera

Re: [PR] [#4867] feat(core): Add storage support for columns in Gravitino [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5078: URL: https://github.com/apache/gravitino/pull/5078#discussion_r1800351958 ## core/src/main/java/org/apache/gravitino/storage/relational/service/TableColumnMetaService.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Foun

Re: [PR] [#3973] improvement(core):support audit log [gravitino]

2024-10-14 Thread via GitHub
hanwxx commented on PR #4575: URL: https://github.com/apache/gravitino/pull/4575#issuecomment-2412737315 > > > I kind of agree with @hanwxx , AuditLog and event are two things, we don't have to use interface to put them together. Using a converter to bridge them together without hard combin

Re: [PR] [#3973] improvement(core):support audit log [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #4575: URL: https://github.com/apache/gravitino/pull/4575#discussion_r1800341207 ## core/src/main/java/org/apache/gravitino/Configs.java: ## @@ -342,4 +342,31 @@ private Configs() {} .stringConf() .toSequence() .cre

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800373780 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -119,26 +123,22 @@ public void initialize( M

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
yuqi1129 commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800377602 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -72,10 +71,11 @@ public class HadoopCatalogOperat

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
yuqi1129 commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800379555 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -119,26 +123,22 @@ public void initialize( Ma

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800384620 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -742,4 +742,44 @@ private boolean checkSingleFile(F

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
yuqi1129 commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800383266 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -72,10 +71,11 @@ public class HadoopCatalogOperat

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800383635 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -742,4 +742,44 @@ private boolean checkSingleFile(F

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
yuqi1129 commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800388253 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -742,4 +742,44 @@ private boolean checkSingleFile(Fi

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800389410 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -742,4 +742,44 @@ private boolean checkSingleFile(F

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800393954 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -742,4 +742,44 @@ private boolean checkSingleFile(F

Re: [PR] [MINOR] Shrink the flink-connector-runtime jar [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on PR #4819: URL: https://github.com/apache/gravitino/pull/4819#issuecomment-2412808204 Could you update the PR title to add the shrink info like `shrink from xxM to xxM`? and paste the related dependence jars in the comment like https://github.com/apache/gravitino/pull/45

Re: [PR] [#4951] improvement(test): Reduce fields shares between different IT to make AbstractIT more independent. [gravitino]

2024-10-14 Thread via GitHub
diqiu50 commented on code in PR #4996: URL: https://github.com/apache/gravitino/pull/4996#discussion_r1800395623 ## trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryITBase.java: ## @@ -68,14 +68,17 @@ public class Tri

svn commit: r72329 - /release/incubator/gravitino/KEYS

2024-10-14 Thread mchades
Author: mchades Date: Tue Oct 15 06:14:18 2024 New Revision: 72329 Log: Update KEYS Modified: release/incubator/gravitino/KEYS Modified: release/incubator/gravitino/KEYS == --- release/incubator/gravitino/KEYS (origi

Re: [PR] [MINOR] Shrink the flink-connector-runtime lib size from 84MB to 16MB [gravitino]

2024-10-14 Thread via GitHub
coolderli commented on PR #4819: URL: https://github.com/apache/gravitino/pull/4819#issuecomment-241247 @FANNG1 I can't find a way to print the dependent jar in the connector jar. Here are the dependencies. ``` Pro

Re: [I] [Bug report] Display users Java API on playground fails [gravitino]

2024-10-14 Thread via GitHub
jerqi commented on issue #5132: URL: https://github.com/apache/gravitino/issues/5132#issuecomment-2412977078 What's your Gravitino client version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [Bug report] Display users Java API on playground fails [gravitino]

2024-10-14 Thread via GitHub
jerqi commented on issue #5132: URL: https://github.com/apache/gravitino/issues/5132#issuecomment-2412987912 Playground uses 0.6.0. We supports `list roles` in 0.6.1 and 0.7.0. It's expected behaviour. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800542923 ## core/src/main/java/org/apache/gravitino/listener/EventListenerPluginWrapper.java: ## @@ -68,13 +70,40 @@ public void onPostEvent(Event event) { userEventList

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800543905 ## core/src/main/java/org/apache/gravitino/listener/api/EventListenerPlugin.java: ## @@ -95,17 +97,29 @@ enum Mode { void stop() throws RuntimeException; /** -

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800543570 ## core/src/main/java/org/apache/gravitino/listener/api/EventListenerPlugin.java: ## @@ -95,17 +97,29 @@ enum Mode { void stop() throws RuntimeException; /** -

Re: [PR] [#3919] feat(catalog-lakehouse-paimon): Support hive backend for Paimon Catalog [gravitino]

2024-10-14 Thread via GitHub
caican00 commented on PR #5092: URL: https://github.com/apache/gravitino/pull/5092#issuecomment-2413044328 > Could you add related document in this PR? updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] [#3919] feat(catalog-lakehouse-paimon): Support hive backend for Paimon Catalog [gravitino]

2024-10-14 Thread via GitHub
caican00 commented on code in PR #5092: URL: https://github.com/apache/gravitino/pull/5092#discussion_r1800558751 ## catalogs/catalog-lakehouse-paimon/build.gradle.kts: ## @@ -46,7 +46,6 @@ dependencies { exclude("com.sun.jersey") exclude("javax.servlet") exclude(

Re: [PR] [#3919] feat(catalog-lakehouse-paimon): Support hive backend for Paimon Catalog [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #5092: URL: https://github.com/apache/gravitino/pull/5092#discussion_r1800561650 ## docs/lakehouse-paimon-catalog.md: ## @@ -22,38 +22,40 @@ Builds with Apache Paimon `0.8.0`. ### Catalog capabilities -- Works as a catalog proxy, supporting `F

Re: [I] [Subtask] Create a role, delete a role and recreate a role, it will throw an exception [gravitino]

2024-10-14 Thread via GitHub
jerqi closed issue #5129: [Subtask] Create a role, delete a role and recreate a role, it will throw an exception URL: https://github.com/apache/gravitino/issues/5129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] [Subtask] Create a role, delete a role and recreate a role, it will throw an exception [gravitino]

2024-10-14 Thread via GitHub
jerqi commented on issue #5129: URL: https://github.com/apache/gravitino/issues/5129#issuecomment-2412701098 Because I modify the policy parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [MINOR] Shrink the flink-connector-runtime jar [gravitino]

2024-10-14 Thread via GitHub
coolderli commented on PR #4819: URL: https://github.com/apache/gravitino/pull/4819#issuecomment-2412696615 @FANNG1 @mchades Please help review this, Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800413669 ## core/src/main/java/org/apache/gravitino/listener/api/EventListenerPlugin.java: ## @@ -95,17 +97,29 @@ enum Mode { void stop() throws RuntimeException; /*

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
yuqi1129 commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800416046 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -742,4 +742,44 @@ private boolean checkSingleFile(Fi

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800411737 ## core/src/main/java/org/apache/gravitino/listener/EventBus.java: ## @@ -64,7 +73,15 @@ public void dispatchEvent(Event event) { * EventBus. */ @Vis

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800412895 ## core/src/main/java/org/apache/gravitino/listener/EventListenerPluginWrapper.java: ## @@ -68,13 +70,40 @@ public void onPostEvent(Event event) { userEventL

Re: [PR] [#3973] improvement(core):support audit log [gravitino]

2024-10-14 Thread via GitHub
hanwxx commented on PR #4575: URL: https://github.com/apache/gravitino/pull/4575#issuecomment-2412850572 @jerryshao Hi, adjusted based on review comments, please see again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800417697 ## core/src/main/java/org/apache/gravitino/listener/EventBus.java: ## @@ -64,7 +73,15 @@ public void dispatchEvent(Event event) { * EventBus. */ @Visibl

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
yuqi1129 commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800413212 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -742,4 +742,44 @@ private boolean checkSingleFile(Fi

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800414396 ## core/src/main/java/org/apache/gravitino/listener/api/EventListenerPlugin.java: ## @@ -95,17 +97,29 @@ enum Mode { void stop() throws RuntimeException; /*

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800418912 ## core/src/main/java/org/apache/gravitino/listener/api/EventListenerPlugin.java: ## @@ -95,17 +97,29 @@ enum Mode { void stop() throws RuntimeException; /** -

Re: [PR] [MINOR] Shrink the flink-connector-runtime jar [gravitino]

2024-10-14 Thread via GitHub
coolderli closed pull request #4819: [MINOR] Shrink the flink-connector-runtime jar URL: https://github.com/apache/gravitino/pull/4819 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800331960 ## core/src/main/java/org/apache/gravitino/listener/api/EventListenerPlugin.java: ## @@ -95,17 +97,29 @@ enum Mode { void stop() throws RuntimeException; /** -

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800332098 ## core/src/main/java/org/apache/gravitino/listener/EventBus.java: ## @@ -35,25 +37,45 @@ public class EventBus { // which are meant for synchronous event listening

Re: [PR] [MINOR] Shrink the flink-connector-runtime lib size from 84MB to 16MB [gravitino]

2024-10-14 Thread via GitHub
coolderli commented on PR #4819: URL: https://github.com/apache/gravitino/pull/4819#issuecomment-2413052497 @FANNG1 Hi, here are the dependency jars. Please take a look. ``` total 16M -rw-rw-r-- 1 mi mi 41K 10月 15 14:57 gravitino-flink-1.18_2.12-0.7.0-incubating-SNAPSHOT.jar -rw

(gravitino) branch main updated: [#4605] Handle NPE in Doris table operation prop append (#5125)

2024-10-14 Thread yuqi4733
This is an automated email from the ASF dual-hosted git repository. yuqi4733 pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new e46888191 [#4605] Handle NPE in Doris table ope

Re: [PR] [#4605] Handle NPE in Doris table operation prop append [gravitino]

2024-10-14 Thread via GitHub
yuqi1129 merged PR #5125: URL: https://github.com/apache/gravitino/pull/5125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@graviti

Re: [PR] [#4867] feat(core): Add storage support for columns in Gravitino [gravitino]

2024-10-14 Thread via GitHub
yuqi1129 commented on code in PR #5078: URL: https://github.com/apache/gravitino/pull/5078#discussion_r1800296210 ## core/src/main/java/org/apache/gravitino/storage/relational/service/TableColumnMetaService.java: ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1800306465 ## common/src/main/java/org/apache/gravitino/credential/Credential.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [#3973] improvement(core):support audit log [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on PR #4575: URL: https://github.com/apache/gravitino/pull/4575#issuecomment-2412653833 > > I kind of agree with @hanwxx , AuditLog and event are two things, we don't have to use interface to put them together. Using a converter to bridge them together without hard combinat

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-14 Thread via GitHub
shaofengshi commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1800311770 ## gradle/libs.versions.toml: ## @@ -90,6 +90,7 @@ shadow-plugin = "8.1.1" kerby = "2.0.3" node-plugin = "7.0.1" commons-cli = "1.2" +commons-cli-new = "1.9.0"

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800402350 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/HDFSFileSystemProvider.java: ## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Soft

Re: [PR] [#4951] improvement(test): Reduce fields shares between different IT to make AbstractIT more independent. [gravitino]

2024-10-14 Thread via GitHub
diqiu50 commented on code in PR #4996: URL: https://github.com/apache/gravitino/pull/4996#discussion_r1800401817 ## trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryITBase.java: ## @@ -68,14 +68,17 @@ public class Tri

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800402748 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/fs/LocalFileSystemProvider.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800399496 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -742,4 +742,44 @@ private boolean checkSingleFile(F

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800399496 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -742,4 +742,44 @@ private boolean checkSingleFile(F

[PR] [SIP] integrate credential framework to iceberg REST server [gravitino]

2024-10-14 Thread via GitHub
FANNG1 opened a new pull request, #5134: URL: https://github.com/apache/gravitino/pull/5134 ### What changes were proposed in this pull request? (Please outline the changes and how this PR fixes the issue.) ### Why are the changes needed? (Please clarify why the c

Re: [PR] [#5019] feat: (hadoop-catalog): Add a framework to support multi-storage in a pluginized manner for fileset catalog [gravitino]

2024-10-14 Thread via GitHub
yuqi1129 commented on code in PR #5020: URL: https://github.com/apache/gravitino/pull/5020#discussion_r1800405397 ## catalogs/catalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java: ## @@ -742,4 +742,44 @@ private boolean checkSingleFile(Fi

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800408299 ## core/src/main/java/org/apache/gravitino/listener/api/EventListenerPlugin.java: ## @@ -95,17 +97,29 @@ enum Mode { void stop() throws RuntimeException; /*

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1800408048 ## core/src/main/java/org/apache/gravitino/listener/api/EventListenerPlugin.java: ## @@ -95,17 +97,29 @@ enum Mode { void stop() throws RuntimeException; /*

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799165166 ## common/src/main/java/org/apache/gravitino/credential/Credential.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799165801 ## core/src/main/java/org/apache/gravitino/credential/LocationContext.java: ## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on PR #4995: URL: https://github.com/apache/gravitino/pull/4995#issuecomment-2410737834 @jerryshao comments are addressed, please help to review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] [Improvement] We should have a full version list for documents [gravitino]

2024-10-14 Thread via GitHub
JunpingDu commented on issue #5108: URL: https://github.com/apache/gravitino/issues/5108#issuecomment-2410729109 It may not be enough - the users who click docs on website may not aware which version they are current using/deploying, so go directly to latest version may confuse them. Als

Re: [I] [Bug report] authorizations:authorization-ranger:test FAILED (Cron Integration Test 20241013) [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on issue #5126: URL: https://github.com/apache/gravitino/issues/5126#issuecomment-2410861012 @xunliu @jerqi please help to check this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] [Bug report] authorizations:authorization-ranger:test FAILED (Cron Integration Test 20241013) [gravitino]

2024-10-14 Thread via GitHub
xunliu commented on issue #5126: URL: https://github.com/apache/gravitino/issues/5126#issuecomment-2410871661 This issue is related to CI environment, not the code bug, we can fix it in the future. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [#5120] improvement(docs): Add the document of metadata object ownership [gravitino]

2024-10-14 Thread via GitHub
jerqi commented on code in PR #5123: URL: https://github.com/apache/gravitino/pull/5123#discussion_r1799279549 ## docs/security/access-control.md: ## @@ -90,6 +90,18 @@ The owner of each entity has implicit administrative class privilege, for exampl Only the Owner of a securab

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798910543 ## common/build.gradle.kts: ## @@ -28,6 +28,7 @@ plugins { dependencies { implementation(project(":api")) + implementation(project(":catalogs:catalog-common"))

Re: [PR] [#3919] feat(catalog-lakehouse-paimon): Support hive backend for Paimon Catalog [gravitino]

2024-10-14 Thread via GitHub
caican00 commented on PR #5092: URL: https://github.com/apache/gravitino/pull/5092#issuecomment-2410309141 @FANNG1 could you help review again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [#5086] core(feat): Add logic to support manipulating columns in TableOperationDispatcher [gravitino]

2024-10-14 Thread via GitHub
jerryshao opened a new pull request, #5127: URL: https://github.com/apache/gravitino/pull/5127 ### What changes were proposed in this pull request? Add core logic to support manipulating columns in table create/load/load operations. ### Why are the changes needed? With t

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799096933 ## common/src/main/java/org/apache/gravitino/credential/Credential.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799104878 ## common/src/main/java/org/apache/gravitino/credential/Credential.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798876861 ## common/build.gradle.kts: ## @@ -28,6 +28,7 @@ plugins { dependencies { implementation(project(":api")) + implementation(project(":catalogs:catalog-common"

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798925186 ## common/src/main/java/org/apache/gravitino/credential/Credential.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798941527 ## core/src/main/java/org/apache/gravitino/credential/Context.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or

Re: [I] [Improvement] README.md should refer the link to our doc website but not doc's source directory [gravitino]

2024-10-14 Thread via GitHub
JunpingDu commented on issue #5109: URL: https://github.com/apache/gravitino/issues/5109#issuecomment-2410590330 @SeanAverS welcome to your contributions, I just assign the issue to you, please go ahead to work on it! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [#4951] improvement(test): Reduce fields shares between different IT to make AbstractIT more independent. [gravitino]

2024-10-14 Thread via GitHub
mchades commented on code in PR #4996: URL: https://github.com/apache/gravitino/pull/4996#discussion_r1798996634 ## trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryITBase.java: ## @@ -68,14 +68,17 @@ public class Tri

Re: [PR] [#3919] feat(catalog-lakehouse-paimon): Support hive backend for Paimon Catalog [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #5092: URL: https://github.com/apache/gravitino/pull/5092#discussion_r1799366005 ## catalogs/catalog-lakehouse-paimon/src/test/java/org/apache/gravitino/catalog/lakehouse/paimon/integration/test/CatalogPaimonBaseIT.java: ## @@ -712,11 +727,11 @@ pu

Re: [PR] [#3919] feat(catalog-lakehouse-paimon): Support hive backend for Paimon Catalog [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on PR #5092: URL: https://github.com/apache/gravitino/pull/5092#issuecomment-2411036224 Could you add related document in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[I] [Subtask] Create a role, delete a role and recreate a role, it will throw an exception [gravitino]

2024-10-14 Thread via GitHub
jerqi opened a new issue, #5129: URL: https://github.com/apache/gravitino/issues/5129 ### Describe the subtask ``` {"code":1002,"type":"RuntimeException","message":"Failed to operate object [role1] operation [CREATE] under [metalake_demo], reason [Ranger API org.apache.ranger.Rang

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1798876861 ## common/build.gradle.kts: ## @@ -28,6 +28,7 @@ plugins { dependencies { implementation(project(":api")) + implementation(project(":catalogs:catalog-common"

(gravitino) branch main updated: [#5077] feat(core): Add the check of user before creating metadata object (#5096)

2024-10-14 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 6aefe3bfb [#5077] feat(core): Add the check of use

Re: [I] [Improvement] Add the check whether user is added to the metalake [gravitino]

2024-10-14 Thread via GitHub
jerryshao closed issue #5077: [Improvement] Add the check whether user is added to the metalake URL: https://github.com/apache/gravitino/issues/5077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] [Improvement] Add the check whether user is added to the metalake [gravitino]

2024-10-14 Thread via GitHub
jerryshao closed issue #5077: [Improvement] Add the check whether user is added to the metalake URL: https://github.com/apache/gravitino/issues/5077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [#5077] feat(core): Add the check of user before creating metadata object [gravitino]

2024-10-14 Thread via GitHub
jerryshao merged PR #5096: URL: https://github.com/apache/gravitino/pull/5096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

Re: [PR] [#4954] docs(hudi-catalog): Add docs for Hudi catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao merged PR #4976: URL: https://github.com/apache/gravitino/pull/4976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

(gravitino) branch main updated: [#4954] docs(hudi-catalog): Add docs for Hudi catalog (#4976)

2024-10-14 Thread jshao
This is an automated email from the ASF dual-hosted git repository. jshao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/gravitino.git The following commit(s) were added to refs/heads/main by this push: new 67b7be044 [#4954] docs(hudi-catalog): Add docs for

Re: [I] [Subtask] Add docs for Hudi catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao closed issue #4954: [Subtask] Add docs for Hudi catalog URL: https://github.com/apache/gravitino/issues/4954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [I] [Subtask] Add docs for Hudi catalog [gravitino]

2024-10-14 Thread via GitHub
jerryshao closed issue #4954: [Subtask] Add docs for Hudi catalog URL: https://github.com/apache/gravitino/issues/4954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] [#4605] Handle NPE in Doris table operation prop append [gravitino]

2024-10-14 Thread via GitHub
itsaviu commented on code in PR #5125: URL: https://github.com/apache/gravitino/pull/5125#discussion_r1798787186 ## catalogs/catalog-jdbc-doris/src/main/java/org/apache/gravitino/catalog/doris/operation/DorisTableOperations.java: ## @@ -170,13 +170,12 @@ protected String generat

Re: [PR] [#5120] improvement(docs): Add the document of metadata object ownership [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5123: URL: https://github.com/apache/gravitino/pull/5123#discussion_r1799110412 ## docs/security/access-control.md: ## @@ -90,6 +90,18 @@ The owner of each entity has implicit administrative class privilege, for exampl Only the Owner of a sec

Re: [PR] [#4992] support credential vending framework [gravitino]

2024-10-14 Thread via GitHub
FANNG1 commented on code in PR #4995: URL: https://github.com/apache/gravitino/pull/4995#discussion_r1799120113 ## common/src/main/java/org/apache/gravitino/credential/Credential.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * o

Re: [PR] [#5057] Added first part of CLI code [gravitino]

2024-10-14 Thread via GitHub
shaofengshi commented on code in PR #5058: URL: https://github.com/apache/gravitino/pull/5058#discussion_r1799121901 ## gradle/libs.versions.toml: ## @@ -90,6 +90,7 @@ shadow-plugin = "8.1.1" kerby = "2.0.3" node-plugin = "7.0.1" commons-cli = "1.2" +commons-cli-new = "1.9.0"

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1799133736 ## core/src/main/java/org/apache/gravitino/listener/api/EventListenerPlugin.java: ## @@ -95,17 +97,29 @@ enum Mode { void stop() throws RuntimeException; /*

Re: [PR] [#5112] feat(core): support pre event for event listener systems [gravitino]

2024-10-14 Thread via GitHub
jerryshao commented on code in PR #5110: URL: https://github.com/apache/gravitino/pull/5110#discussion_r1799136039 ## core/src/main/java/org/apache/gravitino/listener/EventBus.java: ## @@ -35,25 +37,45 @@ public class EventBus { // which are meant for synchronous event listen

[I] [Subtask] Fail to delete the role for the authorization plugin [gravitino]

2024-10-14 Thread via GitHub
jerqi opened a new issue, #5130: URL: https://github.com/apache/gravitino/issues/5130 ### Describe the subtask Fail to delete the role for the authorization plugin ``` 024-10-14 12:57:37.589 WARN [Gravitino-webserver-41] [org.apache.gravitino.authorization.ranger.RangerAutho

Re: [I] [EPIC] Ranger authorization Hive production available [gravitino]

2024-10-14 Thread via GitHub
jerqi commented on issue #5115: URL: https://github.com/apache/gravitino/issues/5115#issuecomment-2411234275 [ ] #5129 [ ] #5130 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [#5120] improvement(docs): Add the document of metadata object ownership [gravitino]

2024-10-14 Thread via GitHub
jerryshao merged PR #5123: URL: https://github.com/apache/gravitino/pull/5123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravit

  1   2   >