hanwxx commented on PR #4575: URL: https://github.com/apache/gravitino/pull/4575#issuecomment-2412737315
> > > I kind of agree with @hanwxx , AuditLog and event are two things, we don't have to use interface to put them together. Using a converter to bridge them together without hard combination seems better to me. > > > > > > It will hard to transform `IcebergRESTServiceEvent` to `AuditLog` when supporting Iceberg REST server audit log. `IcebergRESTServiceEvent` will be defined in `IcebergRESTServer` module because it may contains some Iceberg specific object like `TableMetaData`. I agree that we'd better not mix event and audit, but maybe we need a trade-off. > > let's keep the current implementation to move forward the PR, @hanwxx do you have time to continue work on the PR to meet the release of 0.7 ? In addition to design a log audit framework, next i will focus on > > > I kind of agree with @hanwxx , AuditLog and event are two things, we don't have to use interface to put them together. Using a converter to bridge them together without hard combination seems better to me. > > > > > > It will hard to transform `IcebergRESTServiceEvent` to `AuditLog` when supporting Iceberg REST server audit log. `IcebergRESTServiceEvent` will be defined in `IcebergRESTServer` module because it may contains some Iceberg specific object like `TableMetaData`. I agree that we'd better not mix event and audit, but maybe we need a trade-off. > > let's keep the current implementation to move forward the PR, @hanwxx do you have time to continue work on the PR to meet the release of 0.7 ? After finished audit log framework design, next i will optimize class Audit Log, which will contain more detail for different operation， this subtask may not finished in the release of 0.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
