FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1800341207
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -342,4 +342,31 @@ private Configs() {}
.stringConf()
.toSequence()
.createWithDefault(Collections.emptyList());
+
+ public static final String AUDIT_LOG_WRITER_CONFIG_PREFIX =
"gravitino.audit.writer";
+
+ public static final String AUDIT_LOG_DEFAULT_FILE_WRITER_FILE_NAME =
+ "default_gravitino_audit_log";
+ public static final ConfigEntry<Boolean> AUDIT_LOG_ENABLED_CONF =
+ new ConfigBuilder("gravitino.audit.enable")
+ .doc("Gravitino audit log enable flag")
+ .version(ConfigConstants.VERSION_0_7_0)
+ .booleanConf()
+ .createWithDefault(false);
+
+ public static final ConfigEntry<String> WRITER_CLASS_NAME =
+ new ConfigBuilder("gravitino.audit.writer.")
+ .doc("Gravitino audit log writer class name")
+ .version(ConfigConstants.VERSION_0_7_0)
+ .stringConf()
+ .checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
+ .createWithDefault("");
+
+ public static final ConfigEntry<String> FORMATTER_CLASS_NAME =
+ new ConfigBuilder("gravitino.audit.writer.class")
Review Comment:
not fixed?
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -342,4 +342,29 @@ private Configs() {}
.stringConf()
.toSequence()
.createWithDefault(Collections.emptyList());
+
+ public static final String AUDIT_LOG_WRITER_CONFIG_PREFIX =
"gravitino.audit.writer.";
+
+ public static final ConfigEntry<Boolean> AUDIT_LOG_ENABLED_CONF =
+ new ConfigBuilder("gravitino.audit.enable")
+ .doc("Gravitino audit log enable flag")
+ .version(ConfigConstants.VERSION_0_7_0)
+ .booleanConf()
+ .createWithDefault(false);
+
+ public static final ConfigEntry<String> AUDIT_LOG_WRITER_CLASS_NAME =
+ new ConfigBuilder("gravitino.audit.writer.")
+ .doc("Gravitino audit log writer class name")
+ .version(ConfigConstants.VERSION_0_7_0)
+ .stringConf()
+ .checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
Review Comment:
There is no need add the empty check if the config has the default value
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -342,4 +342,31 @@ private Configs() {}
.stringConf()
.toSequence()
.createWithDefault(Collections.emptyList());
+
+ public static final String AUDIT_LOG_WRITER_CONFIG_PREFIX =
"gravitino.audit.writer";
+
+ public static final String AUDIT_LOG_DEFAULT_FILE_WRITER_FILE_NAME =
+ "default_gravitino_audit_log";
+ public static final ConfigEntry<Boolean> AUDIT_LOG_ENABLED_CONF =
+ new ConfigBuilder("gravitino.audit.enable")
+ .doc("Gravitino audit log enable flag")
+ .version(ConfigConstants.VERSION_0_7_0)
+ .booleanConf()
+ .createWithDefault(false);
+
+ public static final ConfigEntry<String> WRITER_CLASS_NAME =
+ new ConfigBuilder("gravitino.audit.writer.")
Review Comment:
not fixed
##########
core/src/main/java/org/apache/gravitino/audit/StringFormatter.java:
##########
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.gravitino.audit;
+
+import java.util.Objects;
+import org.apache.gravitino.audit.AuditLog.Status;
+import org.apache.gravitino.listener.api.event.Event;
+import org.apache.gravitino.listener.api.event.FailureEvent;
+
+/** The default implementation of the audit log. */
+public class StringFormatter implements Formatter {
Review Comment:
seems not related to String, rename to `SimpleAuditLogFormatter`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
