FANNG1 commented on PR #4987:
URL: https://github.com/apache/gravitino/pull/4987#issuecomment-2372623460
> @FANNG1 Thanks for sharing this. I am curious in this PR, how can users
access `icebergCatalogWrapperManager` instance if user plugin their API into
IRC?
1. `IcebergCatalogWrap
jun-ma commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1774303874
##
docs/manage-metalake-using-gravitino.md:
##
@@ -136,9 +133,6 @@ GravitinoMetalake renamed =
gravitinoAdminClient.alterMetalake(
```python
changes = (
Metala
mchades commented on issue #4949:
URL: https://github.com/apache/gravitino/issues/4949#issuecomment-2372741458
I suggest increasing the timeout period first.
The current information cannot determine the specific cause of failure, and
increasing the timeout period will help further ju
yuqi1129 commented on code in PR #4935:
URL: https://github.com/apache/gravitino/pull/4935#discussion_r1774296293
##
docs/trino-connector/trino-cascading-query.md:
##
@@ -0,0 +1,162 @@
+---
+title: "Apache Gravitino connector Trino cascading query"
+slug: /trino-connector/trino-
jun-ma commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1774296728
##
docs/manage-metalake-using-gravitino.md:
##
@@ -107,15 +109,10 @@ curl -X PUT -H "Accept:
application/vnd.gravitino.v1+json" \
"updates": [
{
"@type
FANNG1 commented on PR #5011:
URL: https://github.com/apache/gravitino/pull/5011#issuecomment-2372718952
@justinmclean thanks for your work, do you mind copy the LICENCE and
NOTICE files to the Iceberg REST package in
https://github.com/apache/gravitino/blob/main/build.gradle.kts#L624-
mchades commented on code in PR #4935:
URL: https://github.com/apache/gravitino/pull/4935#discussion_r1774308980
##
docs/trino-connector/trino-cascading-query.md:
##
@@ -0,0 +1,162 @@
+---
+title: "Apache Gravitino connector Trino cascading query"
+slug: /trino-connector/trino-c
yuqi1129 commented on PR #4547:
URL: https://github.com/apache/gravitino/pull/4547#issuecomment-2372754832
> > Also, why do we need hdfs jar? I assume the hdfs client jar should be
enough.
>
> Kerberos relies on the default HDFS configuration, removing hdfs jar may
cause Kerberos ope
diqiu50 opened a new pull request, #5012:
URL: https://github.com/apache/gravitino/pull/5012
### What changes were proposed in this pull request?
Add docs for Trino cascading query
### Why are the changes needed?
Fix: # (issue)
### Does this PR introduce _any_ user
jun-ma commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1774318675
##
docs/manage-metalake-using-gravitino.md:
##
@@ -136,9 +133,6 @@ GravitinoMetalake renamed =
gravitinoAdminClient.alterMetalake(
```python
changes = (
Metala
mchades commented on code in PR #4935:
URL: https://github.com/apache/gravitino/pull/4935#discussion_r1774320926
##
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/DefaultCatalogConnectorFactory.java:
##
@@ -35,25 +36,49 @@
public clas
yuqi1129 commented on code in PR #4985:
URL: https://github.com/apache/gravitino/pull/4985#discussion_r1774324507
##
api/src/main/java/org/apache/gravitino/rel/expressions/distributions/Strategy.java:
##
@@ -50,7 +50,10 @@ public enum Strategy {
RANGE,
/** Distributes da
yuanoOo opened a new pull request, #5013:
URL: https://github.com/apache/gravitino/pull/5013
### What changes were proposed in this pull request?
- Support schema operations for OceanBase JDBC catalog.
- Add OceanBaseContainer to test schema operations.
### Why are th
yuanoOo commented on PR #5013:
URL: https://github.com/apache/gravitino/pull/5013#issuecomment-2372771659
@mchades PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jerryshao opened a new pull request, #5009:
URL: https://github.com/apache/gravitino/pull/5009
### What changes were proposed in this pull request?
This PR adjust and add some package for SQL provider to make the code more
separately and clear.
### Why are the changes needed?
jerqi opened a new pull request, #5001:
URL: https://github.com/apache/gravitino/pull/5001
### What changes were proposed in this pull request?
Change tag, user, and role-related code to support the new framework
introduced by #4832
### Why are the changes needed?
To sup
FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1772960525
##
core/src/main/java/org/apache/gravitino/audit/AuditLogWriter.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
FANNG1 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772980833
##
.github/workflows/python-integration-test.yml:
##
@@ -48,7 +48,7 @@ jobs:
needs: changes
if: needs.changes.outputs.source_changes == 'true'
runs-on:
FANNG1 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772988398
##
authorizations/authorization-ranger/build.gradle.kts:
##
@@ -57,36 +61,26 @@ dependencies {
exclude("net.java.dev.jna")
exclude("javax.ws.rs")
exclud
FANNG1 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772988398
##
authorizations/authorization-ranger/build.gradle.kts:
##
@@ -57,36 +61,26 @@ dependencies {
exclude("net.java.dev.jna")
exclude("javax.ws.rs")
exclud
FANNG1 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772988398
##
authorizations/authorization-ranger/build.gradle.kts:
##
@@ -57,36 +61,26 @@ dependencies {
exclude("net.java.dev.jna")
exclude("javax.ws.rs")
exclud
FANNG1 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772996496
##
authorizations/authorization-ranger/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerHiveE2EIT.java:
##
@@ -77,63 +76,195 @@ public cl
This is an automated email from the ASF dual-hosted git repository.
yuqi4733 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 1f9895633 [#5008] improve(core): reorganize the
yuqi1129 merged PR #5009:
URL: https://github.com/apache/gravitino/pull/5009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graviti
yuqi1129 closed issue #5008: [Improvement] Reorganize the SQL provider package
to make it more clear
URL: https://github.com/apache/gravitino/issues/5008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
yuqi1129 closed issue #5008: [Improvement] Reorganize the SQL provider package
to make it more clear
URL: https://github.com/apache/gravitino/issues/5008
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
yuqi1129 commented on code in PR #4985:
URL: https://github.com/apache/gravitino/pull/4985#discussion_r1774364299
##
api/src/main/java/org/apache/gravitino/rel/expressions/distributions/Strategy.java:
##
@@ -50,7 +50,10 @@ public enum Strategy {
RANGE,
/** Distributes da
haitaoyao opened a new issue, #5014:
URL: https://github.com/apache/gravitino/issues/5014
### Describe the feature
Add support for MaxCompute catalogs
### Motivation
Since Aliyun(aka. Alicloud) is very popular in China, Maxcompute, which is a
in-house cloud datawarehouse
yuqi1129 commented on PR #4547:
URL: https://github.com/apache/gravitino/pull/4547#issuecomment-2372853670
> > > Also, why do we need hdfs jar? I assume the hdfs client jar should be
enough.
> >
> >
> > Kerberos relies on the default HDFS configuration, removing hdfs jar may
caus
caican00 commented on PR #4547:
URL: https://github.com/apache/gravitino/pull/4547#issuecomment-2372857636
> > > Why the paimon format jar is so big, is it correct?
> >
> >
> > Paimon format jar packages the dependences in the jar, @caican00 do you
know any other alternative jars?
puchengy commented on PR #4987:
URL: https://github.com/apache/gravitino/pull/4987#issuecomment-2372492708
@FANNG1 Thanks for sharing this. I am curious in this PR, how can users
access `icebergCatalogWrapperManager` instance if user plugin their API into
IRC?
--
This is an automated mes
justinmclean commented on PR #4909:
URL: https://github.com/apache/gravitino/pull/4909#issuecomment-2372691576
See #5011 for the LICENSE and NOTICE files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jerryshao opened a new pull request, #5015:
URL: https://github.com/apache/gravitino/pull/5015
### What changes were proposed in this pull request?
This PR adjusts and adds some packages for SQL provider to make the code
more separately and clear.
### Why are the changes needed
yuqi1129 commented on PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#issuecomment-2371029293
> @mchades
>
> > I am confused about why it worked before without needing an explicit
call?
>
> Because the module after the shadow, there is no longer this file
structur
jerryshao commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1773189087
##
clients/client-java/src/main/java/org/apache/gravitino/client/GenericRole.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
xunliu commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1773302725
##
core/src/main/java/org/apache/gravitino/storage/relational/database/H2Database.java:
##
@@ -54,6 +54,12 @@ public String startH2Database(Config config) {
Str
jerryshao commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1772861356
##
docs/manage-metalake-using-gravitino.md:
##
@@ -107,15 +109,10 @@ curl -X PUT -H "Accept:
application/vnd.gravitino.v1+json" \
"updates": [
{
"@t
jerryshao merged PR #5001:
URL: https://github.com/apache/gravitino/pull/5001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
jerryshao commented on PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#issuecomment-2370946021
@shaofengshi , do you want to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xunliu commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1773122955
##
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/RangerContainer.java:
##
@@ -38,7 +38,7 @@ public class RangerContainer extend
xunliu commented on PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#issuecomment-2371046591
> @xunliu need answer.
Because Jetty server default load
https://github.com/jetty/jetty.project/blob/jetty-12.0.x/jetty-core/jetty-deploy/src/test/resources/etc/webdefault.xml#L37,
shaofengshi commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1773191237
##
docs/manage-metalake-using-gravitino.md:
##
@@ -107,15 +109,10 @@ curl -X PUT -H "Accept:
application/vnd.gravitino.v1+json" \
"updates": [
{
"
shaofengshi commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1773198517
##
docs/manage-metalake-using-gravitino.md:
##
@@ -136,9 +133,6 @@ GravitinoMetalake renamed =
gravitinoAdminClient.alterMetalake(
```python
changes = (
M
shaofengshi commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1773199300
##
docs/manage-metalake-using-gravitino.md:
##
@@ -136,9 +133,6 @@ GravitinoMetalake renamed =
gravitinoAdminClient.alterMetalake(
```python
changes = (
M
shaofengshi commented on PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#issuecomment-2371062385
> @shaofengshi , do you want to take another look?
Cool, thanks jun for the PR! @jun-ma
--
This is an automated message from the Apache Git Service.
To respond to the messa
jerryshao commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1772980454
##
clients/client-java/src/main/java/org/apache/gravitino/client/GenericRole.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
jerryshao merged PR #5004:
URL: https://github.com/apache/gravitino/pull/5004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch branch-0.6
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/branch-0.6 by this push:
new 98aab197a [#3348] feat(core,server): A
FANNG1 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1773008723
##
core/src/main/java/org/apache/gravitino/storage/relational/database/H2Database.java:
##
@@ -54,6 +54,12 @@ public String startH2Database(Config config) {
Str
FANNG1 commented on PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#issuecomment-2370799049
I'm afraid the current shade implement seems to lead some unexpected
behavior, makes the test class more complicated.
--
This is an automated message from the Apache Git Service.
To r
jerryshao commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1773019387
##
core/src/main/java/org/apache/gravitino/audit/AuditLogConfig.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
jerqi commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1773022484
##
api/src/main/java/org/apache/gravitino/authorization/Role.java:
##
@@ -53,4 +52,13 @@ public interface Role extends Auditable {
* @return The securable objects o
jerqi commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1773023679
##
clients/client-java/src/main/java/org/apache/gravitino/client/GenericRole.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
FANNG1 commented on PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#issuecomment-2370807652
BTW, I prefer to drop the support for MiniGravitino to avoid to struggle for
the class conflict related problems. @mchades @yuqi1129 @xunliu WDYT?
--
This is an automated message from
jerqi commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1773027953
##
common/src/main/java/org/apache/gravitino/dto/authorization/RoleDTO.java:
##
@@ -43,9 +44,13 @@ public class RoleDTO implements Role {
@JsonProperty("properties")
FANNG1 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1773001932
##
authorizations/authorization-ranger/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerHiveE2EIT.java:
##
@@ -77,63 +76,195 @@ public cl
jerqi commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1773030140
##
clients/client-java/src/main/java/org/apache/gravitino/client/GenericRole.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
mchades commented on PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#issuecomment-2370818659
> BTW, I prefer to drop the support for MiniGravitino to avoid to struggle
for the class conflict related problems. @mchades @yuqi1129 @xunliu WDYT?
Do you mean to remove the embe
kahnwong commented on PR #79:
URL:
https://github.com/apache/gravitino-playground/pull/79#issuecomment-2370822764
forgot to update the actual compose command, will create a commit for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
jerqi commented on code in PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#discussion_r1773030140
##
clients/client-java/src/main/java/org/apache/gravitino/client/GenericRole.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
yuqi1129 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772694796
##
core/src/main/java/org/apache/gravitino/storage/relational/database/H2Database.java:
##
@@ -54,6 +54,12 @@ public String startH2Database(Config config) {
S
yuqi1129 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772694796
##
core/src/main/java/org/apache/gravitino/storage/relational/database/H2Database.java:
##
@@ -54,6 +54,12 @@ public String startH2Database(Config config) {
S
yuqi1129 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772694796
##
core/src/main/java/org/apache/gravitino/storage/relational/database/H2Database.java:
##
@@ -54,6 +54,12 @@ public String startH2Database(Config config) {
S
yuqi1129 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772694796
##
core/src/main/java/org/apache/gravitino/storage/relational/database/H2Database.java:
##
@@ -54,6 +54,12 @@ public String startH2Database(Config config) {
S
FANNG1 commented on PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#issuecomment-2370842614
> Do you mean to remove the embedded tests?
Yes, MiniGravitino provides the facilities to debug easily, but leading
complicated class conflict problems, it takes much more time to
jerryshao commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1773054315
##
core/src/main/java/org/apache/gravitino/audit/AuditLogConfig.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
jerryshao commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1773054315
##
core/src/main/java/org/apache/gravitino/audit/AuditLogConfig.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
FANNG1 opened a new pull request, #5003:
URL: https://github.com/apache/gravitino/pull/5003
### What changes were proposed in this pull request?
### Why are the changes needed?
(Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarif
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new a89fe9250 [MINOR] docs(core): fix iceberg event li
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
cherry-pick-branch-0.6-a89fe92506221d2d2f7a90c2c8681befdca074e7
in repository https://gitbox.apache.org/repos/asf/gravitino.git
at c2e6f40aa [MINOR] docs(core): fix iceberg event liste
github-actions[bot] opened a new pull request, #5007:
URL: https://github.com/apache/gravitino/pull/5007
### What changes were proposed in this pull request?
correct `gravitino.eventListener.{name}.className` to
`gravitino.eventListener.{name}.class`
### Why are the changes nee
jerryshao merged PR #5003:
URL: https://github.com/apache/gravitino/pull/5003
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
jerryshao closed pull request #5007: [MINOR] docs(core): fix iceberg event
listener configuration
URL: https://github.com/apache/gravitino/pull/5007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jerryshao commented on PR #4547:
URL: https://github.com/apache/gravitino/pull/4547#issuecomment-2370968832
> > Why the paimon format jar is so big, is it correct?
>
> Paimon format jar packages the dependences in the jar, @caican00 do you
know any other alternative jars?
@caic
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a change to branch
cherry-pick-branch-0.6-a89fe92506221d2d2f7a90c2c8681befdca074e7
in repository https://gitbox.apache.org/repos/asf/gravitino.git
was c2e6f40aa [MINOR] docs(core): fix iceberg event listener c
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch branch-0.6
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/branch-0.6 by this push:
new b30aa2b78 [MINOR] docs(core): fix iceb
jerryshao merged PR #5007:
URL: https://github.com/apache/gravitino/pull/5007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
xunliu commented on PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#issuecomment-2370989769
> > Do you mean to remove the embedded tests?
>
> Yes, MiniGravitino provides the facilities to debug easily, but leading
complicated class conflict problems, it takes much more ti
diqiu50 merged PR #4998:
URL: https://github.com/apache/gravitino/pull/4998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitin
FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1772936186
##
core/src/main/java/org/apache/gravitino/audit/AuditLogConfig.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1772941030
##
core/src/main/java/org/apache/gravitino/audit/AuditLogManager.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1772941793
##
core/src/main/java/org/apache/gravitino/audit/AuditLogManager.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1772950327
##
core/src/main/java/org/apache/gravitino/audit/AuditLogManager.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1772950327
##
core/src/main/java/org/apache/gravitino/audit/AuditLogManager.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or m
FANNG1 commented on code in PR #4575:
URL: https://github.com/apache/gravitino/pull/4575#discussion_r1772960525
##
core/src/main/java/org/apache/gravitino/audit/AuditLogWriter.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or mor
yuqi1129 commented on PR #5009:
URL: https://github.com/apache/gravitino/pull/5009#issuecomment-2371520220
LGTM, @jerqi Would you like to take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
LindaSummer commented on issue #4999:
URL: https://github.com/apache/gravitino/issues/4999#issuecomment-2371521852
Hi @mchades ,
Sorry to bother you.
I'm not sure related test case should be put in which test class.
Could you give me some advice?
Best Regards,
E
xunliu commented on PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#issuecomment-2371333284
@FANNG1 @mchades @yuqi1129 I improved this PR based on your suggestion,
Please help me review it again, Thanks.
--
This is an automated message from the Apache Git Service.
To respond
This is an automated email from the ASF dual-hosted git repository.
yuqi4733 pushed a commit to branch branch-0.6
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/branch-0.6 by this push:
new eb24835ff [#5008] improve(core): re
yuqi1129 merged PR #5015:
URL: https://github.com/apache/gravitino/pull/5015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@graviti
diqiu50 commented on code in PR #4925:
URL: https://github.com/apache/gravitino/pull/4925#discussion_r1774594485
##
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergMetadataAdapter.java:
##
@@ -126,20 +120,12 @@ public Gra
yuanoOo commented on code in PR #5013:
URL: https://github.com/apache/gravitino/pull/5013#discussion_r1774596264
##
integration-test-common/src/test/java/org/apache/gravitino/integration/test/container/OceanBaseContainer.java:
##
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache
diqiu50 commented on code in PR #4925:
URL: https://github.com/apache/gravitino/pull/4925#discussion_r1774599971
##
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/ExpressionUtil.java:
##
@@ -0,0 +1,308 @@
+/*
+ * Licensed to th
jerqi commented on PR #4894:
URL: https://github.com/apache/gravitino/pull/4894#issuecomment-2372885355
@xunliu @jerqi `List role operation` only supports to list role names.
Otherwise, it will have poor performance if we fetch objects, or it will be
inconsistent with other interfaces if w
diqiu50 commented on code in PR #4925:
URL: https://github.com/apache/gravitino/pull/4925#discussion_r1774575919
##
trino-connector/integration-test/build.gradle.kts:
##
@@ -70,17 +70,24 @@ dependencies {
testRuntimeOnly(libs.junit.jupiter.engine)
}
+tasks.register("setupD
diqiu50 commented on code in PR #4925:
URL: https://github.com/apache/gravitino/pull/4925#discussion_r1774579129
##
trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/lakehouse-iceberg/5_partition_sort_order.sql:
##
@@ -0,0 +1,63 @@
+CREATE SCHEMA
diqiu50 commented on code in PR #4925:
URL: https://github.com/apache/gravitino/pull/4925#discussion_r1774579129
##
trino-connector/integration-test/src/test/resources/trino-ci-testset/testsets/lakehouse-iceberg/5_partition_sort_order.sql:
##
@@ -0,0 +1,63 @@
+CREATE SCHEMA
FANNG1 commented on code in PR #4925:
URL: https://github.com/apache/gravitino/pull/4925#discussion_r1772898568
##
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergMetadataAdapter.java:
##
@@ -126,20 +120,12 @@ public Grav
FANNG1 commented on PR #4925:
URL: https://github.com/apache/gravitino/pull/4925#issuecomment-2370630576
@yuqi1129 , do you have time to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jerryshao commented on code in PR #4997:
URL: https://github.com/apache/gravitino/pull/4997#discussion_r1772907677
##
docs/manage-metalake-using-gravitino.md:
##
@@ -107,15 +109,10 @@ curl -X PUT -H "Accept:
application/vnd.gravitino.v1+json" \
"updates": [
{
"@t
1 - 100 of 110 matches
Mail list logo
