FANNG1 commented on code in PR #4575: URL: https://github.com/apache/gravitino/pull/4575#discussion_r1772950327
########## core/src/main/java/org/apache/gravitino/audit/AuditLogManager.java: ########## @@ -0,0 +1,114 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.audit; + +import com.google.common.annotations.VisibleForTesting; +import java.util.Map; +import org.apache.commons.lang3.StringUtils; +import org.apache.gravitino.exceptions.GravitinoRuntimeException; +import org.apache.gravitino.listener.EventListenerManager; +import org.apache.gravitino.listener.api.EventListenerPlugin; +import org.apache.gravitino.listener.api.event.Event; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class AuditLogManager { + + private static final Logger LOG = LoggerFactory.getLogger(AuditLogManager.class); + + public static final String AUDIT_LOG_PREFIX = "gravitino.audit."; + + @VisibleForTesting private AuditLogWriter auditLogWriter; + + public void init(Map<String, String> properties, EventListenerManager eventBusManager) { + AuditLogConfig auditLogConfig = new AuditLogConfig(properties); + if (!auditLogConfig.isAuditEnabled()) { + LOG.warn("Audit log is not enabled"); + return; + } + + String writerClassName = auditLogConfig.getWriterClassName(); + String formatterClassName = auditLogConfig.getAuditLogFormatterClassName(); + Formatter formatter = loadFormatter(formatterClassName); + LOG.info("Audit log writer class name {}", writerClassName); + if (StringUtils.isEmpty(writerClassName)) { + throw new GravitinoRuntimeException("Audit log writer class is not configured"); + } + + auditLogWriter = + loadAuditLogWriter( + writerClassName, auditLogConfig.getWriterProperties(properties), formatter); + + eventBusManager.addEventListener( + "audit-log", + new EventListenerPlugin() { + + @Override + public void init(Map<String, String> properties) throws RuntimeException {} + + @Override + public void start() throws RuntimeException {} + + @Override + public void stop() throws RuntimeException { + auditLogWriter.close(); + } + + @Override + public void onPostEvent(Event event) throws RuntimeException { + try { + auditLogWriter.write(event); + } catch (Exception e) { + LOG.warn("Failed to write audit log {}.", event, e); + } + } + + @Override + public Mode mode() { + return Mode.ASYNC_ISOLATED; + } + }); + } + + private AuditLogWriter loadAuditLogWriter( + String className, Map<String, String> config, Formatter formatter) { + try { + AuditLogWriter auditLogWriter = + (AuditLogWriter) + Class.forName(className).getConstructor(Formatter.class).newInstance(formatter); Review Comment: Here add a constrict about the constructor of `AuditLogWriter`, but not defined in interface, how about pass `format` in auditLogWriter.init(formatter, config) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
