FANNG1 commented on code in PR #4948:
URL: https://github.com/apache/gravitino/pull/4948#discussion_r1772996496


##########
authorizations/authorization-ranger/src/test/java/org/apache/gravitino/authorization/ranger/integration/test/RangerHiveE2EIT.java:
##########
@@ -77,63 +76,195 @@ public class RangerHiveE2EIT extends AbstractIT {
 
   private static RangerAuthorizationPlugin rangerAuthPlugin;
   public static final String metalakeName =
-      
GravitinoITUtils.genRandomName("RangerHiveAuthIT_metalake").toLowerCase();
+      GravitinoITUtils.genRandomName("RangerHiveE2EIT_metalake").toLowerCase();
   public static final String catalogName =
-      GravitinoITUtils.genRandomName("RangerHiveAuthIT_catalog").toLowerCase();
+      GravitinoITUtils.genRandomName("RangerHiveE2EIT_catalog").toLowerCase();
   public static final String schemaName =
-      GravitinoITUtils.genRandomName("RangerHiveAuthIT_schema").toLowerCase();
-  public static final String tableName =
-      GravitinoITUtils.genRandomName("RangerHiveAuthIT_table").toLowerCase();
-
-  public static final String HIVE_COL_NAME1 = "hive_col_name1";
-  public static final String HIVE_COL_NAME2 = "hive_col_name2";
-  public static final String HIVE_COL_NAME3 = "hive_col_name3";
+      GravitinoITUtils.genRandomName("RangerHiveE2EIT_schema").toLowerCase();
 
   private static GravitinoMetalake metalake;
   private static Catalog catalog;
   private static final String provider = "hive";
   private static String HIVE_METASTORE_URIS;
 
+  private static SparkSession sparkSession = null;
+  private final AuditInfo auditInfo =
+      
AuditInfo.builder().withCreator("test").withCreateTime(Instant.now()).build();
+  private static final String HADOOP_USER_NAME = "HADOOP_USER_NAME";
+  private static final String TEST_USER_NAME = "e2e_it_user";
+
+  private static final String SQL_SHOW_DATABASES =
+      String.format("SHOW DATABASES like '%s'", schemaName);
+
+  private static String RANGER_ADMIN_URL = null;
+
   @BeforeAll
   public static void startIntegrationTest() throws Exception {
+    // Enable Gravitino Authorization mode
     Map<String, String> configs = Maps.newHashMap();
     configs.put(Configs.ENABLE_AUTHORIZATION.getKey(), String.valueOf(true));
-    configs.put(Configs.SERVICE_ADMINS.getKey(), AuthConstants.ANONYMOUS_USER);
+    configs.put(Configs.SERVICE_ADMINS.getKey(), RangerITEnv.HADOOP_USER_NAME);
+    configs.put(Configs.AUTHENTICATORS.getKey(), 
AuthenticatorType.SIMPLE.name().toLowerCase());
+    configs.put("SimpleAuthUserName", TEST_USER_NAME);
     registerCustomConfigs(configs);
     AbstractIT.startIntegrationTest();
 
     RangerITEnv.setup();
-    containerSuite.startHiveContainer();
+    RangerITEnv.startHiveRangerContainer();
+
+    RANGER_ADMIN_URL =
+        String.format(
+            "http://%s:%d";,
+            containerSuite.getRangerContainer().getContainerIpAddress(), 
RANGER_SERVER_PORT);
+
     HIVE_METASTORE_URIS =
         String.format(
             "thrift://%s:%d",
-            containerSuite.getHiveContainer().getContainerIpAddress(),
+            containerSuite.getHiveRangerContainer().getContainerIpAddress(),
             HiveContainer.HIVE_METASTORE_PORT);
 
+    generateRangerSparkSecurityXML();
+
+    sparkSession =
+        SparkSession.builder()
+            .master("local[1]")
+            .appName("Hive Catalog integration test")

Review Comment:
   better add ranger to app name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to