unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1895668527
##
init/spark/spark-defaults.conf:
##
@@ -18,14 +18,14 @@
#
spark.plugins org.apache.gravitino.spark.connector.plugin.GravitinoSparkPlugin
-spark.sql.g
FANNG1 commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1895653118
##
init/spark/spark-defaults.conf:
##
@@ -18,14 +18,14 @@
#
spark.plugins org.apache.gravitino.spark.connector.plugin.GravitinoSparkPlugin
-spark.sql.gravi
FANNG1 commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1895653118
##
init/spark/spark-defaults.conf:
##
@@ -18,14 +18,14 @@
#
spark.plugins org.apache.gravitino.spark.connector.plugin.GravitinoSparkPlugin
-spark.sql.gravi
xunliu merged PR #56:
URL: https://github.com/apache/gravitino-playground/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gr
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2463598504
@xunliu This PR is ok. Can you help merge to main branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2463597812
> @danhuawang Note that there's a prometheus and grafana service comes in
during this rebase, could we implement it at another PR ? Because this PR is
too big, and meanwhile,
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2463592996
@danhuawang Note that there's a prometheus and grafana service comes in
during this rebase, could we implement it at another PR ? Because this PR is
too big, and meanwhile, l
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1833588200
##
playground.sh:
##
@@ -55,50 +94,95 @@ checkPortInUse() {
openPort=$(sudo lsof -i :$port -sTCP:LISTEN)
fi
if [ -z "${openPort}" ]; then
-e
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1833583161
##
playground.sh:
##
@@ -55,50 +94,95 @@ checkPortInUse() {
openPort=$(sudo lsof -i :$port -sTCP:LISTEN)
fi
if [ -z "${openPort}" ]; then
-e
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1833583161
##
playground.sh:
##
@@ -55,50 +94,95 @@ checkPortInUse() {
openPort=$(sudo lsof -i :$port -sTCP:LISTEN)
fi
if [ -z "${openPort}" ]; then
-e
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2462075246
@unknowntpo Some tiny issue
1. check status, I expect to get pods status instead of k8s service info
```
./playground.sh k8s status
NAME TYPEC
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2454708105
@danhuawang now I can run all jupyter notebook example without any problems,
and I also modified `./playground.sh` to support k8s, please take a look.
--
This is an auto
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2454703738
Actually, some people have same issue:
[link](https://stackoverflow.com/q/54661095)
but doesn't have great solution.
I manually set `hostname` to `hive` as a workaro
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2451009301
main branch seems to have lots of changes, for example, it use
`gravitino-dependency.sh` to download jars, I'll rebase and apply that change
to helm chart first.
--
This i
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2450919920
@jerqi @danhuawang
I found a wired thing and still can't solve it:
in `init/jupyter/gravitino-spark-trino-example.ipynb`, we create table with
`spark.sql.warehouse.
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2432342662
Now, llamaindex example has no problem, I still needs to fix
`init/jupyter/gravitino-spark-trino-example.ipynb` and resolve conflicts.
--
This is an automated message from
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2432336970
> > > > > Could he create a file set using location
`file:/tmp/gravitino/data/pdfs`?
> > > >
> > > >
> > > > @jerqi sorry for the late reply, I set the storage_loca
jerqi commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2428071126
> > > > Could he create a file set using location
`file:/tmp/gravitino/data/pdfs`?
> > >
> > >
> > > @jerqi sorry for the late reply, I set the storage_location to:
>
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2426703243
> > > Could he create a file set using location
`file:/tmp/gravitino/data/pdfs`?
> >
> >
> > @jerqi sorry for the late reply, I set the storage_location to:
> >
jerqi commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2401162247
> > Could he create a file set using location
`file:/tmp/gravitino/data/pdfs`?
>
> @jerqi sorry for the late reply, I set the storage_location to:
>
> ```
> storag
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2401157641
> > Could he create a file set using location
`file:/tmp/gravitino/data/pdfs`?
>
> @jerqi sorry for the late reply, I set the storage_location to:
>
> ```
> s
jerqi commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2369970390
Could he create a file set using location `file:/tmp/gravitino/data/pdfs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2369952892
@jerqi @qqqttt123 Can you help Eric to figure out this problem ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2369867121
@danhuawang in llamaindex jupyter notebook example, at this step of creating
fileset `cities`, it will throw `InternalError`, this happed at
`docker-compose` and `helm-chart`
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1770666509
##
init/gravitino/init.sh:
##
@@ -25,6 +25,10 @@ cp
/root/gravitino/catalogs/jdbc-mysql/libs/mysql-connector-java-8.0.27.jar /roo
cp /root/gravitino/cata
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2367003012
> @unknowntpo I am going to add CI check for this repository. But there's an
issue when I lint this helm-chart. Can you help check this issue? Thanks!
>
> ```
> helm
lilyzhoupeijie commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1766256149
##
init/gravitino/init.sh:
##
@@ -25,6 +25,10 @@ cp
/root/gravitino/catalogs/jdbc-mysql/libs/mysql-connector-java-8.0.27.jar /roo
cp /root/gravitino/
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2359800516
@unknowntpo I am going to add CI check for this repository. But there's an
issue when I lint this helm-chart. Can you help check this issue? Thanks!
```
helm lint helm-
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2359736383
@unknowntpo I saw docker-compose.yaml and healthy check scripts changed.
These changes cause docker compose launch playground failed.
--
This is an automated message from
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1764595136
##
healthcheck/gravitino-healthcheck.sh:
##
@@ -23,22 +23,24 @@ max_attempts=3
attempt=0
success=false
+HOST_IP=${GRAVITINO_HOST_IP:-127.0.0.1}
+
whil
xunliu commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1764332017
##
healthcheck/gravitino-healthcheck.sh:
##
@@ -23,22 +23,24 @@ max_attempts=3
attempt=0
success=false
+HOST_IP=${GRAVITINO_HOST_IP:-127.0.0.1}
+
while [
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2357387930
LGTM. @xunliu Would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2354746545
@danhuawang Done, please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2354401790
@danhuawang Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2342613385
@unknowntpo Thanks for your work!
I install this chart on Docker Desktop , it works. It seems Docker Desktop
(enable kubenetes) is more easy to use than minikube and it's
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2342412516
It looks good to me.
@jerqi Would you like to take a look at this PR? Any more comments?
--
This is an automated message from the Apache Git Service.
To respond to the me
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2340330075
> > Can you help add some steps in README.md like the following examples?
Then these commands are align with above Docker Container CLI , so user can use
Trino CLI or spark s
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2339398569
> I didn't see the dependency logic in docker-compose.yaml that is
implemented in helm chart yaml. Do you think we need to add this in helm chart ?
I use `initContainer
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1751098792
##
README.md:
##
@@ -229,3 +229,9 @@ select * from catalog_iceberg.sales.customers;
Apache Gravitino is an effort undergoing incubation at The Apache Soft
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2339397455
> Can you help add some steps in README.md like the following examples? Then
these commands are align with above Docker Container CLI , so user can use
Trino CLI or spark sql
unknowntpo commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2316692394
> @unknowntpo Just reminder: some important changes are merged to main
branch, https://github.com/apache/gravitino-playground/pull/68.
>
>
Thanks for your rem
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2316518091
@unknowntpo Just reminder: some important changes are merged to main
branch, https://github.com/apache/gravitino-playground/pull/68.
--
This is an automated message f
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2300523072
There's still issue when create namespace like `test`. Configmap resources
are created in `test` namespace, but pods are created in gravitino-playground
namespace.
`
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1722987523
##
helm-chart/templates/NOTES.txt:
##
@@ -0,0 +1,22 @@
+1. Get the application URL by running these commands:
+{{- if .Values.ingress.enabled }}
+{{- range
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2298156442
Can you help add some steps in README.md like the following examples ,so
that the doc is more user friendly ?
1. Log in to the Gravitino playground Trino pod using the
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1722809443
##
README.md:
##
@@ -229,3 +229,9 @@ select * from catalog_iceberg.sales.customers;
Apache Gravitino is an effort undergoing incubation at The Apache Soft
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2296442320
After I try to access gravitino ui , gravitino pod is restarting. I think
the resources for the pod of gravitino is not enough . After I changed to the
following configurati
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2296416879
I didn't see the dependency logic in docker-compose.yaml that is implemented
in helm chart yaml. I think these dependencies are important for pod launch.
--
This is an auto
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1721680582
##
helm-chart/values.yaml:
##
@@ -0,0 +1,150 @@
+# Global settings
+global:
+ storageClass: ""
+ namespace: gravitino-playground
+
+# Hive settings
+hive
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1721676175
##
helm-chart/values.yaml:
##
@@ -0,0 +1,150 @@
+# Global settings
+global:
+ storageClass: ""
+ namespace: gravitino-playground
+
+# Hive settings
+hive
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1720883578
##
helm-chart/templates/spark.yaml:
##
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the messa
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1720883484
##
helm-chart/templates/hive.yaml:
##
@@ -0,0 +1,74 @@
+# templates/hive.yaml
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: {{ .Release.N
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1720881734
##
.DS_Store:
##
Review Comment:
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1720881734
##
.DS_Store:
##
Review Comment:
I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1720881673
##
helm-chart/values.yaml:
##
@@ -0,0 +1,150 @@
+# Global settings
+global:
+ storageClass: ""
+ namespace: gravitino-playground
+
+# Hive settings
+hive
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1720881544
##
helm-chart/values.yaml:
##
@@ -0,0 +1,150 @@
+# Global settings
+global:
+ storageClass: ""
+ namespace: gravitino-playground
+
+# Hive settings
+hive
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1710396459
##
helm-chart/templates/spark.yaml:
##
Review Comment:
This is because I forgot to add files in `init/spark` and forgot to call the
init script.
I
unknowntpo commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1710395643
##
helm-chart/templates/_helpers.tpl:
##
@@ -0,0 +1,62 @@
+{{/*
+Expand the name of the chart.
+*/}}
+{{- define "gravitino-playground.name" -}}
+{{- defau
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705327571
##
helm-chart/values.yaml:
##
@@ -0,0 +1,150 @@
+# Global settings
+global:
+ storageClass: ""
+ namespace: gravitino-playground
+
+# Hive settings
+hive
danhuawang commented on PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#issuecomment-2270958178
I failed to install it in a new namespace named as `test`.
```
ubuntu@ip-10-0-4-171:~$ helm upgrade --install gravitino-playground
./gravitino-playground --create-namesp
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705299205
##
helm-chart/values.yaml:
##
@@ -0,0 +1,150 @@
+# Global settings
+global:
+ storageClass: ""
+ namespace: gravitino-playground
+
+# Hive settings
+hive
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705288994
##
helm-chart/templates/NOTES.txt:
##
Review Comment:
The command that print on console is incorrect?
```
ubuntu@ip-10-0-4-171:~$ kubectl get po
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705284190
##
helm-chart/templates/spark.yaml:
##
Review Comment:
```
gravitino-playground-spark-6cd88b7997-7h6dn0/1 CrashLoopBackOff
9 (46s ag
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705238701
##
helm-chart/templates/_helpers.tpl:
##
@@ -0,0 +1,62 @@
+{{/*
+Expand the name of the chart.
+*/}}
+{{- define "gravitino-playground.name" -}}
+{{- defau
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705212866
##
helm-chart/values.yaml:
##
@@ -0,0 +1,150 @@
+# Global settings
+global:
+ storageClass: ""
+ namespace: gravitino-playground
+
+# Hive settings
+hive
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705162434
##
helm-chart/templates/mysql.yaml:
##
@@ -0,0 +1,66 @@
+# templates/mysql.yaml
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: {{ .Release
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705142527
##
helm-chart/templates/hive.yaml:
##
@@ -0,0 +1,74 @@
+# templates/hive.yaml
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: {{ .Release.N
danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705010451
##
.DS_Store:
##
Review Comment:
Why this .DS_Store is uploaded? I suppose it's not necessary.
--
This is an automated message from the Apache Git
unknowntpo opened a new pull request, #56:
URL: https://github.com/apache/gravitino-playground/pull/56
This is a draft PR for adding helm chart.
TODO:
- [ ] Add documentation
FIXME:
- [ ] Use env var to pass dns name, don't hard code it, like `hive`, `trino`.
- [ ] Bina
69 matches
Mail list logo
