danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705162434
##########
helm-chart/templates/mysql.yaml:
##########
@@ -0,0 +1,66 @@
+# templates/mysql.yaml
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: {{ .Release.Name }}-mysql
+ namespace: {{ .Values.global.namespace }}
+ labels:
+ app: {{ .Release.Name }}-mysql
+spec:
+ replicas: 1
+ selector:
+ matchLabels:
+ app: {{ .Release.Name }}-mysql
+ template:
+ metadata:
+ labels:
+ app: {{ .Release.Name }}-mysql
+ spec:
+ containers:
+ - name: mysql
+ image: "{{ .Values.mysql.image.repository }}:{{
.Values.mysql.image.tag }}"
+ ports:
+ - containerPort: 3306
+ env:
+ - name: MYSQL_ROOT_PASSWORD
+ value: mysql
+ - name: MYSQL_USER
+ value: mysql
+ - name: MYSQL_PASSWORD
+ value: mysql
+ - name: MYSQL_DATABASE
+ value: db
Review Comment:
Can we move these environment variables to values.yaml and use place holder
in yaml template?
```
env:
{{- toYaml .Values.env | nindent 12 }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
