danhuawang commented on code in PR #56:
URL:
https://github.com/apache/gravitino-playground/pull/56#discussion_r1705142527
##########
helm-chart/templates/hive.yaml:
##########
@@ -0,0 +1,74 @@
+# templates/hive.yaml
+---
+apiVersion: apps/v1
+kind: Deployment
+metadata:
+ name: {{ .Release.Name }}-hive
+ namespace: {{ .Values.global.namespace }}
+ labels:
+ app: {{ .Release.Name }}-hive
+spec:
+ replicas: 1
+ selector:
+ matchLabels:
+ app: {{ .Release.Name }}-hive
+ template:
+ metadata:
+ labels:
+ app: {{ .Release.Name }}-hive
+ spec:
+ containers:
+ - name: hive
+ image: "{{ .Values.hive.image.repository }}:{{ .Values.hive.image.tag
}}"
+ ports:
+ - containerPort: 3306
+ - containerPort: 9000
+ - containerPort: 9083
+ - containerPort: 50070
+ readinessProbe:
+ exec:
+ command: ["/tmp/check-status.sh"]
+ periodSeconds: 10
+ timeoutSeconds: 60
+ failureThreshold: 5
+ env:
+ - name: HADOOP_USER_NAME
+ value: root
Review Comment:
The environment variable `HADOOP_USER_NAME` is hard code in yaml template.
Since `HADOOP_USER_NAME` is also defined in spark , trino yaml template and
these values is required to be the same in playground environment. I suggest
replace the value with placeholder in template yaml and set the default value
"root" in values.yaml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
