xunliu closed issue #5993: [Subtask] Move the JdbcAuthorizationPlugin to
`authorization-common` module
URL: https://github.com/apache/gravitino/issues/5993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
xunliu merged PR #5994:
URL: https://github.com/apache/gravitino/pull/5994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitino
This is an automated email from the ASF dual-hosted git repository.
liuxun pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 061f24bcae [#5993] refactor: Move the JdbcAuthori
xunliu closed issue #5993: [Subtask] Move the JdbcAuthorizationPlugin to
`authorization-common` module
URL: https://github.com/apache/gravitino/issues/5993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
FANNG1 commented on code in PR #5995:
URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897718598
##
core/src/main/java/org/apache/gravitino/credential/CredentialUtils.java:
##
@@ -19,14 +19,74 @@
package org.apache.gravitino.credential;
+import com.google.com
FANNG1 commented on code in PR #5995:
URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897718392
##
core/src/main/java/org/apache/gravitino/credential/CatalogCredentialManager.java:
##
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
FANNG1 commented on code in PR #5995:
URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897718087
##
core/src/main/java/org/apache/gravitino/credential/CatalogCredentialContext.java:
##
@@ -35,4 +35,27 @@ public CatalogCredentialContext(String userName) {
public
unknowntpo commented on code in PR #5964:
URL: https://github.com/apache/gravitino/pull/5964#discussion_r1897712615
##
clients/client-python/gravitino/api/expressions/partitions/list_partition.py:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
unknowntpo commented on code in PR #5964:
URL: https://github.com/apache/gravitino/pull/5964#discussion_r1897712615
##
clients/client-python/gravitino/api/expressions/partitions/list_partition.py:
##
@@ -0,0 +1,46 @@
+# Licensed to the Apache Software Foundation (ASF) under one
unknowntpo commented on code in PR #5964:
URL: https://github.com/apache/gravitino/pull/5964#discussion_r1897712212
##
clients/client-python/gravitino/api/expressions/partitions/identity_partition.py:
##
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under
mchades closed issue #5817: [Subtask]Implement the server rest endpoint for
model catalog.
URL: https://github.com/apache/gravitino/issues/5817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
This is an automated email from the ASF dual-hosted git repository.
mchades pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new a68e5e22ad [#5817] core(feat): Add server-side R
mchades closed issue #5817: [Subtask]Implement the server rest endpoint for
model catalog.
URL: https://github.com/apache/gravitino/issues/5817
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
mchades merged PR #5948:
URL: https://github.com/apache/gravitino/pull/5948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravitin
jerqi commented on code in PR #5999:
URL: https://github.com/apache/gravitino/pull/5999#discussion_r1897705443
##
server/src/main/java/org/apache/gravitino/server/web/ConfigServlet.java:
##
Review Comment:
Added a UT.
--
This is an automated message from the Apache Git
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897696107
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897696107
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897681166
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
Abyss-lord commented on PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#issuecomment-2562231460
> Probably not. You might want to grant multiple permissions at once (which
is supported), but it's perhaps not that common to grant or revoke to/from
multiple roles at once.
Abyss-lord commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897690099
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userName
jerryshao commented on code in PR #5806:
URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897692106
##
docs/how-to-use-gvfs.md:
##
@@ -137,8 +137,13 @@ You can configure these properties in two ways:
```
:::note
-If you want to access the S3, GCS, OSS o
Abyss-lord commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897690099
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userName
FANNG1 commented on PR #5995:
URL: https://github.com/apache/gravitino/pull/5995#issuecomment-2562224231
@tengqm @jerryshao @yuqi1129 @orenccl , it's ready to review now, please
help to review thanks
--
This is an automated message from the Apache Git Service.
To respond to the message,
mchades commented on code in PR #5999:
URL: https://github.com/apache/gravitino/pull/5999#discussion_r1897686765
##
server/src/main/java/org/apache/gravitino/server/web/ConfigServlet.java:
##
Review Comment:
suggest adding UT to cover the changes
--
This is an automated
jerqi commented on PR #5999:
URL: https://github.com/apache/gravitino/pull/5999#issuecomment-256456
cc @lw-yang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897681166
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897681166
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897681166
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
Abyss-lord commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897678820
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userName
justinmclean commented on PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#issuecomment-2562214425
Probably not. You might want to grant multiple permissions at once (which is
supported), but it's perhaps not that common to grant or revoke to/from
multiple roles at once.
--
T
orenccl commented on PR #5998:
URL: https://github.com/apache/gravitino/pull/5998#issuecomment-2562214323
It would be better to turn this PR into a draft before updating the unit
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897490774
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -775,6 +786,11 @@ protected void handleRoleCommand() {
}
}
+ pr
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897674764
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897673684
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
orenccl commented on issue #5536:
URL: https://github.com/apache/gravitino/issues/5536#issuecomment-2562205222
Working on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
hdygxsj commented on PR #5818:
URL: https://github.com/apache/gravitino/pull/5818#issuecomment-2562203368
Is there anything else that needs to be changed @FANNG1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jerqi commented on PR #5999:
URL: https://github.com/apache/gravitino/pull/5999#issuecomment-2562203427
> Should the value be `"[Simple]"` or `["Simple"]`?
You are right. It should be `["simple"]`.
--
This is an automated message from the Apache Git Service.
To respond to the messag
Abyss-lord commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897661512
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userName
Abyss-lord commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897661512
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userName
liangyouze opened a new issue, #6000:
URL: https://github.com/apache/gravitino/issues/6000
### Version
main branch
### Describe what's wrong
Because of the config such as s3-access-key-id and s3-secret-access-key are
hidden，the Iceberg Rest Catalog service cannot get AKS
Abyss-lord commented on PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#issuecomment-2562183700
@justinmclean Should `GRANT` and `revoke` also support multiple values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
tengqm commented on PR #5999:
URL: https://github.com/apache/gravitino/pull/5999#issuecomment-2562175276
Should the value be `"[Simple]"` or `["Simple"]`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
liuchunhao commented on code in PR #5977:
URL: https://github.com/apache/gravitino/pull/5977#discussion_r1897637617
##
bin/common.sh:
##
@@ -18,6 +18,13 @@
# Referred from Apache Submarine's common.sh implementation
# bin/common.sh
+GRAVITINO_VERSION=GRAVITINO_VERSION_PLACEH
justinmclean commented on PR #5843:
URL: https://github.com/apache/gravitino/pull/5843#issuecomment-2562162609
Given they have not answered in a week, you can take over it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
tengqm commented on code in PR #5992:
URL: https://github.com/apache/gravitino/pull/5992#discussion_r1897634614
##
catalogs/catalog-common/src/main/java/org/apache/gravitino/storage/GCSProperties.java:
##
@@ -22,7 +22,7 @@
public class GCSProperties {
// The path of servic
Abyss-lord commented on PR #5843:
URL: https://github.com/apache/gravitino/pull/5843#issuecomment-2562152843
> @muhammed-mamun are you still working on this?
@justinmclean If he doesn't continue, can you give me the task
--
This is an automated message from the Apache Git Service.
T
jerryshao merged PR #5682:
URL: https://github.com/apache/gravitino/pull/5682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gravit
This is an automated email from the ASF dual-hosted git repository.
jshao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 082bbdc157 [#5620] feat(fileset): Support credenti
jerryshao closed issue #5620: [Subtask] Support credential vending for fileset
catalog
URL: https://github.com/apache/gravitino/issues/5620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
jerryshao closed issue #5620: [Subtask] Support credential vending for fileset
catalog
URL: https://github.com/apache/gravitino/issues/5620
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
jerqi commented on PR #5999:
URL: https://github.com/apache/gravitino/pull/5999#issuecomment-2562116340
cc @LauraXia123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jerqi opened a new pull request, #5999:
URL: https://github.com/apache/gravitino/pull/5999
### What changes were proposed in this pull request?
Add more configurations for the config API
### Why are the changes needed?
Front end can use this config option to optimize the
orenccl commented on code in PR #5998:
URL: https://github.com/apache/gravitino/pull/5998#discussion_r1897584898
##
core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java:
##
@@ -72,7 +85,10 @@ public Tag getTag(String metalake, String name) throws
NoSuchTagEx
jerqi commented on issue #5987:
URL: https://github.com/apache/gravitino/issues/5987#issuecomment-2562109678
I will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897587463
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
justinmclean commented on code in PR #5975:
URL: https://github.com/apache/gravitino/pull/5975#discussion_r1897586732
##
clients/cli/src/main/java/org/apache/gravitino/cli/outputs/PlainFormat.java:
##
@@ -80,4 +83,11 @@ public void output(Catalog[] catalogs) {
System.out.
justinmclean merged PR #5978:
URL: https://github.com/apache/gravitino/pull/5978
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gra
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new f7656bec17 [#5930] improvement(CLI): improve unk
justinmclean closed issue #5930: [Improvement] In the Gravitino CLI add an
unknown tags give no error
URL: https://github.com/apache/gravitino/issues/5930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
justinmclean closed issue #5930: [Improvement] In the Gravitino CLI add an
unknown tags give no error
URL: https://github.com/apache/gravitino/issues/5930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
TungYuChiang opened a new pull request, #5998:
URL: https://github.com/apache/gravitino/pull/5998
### What changes were proposed in this pull request?
1. Create corresponding event like ListTagEvent
2. Add corresponding event to TagEventDispatcher
### Why are the changes need
FANNG1 commented on code in PR #5682:
URL: https://github.com/apache/gravitino/pull/5682#discussion_r1897575367
##
core/src/main/java/org/apache/gravitino/connector/credential/SupportsPathBasedCredentials.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundat
unknowntpo commented on PR #5905:
URL: https://github.com/apache/gravitino/pull/5905#issuecomment-2562096085
> Finally, we need to verify the log format to see if it meets expectations.
This needs to be validated in the #5886, and you can wait for it to be merged.
Since #5886 is done,
jerryshao commented on code in PR #5682:
URL: https://github.com/apache/gravitino/pull/5682#discussion_r1897569317
##
core/src/main/java/org/apache/gravitino/connector/credential/SupportsPathBasedCredentials.java:
##
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foun
FANNG1 commented on code in PR #5992:
URL: https://github.com/apache/gravitino/pull/5992#discussion_r1897569468
##
catalogs/catalog-common/src/main/java/org/apache/gravitino/storage/GCSProperties.java:
##
@@ -22,7 +22,7 @@
public class GCSProperties {
// The path of servic
FANNG1 commented on PR #5990:
URL: https://github.com/apache/gravitino/pull/5990#issuecomment-2562090498
updating the PR to replace `adls-sas-token` with `adls-token` for the
credential type of `ADLSTokenCredential` to keep with other credential types
like `s3-token`, `oss-token`, `gcs-toke
xunliu commented on PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#issuecomment-2562084359
@Abyss-lord Please fix the conflicting file. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
jerqi commented on code in PR #5994:
URL: https://github.com/apache/gravitino/pull/5994#discussion_r1897555156
##
authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/JdbcAuthorizationPlugin.java:
##
Review Comment:
Moved.
--
This
yuqi1129 opened a new pull request, #5997:
URL: https://github.com/apache/gravitino/pull/5997
### What changes were proposed in this pull request?
Support using credentail in GVFS python client for cloud storage.
### Why are the changes needed?
It's need.
Fix:
yuqi1129 opened a new issue, #5996:
URL: https://github.com/apache/gravitino/issues/5996
### Describe the feature
This is a mirror issue for #5973
### Motivation
_No response_
### Describe the solution
_No response_
### Additional context
_No r
FANNG1 commented on code in PR #5682:
URL: https://github.com/apache/gravitino/pull/5682#discussion_r1897544784
##
core/src/main/java/org/apache/gravitino/connector/credential/PathBasedContext.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
tengqm commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897519512
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userName = l
tengqm commented on PR #5990:
URL: https://github.com/apache/gravitino/pull/5990#issuecomment-2562036095
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
tengqm commented on code in PR #5992:
URL: https://github.com/apache/gravitino/pull/5992#discussion_r1897514556
##
catalogs/catalog-common/src/main/java/org/apache/gravitino/storage/GCSProperties.java:
##
@@ -22,7 +22,7 @@
public class GCSProperties {
// The path of servic
tengqm commented on code in PR #5995:
URL: https://github.com/apache/gravitino/pull/5995#discussion_r1897510667
##
core/src/main/java/org/apache/gravitino/credential/CatalogCredentialContext.java:
##
@@ -35,4 +35,27 @@ public CatalogCredentialContext(String userName) {
public
liuchunhao commented on PR #5977:
URL: https://github.com/apache/gravitino/pull/5977#issuecomment-2562021955
> I will use your PR to test, because `gravitino.sh` is very important. So,
I need some time to review this PR. Thanks.
I ran `./gradle clean build compileDistribution` with al
justinmclean commented on issue #5962:
URL: https://github.com/apache/gravitino/issues/5962#issuecomment-2562017180
Thanks for offering to help, I'm currently on holiday and might be slow to
respond.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
justinmclean commented on code in PR #5977:
URL: https://github.com/apache/gravitino/pull/5977#discussion_r1897496152
##
bin/common.sh:
##
@@ -18,6 +18,13 @@
# Referred from Apache Submarine's common.sh implementation
# bin/common.sh
+GRAVITINO_VERSION=GRAVITINO_VERSION_PLAC
justinmclean commented on issue #5957:
URL: https://github.com/apache/gravitino/issues/5957#issuecomment-2562015624
You can leave the existing method as `output(catalogs)` and just have that
method output "No catalogs exist." if null is passed into it.
--
This is an automated message from
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897491486
##
clients/cli/src/test/java/org/apache/gravitino/cli/TestRoleCommands.java:
##
@@ -214,4 +295,23 @@ void testRevokePrivilegesFromRole() {
commandLine.handl
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897491193
##
clients/cli/src/test/java/org/apache/gravitino/cli/TestRoleCommands.java:
##
@@ -36,17 +42,35 @@
import org.apache.gravitino.cli.commands.RevokePrivilegesFro
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897491049
##
clients/cli/src/main/java/org/apache/gravitino/cli/commands/DeleteRole.java:
##
@@ -38,28 +39,30 @@ public class DeleteRole extends Command {
* @param ign
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897490774
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -775,6 +786,11 @@ protected void handleRoleCommand() {
}
}
+ pr
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897490349
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
justinmclean commented on code in PR #5988:
URL: https://github.com/apache/gravitino/pull/5988#discussion_r1897490349
##
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java:
##
@@ -733,17 +733,26 @@ protected void handleRoleCommand() {
String userNa
justinmclean closed issue #5861: [Improvement] Refactor the validation logic in
the handle methods
URL: https://github.com/apache/gravitino/issues/5861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 304ef70c3 [#5861] improvement(CLI): Refactor the
justinmclean merged PR #5972:
URL: https://github.com/apache/gravitino/pull/5972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@gra
justinmclean commented on PR #5972:
URL: https://github.com/apache/gravitino/pull/5972#issuecomment-2562009630
Adding a validate method or similar to commands has already been proposed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
justinmclean commented on PR #5972:
URL: https://github.com/apache/gravitino/pull/5972#issuecomment-2562008069
@tengqm see #5861 - this is currently waiting for review/merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jerryshao commented on PR #5682:
URL: https://github.com/apache/gravitino/pull/5682#issuecomment-2561912448
Generally LGTM, just two small issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jerryshao commented on code in PR #5682:
URL: https://github.com/apache/gravitino/pull/5682#discussion_r1897387815
##
core/src/main/java/org/apache/gravitino/credential/CredentialUtils.java:
##
@@ -19,14 +19,74 @@
package org.apache.gravitino.credential;
+import com.google.
yuqi1129 commented on PR #5806:
URL: https://github.com/apache/gravitino/pull/5806#issuecomment-2561911255
I have changed other documents slightly, it's quite time-consuming to change
them all, and I would rather optimize them later.
--
This is an automated message from the Apache Git Se
jerryshao commented on code in PR #5682:
URL: https://github.com/apache/gravitino/pull/5682#discussion_r1897387260
##
core/src/main/java/org/apache/gravitino/connector/credential/PathBasedContext.java:
##
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
yuqi1129 commented on code in PR #5806:
URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897385300
##
docs/cloud-storage-fileset-example.md:
##
@@ -0,0 +1,676 @@
+---
+title: "How to use cloud storage fileset"
+slug: /how-to-use-cloud-storage-fileset
+keyword: fil
yuqi1129 commented on code in PR #5806:
URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897385407
##
build.gradle.kts:
##
@@ -779,7 +779,9 @@ tasks {
!it.name.startsWith("client") && !it.name.startsWith("filesystem") &&
!it.name.startsWith("spark") && !
FANNG1 opened a new pull request, #5995:
URL: https://github.com/apache/gravitino/pull/5995
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
(Please clarify why the c
mchades commented on code in PR #5806:
URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897382901
##
build.gradle.kts:
##
@@ -779,7 +779,9 @@ tasks {
!it.name.startsWith("client") && !it.name.startsWith("filesystem") &&
!it.name.startsWith("spark") && !i
yuqi1129 commented on code in PR #5806:
URL: https://github.com/apache/gravitino/pull/5806#discussion_r1897381028
##
docs/cloud-storage-fileset-example.md:
##
@@ -0,0 +1,676 @@
+---
+title: "How to use cloud storage fileset"
+slug: /how-to-use-cloud-storage-fileset
+keyword: fil
xunliu commented on code in PR #5994:
URL: https://github.com/apache/gravitino/pull/5994#discussion_r1897377607
##
authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/JdbcAuthorizationPlugin.java:
##
Review Comment:
I think it is bett
1 - 100 of 132 matches
Mail list logo
