justinmclean commented on code in PR #5977: URL: https://github.com/apache/gravitino/pull/5977#discussion_r1897496152
########## bin/common.sh: ########## @@ -18,6 +18,13 @@ # Referred from Apache Submarine's common.sh implementation # bin/common.sh +GRAVITINO_VERSION=GRAVITINO_VERSION_PLACEHOLDER +if [[ "$GRAVITINO_VERSION" == *_VERSION_PLACEHOLDER ]]; then + echo "GRAVITINO_VERSION is not set. Please make sure you are running the script from the distribution/package/bin and before running the script, run './gradle clean build -x test compileDistribution'" + exit 1 Review Comment: "Run the gravitino.sh script in the release package." this may not be the best instructions, as an ASF release package is source, not binary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
