unknowntpo commented on code in PR #5964: URL: https://github.com/apache/gravitino/pull/5964#discussion_r1897712615
########## clients/client-python/gravitino/api/expressions/partitions/list_partition.py: ########## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from abc import abstractmethod +from typing import List, Any +from .partition import Partition + +class ListPartition(Partition): + """ + A list partition represents a result of list partitioning. For example, for list partition + + ``` + PARTITION p202204_California VALUES IN ( + ("2022-04-01", "Los Angeles"), + ("2022-04-01", "San Francisco") + ) + ``` + + its name is "p202204_California" and lists are [["2022-04-01","Los Angeles"], ["2022-04-01", "San Francisco"]]. + + This class is evolving and may change in future versions. + """ + + @abstractmethod + def lists(self) -> List[List[Any]]: Review Comment: > We can use `Literal`, This line code may be like this? > > ``` > def lists(self) -> List[List[Literal]]: > ``` We should defined it at ``` > def lists(self) -> List[List[Literal[Any]]]: ``` ########## clients/client-python/gravitino/api/expressions/partitions/list_partition.py: ########## @@ -0,0 +1,46 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from abc import abstractmethod +from typing import List, Any +from .partition import Partition + +class ListPartition(Partition): + """ + A list partition represents a result of list partitioning. For example, for list partition + + ``` + PARTITION p202204_California VALUES IN ( + ("2022-04-01", "Los Angeles"), + ("2022-04-01", "San Francisco") + ) + ``` + + its name is "p202204_California" and lists are [["2022-04-01","Los Angeles"], ["2022-04-01", "San Francisco"]]. + + This class is evolving and may change in future versions. + """ + + @abstractmethod + def lists(self) -> List[List[Any]]: Review Comment: > We can use `Literal`, This line code may be like this? > > ``` > def lists(self) -> List[List[Literal]]: > ``` We should defined it as ``` > def lists(self) -> List[List[Literal[Any]]]: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
