Re: [PR] [feat](nereids) support Iceberg time travel syntax [doris]

2024-05-13 Thread via GitHub
zhangbutao commented on code in PR #34681: URL: https://github.com/apache/doris/pull/34681#discussion_r1599310349 ## fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/UnboundRelation.java: ## @@ -59,41 +60,46 @@ public class UnboundRelation extends LogicalRelation impl

Re: [PR] [bump](fe)upgrade dependencies [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34800: URL: https://github.com/apache/doris/pull/34800#issuecomment-2109179768 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [bump](fe)upgrade dependencies [doris]

2024-05-13 Thread via GitHub
CalvinKirs commented on PR #34800: URL: https://github.com/apache/doris/pull/34800#issuecomment-2109180348 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [fix](group_commit) Wal reader should check block length to avoid reading empty block [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34792: URL: https://github.com/apache/doris/pull/34792#issuecomment-2109180359 TPC-H: Total hot run time: 41274 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109180449 TPC-H: Total hot run time: 41988 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [doc](fix) add caution for `group_concat` and `lateral view` [doris-website]

2024-05-13 Thread via GitHub
luzhijing merged PR #646: URL: https://github.com/apache/doris-website/pull/646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dori

Re: [PR] [Feature](function)support array-match-any function [doris]

2024-05-13 Thread via GitHub
morrySnow commented on code in PR #34501: URL: https://github.com/apache/doris/pull/34501#discussion_r1599310861 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/expression/rules/ArrayMatchAnyExpander.java: ## @@ -61,28 +61,32 @@ public Rule build() { } Pla

Re: [PR] [doc](stream load) Correct Some Mistakes [doris-website]

2024-05-13 Thread via GitHub
luzhijing merged PR #641: URL: https://github.com/apache/doris-website/pull/641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dori

(doris-website) branch master updated: [doc](fix) add caution for `group_concat` and `lateral view` (#646)

2024-05-13 Thread luzhijing
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 13096ed967f [doc](fix) add caution for

Error while running notifications feature from .asf.yaml in doris-website!

2024-05-13 Thread Apache Infrastructure
An error occurred while running notifications feature in .asf.yaml!: Invalid notification target 'comm...@foo.apache.org'. Must be a valid @doris.apache.org list! - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

Re: [PR] [doc](OUTFILE) Fix some typos [doris-website]

2024-05-13 Thread via GitHub
luzhijing merged PR #645: URL: https://github.com/apache/doris-website/pull/645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@dori

Error while running notifications feature from .asf.yaml in doris-website!

2024-05-13 Thread Apache Infrastructure
An error occurred while running notifications feature in .asf.yaml!: Invalid notification target 'comm...@foo.apache.org'. Must be a valid @doris.apache.org list! - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

Error while running notifications feature from .asf.yaml in doris-website!

2024-05-13 Thread Apache Infrastructure
An error occurred while running notifications feature in .asf.yaml!: Invalid notification target 'comm...@foo.apache.org'. Must be a valid @doris.apache.org list! - To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

(doris-website) branch master updated: [doc](OUTFILE) Fix some typos (#645)

2024-05-13 Thread luzhijing
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 6ddf2168a29 [doc](OUTFILE) Fix some ty

(doris-website) branch master updated: [doc](stream load) Correct Some Mistakes (#641)

2024-05-13 Thread luzhijing
This is an automated email from the ASF dual-hosted git repository. luzhijing pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris-website.git The following commit(s) were added to refs/heads/master by this push: new 9af02aee6c1 [doc](stream load) Correct

Re: [PR] [refactor](jdbc catalog) split clickhouse jdbc executor [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34794: URL: https://github.com/apache/doris/pull/34794#issuecomment-2109181974 TPC-H: Total hot run time: 41616 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Feat](nereids)when dealing insert into stmt with empty table source, fe returns directly [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34418: URL: https://github.com/apache/doris/pull/34418#issuecomment-2109182346 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](jdbc catalog) fix jdbc table checksum and query jdbc tvf [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34779: URL: https://github.com/apache/doris/pull/34779#issuecomment-2109182969 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](function) fix pad functions behaviour of empty pad string [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34796: URL: https://github.com/apache/doris/pull/34796#issuecomment-2109183063 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Fix](function) money format [doris]

2024-05-13 Thread via GitHub
jacktengg commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599312403 ## be/src/vec/functions/function_string.h: ## @@ -2961,18 +2965,77 @@ class FunctionMoneyFormat : public IFunction { namespace MoneyFormat { +constexpr size_t MA

Re: [PR] [Fix](function) money format [doris]

2024-05-13 Thread via GitHub
zhiqiang- commented on code in PR #34680: URL: https://github.com/apache/doris/pull/34680#discussion_r1599313151 ## be/src/vec/functions/function_string.h: ## @@ -2961,18 +2965,77 @@ class FunctionMoneyFormat : public IFunction { namespace MoneyFormat { +constexpr size_

Re: [PR] [fix](multi-table-load) fix be core when partial table load failed [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34712: URL: https://github.com/apache/doris/pull/34712#issuecomment-2109184232 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](multi-table-load) fix be core when partial table load failed [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34712: URL: https://github.com/apache/doris/pull/34712#issuecomment-2109184259 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](IO) Fix async close's raii and lazily load jni's jvm max heap value [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34799: URL: https://github.com/apache/doris/pull/34799#issuecomment-2109184694 TeamCity be ut coverage result: Function Coverage: 35.67% (8982/25180) Line Coverage: 27.33% (74266/271748) Region Coverage: 26.56% (38364/19) Branch Coverage: 23.3

(doris) branch master updated (a1607011c07 -> dae90d30f5d)

2024-05-13 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from a1607011c07 [opt](mtmv) Cache materialization check result for performance (#34301) add dae90d30f5d [Feat](ner

Re: [PR] [Feat](nereids)when dealing insert into stmt with empty table source, fe returns directly [doris]

2024-05-13 Thread via GitHub
morrySnow merged PR #34418: URL: https://github.com/apache/doris/pull/34418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

Re: [PR] [fix](iceberg) prevent coredump if read position delete file failed [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34797: URL: https://github.com/apache/doris/pull/34797#issuecomment-2109185691 TPC-DS: Total hot run time: 187545 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Chore](case) move test_ctas_mv,test_mv_case to single directory [doris]

2024-05-13 Thread via GitHub
BiteThet commented on PR #34801: URL: https://github.com/apache/doris/pull/34801#issuecomment-2109188278 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(doris) branch master updated (dae90d30f5d -> b9deb890218)

2024-05-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from dae90d30f5d [Feat](nereids) when dealing insert into stmt with empty table source, fe returns directly (#34418)

Re: [PR] [Chore](case) move test_ctas_mv,test_mv_case to single directory [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34801: URL: https://github.com/apache/doris/pull/34801#issuecomment-2109188256 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](runtimefilter)slot comparison bug [doris]

2024-05-13 Thread via GitHub
yiguolei merged PR #34791: URL: https://github.com/apache/doris/pull/34791 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[PR] [Chore](case) move test_ctas_mv,test_mv_case to single directory [doris]

2024-05-13 Thread via GitHub
BiteThet opened a new pull request, #34801: URL: https://github.com/apache/doris/pull/34801 ## Proposed changes Each db can only execute createmv action serially ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.a

Re: [PR] [improvement](spill) fuzzy spill and fix bugs [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #33291: URL: https://github.com/apache/doris/pull/33291#issuecomment-2109189011 TPC-DS: Total hot run time: 187548 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](group_commit) Wal reader should check block length to avoid reading empty block [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34792: URL: https://github.com/apache/doris/pull/34792#issuecomment-2109189655 TPC-DS: Total hot run time: 187412 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109189722 TPC-DS: Total hot run time: 187889 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [fix](IO) Fix async close's raii and lazily load jni's jvm max heap value [doris]

2024-05-13 Thread via GitHub
ByteYue commented on PR #34799: URL: https://github.com/apache/doris/pull/34799#issuecomment-2109190086 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] [refactor](jdbc catalog) split clickhouse jdbc executor [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34794: URL: https://github.com/apache/doris/pull/34794#issuecomment-2109190875 TPC-DS: Total hot run time: 186956 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

[PR] [fix](iceberg) prevent coredump if read position delete file failed [doris]

2024-05-13 Thread via GitHub
AshinGau opened a new pull request, #34802: URL: https://github.com/apache/doris/pull/34802 ## Proposed changes backport: #34797 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apac

Re: [PR] [fix](iceberg) prevent coredump if read position delete file failed [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34802: URL: https://github.com/apache/doris/pull/34802#issuecomment-2109191217 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](iceberg) prevent coredump if read position delete file failed [doris]

2024-05-13 Thread via GitHub
AshinGau commented on PR #34802: URL: https://github.com/apache/doris/pull/34802#issuecomment-2109191400 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
XieJiann commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109191812 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [feat](nereids) support Iceberg time travel syntax [doris]

2024-05-13 Thread via GitHub
zhangbutao commented on PR #34681: URL: https://github.com/apache/doris/pull/34681#issuecomment-2109192782 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34761: URL: https://github.com/apache/doris/pull/34761#issuecomment-2109192861 TPC-H: Total hot run time: 40258 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](user manager) Add rwlock for userManager [doris]

2024-05-13 Thread via GitHub
deardeng commented on PR #34699: URL: https://github.com/apache/doris/pull/34699#issuecomment-2109193647 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [bugfix](hive)fix error for writing to hive [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34520: URL: https://github.com/apache/doris/pull/34520#issuecomment-2109193813 TeamCity be ut coverage result: Function Coverage: 35.67% (8982/25180) Line Coverage: 27.33% (74262/271758) Region Coverage: 26.56% (38372/144455) Branch Coverage: 23.3

[PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]

2024-05-13 Thread via GitHub
BiteThet opened a new pull request, #34803: URL: https://github.com/apache/doris/pull/34803 ## Proposed changes pick from #32662 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto:d...@doris.apac

Re: [PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34803: URL: https://github.com/apache/doris/pull/34803#issuecomment-2109193912 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]

2024-05-13 Thread via GitHub
BiteThet commented on PR #34803: URL: https://github.com/apache/doris/pull/34803#issuecomment-2109194105 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109194464 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109194487 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [Bug](regression) Fix occasional timeout issues [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34691: URL: https://github.com/apache/doris/pull/34691#issuecomment-2109195624 TeamCity be ut coverage result: Function Coverage: 35.67% (8987/25195) Line Coverage: 27.32% (74272/271842) Region Coverage: 26.56% (38383/144519) Branch Coverage: 23.3

Re: [PR] [fix](iceberg) prevent coredump if read position delete file failed [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34802: URL: https://github.com/apache/doris/pull/34802#issuecomment-2109196601 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

(doris) branch branch-2.1 updated: [fix](runtimefilter)slot comparison bug #34791

2024-05-13 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch branch-2.1 in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/branch-2.1 by this push: new fcf26c92246 [fix](runtimefilter)slot co

[PR] [fix](cloud) Fix cloudInstanceStatusChecker npe when ms not start [doris]

2024-05-13 Thread via GitHub
deardeng opened a new pull request, #34804: URL: https://github.com/apache/doris/pull/34804 ## Proposed changes Issue Number: close #xxx ![image](https://github.com/apache/doris/assets/3887565/43107907-e213-4046-b78a-8d9ec1aa1915) ## Further comments If this i

Re: [PR] [fix](cloud) Fix cloudInstanceStatusChecker npe when ms not start [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34804: URL: https://github.com/apache/doris/pull/34804#issuecomment-2109197358 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](cloud) Fix cloudInstanceStatusChecker npe when ms not start [doris]

2024-05-13 Thread via GitHub
deardeng commented on PR #34804: URL: https://github.com/apache/doris/pull/34804#issuecomment-2109197599 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [opt](profile) Avoid unnecessary copies in the profile thrift. [doris]

2024-05-13 Thread via GitHub
HappenLee commented on code in PR #34720: URL: https://github.com/apache/doris/pull/34720#discussion_r1599322065 ## be/src/runtime/fragment_mgr.cpp: ## @@ -272,7 +272,7 @@ void FragmentMgr::coordinator_callback(const ReportStatusRequest& req) { detailed_par

[PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-13 Thread via GitHub
Gabriel39 opened a new pull request, #34805: URL: https://github.com/apache/doris/pull/34805 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt

Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34805: URL: https://github.com/apache/doris/pull/34805#issuecomment-2109198710 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Fix](Planner) fix date_xxx functions without complete function signature [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34761: URL: https://github.com/apache/doris/pull/34761#issuecomment-2109201982 TPC-DS: Total hot run time: 187683 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](profile) Avoid unnecessary copies in the profile thrift. [doris]

2024-05-13 Thread via GitHub
HappenLee commented on code in PR #34720: URL: https://github.com/apache/doris/pull/34720#discussion_r1599324762 ## be/src/runtime/runtime_query_statistics_mgr.cpp: ## @@ -151,15 +160,17 @@ TReportExecStatusParams RuntimeQueryStatiticsMgr::create_report_exec_status_para

Re: [PR] [fix](cloud) Fix cloudInstanceStatusChecker npe when ms not start [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34804: URL: https://github.com/apache/doris/pull/34804#issuecomment-2109203540 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](IO) Fix async close's raii and lazily load jni's jvm max heap value [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34799: URL: https://github.com/apache/doris/pull/34799#issuecomment-2109204051 TeamCity be ut coverage result: Function Coverage: 35.67% (8982/25180) Line Coverage: 27.32% (74253/271748) Region Coverage: 26.55% (38358/19) Branch Coverage: 23.3

Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on code in PR #34805: URL: https://github.com/apache/doris/pull/34805#discussion_r1599325595 ## be/src/pipeline/pipeline_task.cpp: ## @@ -218,7 +216,7 @@ bool PipelineTask::_wait_to_start() { return false; } -bool PipelineTask::_is_blocked()

Re: [PR] [ui](profile) Do not do profile format in the FE [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34757: URL: https://github.com/apache/doris/pull/34757#issuecomment-2109205148 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [ui](profile) Do not do profile format in the FE [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34757: URL: https://github.com/apache/doris/pull/34757#issuecomment-2109205195 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109205836 TPC-H: Total hot run time: 40279 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [feat](nereids) support Iceberg time travel syntax [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34681: URL: https://github.com/apache/doris/pull/34681#issuecomment-2109207241 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [improve](exchange) the sink could eos early when all queues have enough rows [doris]

2024-05-13 Thread via GitHub
zhangstar333 commented on PR #34541: URL: https://github.com/apache/doris/pull/34541#issuecomment-2109207270 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feat](nereids) support Iceberg time travel syntax [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34681: URL: https://github.com/apache/doris/pull/34681#issuecomment-2109207268 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [feat](nereids) support Iceberg time travel syntax [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34681: URL: https://github.com/apache/doris/pull/34681#issuecomment-2109209310 TPC-H: Total hot run time: 40423 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [fix](user manager) Add rwlock for userManager [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34699: URL: https://github.com/apache/doris/pull/34699#issuecomment-2109210006 TPC-H: Total hot run time: 40422 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34803: URL: https://github.com/apache/doris/pull/34803#issuecomment-2109211167 TPC-H: Total hot run time: 49641 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [opt](nereids) support topn-filter for all types of scan (including external table) [doris]

2024-05-13 Thread via GitHub
englefly commented on PR #34674: URL: https://github.com/apache/doris/pull/34674#issuecomment-2109213345 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-13 Thread via GitHub
Gabriel39 commented on PR #34805: URL: https://github.com/apache/doris/pull/34805#issuecomment-2109213667 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[PR] [regression-test](framework) fix trino connector download bug in multi be [doris]

2024-05-13 Thread via GitHub
shuke987 opened a new pull request, #34806: URL: https://github.com/apache/doris/pull/34806 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailto

Re: [PR] [regression-test](framework) fix trino connector download bug in multi be [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34806: URL: https://github.com/apache/doris/pull/34806#issuecomment-2109215566 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [fix](Nereids): clone the producer plan and put logicalAnchor generated by `Or_Expansion` above `logicalSink` [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34771: URL: https://github.com/apache/doris/pull/34771#issuecomment-2109215945 TPC-DS: Total hot run time: 187540 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] Datetimev2 binary 2.0 [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34807: URL: https://github.com/apache/doris/pull/34807#issuecomment-2109216700 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] Datetimev2 binary 2.0 [doris]

2024-05-13 Thread via GitHub
nextdreamblue opened a new pull request, #34807: URL: https://github.com/apache/doris/pull/34807 ## Proposed changes cherry-pick from #34662 ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](ma

Re: [PR] Datetimev2 binary 2.0 [doris]

2024-05-13 Thread via GitHub
nextdreamblue commented on PR #34807: URL: https://github.com/apache/doris/pull/34807#issuecomment-2109216766 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [regression-test](framework) fix trino connector download bug in multi be [doris]

2024-05-13 Thread via GitHub
shuke987 commented on PR #34806: URL: https://github.com/apache/doris/pull/34806#issuecomment-2109217356 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

Re: [PR] [fix](cloud) Fix cloudInstanceStatusChecker npe when ms not start [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34804: URL: https://github.com/apache/doris/pull/34804#issuecomment-2109217655 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
BiteThet opened a new pull request, #34808: URL: https://github.com/apache/doris/pull/34808 …_ids going into old topn logic ## Proposed changes fix dcheck failed when _tablet_reader_params.topn_filter_source_node_ids going into old topn logi introduced by https://github.com

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109217877 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34805: URL: https://github.com/apache/doris/pull/34805#issuecomment-2109217939 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
BiteThet commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109218024 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [feat](nereids) support Iceberg time travel syntax [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34681: URL: https://github.com/apache/doris/pull/34681#issuecomment-2109219781 TPC-DS: Total hot run time: 187388 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Improvement](pipeline) blocking tasks before putting in runnable queue [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34805: URL: https://github.com/apache/doris/pull/34805#issuecomment-2109220274 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [fix](user manager) Add rwlock for userManager [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34699: URL: https://github.com/apache/doris/pull/34699#issuecomment-2109220529 TPC-DS: Total hot run time: 187355 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109220802 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [fix](prepare) fix datetimev2 return err when binary_row_format #34662 [doris]

2024-05-13 Thread via GitHub
nextdreamblue commented on PR #34807: URL: https://github.com/apache/doris/pull/34807#issuecomment-2109220885 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109220774 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] [Bug](topn) fix dcheck failed when _tablet_reader_params.topn_filter_source_node… [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34808: URL: https://github.com/apache/doris/pull/34808#issuecomment-2109222680 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [Pick](repeat) fix core dump coz output slot'order on repeat node not match with pre repeat exprs [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34803: URL: https://github.com/apache/doris/pull/34803#issuecomment-2109222711 TPC-DS: Total hot run time: 202378 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34809: URL: https://github.com/apache/doris/pull/34809#issuecomment-2109225839 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [opt](fe) exit FE when transfer to (non)master failed [doris]

2024-05-13 Thread via GitHub
morningman opened a new pull request, #34809: URL: https://github.com/apache/doris/pull/34809 ## Proposed changes 1. If there is exception thrown when doing `transferToMaster` or `tranferToNonMaster`, we should catch it and exit the FE process. Otherwise, the statelistener t

Re: [PR] [optimize](information_schema) optimize the data type of table information_schema.rowsets [doris]

2024-05-13 Thread via GitHub
github-actions[bot] commented on PR #34739: URL: https://github.com/apache/doris/pull/34739#issuecomment-2109226623 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
zhangstar333 opened a new pull request, #34810: URL: https://github.com/apache/doris/pull/34810 if the user input big value of length, maybe cause some memory problem or exceeded size limit of thrift, so add this check to report error for user firstly. ## Proposed changes I

Re: [PR] [improve](function) add limit check for lpad/rpad function input big value of length [doris]

2024-05-13 Thread via GitHub
doris-robot commented on PR #34810: URL: https://github.com/apache/doris/pull/34810#issuecomment-2109226932 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

<    1   2   3   4   5   6   7   8   >