HappenLee commented on code in PR #34720:
URL: https://github.com/apache/doris/pull/34720#discussion_r1599324762
##########
be/src/runtime/runtime_query_statistics_mgr.cpp:
##########
@@ -151,15 +160,17 @@ TReportExecStatusParams
RuntimeQueryStatiticsMgr::create_report_exec_status_para
continue;
}
- load_channel_profiles_req.push_back(*load_channel_profile);
+ load_channel_profiles_req.push_back(std::move(*load_channel_profile));
}
- if (load_channel_profiles_req.size() > 0) {
- profile.__set_load_channel_profiles(load_channel_profiles_req);
+ if (!load_channel_profiles_req.empty()) {
+ profile.__isset.load_channel_profiles = true;
+ profile.load_channel_profiles = std::move(load_channel_profiles_req);
}
TReportExecStatusParams req;
- req.__set_query_profile(profile);
Review Comment:
check the thrift api have a better way？
like```req.__set_query_profile(std::move(profile)```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
