[GitHub] [doris] xiaokang commented on a diff in pull request #16758: [improve](inverted index) Add element count limit for inverted index searcher cache

2023-02-14 Thread via GitHub
xiaokang commented on code in PR #16758: URL: https://github.com/apache/doris/pull/16758#discussion_r1106530628 ## be/src/olap/rowset/segment_v2/inverted_index_cache.cpp: ## @@ -49,6 +49,19 @@ void InvertedIndexSearcherCache::create_global_instance(size_t capacity, uint32_ Inv

[GitHub] [doris] yiguolei merged pull request #16766: [docs](releasenote)1.2.2 release note

2023-02-14 Thread via GitHub
yiguolei merged PR #16766: URL: https://github.com/apache/doris/pull/16766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [docs](releasenote)1.2.2 release note (#16766)

2023-02-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 040a715251 [docs](releasenote)1.2.2 release not

[doris] branch master updated (040a715251 -> 92417cedec)

2023-02-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 040a715251 [docs](releasenote)1.2.2 release note (#16766) add 92417cedec MOD: Reduce clang version (#16755) No

[GitHub] [doris] yiguolei merged pull request #16755: [Fix](CMakeLists): Reduce clang version

2023-02-14 Thread via GitHub
yiguolei merged PR #16755: URL: https://github.com/apache/doris/pull/16755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[GitHub] [doris] hello-stephen commented on pull request #16761: [feature](nereids)add rule eliminate inner join when any child is EmptyRelation.

2023-02-14 Thread via GitHub
hello-stephen commented on PR #16761: URL: https://github.com/apache/doris/pull/16761#issuecomment-1430627421 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 35.16 seconds stream load tsv: 477 seconds loaded 74807831229 Bytes, about 149 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #16472: [improvement](meta) Enhance Doris's fault tolerance to disk error

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16472: URL: https://github.com/apache/doris/pull/16472#issuecomment-1430637416 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] AshinGau opened a new pull request, #16767: [improvement](filecache) split file cache into sharding directories

2023-02-14 Thread via GitHub
AshinGau opened a new pull request, #16767: URL: https://github.com/apache/doris/pull/16767 # Proposed changes Save cached file segment into path like `cache_path / hash(filepath).substr(0, 3) / hash(filepath) / offset` to prevent too many directories in `cache_path`. ## Check

[GitHub] [doris] dataroaring commented on a diff in pull request #16617: [Feature](network interface) Support network interface

2023-02-14 Thread via GitHub
dataroaring commented on code in PR #16617: URL: https://github.com/apache/doris/pull/16617#discussion_r1106567023 ## be/src/service/backend_options.cpp: ## @@ -81,6 +84,51 @@ std::string BackendOptions::get_localhost() { return _s_localhost; } +bool BackendOptions::anal

[GitHub] [doris] github-actions[bot] commented on pull request #16767: [improvement](filecache) split file cache into sharding directories

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16767: URL: https://github.com/apache/doris/pull/16767#issuecomment-1430640623 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16472: [improvement](meta) Enhance Doris's fault tolerance to disk error

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16472: URL: https://github.com/apache/doris/pull/16472#issuecomment-1430644622 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16383: [Improvement](thrift) optimize thrift message

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16383: URL: https://github.com/apache/doris/pull/16383#issuecomment-1430652403 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] bowenliang123 opened a new pull request, #16768: [docs](docs) Fix broken graph in en/broker-load-manual.md

2023-02-14 Thread via GitHub
bowenliang123 opened a new pull request, #16768: URL: https://github.com/apache/doris/pull/16768 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ]

[GitHub] [doris] bowenliang123 commented on pull request #16768: [docs](docs) Fix broken graph in en/broker-load-manual.md

2023-02-14 Thread via GitHub
bowenliang123 commented on PR #16768: URL: https://github.com/apache/doris/pull/16768#issuecomment-1430655504 This PR is fixing a bug in docs introduced at https://github.com/apache/doris/pull/8757. cc @hf200012 -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [doris] github-actions[bot] commented on pull request #16586: [refactor](Nereids): add two phase sort

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16586: URL: https://github.com/apache/doris/pull/16586#issuecomment-1430658823 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16586: [refactor](Nereids): add two phase sort

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16586: URL: https://github.com/apache/doris/pull/16586#issuecomment-1430658846 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16748: [Chore](build) enable fallthrough check annd fix some fallthrough bug

2023-02-14 Thread via GitHub
github-actions[bot] commented on code in PR #16748: URL: https://github.com/apache/doris/pull/16748#discussion_r1106586675 ## be/test/olap/rowset/rowset_tree_test.cpp: ## @@ -255,11 +255,13 @@ TEST_F(TestRowsetTree, TestTreeRandomized) { int r = strcmp(s1.c_str(), s

[GitHub] [doris] morrySnow merged pull request #16586: [refactor](Nereids): add two phase sort

2023-02-14 Thread via GitHub
morrySnow merged PR #16586: URL: https://github.com/apache/doris/pull/16586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[doris] branch master updated (92417cedec -> db9319b881)

2023-02-14 Thread morrysnow
This is an automated email from the ASF dual-hosted git repository. morrysnow pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 92417cedec MOD: Reduce clang version (#16755) add db9319b881 [refactor](Nereids) add two phase sort (#16586) N

[GitHub] [doris] github-actions[bot] commented on pull request #16610: [fix](compaction) if there is a rowset version hole, do not compaction

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16610: URL: https://github.com/apache/doris/pull/16610#issuecomment-1430671380 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16036: [feature] Support mutable property for partition

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16036: URL: https://github.com/apache/doris/pull/16036#issuecomment-1430671737 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] hello-stephen commented on pull request #16767: [improvement](filecache) split file cache into sharding directories

2023-02-14 Thread via GitHub
hello-stephen commented on PR #16767: URL: https://github.com/apache/doris/pull/16767#issuecomment-1430673920 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.09 seconds stream load tsv: 486 seconds loaded 74807831229 Bytes, about 146 MB/s

[GitHub] [doris] github-actions[bot] commented on pull request #16734: [Opt](exec) opt aggreate function performance in nullable column

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16734: URL: https://github.com/apache/doris/pull/16734#issuecomment-1430680606 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yiguolei merged pull request #16680: [improvement](rowset reader) fix possible memleak

2023-02-14 Thread via GitHub
yiguolei merged PR #16680: URL: https://github.com/apache/doris/pull/16680 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated (db9319b881 -> 9b8c91e18c)

2023-02-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from db9319b881 [refactor](Nereids) add two phase sort (#16586) add 9b8c91e18c [improvement](rowset reader) fix possi

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-14 Thread via GitHub
github-actions[bot] commented on code in PR #15339: URL: https://github.com/apache/doris/pull/15339#discussion_r1106604940 ## be/src/vec/exec/join/process_hash_table_probe_impl.h: ## @@ -607,6 +607,7 @@ Status ProcessHashTableProbe::do_process_with_other_join_conjuncts(

[GitHub] [doris] github-actions[bot] commented on pull request #16738: [fix](fe)should check slot from both lhs and rhs of outputSmap of join node for colocate join

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16738: URL: https://github.com/apache/doris/pull/16738#issuecomment-1430697820 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16738: [fix](fe)should check slot from both lhs and rhs of outputSmap of join node for colocate join

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16738: URL: https://github.com/apache/doris/pull/16738#issuecomment-1430697846 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] SaintBacchus commented on pull request #16461: [fix](compute_node) fix backend_num_for_federation bug for federation…

2023-02-14 Thread via GitHub
SaintBacchus commented on PR #16461: URL: https://github.com/apache/doris/pull/16461#issuecomment-1430702673 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [doris] yiguolei merged pull request #16679: [Refactor](auth) Add AccessController to support customized authorization

2023-02-14 Thread via GitHub
yiguolei merged PR #16679: URL: https://github.com/apache/doris/pull/16679 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated (9b8c91e18c -> 69c70d27bd)

2023-02-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/doris.git from 9b8c91e18c [improvement](rowset reader) fix possible memleak (#16680) add 69c70d27bd [Refactor](auth) Add Access

[GitHub] [doris] zhannngchen commented on a diff in pull request #16689: [Enchancement](merge-on-write) check the correctness of rowid conversion after compaction

2023-02-14 Thread via GitHub
zhannngchen commented on code in PR #16689: URL: https://github.com/apache/doris/pull/16689#discussion_r1106616091 ## be/src/olap/compaction.cpp: ## @@ -390,11 +391,12 @@ Status Compaction::modify_rowsets() { if (_tablet->keys_type() == KeysType::UNIQUE_KEYS &&

[GitHub] [doris] zhannngchen commented on a diff in pull request #16689: [Enchancement](merge-on-write) check the correctness of rowid conversion after compaction

2023-02-14 Thread via GitHub
zhannngchen commented on code in PR #16689: URL: https://github.com/apache/doris/pull/16689#discussion_r1106616091 ## be/src/olap/compaction.cpp: ## @@ -390,11 +391,12 @@ Status Compaction::modify_rowsets() { if (_tablet->keys_type() == KeysType::UNIQUE_KEYS &&

[GitHub] [doris] LemonLiTree opened a new pull request, #16769: [fix](docs)Supplement show processlist documentation

2023-02-14 Thread via GitHub
LemonLiTree opened a new pull request, #16769: URL: https://github.com/apache/doris/pull/16769 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Ha

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430718478 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430723619 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430723901 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430727032 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430727755 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430730562 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] eldenmoon opened a new pull request, #16770: [improve](point query) reuse rowset from lookup_row_key to eliminate …

2023-02-14 Thread via GitHub
eldenmoon opened a new pull request, #16770: URL: https://github.com/apache/doris/pull/16770 …tablet lock Reuse rowset for 2 reasons: 1. eliminate tablet lock for performance issue, if other thread hold the lock too long could affect point query latency 2. rowset should be acqui

[GitHub] [doris] yiguolei opened a new pull request, #16771: [enhancement](exception safe) make function state exception safe

2023-02-14 Thread via GitHub
yiguolei opened a new pull request, #16771: URL: https://github.com/apache/doris/pull/16771 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has u

[GitHub] [doris] github-actions[bot] commented on pull request #16770: [improve](point query) reuse rowset from lookup_row_key to eliminate …

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16770: URL: https://github.com/apache/doris/pull/16770#issuecomment-1430734565 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16771: [enhancement](exception safe) make function state exception safe

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16771: URL: https://github.com/apache/doris/pull/16771#issuecomment-1430736737 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris-thirdparty] kaka11chen opened a new pull request, #37: [Enhancement] If kms url is empty, do not call getfileStatus() rpc.

2023-02-14 Thread via GitHub
kaka11chen opened a new pull request, #37: URL: https://github.com/apache/doris-thirdparty/pull/37 If kms url is empty, do not call `getfileStatus()` rpc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [doris] github-actions[bot] commented on pull request #15339: [enhancement-wip](aggregate-function) enhance aggregate funtion collect and add group_array aliases

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #15339: URL: https://github.com/apache/doris/pull/15339#issuecomment-1430738432 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yiguolei merged pull request #16738: [fix](fe)should check slot from both lhs and rhs of outputSmap of join node for colocate join

2023-02-14 Thread via GitHub
yiguolei merged PR #16738: URL: https://github.com/apache/doris/pull/16738 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [fix](fe)should check slot from both lhs and rhs of outputSmap of join node for colocate join (#16738)

2023-02-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 13134c1bfe [fix](fe)should check slot from both

[GitHub] [doris] BiteTheDDDDt closed pull request #16654: [Feature](Materialized-View) testing

2023-02-14 Thread via GitHub
BiteThet closed pull request #16654: [Feature](Materialized-View) testing URL: https://github.com/apache/doris/pull/16654 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] jackwener commented on a diff in pull request #16761: [feature](nereids)add rule eliminate inner join when any child is EmptyRelation.

2023-02-14 Thread via GitHub
jackwener commented on code in PR #16761: URL: https://github.com/apache/doris/pull/16761#discussion_r1106660071 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/EliminateInnerJoinByEmptyRelation.java: ## @@ -0,0 +1,61 @@ +// Licensed to the Apache Soft

[GitHub] [doris] jackwener commented on a diff in pull request #16761: [feature](nereids)add rule eliminate inner join when any child is EmptyRelation.

2023-02-14 Thread via GitHub
jackwener commented on code in PR #16761: URL: https://github.com/apache/doris/pull/16761#discussion_r1106660704 ## regression-test/suites/nereids_tpch_p0/nereids_emptyset_prune.groovy: ## @@ -0,0 +1,56 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or mor

[GitHub] [doris] jackwener closed pull request #14906: [feature](Nereids): OuterJoinAssoc Rule.

2023-02-14 Thread via GitHub
jackwener closed pull request #14906: [feature](Nereids): OuterJoinAssoc Rule. URL: https://github.com/apache/doris/pull/14906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[doris] branch master updated: fix doc (#16769)

2023-02-14 Thread diwu
This is an automated email from the ASF dual-hosted git repository. diwu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 0664186efe fix doc (#16769) 0664186efe is described

[GitHub] [doris] JNSimba merged pull request #16769: [fix](docs)Supplement show processlist documentation

2023-02-14 Thread via GitHub
JNSimba merged PR #16769: URL: https://github.com/apache/doris/pull/16769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apac

[GitHub] [doris] github-actions[bot] commented on pull request #16734: [Opt](exec) opt aggreate function performance in nullable column

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16734: URL: https://github.com/apache/doris/pull/16734#issuecomment-1430777614 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16734: [Opt](exec) opt aggreate function performance in nullable column

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16734: URL: https://github.com/apache/doris/pull/16734#issuecomment-1430777642 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] hello-stephen commented on pull request #16771: [enhancement](exception safe) make function state exception safe

2023-02-14 Thread via GitHub
hello-stephen commented on PR #16771: URL: https://github.com/apache/doris/pull/16771#issuecomment-1430777894 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.81 seconds stream load tsv: 476 seconds loaded 74807831229 Bytes, about 149 MB/s

[GitHub] [doris] starocean999 commented on a diff in pull request #16676: [feature](Nereids): add OuterJoinAssoc rule

2023-02-14 Thread via GitHub
starocean999 commented on code in PR #16676: URL: https://github.com/apache/doris/pull/16676#discussion_r1106664901 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/OuterJoinAssoc.java: ## @@ -0,0 +1,112 @@ +// Licensed to the Apache Software Foundatio

[GitHub] [doris] starocean999 commented on a diff in pull request #16676: [feature](Nereids): add OuterJoinAssoc rule

2023-02-14 Thread via GitHub
starocean999 commented on code in PR #16676: URL: https://github.com/apache/doris/pull/16676#discussion_r1106665552 ## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/join/OuterJoinLAsscomProject.java: ## @@ -74,95 +69,56 @@ public Rule build() {

[GitHub] [doris] github-actions[bot] commented on pull request #16411: [feature](Nereids): Infer isNotNull from filter and eliminate OuterJoin

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16411: URL: https://github.com/apache/doris/pull/16411#issuecomment-1430780328 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16411: [feature](Nereids): Infer isNotNull from filter and eliminate OuterJoin

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16411: URL: https://github.com/apache/doris/pull/16411#issuecomment-1430780366 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] jackwener merged pull request #16411: [feature](Nereids): Infer isNotNull from filter and eliminate OuterJoin

2023-02-14 Thread via GitHub
jackwener merged PR #16411: URL: https://github.com/apache/doris/pull/16411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.ap

[GitHub] [doris] jackwener closed issue #16707: outer join elimination

2023-02-14 Thread via GitHub
jackwener closed issue #16707: outer join elimination URL: https://github.com/apache/doris/issues/16707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[doris] branch master updated: [feature](Nereids): Infer isNotNull from filter and eliminate OuterJoin (#16411)

2023-02-14 Thread jakevin
This is an automated email from the ASF dual-hosted git repository. jakevin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new ad46e529d8 [feature](Nereids): Infer isNotNull f

[GitHub] [doris] starocean999 commented on a diff in pull request #16676: [feature](Nereids): add OuterJoinAssoc rule

2023-02-14 Thread via GitHub
starocean999 commented on code in PR #16676: URL: https://github.com/apache/doris/pull/16676#discussion_r1106667717 ## fe/fe-core/src/main/java/org/apache/doris/nereids/util/Utils.java: ## @@ -79,6 +79,30 @@ public static R execWithReturnVal(Supplier f) { return (R) an

[GitHub] [doris] bowenliang123 commented on pull request #16754: [chore](dependency) fix ubuntu package conflict by skipping `apt upgrade` in build-thirdparty workflow

2023-02-14 Thread via GitHub
bowenliang123 commented on PR #16754: URL: https://github.com/apache/doris/pull/16754#issuecomment-1430783580 Hi, kind ping to @adonis0147 again. I have force pushed to trigger the CI again to pass the P0 Rregression. Nothing new changed. -- This is an automated message from the Apache Gi

[GitHub] [doris] starocean999 commented on a diff in pull request #16676: [feature](Nereids): add OuterJoinAssoc rule

2023-02-14 Thread via GitHub
starocean999 commented on code in PR #16676: URL: https://github.com/apache/doris/pull/16676#discussion_r1106667717 ## fe/fe-core/src/main/java/org/apache/doris/nereids/util/Utils.java: ## @@ -79,6 +79,30 @@ public static R execWithReturnVal(Supplier f) { return (R) an

[GitHub] [doris] Gabriel39 opened a new pull request, #16772: [pipeline](profile) Support real-time profile report in pipeline

2023-02-14 Thread via GitHub
Gabriel39 opened a new pull request, #16772: URL: https://github.com/apache/doris/pull/16772 # Proposed changes Issue Number: close #xxx ## Problem summary Describe your changes. ## Checklist(Required) * [ ] Does it affect the original behavior * [ ] Has

[GitHub] [doris] github-actions[bot] commented on pull request #16772: [pipeline](profile) Support real-time profile report in pipeline

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16772: URL: https://github.com/apache/doris/pull/16772#issuecomment-1430791283 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] yagagagaga closed pull request #16751: [typo](docs) Fix some misspelled words

2023-02-14 Thread via GitHub
yagagagaga closed pull request #16751: [typo](docs) Fix some misspelled words URL: https://github.com/apache/doris/pull/16751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [doris] starocean999 opened a new pull request, #16774: [enhancement](nereids)add eliminate left nullaware anti join rule

2023-02-14 Thread via GitHub
starocean999 opened a new pull request, #16774: URL: https://github.com/apache/doris/pull/16774 # Proposed changes Issue Number: close #xxx ## Problem summary if no join conjunct is nullable, the left null aware anti join can be converted to left anti join ## Chec

[GitHub] [doris] morningman commented on a diff in pull request #16649: [doc](filecache) add file cache document

2023-02-14 Thread via GitHub
morningman commented on code in PR #16649: URL: https://github.com/apache/doris/pull/16649#discussion_r1106691731 ## docs/en/docs/lakehouse/filecache.md: ## @@ -0,0 +1,89 @@ +--- +{ +"title": "File Cache", +"language": "en" +} +--- + + + +# File Cache + + Review Comment

[GitHub] [doris] JackDrogon opened a new pull request, #16775: [enhance](util) Split PriorityWorkStealingThreadPool into impl cpp && modernize-pass-by-value blocking_put

2023-02-14 Thread via GitHub
JackDrogon opened a new pull request, #16775: URL: https://github.com/apache/doris/pull/16775 ## Problem summary - Split PriorityWorkStealingThreadPool into impl cpp to reduce compile time - Refactor record_batch_queue blocking_queue blocking_put to pass-by-value ## Checklist

[GitHub] [doris] morningman commented on a diff in pull request #16767: [improvement](filecache) split file cache into sharding directories

2023-02-14 Thread via GitHub
morningman commented on code in PR #16767: URL: https://github.com/apache/doris/pull/16767#discussion_r1106698431 ## be/src/io/cache/block/block_lru_file_cache.cpp: ## @@ -634,63 +637,113 @@ void LRUFileCache::remove(const Key& key, bool is_persistent, size_t offset, } void

[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #16768: [fix](docs) Fix broken graph in en/broker-load-manual.md

2023-02-14 Thread via GitHub
carlvinhust2012 commented on code in PR #16768: URL: https://github.com/apache/doris/pull/16768#discussion_r1106699670 ## docs/en/docs/data-operate/import/import-way/broker-load-manual.md: ## @@ -43,38 +43,38 @@ After the user submits the import task, FE will generate the corre

[GitHub] [doris] github-actions[bot] commented on pull request #16540: [Fix](profile) fix `/query_profile` action.

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16540: URL: https://github.com/apache/doris/pull/16540#issuecomment-1430813826 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16540: [Fix](profile) fix `/query_profile` action.

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16540: URL: https://github.com/apache/doris/pull/16540#issuecomment-1430813866 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] carlvinhust2012 commented on a diff in pull request #16763: [Fix](multi catalog)Fix partition case bug.

2023-02-14 Thread via GitHub
carlvinhust2012 commented on code in PR #16763: URL: https://github.com/apache/doris/pull/16763#discussion_r1106701378 ## fe/fe-core/src/main/java/org/apache/doris/common/util/BrokerUtil.java: ## @@ -119,6 +119,12 @@ public static List parseColumnsFromPath( if (columnsF

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16775: [enhance](util) Split PriorityWorkStealingThreadPool into impl cpp && modernize-pass-by-value blocking_put

2023-02-14 Thread via GitHub
github-actions[bot] commented on code in PR #16775: URL: https://github.com/apache/doris/pull/16775#discussion_r1106701569 ## be/src/util/priority_work_stealing_thread_pool.cpp: ## @@ -0,0 +1,113 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contr

[GitHub] [doris] yiguolei merged pull request #16540: [Fix](profile) fix `/query_profile` action.

2023-02-14 Thread via GitHub
yiguolei merged PR #16540: URL: https://github.com/apache/doris/pull/16540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apa

[doris] branch master updated: [Fix](profile) fix `/query_profile` action. (#16540)

2023-02-14 Thread yiguolei
This is an automated email from the ASF dual-hosted git repository. yiguolei pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new a6bda81dba [Fix](profile) fix `/query_profile`

[GitHub] [doris] bowenliang123 commented on a diff in pull request #16768: [fix](docs) Fix broken graph in en/broker-load-manual.md

2023-02-14 Thread via GitHub
bowenliang123 commented on code in PR #16768: URL: https://github.com/apache/doris/pull/16768#discussion_r1106706838 ## docs/en/docs/data-operate/import/import-way/broker-load-manual.md: ## @@ -43,38 +43,38 @@ After the user submits the import task, FE will generate the corresp

[GitHub] [doris] bowenliang123 commented on a diff in pull request #16768: [fix](docs) Fix broken graph in en/broker-load-manual.md

2023-02-14 Thread via GitHub
bowenliang123 commented on code in PR #16768: URL: https://github.com/apache/doris/pull/16768#discussion_r1106706838 ## docs/en/docs/data-operate/import/import-way/broker-load-manual.md: ## @@ -43,38 +43,38 @@ After the user submits the import task, FE will generate the corresp

[GitHub] [doris] bowenliang123 commented on a diff in pull request #16768: [fix](docs) Fix broken graph in en/broker-load-manual.md

2023-02-14 Thread via GitHub
bowenliang123 commented on code in PR #16768: URL: https://github.com/apache/doris/pull/16768#discussion_r1106706838 ## docs/en/docs/data-operate/import/import-way/broker-load-manual.md: ## @@ -43,38 +43,38 @@ After the user submits the import task, FE will generate the corresp

[GitHub] [doris] luozenglin commented on pull request #16748: [Chore](build) enable fallthrough check annd fix some fallthrough bug

2023-02-14 Thread via GitHub
luozenglin commented on PR #16748: URL: https://github.com/apache/doris/pull/16748#issuecomment-1430839908 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [doris] Tanya-W commented on a diff in pull request #16758: [improve](inverted index) Add element count limit for inverted index searcher cache

2023-02-14 Thread via GitHub
Tanya-W commented on code in PR #16758: URL: https://github.com/apache/doris/pull/16758#discussion_r1106715012 ## be/src/olap/lru_cache.h: ## @@ -322,6 +324,9 @@ class LRUCache { // Separate from constructor so caller can easily make an array of LRUCache void set_cap

[GitHub] [doris] github-actions[bot] commented on pull request #16748: [Chore](build) enable fallthrough check annd fix some fallthrough bug

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16748: URL: https://github.com/apache/doris/pull/16748#issuecomment-1430842162 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16748: [Chore](build) enable fallthrough check annd fix some fallthrough bug

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16748: URL: https://github.com/apache/doris/pull/16748#issuecomment-1430842200 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] Tanya-W commented on a diff in pull request #16758: [improve](inverted index) Add element count limit for inverted index searcher cache

2023-02-14 Thread via GitHub
Tanya-W commented on code in PR #16758: URL: https://github.com/apache/doris/pull/16758#discussion_r1106717034 ## be/src/olap/rowset/segment_v2/inverted_index_cache.cpp: ## @@ -49,6 +49,19 @@ void InvertedIndexSearcherCache::create_global_instance(size_t capacity, uint32_ Inve

[GitHub] [doris] amorynan opened a new pull request, #16776: [Feature](map-type) Support stream load and fix some bugs for map type

2023-02-14 Thread via GitHub
amorynan opened a new pull request, #16776: URL: https://github.com/apache/doris/pull/16776 # Proposed changes 1. support stream load with json, csv format for map 2. fix olap convertor when compaction action in map column which has null Add implicitly cast for struct-type.

[GitHub] [doris] github-actions[bot] commented on pull request #16776: [Feature](map-type) Support stream load and fix some bugs for map type

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16776: URL: https://github.com/apache/doris/pull/16776#issuecomment-1430846525 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] AshinGau commented on a diff in pull request #16767: [improvement](filecache) split file cache into sharding directories

2023-02-14 Thread via GitHub
AshinGau commented on code in PR #16767: URL: https://github.com/apache/doris/pull/16767#discussion_r1106726945 ## be/src/io/cache/block/block_lru_file_cache.cpp: ## @@ -634,63 +637,113 @@ void LRUFileCache::remove(const Key& key, bool is_persistent, size_t offset, } void L

[GitHub] [doris] github-actions[bot] commented on pull request #16754: [chore](dependency) fix ubuntu package conflict by skipping `apt upgrade` in build-thirdparty workflow

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16754: URL: https://github.com/apache/doris/pull/16754#issuecomment-1430861902 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16767: [improvement](filecache) split file cache into sharding directories

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16767: URL: https://github.com/apache/doris/pull/16767#issuecomment-1430862609 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [doris] github-actions[bot] commented on pull request #16613: [Feature](struct-type) Add implicitly cast for struct-type

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16613: URL: https://github.com/apache/doris/pull/16613#issuecomment-1430864840 PR approved by at least one committer and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [doris] github-actions[bot] commented on pull request #16613: [Feature](struct-type) Add implicitly cast for struct-type

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16613: URL: https://github.com/apache/doris/pull/16613#issuecomment-1430864885 PR approved by anyone and no changes requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [doris] hello-stephen commented on pull request #16775: [enhance](util) Split PriorityWorkStealingThreadPool into impl cpp && modernize-pass-by-value blocking_put

2023-02-14 Thread via GitHub
hello-stephen commented on PR #16775: URL: https://github.com/apache/doris/pull/16775#issuecomment-1430868621 TeamCity pipeline, clickbench performance test result: the sum of best hot time: 33.86 seconds stream load tsv: 478 seconds loaded 74807831229 Bytes, about 149 MB/s

[GitHub] [doris] adonis0147 merged pull request #16754: [chore](workflow) Fix Ubuntu package conflicts by skipping `apt upgrade`

2023-02-14 Thread via GitHub
adonis0147 merged PR #16754: URL: https://github.com/apache/doris/pull/16754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.a

[doris] branch master updated: [chore](workflow) Fix Ubuntu package conflicts by skipping apt upgrade (#16754)

2023-02-14 Thread adonisling
This is an automated email from the ASF dual-hosted git repository. adonisling pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/doris.git The following commit(s) were added to refs/heads/master by this push: new 585b74b175 [chore](workflow) Fix Ubuntu packa

[GitHub] [doris] github-actions[bot] commented on pull request #16758: [improve](inverted index) Add element count limit for inverted index searcher cache

2023-02-14 Thread via GitHub
github-actions[bot] commented on PR #16758: URL: https://github.com/apache/doris/pull/16758#issuecomment-1430871799 clang-tidy review says "All clean, LGTM! :+1:" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

<    1   2   3   >