zhannngchen commented on code in PR #16689:
URL: https://github.com/apache/doris/pull/16689#discussion_r1106616091
##########
be/src/olap/compaction.cpp:
##########
@@ -390,11 +391,12 @@ Status Compaction::modify_rowsets() {
if (_tablet->keys_type() == KeysType::UNIQUE_KEYS &&
_tablet->enable_unique_key_merge_on_write()) {
_tablet->tablet_meta()->update_delete_bitmap(
- _input_rowsets, _output_rs_writer->version(),
_rowid_conversion);
+ _input_rowsets, _output_rs_writer->version(),
_rowid_conversion, &location_map);
}
RETURN_NOT_OK(_tablet->modify_rowsets(output_rowsets, _input_rowsets,
true));
}
+ _tablet->check_rowid_conversion(_output_rowset, location_map);
Review Comment:
Do we need to add a config here? once user encountered this kind of issue,
and we need to trigger the full compaction to fix the data issue, in that case,
if the `check_rowid_conversion` keep failing, the fix work won't success.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
