dataroaring commented on code in PR #16617:
URL: https://github.com/apache/doris/pull/16617#discussion_r1106567023
##########
be/src/service/backend_options.cpp:
##########
@@ -81,6 +84,51 @@ std::string BackendOptions::get_localhost() {
return _s_localhost;
}
+bool BackendOptions::analyze_network_interface() {
+ if (config::network_interface[0] == "") {
+ return false;
+ }
+ LOG(INFO) << "network name in conf: " << config::network_interface[0] <<
"\tpriority cidrs in conf: " << config::network_interface[1];
+
Review Comment:
we should not print cidrs here, it is confusing.
##########
be/src/common/config.h:
##########
@@ -49,6 +49,8 @@ CONF_Int32(single_replica_load_brpc_num_threads, "64");
// If no ip match this rule, will choose one randomly.
CONF_String(priority_networks, "");
+CONF_Strings(network_interface, "");
Review Comment:
String is enough.
##########
be/src/service/backend_options.cpp:
##########
@@ -81,6 +84,51 @@ std::string BackendOptions::get_localhost() {
return _s_localhost;
}
+bool BackendOptions::analyze_network_interface() {
+ if (config::network_interface[0] == "") {
+ return false;
+ }
+ LOG(INFO) << "network name in conf: " << config::network_interface[0] <<
"\tpriority cidrs in conf: " << config::network_interface[1];
+
+ std::vector<std::string> cidr_strs =
Review Comment:
variable name is confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
