Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-05-06 Thread via GitHub
jacktengg closed pull request #34145: [improvement](spill) release memory in time if task is closed URL: https://github.com/apache/doris/pull/34145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-05-05 Thread via GitHub
yiguolei commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1590571741 ## be/src/pipeline/dependency.h: ## @@ -312,19 +312,56 @@ class RuntimeFilterDependency final : public Dependency { const IRuntimeFilter* _runtime_filter = nullpt

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-05-05 Thread via GitHub
yiguolei commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1590571163 ## be/src/pipeline/dependency.h: ## @@ -312,19 +312,56 @@ class RuntimeFilterDependency final : public Dependency { const IRuntimeFilter* _runtime_filter = nullpt

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-05-05 Thread via GitHub
yiguolei commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1590570518 ## be/src/pipeline/dependency.cpp: ## @@ -178,6 +179,19 @@ LocalExchangeSharedState::LocalExchangeSharedState(int num_instances) { mem_trackers.resize(num_instan

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-05-05 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2094903220 TPC-DS: Total hot run time: 187897 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-05-05 Thread via GitHub
github-actions[bot] commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1590370418 ## be/src/pipeline/dependency.h: ## @@ -567,14 +636,38 @@ struct HashJoinSharedState : public JoinSharedState { bool probe_ignore_null = false; }; +

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-05-05 Thread via GitHub
jacktengg commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2094886448 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-30 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2085735335 TPC-DS: Total hot run time: 187601 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-30 Thread via GitHub
jacktengg commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2085566234 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-30 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2085019667 TPC-DS: Total hot run time: 184600 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-30 Thread via GitHub
jacktengg commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2084919577 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-29 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2083024467 TPC-DS: Total hot run time: 186246 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-29 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2082999503 TPC-H: Total hot run time: 41655 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-29 Thread via GitHub
jacktengg commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2082891561 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-29 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2082433886 TPC-DS: Total hot run time: 186219 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-29 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2082415027 TPC-H: Total hot run time: 39859 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-29 Thread via GitHub
jacktengg commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2082385989 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-29 Thread via GitHub
github-actions[bot] commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1582833180 ## be/src/pipeline/dependency.h: ## @@ -418,6 +469,8 @@ struct PartitionedAggSharedState : public BasicSharedState, void close(); +void close_s

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-29 Thread via GitHub
jacktengg commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2082359382 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-29 Thread via GitHub
github-actions[bot] commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1582670536 ## be/src/pipeline/pipeline_x/dependency.h: ## @@ -419,6 +470,8 @@ struct PartitionedAggSharedState : public BasicSharedState, void close(); +v

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-27 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2081322322 TPC-DS: Total hot run time: 186191 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-27 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2081319446 TPC-H: Total hot run time: 40413 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools Tpch sf100

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-27 Thread via GitHub
github-actions[bot] commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1582008487 ## be/src/pipeline/pipeline_x/dependency.h: ## @@ -579,14 +605,27 @@ struct HashJoinSharedState : public JoinSharedState { bool probe_ignore_null = fal

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-27 Thread via GitHub
jacktengg commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2081312238 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-26 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2079057190 TPC-DS: Total hot run time: 189215 ms ``` machine: 'aliyun_ecs.c7a.8xlarge_32C64G' scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools TPC-DS

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-26 Thread via GitHub
github-actions[bot] commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1580730664 ## be/src/pipeline/pipeline_x/dependency.h: ## @@ -313,12 +313,31 @@ class RuntimeFilterDependency final : public Dependency { const IRuntimeFilter* _r

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-26 Thread via GitHub
jacktengg commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2078967961 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-25 Thread via GitHub
yiguolei commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1579823971 ## be/src/pipeline/pipeline_x/operator.h: ## @@ -465,6 +466,13 @@ class PipelineXSpillLocalState : public PipelineXLocalState { return Status::OK(); }

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-25 Thread via GitHub
yiguolei commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1579821504 ## be/src/pipeline/exec/partitioned_aggregation_sink_operator.cpp: ## @@ -253,10 +264,14 @@ Status PartitionedAggSinkLocalState::revoke_memory(RuntimeState* state) {

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-25 Thread via GitHub
github-actions[bot] commented on code in PR #34145: URL: https://github.com/apache/doris/pull/34145#discussion_r1579819513 ## be/src/vec/spill/spill_task.h: ## @@ -0,0 +1,30 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-25 Thread via GitHub
jacktengg commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2077696435 run buildall -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-25 Thread via GitHub
doris-robot commented on PR #34145: URL: https://github.com/apache/doris/pull/34145#issuecomment-2077692239 Thank you for your contribution to Apache Doris. Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+y

[PR] [improvement](spill) release memory in time if task is closed [doris]

2024-04-25 Thread via GitHub
jacktengg opened a new pull request, #34145: URL: https://github.com/apache/doris/pull/34145 ## Proposed changes Issue Number: close #xxx ## Further comments If this is a relatively large or complex change, kick off the discussion at [d...@doris.apache.org](mailt